From nobody Thu Dec 18 05:01:18 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5465EC4167B for ; Tue, 28 Nov 2023 21:35:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345539AbjK1Vfh (ORCPT ); Tue, 28 Nov 2023 16:35:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229763AbjK1Vff (ORCPT ); Tue, 28 Nov 2023 16:35:35 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1EADBD63; Tue, 28 Nov 2023 13:35:40 -0800 (PST) Received: from beast.luon.net (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sjoerd) by madras.collabora.co.uk (Postfix) with ESMTPSA id DDB496602F24; Tue, 28 Nov 2023 21:35:38 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701207339; bh=67uH3wWuxI9nNHNPdHxCUf8N5hbi47QYbIBUACpFrkY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=khtNOesDlK2le5wbv0ZMy887UBOAZ36fL0jPVecU7ugeEmY+aX5RgaAYA0R3fwBOm hx+bpW/rRLZl+Y0wZRHlW3oqZDXtPryVFMvIpvKMTzDKNDp0ECeI4a83Drd4MXvC09 KXLtD6WeiXdz/lx91N/PGNWKF1kXdlc+SOBH2q0jdb8B82JRFG5n1cG0KzzJvsbRVz ip1VRknzrYMxYPY5N3bAjsligu4PGW/N5p1c+aZehVnfX5lPxeMaY7//RFJFahucfi U3TyDcEK2KlGyf2jtx+STyXQKMHv8efs1HN+rxgaGh0es1GMvrFeEIqxIMAl3QNiEd aRbAXVi8khXCQ== Received: by beast.luon.net (Postfix, from userid 1000) id 203179676CFA; Tue, 28 Nov 2023 22:35:37 +0100 (CET) From: Sjoerd Simons To: =?UTF-8?q?Marek=20Beh=C3=BAn?= Cc: =?UTF-8?q?Pali=20Roh=C3=A1r?= , kernel@collabora.com, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] bus: moxtet: Mark the irq as shared Date: Tue, 28 Nov 2023 22:35:04 +0100 Message-ID: <20231128213536.3764212-2-sjoerd@collabora.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231128213536.3764212-1-sjoerd@collabora.com> References: <20231128213536.3764212-1-sjoerd@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The Turris Mox shares the moxtet IRQ with various devices on the board, so mark the IRQ as shared in the driver as well. Without this loading the module will fail with: genirq: Flags mismatch irq 40. 00002002 (moxtet) vs. 00002080 (mcp7940x) Signed-off-by: Sjoerd Simons Cc: stable@vger.kernel.org # v6.2+ Reviewed-by: Marek Beh=C3=BAn --- (no changes since v1) drivers/bus/moxtet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/moxtet.c b/drivers/bus/moxtet.c index 5eb0fe73ddc4..48c18f95660a 100644 --- a/drivers/bus/moxtet.c +++ b/drivers/bus/moxtet.c @@ -755,7 +755,7 @@ static int moxtet_irq_setup(struct moxtet *moxtet) moxtet->irq.masked =3D ~0; =20 ret =3D request_threaded_irq(moxtet->dev_irq, NULL, moxtet_irq_thread_fn, - IRQF_ONESHOT, "moxtet", moxtet); + IRQF_SHARED | IRQF_ONESHOT, "moxtet", moxtet); if (ret < 0) goto err_free; =20 --=20 2.43.0