From nobody Wed Dec 17 10:56:01 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71CFC4167B for ; Tue, 28 Nov 2023 18:56:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345912AbjK1S4c (ORCPT ); Tue, 28 Nov 2023 13:56:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345686AbjK1S4a (ORCPT ); Tue, 28 Nov 2023 13:56:30 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B4250D64; Tue, 28 Nov 2023 10:56:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701197796; x=1732733796; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=RpaakXVVU73ujUwc2z7MfhlZOW+dmSN/82961j5n3xI=; b=UIMcaI5XJAOEL5sIcrF/s2L8L/Z9iC8Rrso2Z3iRCYHcqDoKuDaaxnpL s4G87eUbYnN/Bi3GhgrZyUXPTYc/GOS/Q/8G4IX1D1iLvnxXJMRKSpa3b QgdiuVwIPNo/SzPoot7U/01UXs4yiLdxuO76FH1KLwMQ5+R09UzFlBmpO WTbXVFUeQeXBE/fEdTua6wEHoD9sZHyOHckN5FoW81nQXnF9cajLAdEUa xIkXHZ9ZBY1UGhClw10eZhKqLYbyEkUGjxDI+Rb1tQDQ4du8BpljqslTN pUKzXqaHL77E82z7grK7iIQwYqQa7h15xSz13D0jm+Vqj7tG9o7dRFHzG w==; X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="372366959" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="372366959" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 10:56:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="892165781" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="892165781" Received: from spandruv-desk.jf.intel.com ([10.54.75.14]) by orsmga004.jf.intel.com with ESMTP; 28 Nov 2023 10:56:10 -0800 From: Srinivas Pandruvada To: hdegoede@redhat.com, markgross@kernel.org, ilpo.jarvinen@linux.intel.com, andriy.shevchenko@linux.intel.com Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Srinivas Pandruvada Subject: [PATCH 2/6] platform/x86/intel/tpmi: Don't create devices for disabled features Date: Tue, 28 Nov 2023 10:56:01 -0800 Message-Id: <20231128185605.3027653-3-srinivas.pandruvada@linux.intel.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231128185605.3027653-1-srinivas.pandruvada@linux.intel.com> References: <20231128185605.3027653-1-srinivas.pandruvada@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If some TPMI features are disabled, don't create auxiliary devices. In this way feature drivers will not load. While creating auxiliary devices, call tpmi_read_feature_status() to check feature state and return if the feature is disabled without creating a device. Signed-off-by: Srinivas Pandruvada --- drivers/platform/x86/intel/tpmi.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel/tpmi.c b/drivers/platform/x86/intel= /tpmi.c index c89aa4d14bea..4edaa182db04 100644 --- a/drivers/platform/x86/intel/tpmi.c +++ b/drivers/platform/x86/intel/tpmi.c @@ -604,9 +604,17 @@ static int tpmi_create_device(struct intel_tpmi_info *= tpmi_info, struct intel_vsec_device *vsec_dev =3D tpmi_info->vsec_dev; char feature_id_name[TPMI_FEATURE_NAME_LEN]; struct intel_vsec_device *feature_vsec_dev; + struct tpmi_feature_state feature_state; struct resource *res, *tmp; const char *name; - int i; + int i, ret; + + ret =3D tpmi_read_feature_status(tpmi_info, pfs->pfs_header.tpmi_id, &fea= ture_state); + if (ret) + return ret; + + if (!feature_state.enabled) + return -EOPNOTSUPP; =20 name =3D intel_tpmi_name(pfs->pfs_header.tpmi_id); if (!name) --=20 2.41.0