From nobody Wed Dec 17 10:55:23 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD9E3C46CA0 for ; Tue, 28 Nov 2023 10:24:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234883AbjK1KYr (ORCPT ); Tue, 28 Nov 2023 05:24:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344155AbjK1KYe (ORCPT ); Tue, 28 Nov 2023 05:24:34 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE544D72 for ; Tue, 28 Nov 2023 02:24:33 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 417F5C433C7; Tue, 28 Nov 2023 10:24:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701167073; bh=G8HSSrdcKPJIlhvVxRehBG//p41ZlqdTJZFDrSgI9fQ=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=Y/JUpw11OJsavB6K3RgNTVHwOySrfyn9/bRfQp7OUYl2Tfm5pYxeSuXnYIQT1Mc/C RKsn4r5MCXUdrO4JvpjJzjrn1BDMxB6cAl4efjmEwJP9IywxNcE9NH7D+Rnh8Xcj0Z wTqsvjpXqWwcn12Vub3lKF+pYBIqHCDwFBtqooDiidRbwWvn4H2n2kXQYsi5A5TT20 cn6SzRSR3+ElW4RnM2FMES/S64uJgmoHpMSCUwbyABOwXz3IOYc4tv9De/mgsgvcmc UEZmhDBg4rHgeDsIH3zhuLdjw60sEFjov+hVaj0lRvuQIDE5trwMteC4v4E4N7TSc+ 8c2mDHJ91+75g== From: Maxime Ripard Date: Tue, 28 Nov 2023 11:24:15 +0100 Subject: [PATCH v4 04/45] drm/tests: Add helper to create mock crtc MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20231128-kms-hdmi-connector-state-v4-4-c7602158306e@kernel.org> References: <20231128-kms-hdmi-connector-state-v4-0-c7602158306e@kernel.org> In-Reply-To: <20231128-kms-hdmi-connector-state-v4-0-c7602158306e@kernel.org> To: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Emma Anholt , Jonathan Corbet , Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: Hans Verkuil , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev, Maxime Ripard X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=openpgp-sha256; l=3793; i=mripard@kernel.org; h=from:subject:message-id; bh=G8HSSrdcKPJIlhvVxRehBG//p41ZlqdTJZFDrSgI9fQ=; b=owGbwMvMwCX2+D1vfrpE4FHG02pJDKmp+y8uirozh3WrZG1yUeZZ1h1VoSc8WjN9e5i9ui8pd pafeBLSUcrCIMbFICumyBIjbL4k7tSs151sfPNg5rAygQxh4OIUgIm0BjP89zcqXWDVlnaibzXH TdOn6g7mF2UFT/kulNII3VOtXOt6n5Hhlej79EfLogz2a7zcvmfG+4mXz8jeL8jtuzrVaBlLUcV uLgA= X-Developer-Key: i=mripard@kernel.org; a=openpgp; fpr=BE5675C37E818C8B5764241C254BCFC56BF6CE8D Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We're going to need a full-blown, functional, KMS device to test more components of the atomic modesetting infrastructure. Let's add a new helper to create a dumb, mocked, CRTC. By default it will create a CRTC relying only on the default helpers, but drivers are free to deviate from that. Signed-off-by: Maxime Ripard --- drivers/gpu/drm/tests/drm_kunit_helpers.c | 62 +++++++++++++++++++++++++++= ++++ include/drm/drm_kunit_helpers.h | 10 +++++ 2 files changed, 72 insertions(+) diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c b/drivers/gpu/drm/te= sts/drm_kunit_helpers.c index 4a1559424396..49c7b320679b 100644 --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c @@ -321,5 +321,67 @@ drm_kunit_helper_create_primary_plane(struct kunit *te= st, } EXPORT_SYMBOL_GPL(drm_kunit_helper_create_primary_plane); =20 +static const struct drm_crtc_helper_funcs default_crtc_helper_funcs =3D { +}; + +static const struct drm_crtc_funcs default_crtc_funcs =3D { + .atomic_destroy_state =3D drm_atomic_helper_crtc_destroy_state, + .atomic_duplicate_state =3D drm_atomic_helper_crtc_duplicate_state, + .reset =3D drm_atomic_helper_crtc_reset, +}; + +/** + * drm_kunit_helper_create_crtc - Creates a mock CRTC for a KUnit test + * @test: The test context object + * @drm: The device to alloc the plane for + * @primary: Primary plane for CRTC + * @cursor: Cursor plane for CRTC. Optional. + * @funcs: Callbacks for the new plane. Optional. + * @helper_funcs: Helpers callbacks for the new plane. Optional. + * + * This allocates and initializes a mock struct &drm_crtc meant to be + * part of a mock device for a KUnit test. + * + * Resources will be cleaned up automatically. + * + * @funcs will default to the default helpers implementations. + * @helper_funcs will default to an empty implementation. + * + * Returns: + * A pointer to the new CRTC, or an ERR_PTR() otherwise. + */ +struct drm_crtc * +drm_kunit_helper_create_crtc(struct kunit *test, + struct drm_device *drm, + struct drm_plane *primary, + struct drm_plane *cursor, + const struct drm_crtc_funcs *funcs, + const struct drm_crtc_helper_funcs *helper_funcs) +{ + struct drm_crtc *crtc; + int ret; + + if (!funcs) + funcs =3D &default_crtc_funcs; + + if (!helper_funcs) + helper_funcs =3D &default_crtc_helper_funcs; + + crtc =3D drmm_kzalloc(drm, sizeof(*crtc), GFP_KERNEL); + KUNIT_ASSERT_NOT_NULL(test, crtc); + + ret =3D drmm_crtc_init_with_planes(drm, crtc, + primary, + cursor, + funcs, + NULL); + KUNIT_ASSERT_EQ(test, ret, 0); + + drm_crtc_helper_add(crtc, helper_funcs); + + return crtc; +} +EXPORT_SYMBOL_GPL(drm_kunit_helper_create_crtc); + MODULE_AUTHOR("Maxime Ripard "); MODULE_LICENSE("GPL"); diff --git a/include/drm/drm_kunit_helpers.h b/include/drm/drm_kunit_helper= s.h index 38667d624aa8..6e99627edf45 100644 --- a/include/drm/drm_kunit_helpers.h +++ b/include/drm/drm_kunit_helpers.h @@ -9,6 +9,8 @@ =20 #include =20 +struct drm_crtc_funcs; +struct drm_crtc_helper_funcs; struct drm_device; struct drm_plane_funcs; struct drm_plane_helper_funcs; @@ -110,4 +112,12 @@ drm_kunit_helper_create_primary_plane(struct kunit *te= st, unsigned int num_formats, const uint64_t *modifiers); =20 +struct drm_crtc * +drm_kunit_helper_create_crtc(struct kunit *test, + struct drm_device *drm, + struct drm_plane *primary, + struct drm_plane *cursor, + const struct drm_crtc_funcs *funcs, + const struct drm_crtc_helper_funcs *helper_funcs); + #endif // DRM_KUNIT_HELPERS_H_ --=20 2.41.0