From nobody Wed Dec 17 12:33:49 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5151FC4167B for ; Mon, 27 Nov 2023 16:56:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234454AbjK0Q4q (ORCPT ); Mon, 27 Nov 2023 11:56:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234549AbjK0Qzy (ORCPT ); Mon, 27 Nov 2023 11:55:54 -0500 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E9F91BFE; Mon, 27 Nov 2023 08:55:28 -0800 (PST) Received: from benjamin-XPS-13-9310.. (ec2-34-240-57-77.eu-west-1.compute.amazonaws.com [34.240.57.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: benjamin.gaignard) by madras.collabora.co.uk (Postfix) with ESMTPSA id 75A956607286; Mon, 27 Nov 2023 16:55:26 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1701104127; bh=YIgkAExbbbECDPnkaD6N0lG+VUJuWN8PC9JRmzX9TCI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AiG+Ejb2+mNZ23dQ58fH8HeFPy3hJ02mlj2Hi6rxIeY+Gy1a8/QIAfOk23U/takDW v6q5IkEXN2y6tQf+omLSLpcCgvsdNkad61xg1wUI87O6gd/fMVHJPt7beMBJxoFrzv o3zi6w3FT8MG0PcMXFjmkzio7deWNDtDOAOgQxgjwDHJYjxGTvkbAVGKotPtggFhjH nEwfKFLrFCHpdhjTGSVVIYW9HnpEUsKJSQJhbxaToNiZ+59Uk/fYnCZBuMuMOIXmHs 95pGFhjthjI/q+XLSrPOYxKfQ89KGXqn3gvvCg3f+9+VRpC04Qij8+Svm2OuMVLuVw WvZajJW/poNYw== From: Benjamin Gaignard To: hverkuil@xs4all.nl, mchehab@kernel.org, tfiga@chromium.org, m.szyprowski@samsung.com, matt.ranostay@konsulko.com Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, kernel@collabora.com, Benjamin Gaignard , Paul Kocialkowski , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , linux-sunxi@lists.linux.dev Subject: [PATCH 27/55] media: sun6i-isp: Stop abusing of min_buffers_needed field Date: Mon, 27 Nov 2023 17:54:26 +0100 Message-Id: <20231127165454.166373-28-benjamin.gaignard@collabora.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231127165454.166373-1-benjamin.gaignard@collabora.com> References: <20231127165454.166373-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" 'min_buffers_needed' is suppose to be used to indicate the number of buffers needed by DMA engine to start streaming. sun6i-isp driver doesn't use DMA engine and just want to specify the minimum number of buffers to allocate when calling VIDIOC_REQBUFS. That 'min_reqbufs_allocation' field purpose so use it. Signed-off-by: Benjamin Gaignard CC: Paul Kocialkowski CC: Chen-Yu Tsai CC: Jernej Skrabec CC: Samuel Holland CC: linux-sunxi@lists.linux.dev --- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c | 2 +- drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c b/dr= ivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c index 1595a9607775..f47f9946c19f 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_capture.c @@ -660,7 +660,7 @@ int sun6i_isp_capture_setup(struct sun6i_isp_device *is= p_dev) queue->buf_struct_size =3D sizeof(struct sun6i_isp_buffer); queue->ops =3D &sun6i_isp_capture_queue_ops; queue->mem_ops =3D &vb2_dma_contig_memops; - queue->min_buffers_needed =3D 2; + queue->min_reqbufs_allocation =3D 2; queue->timestamp_flags =3D V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; queue->lock =3D &capture->lock; queue->dev =3D isp_dev->dev; diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c b/dri= vers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c index e28be895b486..259f6bfcb620 100644 --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp_params.c @@ -489,7 +489,7 @@ int sun6i_isp_params_setup(struct sun6i_isp_device *isp= _dev) queue->buf_struct_size =3D sizeof(struct sun6i_isp_buffer); queue->ops =3D &sun6i_isp_params_queue_ops; queue->mem_ops =3D &vb2_vmalloc_memops; - queue->min_buffers_needed =3D 1; + queue->min_reqbufs_allocation =3D 1; queue->timestamp_flags =3D V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC; queue->lock =3D ¶ms->lock; queue->dev =3D isp_dev->dev; --=20 2.39.2