From nobody Wed Dec 17 14:22:04 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15F1EC4167B for ; Mon, 27 Nov 2023 05:36:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232209AbjK0Fgj (ORCPT ); Mon, 27 Nov 2023 00:36:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231314AbjK0FgU (ORCPT ); Mon, 27 Nov 2023 00:36:20 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42D86189 for ; Sun, 26 Nov 2023 21:36:25 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1cfae5ca719so13902145ad.0 for ; Sun, 26 Nov 2023 21:36:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063385; x=1701668185; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tVZx2znymTutkOywVzUkt2j2sn+uTemk2vkexBlkB8A=; b=lXtH+WCTPNK3SmWE65BNYyNLduRpJx2uRYYQ95vbOQch4/go5rmy+K/rT5FZ7g8lUT A+aenF8Dg1rJUbSUAIWwPLZ3iLc5jAQJCrbz5PxTNTokyeacDp90VN10ugZ4JvQjsjMb P0vNvzedBa0fahDmmzDBinXTuUr2idTRhgLb96arIWRqy8UzzZEoIJNaLvSjZZQWhU20 retcC4C628eL9+1D43YrrAGyjlw+uYn8ZOcmXPW46Ibz/C0FPIRneyah/XuVEfvKrZsI DQNjIZ/2MSuAMOy3TTLlY7AetUonfZQYfDB3WdlBAm9K3XXXPMqVvSfEftq0DEb68y8I tvYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063385; x=1701668185; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tVZx2znymTutkOywVzUkt2j2sn+uTemk2vkexBlkB8A=; b=mPeDq4011MnHSB6w/wUj+EQp/pQ7yQOD8gseZ1m4mW60Tfswi/TfT2Gyr+bOtrSke/ aabztaDG7v9k5F4ZsvW5og1DvigDKitFSGDMWrwpY+3FVrqmqFg8aNyMjKLBqqnL+2xv IRTdwHYgxu9kTFffJG6h9UFZQ53pJh5gB1f0gi4DMq2NSn/vflv5/sfz+8UEPm+xN4/K +M19g3mNN5+fA+f66FNsoZuuIWd/wKIyvUmEcSSpdKRrj/eRP/ipMVuoAoOVh20hLYZ2 piZe33qrqnCf+nZBPPWFLcQ68srWdTjNEJ3aAa5QZPOg3u+qpxNjBFRan0kHEarS1iq3 brew== X-Gm-Message-State: AOJu0Yz7qaNUFMk83JPuQUTrWdR0BV09+t4a7g+10ALRZzqA3Vf1DeXV yZLkbA16b4J3wPEP+BBZi3EDXw== X-Google-Smtp-Source: AGHT+IFgTjNmDfa98uCeE9DnBvPC5kZubca/TiaCBOiEBfJvfJgqdUncaAbgjCkb8hDdxr4iO7033A== X-Received: by 2002:a17:902:ec85:b0:1cf:a9c4:7f4b with SMTP id x5-20020a170902ec8500b001cfa9c47f4bmr9325205plg.24.1701063384760; Sun, 26 Nov 2023 21:36:24 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:24 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 07/15] Staging: rtl8192e: Rename variable pDialogToken Date: Sun, 26 Nov 2023 21:42:57 -0800 Message-ID: <20231127054305.148276-8-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable pDialogToken to dialog_token to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 51deab720e76..78da79ebd775 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -215,7 +215,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) { struct ieee80211_hdr_3addr *req =3D NULL; u16 rc =3D 0; - u8 *dst =3D NULL, *pDialogToken =3D NULL, *tag =3D NULL; + u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; struct ba_record *ba =3D NULL; union ba_param_set *pBaParamSet =3D NULL; u16 *pBaTimeoutVal =3D NULL; @@ -238,7 +238,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) tag =3D (u8 *)req; dst =3D (u8 *)(&req->addr2[0]); tag +=3D sizeof(struct ieee80211_hdr_3addr); - pDialogToken =3D tag + 2; + dialog_token =3D tag + 2; pBaParamSet =3D (union ba_param_set *)(tag + 3); pBaTimeoutVal =3D (u16 *)(tag + 5); pBaStartSeqCtrl =3D (union sequence_control *)(req + 7); @@ -271,7 +271,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) rtllib_FlushRxTsPendingPkts(ieee, ts); =20 deactivate_ba_entry(ieee, ba); - ba->dialog_token =3D *pDialogToken; + ba->dialog_token =3D *dialog_token; ba->ba_param_set =3D *pBaParamSet; ba->ba_timeout_value =3D *pBaTimeoutVal; ba->ba_start_seq_ctrl =3D *pBaStartSeqCtrl; @@ -293,7 +293,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) =20 BA.ba_param_set =3D *pBaParamSet; BA.ba_timeout_value =3D *pBaTimeoutVal; - BA.dialog_token =3D *pDialogToken; + BA.dialog_token =3D *dialog_token; BA.ba_param_set.field.ba_policy =3D BA_POLICY_IMMEDIATE; rtllib_send_ADDBARsp(ieee, dst, &BA, rc); return 0; @@ -305,7 +305,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) struct ieee80211_hdr_3addr *rsp =3D NULL; struct ba_record *pending_ba, *pAdmittedBA; struct tx_ts_record *ts =3D NULL; - u8 *dst =3D NULL, *pDialogToken =3D NULL, *tag =3D NULL; + u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; u16 *status_code =3D NULL, *pBaTimeoutVal =3D NULL; union ba_param_set *pBaParamSet =3D NULL; u16 reason_code; @@ -320,7 +320,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) tag =3D (u8 *)rsp; dst =3D (u8 *)(&rsp->addr2[0]); tag +=3D sizeof(struct ieee80211_hdr_3addr); - pDialogToken =3D tag + 2; + dialog_token =3D tag + 2; status_code =3D (u16 *)(tag + 3); pBaParamSet =3D (union ba_param_set *)(tag + 5); pBaTimeoutVal =3D (u16 *)(tag + 7); @@ -353,7 +353,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) __func__); return -1; } else if (!pending_ba->b_valid || - (*pDialogToken !=3D pending_ba->dialog_token)) { + (*dialog_token !=3D pending_ba->dialog_token)) { netdev_warn(ieee->dev, "%s(): ADDBA Rsp. BA invalid, DELBA!\n", __func__); @@ -374,7 +374,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) goto OnADDBARsp_Reject; } =20 - pAdmittedBA->dialog_token =3D *pDialogToken; + pAdmittedBA->dialog_token =3D *dialog_token; pAdmittedBA->ba_timeout_value =3D *pBaTimeoutVal; pAdmittedBA->ba_start_seq_ctrl =3D pending_ba->ba_start_seq_ctrl; pAdmittedBA->ba_param_set =3D *pBaParamSet; --=20 2.39.2