From nobody Wed Dec 17 14:22:03 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D8D1C4167B for ; Mon, 27 Nov 2023 05:37:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232461AbjK0FhD (ORCPT ); Mon, 27 Nov 2023 00:37:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231931AbjK0Fgb (ORCPT ); Mon, 27 Nov 2023 00:36:31 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34A2A184 for ; Sun, 26 Nov 2023 21:36:31 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1cfc2d03b3aso4394025ad.1 for ; Sun, 26 Nov 2023 21:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063390; x=1701668190; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wRGlPinq49hmId5T7GGWMwmGcH6Fr21H2t959wvL11c=; b=d/D75T/q56Q6dYrAO3JsUFFmfV70GMi0AHg+PlgO/JxusdNcAH804t3HupoL0GR6Iz MFSDb2LyS2tMxJLRLPh6OfQi3y5BJu4KSczjcYGvzIKbsC5hOBCJybkjGKV7jIY9A3F1 Y5c+67C9bgNu7VyFoMr+DQDfs+v+MC3MGMgS8mETTpJnlRW3qOhdae+WeF6RevMd6tLZ 3XRYZYbAkz4lGh/lmhIBm6ASrCAiAQJsuPCybtHO8zC+zfabq2mYKRTgtRaxjFujtG1B HLICZn6KvSJ1K6F6Tnd/s9Bipm/JfytHQ4r59aHY67ynPXeA/rthQ5dSDcyAf81JeZH7 zqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063390; x=1701668190; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wRGlPinq49hmId5T7GGWMwmGcH6Fr21H2t959wvL11c=; b=VB0Np5RKfPcpRG9edjzDfhymIghqSMNy5aq91gvYZZFL4HtW8ailq9/HgFW0kttzm7 7O/+EkzoHl+Nb+dZsGOsgHsvPQD1FV2OO/1+xWPW04N7B30jdY1SSBq2dwZBfB5SNfoj b0osehwKs/Xn04wEGZ696RuNQiOVUObsPZF+7tp4ooqX/HrC7vNh2jCdxzX8AVv7eg34 /HOD99GG1WI3qNmqstVeFQpTGi8G93hcO9tjULCcuSHWYwd8R43oHmpllaze5hfrt/ox Ay7nKHy7I8GnYgmTq7B22VkgPPFOkrA/u6Ni7mnYvIgl/YTUfmHaDaYzbdWijxCqxLml ZHFg== X-Gm-Message-State: AOJu0YxckLZaUGQOaTWQBHW3On0ci+D77T6GOB5phizqH/EOn2QAK4tF aG62OMliXMxXgeADY+ZG87tc6Q== X-Google-Smtp-Source: AGHT+IGALDll4IeJDU4dTVXoQihuuXYJuf0E0LL+K3imBQayxVKQC1VDR8/nm/kaQU8omQQWVgsYxA== X-Received: by 2002:a17:903:1d2:b0:1cf:ad61:7a67 with SMTP id e18-20020a17090301d200b001cfad617a67mr8258718plh.32.1701063390670; Sun, 26 Nov 2023 21:36:30 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:30 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 12/15] Staging: rtl8192e: Rename variable pBaParamSet Date: Sun, 26 Nov 2023 21:43:02 -0800 Message-ID: <20231127054305.148276-13-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable pBaParamSet to ba_param_set to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 24 +++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index bd037069d4f3..7074a01ad2e8 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -217,7 +217,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) u16 rc =3D 0; u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; struct ba_record *ba =3D NULL; - union ba_param_set *pBaParamSet =3D NULL; + union ba_param_set *ba_param_set =3D NULL; u16 *pBaTimeoutVal =3D NULL; union sequence_control *pBaStartSeqCtrl =3D NULL; struct rx_ts_record *ts =3D NULL; @@ -239,7 +239,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) dst =3D (u8 *)(&req->addr2[0]); tag +=3D sizeof(struct ieee80211_hdr_3addr); dialog_token =3D tag + 2; - pBaParamSet =3D (union ba_param_set *)(tag + 3); + ba_param_set =3D (union ba_param_set *)(tag + 3); pBaTimeoutVal =3D (u16 *)(tag + 5); pBaStartSeqCtrl =3D (union sequence_control *)(req + 7); =20 @@ -254,14 +254,14 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, st= ruct sk_buff *skb) goto OnADDBAReq_Fail; } if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)(pBaParamSet->field.tid), RX_DIR, true)) { + (u8)(ba_param_set->field.tid), RX_DIR, true)) { rc =3D ADDBA_STATUS_REFUSED; netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); goto OnADDBAReq_Fail; } ba =3D &ts->rx_admitted_ba_record; =20 - if (pBaParamSet->field.ba_policy =3D=3D BA_POLICY_DELAYED) { + if (ba_param_set->field.ba_policy =3D=3D BA_POLICY_DELAYED) { rc =3D ADDBA_STATUS_INVALID_PARAM; netdev_warn(ieee->dev, "%s(): BA Policy is not correct\n", __func__); @@ -272,7 +272,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) =20 deactivate_ba_entry(ieee, ba); ba->dialog_token =3D *dialog_token; - ba->ba_param_set =3D *pBaParamSet; + ba->ba_param_set =3D *ba_param_set; ba->ba_timeout_value =3D *pBaTimeoutVal; ba->ba_start_seq_ctrl =3D *pBaStartSeqCtrl; =20 @@ -291,7 +291,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) { struct ba_record BA; =20 - BA.ba_param_set =3D *pBaParamSet; + BA.ba_param_set =3D *ba_param_set; BA.ba_timeout_value =3D *pBaTimeoutVal; BA.dialog_token =3D *dialog_token; BA.ba_param_set.field.ba_policy =3D BA_POLICY_IMMEDIATE; @@ -307,7 +307,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) struct tx_ts_record *ts =3D NULL; u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; u16 *status_code =3D NULL, *pBaTimeoutVal =3D NULL; - union ba_param_set *pBaParamSet =3D NULL; + union ba_param_set *ba_param_set =3D NULL; u16 reason_code; =20 if (skb->len < sizeof(struct ieee80211_hdr_3addr) + 9) { @@ -322,7 +322,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) tag +=3D sizeof(struct ieee80211_hdr_3addr); dialog_token =3D tag + 2; status_code =3D (u16 *)(tag + 3); - pBaParamSet =3D (union ba_param_set *)(tag + 5); + ba_param_set =3D (union ba_param_set *)(tag + 5); pBaTimeoutVal =3D (u16 *)(tag + 7); =20 if (!ieee->current_network.qos_data.active || @@ -338,7 +338,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) } =20 if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)(pBaParamSet->field.tid), TX_DIR, false)) { + (u8)(ba_param_set->field.tid), TX_DIR, false)) { netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); reason_code =3D DELBA_REASON_UNKNOWN_BA; goto OnADDBARsp_Reject; @@ -367,7 +367,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) } =20 if (*status_code =3D=3D ADDBA_STATUS_SUCCESS) { - if (pBaParamSet->field.ba_policy =3D=3D BA_POLICY_DELAYED) { + if (ba_param_set->field.ba_policy =3D=3D BA_POLICY_DELAYED) { ts->add_ba_req_delayed =3D true; deactivate_ba_entry(ieee, pAdmittedBA); reason_code =3D DELBA_REASON_END_BA; @@ -377,7 +377,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) pAdmittedBA->dialog_token =3D *dialog_token; pAdmittedBA->ba_timeout_value =3D *pBaTimeoutVal; pAdmittedBA->ba_start_seq_ctrl =3D pending_ba->ba_start_seq_ctrl; - pAdmittedBA->ba_param_set =3D *pBaParamSet; + pAdmittedBA->ba_param_set =3D *ba_param_set; deactivate_ba_entry(ieee, pAdmittedBA); activate_ba_entry(pAdmittedBA, *pBaTimeoutVal); } else { @@ -393,7 +393,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) { struct ba_record BA; =20 - BA.ba_param_set =3D *pBaParamSet; + BA.ba_param_set =3D *ba_param_set; rtllib_send_DELBA(ieee, dst, &BA, TX_DIR, reason_code); return 0; } --=20 2.39.2