From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C17D9C0755A for ; Mon, 27 Nov 2023 05:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229794AbjK0FgO (ORCPT ); Mon, 27 Nov 2023 00:36:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbjK0FgL (ORCPT ); Mon, 27 Nov 2023 00:36:11 -0500 Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C8D9F0 for ; Sun, 26 Nov 2023 21:36:17 -0800 (PST) Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-6cd8c3a9edaso480190b3a.2 for ; Sun, 26 Nov 2023 21:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063377; x=1701668177; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7BNSjAfjsj6TnStXG6ZmHRofXAvHYH/XMDwqXWavaiA=; b=djCOBxEufKTjjCU3R9kJFeIMdc/qTwwDfzY0BszzAliVJS4PDmUD/xtEvUsjK1eo/N vrjpY9OlDV9m0wmYVEo+JYPQ8gaen2EhNxl6iJf8WZFzB0wHLwiDUISvrobfVgCRAWKO 9L6+qIjzbOLN8uGddnBFxayJDANTa8Ap2DR2p1Sag97NW7MS/GIRVJzJYRWqG2gTQUqE MUFZjkNTj5OOsM6i6sMqzWdE8SGC+SPKKo7CVItXglGJH4rxeT2NMxSST6cPmcCSIrCn pMRP6+X5p5zJ7iZLY58exz976XCWeroCJT5/Od1YPGedL0QMWgaAQsBZVvkm64FFU1L0 of/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063377; x=1701668177; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7BNSjAfjsj6TnStXG6ZmHRofXAvHYH/XMDwqXWavaiA=; b=k/bM1z9mdPJzEMi/9Jll+AHElBPfPJ3n9Dbz3jtdOYl4JTBKaW7q+WDAjj9QPa4rIm 1ZGy0uCkxxzOgrK9LuSn0FKn5GidCGFY2RupMmcvxsU8ihing49UwxftjqrhoShddwkq WIodIAQPwYWn9onZsnSFM4idWYAXEVg9g0Ql7Mm1+QRFi40Nn2+gTP6IuryBtWcJ+POC 9wGwNeA3r4wLo9bzaNs+dTJ6BsQlJdxtuRAeaCr0sOSZcvOBDZHj/EALsBiIZ0uV7COu rpAvKl3fiudL3irqFDc7eKO83tzPW6tlR546aosd53fI/9ekE2hYNscXxi6wAsA//S3h mfLg== X-Gm-Message-State: AOJu0YzXtHdmNdLeb2NIAOLXXt3SfPPEtZlmfGZwaFvBFxdqkxleCDYs aG7tylvjcm2c95sOz7VZp3j78A== X-Google-Smtp-Source: AGHT+IF7wlbCLu5aKqnvoDa+vzLrPQ1alT3S0V3uWasMqktoQcwKrtJf60uEqCxrF1GQbEBwQWcW5w== X-Received: by 2002:a05:6a21:3391:b0:182:119d:2d0e with SMTP id yy17-20020a056a21339100b00182119d2d0emr10898995pzb.20.1701063376908; Sun, 26 Nov 2023 21:36:16 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:16 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 01/15] Staging: rtl8192e: Rename variable pTxTs Date: Sun, 26 Nov 2023 21:42:51 -0800 Message-ID: <20231127054305.148276-2-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable pTxTs to ts to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 50 +++++++++++------------ drivers/staging/rtl8192e/rtl819x_TSProc.c | 8 ++-- drivers/staging/rtl8192e/rtllib_tx.c | 18 ++++---- 3 files changed, 38 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index b52b42ac0fc4..497791a980ba 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -23,10 +23,10 @@ static void deactivate_ba_entry(struct rtllib_device *i= eee, struct ba_record *ba del_timer_sync(&ba->timer); } =20 -static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record = *pTxTs) +static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record = *ts) { - struct ba_record *admitted_ba =3D &pTxTs->TxAdmittedBARecord; - struct ba_record *pending_ba =3D &pTxTs->TxPendingBARecord; + struct ba_record *admitted_ba =3D &ts->TxAdmittedBARecord; + struct ba_record *pending_ba =3D &ts->TxPendingBARecord; u8 send_del_ba =3D false; =20 if (pending_ba->b_valid) { @@ -443,20 +443,20 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struc= t sk_buff *skb) =20 rx_ts_delete_ba(ieee, ts); } else { - struct tx_ts_record *pTxTs; + struct tx_ts_record *ts; =20 - if (!rtllib_get_ts(ieee, (struct ts_common_info **)&pTxTs, dst, + if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, (u8)pDelBaParamSet->field.tid, TX_DIR, false)) { netdev_warn(ieee->dev, "%s(): can't get TS for TXTS\n", __func__); return -1; } =20 - pTxTs->using_ba =3D false; - pTxTs->add_ba_req_in_progress =3D false; - pTxTs->add_ba_req_delayed =3D false; - del_timer_sync(&pTxTs->TsAddBaTimer); - tx_ts_delete_ba(ieee, pTxTs); + ts->using_ba =3D false; + ts->add_ba_req_in_progress =3D false; + ts->add_ba_req_delayed =3D false; + del_timer_sync(&ts->TsAddBaTimer); + tx_ts_delete_ba(ieee, ts); } return 0; } @@ -489,14 +489,14 @@ void rtllib_ts_init_del_ba(struct rtllib_device *ieee, enum tr_select TxRxSelect) { if (TxRxSelect =3D=3D TX_DIR) { - struct tx_ts_record *pTxTs =3D + struct tx_ts_record *ts =3D (struct tx_ts_record *)pTsCommonInfo; =20 - if (tx_ts_delete_ba(ieee, pTxTs)) + if (tx_ts_delete_ba(ieee, ts)) rtllib_send_DELBA(ieee, pTsCommonInfo->addr, - (pTxTs->TxAdmittedBARecord.b_valid) ? - (&pTxTs->TxAdmittedBARecord) : - (&pTxTs->TxPendingBARecord), + (ts->TxAdmittedBARecord.b_valid) ? + (&ts->TxAdmittedBARecord) : + (&ts->TxPendingBARecord), TxRxSelect, DELBA_REASON_END_BA); } else if (TxRxSelect =3D=3D RX_DIR) { struct rx_ts_record *ts =3D @@ -510,23 +510,23 @@ void rtllib_ts_init_del_ba(struct rtllib_device *ieee, =20 void rtllib_ba_setup_timeout(struct timer_list *t) { - struct tx_ts_record *pTxTs =3D from_timer(pTxTs, t, + struct tx_ts_record *ts =3D from_timer(ts, t, TxPendingBARecord.timer); =20 - pTxTs->add_ba_req_in_progress =3D false; - pTxTs->add_ba_req_delayed =3D true; - pTxTs->TxPendingBARecord.b_valid =3D false; + ts->add_ba_req_in_progress =3D false; + ts->add_ba_req_delayed =3D true; + ts->TxPendingBARecord.b_valid =3D false; } =20 void rtllib_tx_ba_inact_timeout(struct timer_list *t) { - struct tx_ts_record *pTxTs =3D from_timer(pTxTs, t, + struct tx_ts_record *ts =3D from_timer(ts, t, TxAdmittedBARecord.timer); - struct rtllib_device *ieee =3D container_of(pTxTs, struct rtllib_device, - TxTsRecord[pTxTs->num]); - tx_ts_delete_ba(ieee, pTxTs); - rtllib_send_DELBA(ieee, pTxTs->TsCommonInfo.addr, - &pTxTs->TxAdmittedBARecord, TX_DIR, + struct rtllib_device *ieee =3D container_of(ts, struct rtllib_device, + TxTsRecord[ts->num]); + tx_ts_delete_ba(ieee, ts); + rtllib_send_DELBA(ieee, ts->TsCommonInfo.addr, + &ts->TxAdmittedBARecord, TX_DIR, DELBA_REASON_TIMEOUT); } =20 diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index 41c1e768348a..01d077bf0155 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -82,12 +82,12 @@ static void RxPktPendingTimeout(struct timer_list *t) =20 static void TsAddBaProcess(struct timer_list *t) { - struct tx_ts_record *pTxTs =3D from_timer(pTxTs, t, TsAddBaTimer); - u8 num =3D pTxTs->num; - struct rtllib_device *ieee =3D container_of(pTxTs, struct rtllib_device, + struct tx_ts_record *ts =3D from_timer(ts, t, TsAddBaTimer); + u8 num =3D ts->num; + struct rtllib_device *ieee =3D container_of(ts, struct rtllib_device, TxTsRecord[num]); =20 - rtllib_ts_init_add_ba(ieee, pTxTs, BA_POLICY_IMMEDIATE, false); + rtllib_ts_init_add_ba(ieee, ts, BA_POLICY_IMMEDIATE, false); netdev_dbg(ieee->dev, "%s(): ADDBA Req is started\n", __func__); } =20 diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 1da098f5b84c..2ef617a55995 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -267,7 +267,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, struct cb_desc *tcb_desc) { struct rt_hi_throughput *ht_info =3D ieee->ht_info; - struct tx_ts_record *pTxTs =3D NULL; + struct tx_ts_record *ts =3D NULL; struct ieee80211_hdr *hdr =3D (struct ieee80211_hdr *)skb->data; =20 if (rtllib_act_scanning(ieee, false)) @@ -289,25 +289,25 @@ static void rtllib_tx_query_agg_cap(struct rtllib_dev= ice *ieee, if (!ieee->GetNmodeSupportBySecCfg(ieee->dev)) return; if (ht_info->current_ampdu_enable) { - if (!rtllib_get_ts(ieee, (struct ts_common_info **)(&pTxTs), hdr->addr1, + if (!rtllib_get_ts(ieee, (struct ts_common_info **)(&ts), hdr->addr1, skb->priority, TX_DIR, true)) { netdev_info(ieee->dev, "%s: can't get TS\n", __func__); return; } - if (!pTxTs->TxAdmittedBARecord.b_valid) { + if (!ts->TxAdmittedBARecord.b_valid) { if (ieee->wpa_ie_len && (ieee->pairwise_key_type =3D=3D KEY_TYPE_NA)) { ; } else if (tcb_desc->bdhcp =3D=3D 1) { ; - } else if (!pTxTs->disable_add_ba) { - TsStartAddBaProcess(ieee, pTxTs); + } else if (!ts->disable_add_ba) { + TsStartAddBaProcess(ieee, ts); } goto FORCED_AGG_SETTING; - } else if (!pTxTs->using_ba) { - if (SN_LESS(pTxTs->TxAdmittedBARecord.ba_start_seq_ctrl.field.seq_num, - (pTxTs->TxCurSeq + 1) % 4096)) - pTxTs->using_ba =3D true; + } else if (!ts->using_ba) { + if (SN_LESS(ts->TxAdmittedBARecord.ba_start_seq_ctrl.field.seq_num, + (ts->TxCurSeq + 1) % 4096)) + ts->using_ba =3D true; else goto FORCED_AGG_SETTING; } --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83B38C4167B for ; Mon, 27 Nov 2023 05:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229898AbjK0FgR (ORCPT ); Mon, 27 Nov 2023 00:36:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42552 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229733AbjK0FgM (ORCPT ); Mon, 27 Nov 2023 00:36:12 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABC86B5 for ; Sun, 26 Nov 2023 21:36:18 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1cf89df1eecso23597935ad.3 for ; Sun, 26 Nov 2023 21:36:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063378; x=1701668178; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9mhtCZ2FPHkfJMzES7tFYFByhVEv5qF9kyJcqPMGxvU=; b=kHuT7HnFfwKsMB18g0ZE8pdVwAVSKBwB0+cA+hVUh3r0TXJlhfQgYTtmcctL71PuCG boHIiSVFfCNU6umEZ4Fwm3QywpU7oXNV9ZgPyZlq73CE+FEnYjcR4QD4s6dJW20e8xt7 BcpQ0hGKUasyrxKrLbU0vNHXP2Zuw83TosMKX6f/HLVPHFbdxZ0xcIxhT31OVn/1QRgU l02gjddsiWylPRp+IkMfeUD7GAHivpCFmQjPkAXZWXu7fuv/JrvJf3Wq7LlyOq6r3fGs Pod7zHXZX7p0c6wSiSdpMcOuVBhsoFVLuL66AXDXJJxXeHrucicLMQhVWNUSI3+zsau3 LVVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063378; x=1701668178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9mhtCZ2FPHkfJMzES7tFYFByhVEv5qF9kyJcqPMGxvU=; b=jkuteKlQwQFcBMoFU/5OxocTKJD0mDZx5UhwC0eV6UhYQ/BHa+InWglmpBhod1CwQF 2fBfXwSttI4wFzY/LaTnjrTPb7dDAiNmE4khU74r6Q1OFxB8BJ649VKgDJYj2BML+Vx3 d86uskiSqcqnqVUIBl2ngzK8369jUtpSvWOI7/VYCX1pGeXj1LC5CnhdBr++/SJ4IwTV bvONLwkLgjhoWQ04jRj9dk/l9o/t+1+112COfOsAPR4Dy+X11UtHY2mvNWec+nuAQpJg cwoonjVzX4/9/V4qb97OHEIYhf/mHlhJYSHH3IqTKca/5nhYt4qHwD9fG7nDaBWboCWS Y8hg== X-Gm-Message-State: AOJu0YyUOpfxNPwfXlJ5rT2+JryUZQpINj1Wm8CoHrejsXlaVmv2PPUZ wSkIixr6rBJdBN+ixuiYus0ipw== X-Google-Smtp-Source: AGHT+IEud1ssm4kngq3IOpf/LNa3Jt2Gd16D1urJFcRr2xOSzZtw9tCi93NJGF3GOu4LV8QrVN9dWQ== X-Received: by 2002:a17:902:dac4:b0:1cf:d7e2:5e73 with SMTP id q4-20020a170902dac400b001cfd7e25e73mr470783plx.49.1701063378238; Sun, 26 Nov 2023 21:36:18 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:17 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 02/15] Staging: rtl8192e: Rename variable BAReq Date: Sun, 26 Nov 2023 21:42:52 -0800 Message-ID: <20231127054305.148276-3-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable BAReq to ba_req to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 497791a980ba..f6ba922dc82e 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -68,7 +68,7 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_device = *ieee, u8 *dst, u16 status_code, u8 type) { struct sk_buff *skb =3D NULL; - struct ieee80211_hdr_3addr *BAReq =3D NULL; + struct ieee80211_hdr_3addr *ba_req =3D NULL; u8 *tag =3D NULL; u16 len =3D ieee->tx_headroom + 9; =20 @@ -87,13 +87,13 @@ static struct sk_buff *rtllib_ADDBA(struct rtllib_devic= e *ieee, u8 *dst, =20 skb_reserve(skb, ieee->tx_headroom); =20 - BAReq =3D skb_put(skb, sizeof(struct ieee80211_hdr_3addr)); + ba_req =3D skb_put(skb, sizeof(struct ieee80211_hdr_3addr)); =20 - ether_addr_copy(BAReq->addr1, dst); - ether_addr_copy(BAReq->addr2, ieee->dev->dev_addr); + ether_addr_copy(ba_req->addr1, dst); + ether_addr_copy(ba_req->addr2, ieee->dev->dev_addr); =20 - ether_addr_copy(BAReq->addr3, ieee->current_network.bssid); - BAReq->frame_control =3D cpu_to_le16(IEEE80211_STYPE_ACTION); + ether_addr_copy(ba_req->addr3, ieee->current_network.bssid); + ba_req->frame_control =3D cpu_to_le16(IEEE80211_STYPE_ACTION); =20 tag =3D skb_put(skb, 9); *tag++ =3D ACT_CAT_BA; --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0D7BC46CA0 for ; Mon, 27 Nov 2023 05:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230218AbjK0FgW (ORCPT ); Mon, 27 Nov 2023 00:36:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbjK0FgN (ORCPT ); Mon, 27 Nov 2023 00:36:13 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67386B5 for ; Sun, 26 Nov 2023 21:36:20 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1cfc2d03b3aso4393405ad.1 for ; Sun, 26 Nov 2023 21:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063380; x=1701668180; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WoeWuGVtTlW2JdoiNx27SMyvvU67YTUEiN2AiR6Cm+c=; b=mT/57NiKZ6mss7wDOlx/z3fRgY7l9MCP4aY/QpRHbsNO5bAzaEoQ1y6QO/0xacazlB R1zR341TN43slsu1INErUSQB6r/aeyHvtLm0V09FBD5J3xbsYd9PUL7MBTPyfuoyv2me F4pC8i+xyKiMYLkvWGDB1UOJZMuJOdmocJ2WqEmCfHyn6BWHG7KRPOy4Y/Jsyt6ztjBK zAPw+/+bes2rzhntzitsci5ZEeLte1SkqFgqEZAc/NbKcLatx/HGu3rfvTVkTy01eLiy qGMdbycSFZaxhzH7A4IF+tBrspNZwoztmhAD9uU0U60UwUEmCjBgmvI8j6yQJwB3OCyR LPGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063380; x=1701668180; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WoeWuGVtTlW2JdoiNx27SMyvvU67YTUEiN2AiR6Cm+c=; b=UYbGDfqvV1LwybhU1qBMQwU61ZlreIzKo6Zb6R6JSnMryHYGIlD1JsqFcfPIL8yhhe BkYJeN9xyKkDKRJONZPuBMkWrHrv38+tvnO6FamXu53V4d1yQgZJhfz8qejnIiDMEroM l5YhpbG/mL4nCao9bwjZv0hFhbIUADijbaNw7FORbLSEK23FynqVtT8B89LRcAXmkwnF yPZgLJgsSbDlsMhDLZFEAIrm1k2STCV5Q9fTHmRx/NVwiObBPyKV7kZBnC3aVrsNoCCz x0U/in74mtodLMOyXRFjYlKlUMf6Vv91vU+NHiUA8n87puznL/+n2txPdZXgM6KOF6Ub XWPQ== X-Gm-Message-State: AOJu0Yx8lhAR9e9wRm85zEL9OeqYrrDZOwDjQnWHtE9fBmqra2xPxPf3 GKH701yZDIajkADRsNuzvX2kgjNHL4ZelnbQ0Xo= X-Google-Smtp-Source: AGHT+IGwH33yIyeMw5+JjU7swS3KzlABo0WP0t0L2s4Q3aTp+hcLsSMuue5LeZz6wvQJ1xkJ9sR9Ng== X-Received: by 2002:a17:903:2292:b0:1cf:ba9d:abc0 with SMTP id b18-20020a170903229200b001cfba9dabc0mr5472868plh.67.1701063379679; Sun, 26 Nov 2023 21:36:19 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:19 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 03/15] Staging: rtl8192e: Rename variable Delba Date: Sun, 26 Nov 2023 21:42:53 -0800 Message-ID: <20231127054305.148276-4-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable Delba to del_ba to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index f6ba922dc82e..06aaae68aa6a 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -129,7 +129,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_devic= e *ieee, u8 *dst, { union delba_param_set DelbaParamSet; struct sk_buff *skb =3D NULL; - struct ieee80211_hdr_3addr *Delba =3D NULL; + struct ieee80211_hdr_3addr *del_ba =3D NULL; u8 *tag =3D NULL; u16 len =3D 6 + ieee->tx_headroom; =20 @@ -148,12 +148,12 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_dev= ice *ieee, u8 *dst, =20 skb_reserve(skb, ieee->tx_headroom); =20 - Delba =3D skb_put(skb, sizeof(struct ieee80211_hdr_3addr)); + del_ba =3D skb_put(skb, sizeof(struct ieee80211_hdr_3addr)); =20 - ether_addr_copy(Delba->addr1, dst); - ether_addr_copy(Delba->addr2, ieee->dev->dev_addr); - ether_addr_copy(Delba->addr3, ieee->current_network.bssid); - Delba->frame_control =3D cpu_to_le16(IEEE80211_STYPE_ACTION); + ether_addr_copy(del_ba->addr1, dst); + ether_addr_copy(del_ba->addr2, ieee->dev->dev_addr); + ether_addr_copy(del_ba->addr3, ieee->current_network.bssid); + del_ba->frame_control =3D cpu_to_le16(IEEE80211_STYPE_ACTION); =20 tag =3D skb_put(skb, 6); =20 --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35D9DC4167B for ; Mon, 27 Nov 2023 05:36:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231538AbjK0Fg1 (ORCPT ); Mon, 27 Nov 2023 00:36:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229813AbjK0FgP (ORCPT ); Mon, 27 Nov 2023 00:36:15 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C71DF0 for ; Sun, 26 Nov 2023 21:36:21 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1ce3084c2d1so30783775ad.3 for ; Sun, 26 Nov 2023 21:36:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063381; x=1701668181; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sSWu4uGFFfQhQmuUasXzTA2bl0qaMckYxBPrKB/bvN8=; b=CvpfOwzMYYqXBfj9GF6cc+qPaqUnc7bwPJpBOWDopRuqqGxlvq5yBrezF8kxSu7tFM UrwJfR3oWrKSgVPYQDIrWRA12v6tsTsL0c3vQ+DFjlgmuKI0sElpBm75cXL6K864jM8M Wm355kVgiwLF1q0TjGshRbgpXneRKH5Edw2xN4MkX7zlBataB4AsBUemLf5qo2Q+nF+l xWQ086FSBuPV3QbREkNT0fru+8WV2yJBC8AWXNm6fSQMYe/mjUtwGjHk8YPkrT7xtR0m b+Y8pddO5BrM+X8do3Loizyyqwebb5nCd4MxrPOimIg1CKJOeAGtOQuIeIwwfBmO1F0V p/8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063381; x=1701668181; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sSWu4uGFFfQhQmuUasXzTA2bl0qaMckYxBPrKB/bvN8=; b=esjmYDrxU7s05dDFNn/Nm/0YA+XCOutl1KDLQivl2rrSQ2+qvjyOPWrYX9HTdy+/2I Bsq/rtez5Y8341LpkduGP74pPqzrcAO/JKnec4KX6CPwLeyFDfPFqOMVSOihrdNfEuPS +zErnwbVaxspkq1UlOt9NamprR/NQwMuLnL3puIiDJzuGAgYHSg2yYruN8o2JEjc2UxC paZ5h5LiUjVqIOn/Dxdc/3rF2KpImxUtpWGWVtz8A5Inc6S4k2/dWPED0a0Lev7SLvE4 kgVpxp0dCrzsKWgNfFN3pjxs7zS543S/oonQC6TBR6IUo7oJWJsKlpcyAzQs+GgL5jL4 93QA== X-Gm-Message-State: AOJu0Yy96yDBI4vngKz7Wq/yeOwQl84Sp2R1zPUEjppnbgvrp+R2oumL HDCPrNLCUEffREU/apUSoIyP5w== X-Google-Smtp-Source: AGHT+IG9zsMtaxazmqVWmdOzqH/Oz69e+MfWSKGg/wU+gjSjEdOmvtli7gZHl/eLoW7O1VsLZFXmUQ== X-Received: by 2002:a17:902:6947:b0:1cf:c2dc:1c1c with SMTP id k7-20020a170902694700b001cfc2dc1c1cmr5407619plt.29.1701063381031; Sun, 26 Nov 2023 21:36:21 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:20 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 04/15] Staging: rtl8192e: Rename variable TSpec Date: Sun, 26 Nov 2023 21:42:54 -0800 Message-ID: <20231127054305.148276-5-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable TSpec to tspec to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 14 +++++++------- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 06aaae68aa6a..bf8d42668990 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -474,7 +474,7 @@ void rtllib_ts_init_add_ba(struct rtllib_device *ieee, = struct tx_ts_record *ts, ba->dialog_token++; ba->ba_param_set.field.amsdu_support =3D 0; ba->ba_param_set.field.ba_policy =3D policy; - ba->ba_param_set.field.tid =3D ts->TsCommonInfo.TSpec.ucTSID; + ba->ba_param_set.field.tid =3D ts->TsCommonInfo.tspec.ucTSID; ba->ba_param_set.field.buffer_size =3D 32; ba->ba_timeout_value =3D 0; ba->ba_start_seq_ctrl.field.seq_num =3D (ts->TxCurSeq + 3) % 4096; diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl819= 2e/rtl819x_TS.h index 742f575ea637..f2bd53268e3a 100644 --- a/drivers/staging/rtl8192e/rtl819x_TS.h +++ b/drivers/staging/rtl8192e/rtl819x_TS.h @@ -19,7 +19,7 @@ enum tr_select { struct ts_common_info { struct list_head List; u8 addr[ETH_ALEN]; - struct qos_tsinfo TSpec; + struct qos_tsinfo tspec; }; =20 struct tx_ts_record { diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index 01d077bf0155..039f070aadd1 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -94,7 +94,7 @@ static void TsAddBaProcess(struct timer_list *t) static void ResetTsCommonInfo(struct ts_common_info *pTsCommonInfo) { eth_zero_addr(pTsCommonInfo->addr); - memset(&pTsCommonInfo->TSpec, 0, sizeof(struct qos_tsinfo)); + memset(&pTsCommonInfo->tspec, 0, sizeof(struct qos_tsinfo)); } =20 static void ResetTxTsEntry(struct tx_ts_record *ts) @@ -198,8 +198,8 @@ static struct ts_common_info *SearchAdmitTRStream(struc= t rtllib_device *ieee, continue; list_for_each_entry(pRet, psearch_list, List) { if (memcmp(pRet->addr, addr, 6) =3D=3D 0 && - pRet->TSpec.ucTSID =3D=3D TID && - pRet->TSpec.ucDirection =3D=3D dir) + pRet->tspec.ucTSID =3D=3D TID && + pRet->tspec.ucDirection =3D=3D dir) break; } if (&pRet->List !=3D psearch_list) @@ -220,7 +220,7 @@ static void MakeTSEntry(struct ts_common_info *pTsCommo= nInfo, u8 *addr, memcpy(pTsCommonInfo->addr, addr, 6); =20 if (pTSPEC) - memcpy((u8 *)(&(pTsCommonInfo->TSpec)), (u8 *)pTSPEC, + memcpy((u8 *)(&(pTsCommonInfo->tspec)), (u8 *)pTSPEC, sizeof(struct qos_tsinfo)); } =20 @@ -228,8 +228,8 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct t= s_common_info **ppTS, u8 *addr, u8 TID, enum tr_select TxRxSelect, bool bAddNewTs) { u8 UP =3D 0; - struct qos_tsinfo TSpec; - struct qos_tsinfo *ts_info =3D &TSpec; + struct qos_tsinfo tspec; + struct qos_tsinfo *ts_info =3D &tspec; struct list_head *pUnusedList; struct list_head *pAddmitList; enum direction_value Dir; @@ -308,7 +308,7 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct t= s_common_info **ppTS, ts_info->ucTSID =3D UP; ts_info->ucDirection =3D Dir; =20 - MakeTSEntry(*ppTS, addr, &TSpec); + MakeTSEntry(*ppTS, addr, &tspec); list_add_tail(&((*ppTS)->List), pAddmitList); =20 return true; --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42AC0C4167B for ; Mon, 27 Nov 2023 05:36:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232289AbjK0Fgb (ORCPT ); Mon, 27 Nov 2023 00:36:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42588 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229863AbjK0FgQ (ORCPT ); Mon, 27 Nov 2023 00:36:16 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7A80134 for ; Sun, 26 Nov 2023 21:36:22 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1cfc2bcffc7so5090255ad.1 for ; Sun, 26 Nov 2023 21:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063382; x=1701668182; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DZZM2c5g/+TPAQIyy7mIwCyenkF8kluxFKUdyumlEzY=; b=EBKYhY/UtkXNEcDIsw1jlbMBmYVLlgRMbnOVobr8d1SCu6pG/P6bGhVOOKrfMYyuaz KTKkHFR/G5ooWnjXfB86hB4DRLQOVtKPXVSEEs+hv0PCDYcdsPLwU7hHyLGwPEGd+ujN PsrUpvIAV3vWhdYSirWcD7XN/+vP5mfSK5qcU/3/sxXuj7tB7RWRdH6Fk8J4a3MW1N4w zzINIV0yotrMHpL83HY/AuCvuD7lVGoh1Fcpx9nqsr8+hiav5Gd1GHmxsHLUFuQDTGMI NGhPyfUD1ucFDKcfSBzBAD+vPrmdp9Q2581OozsDXHujk2qq0KOAk3hercE/a7il05S0 BXWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063382; x=1701668182; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DZZM2c5g/+TPAQIyy7mIwCyenkF8kluxFKUdyumlEzY=; b=AkfRCsgjU9NV7QPwtpRtU9xZZEPOIC3DD9yXu2hSszVtMpW2cy3AEiBmTSPyiz+Znj zjHK8JrPc2Z3WZeCLRGLG4qyFZDYAvfubw37mhMpoI6O4BNfaWCPG8vZ9zjENDV3C1ad Y7SIq94APQV6cJdDNexQvVXxz47r2g98ySgoAY0PnUP1ufvBJq4Eer37lNv8N8t1kBza 9O1u0RVOCCWS/HC30TRDTIwsNe7vjNZ1h61n4fO/nLhCULHUPewZqRrDbjKl/W5ASg1z luTiYqHp26qN2K74BMhAqxsXOBJvzPUAZbALlmdgLMyeJbORqemXkcxylFF7tcI1Vhj6 6P8w== X-Gm-Message-State: AOJu0YwrK4FJ2YLNOoPp4zZqE5iXNspAK3u4oMW47hoT97AS5SPuQtA2 4lseVljZjJpO6ddPSSZ3TpjJpA== X-Google-Smtp-Source: AGHT+IHCkcRzecB8ILsptMxgN5ky2tpVSiuXnhBEYbPJugtAJYw26N7txXsXCLcOKsZwU4R4h9uY6w== X-Received: by 2002:a17:902:d48d:b0:1cf:c4d3:f337 with SMTP id c13-20020a170902d48d00b001cfc4d3f337mr2817000plg.30.1701063382241; Sun, 26 Nov 2023 21:36:22 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:21 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 05/15] Staging: rtl8192e: Rename variable TxAdmittedBARecord Date: Sun, 26 Nov 2023 21:42:55 -0800 Message-ID: <20231127054305.148276-6-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable TxAdmittedBARecord to tx_admitted_ba_record to fix checkpat= ch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++++++------ drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 4 ++-- drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index bf8d42668990..db529559592b 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -25,7 +25,7 @@ static void deactivate_ba_entry(struct rtllib_device *iee= e, struct ba_record *ba =20 static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record = *ts) { - struct ba_record *admitted_ba =3D &ts->TxAdmittedBARecord; + struct ba_record *admitted_ba =3D &ts->tx_admitted_ba_record; struct ba_record *pending_ba =3D &ts->TxPendingBARecord; u8 send_del_ba =3D false; =20 @@ -346,7 +346,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) =20 ts->add_ba_req_in_progress =3D false; pending_ba =3D &ts->TxPendingBARecord; - pAdmittedBA =3D &ts->TxAdmittedBARecord; + pAdmittedBA =3D &ts->tx_admitted_ba_record; =20 if (pAdmittedBA->b_valid) { netdev_dbg(ieee->dev, "%s(): ADDBA response already admitted\n", @@ -494,8 +494,8 @@ void rtllib_ts_init_del_ba(struct rtllib_device *ieee, =20 if (tx_ts_delete_ba(ieee, ts)) rtllib_send_DELBA(ieee, pTsCommonInfo->addr, - (ts->TxAdmittedBARecord.b_valid) ? - (&ts->TxAdmittedBARecord) : + (ts->tx_admitted_ba_record.b_valid) ? + (&ts->tx_admitted_ba_record) : (&ts->TxPendingBARecord), TxRxSelect, DELBA_REASON_END_BA); } else if (TxRxSelect =3D=3D RX_DIR) { @@ -521,12 +521,12 @@ void rtllib_ba_setup_timeout(struct timer_list *t) void rtllib_tx_ba_inact_timeout(struct timer_list *t) { struct tx_ts_record *ts =3D from_timer(ts, t, - TxAdmittedBARecord.timer); + tx_admitted_ba_record.timer); struct rtllib_device *ieee =3D container_of(ts, struct rtllib_device, TxTsRecord[ts->num]); tx_ts_delete_ba(ieee, ts); rtllib_send_DELBA(ieee, ts->TsCommonInfo.addr, - &ts->TxAdmittedBARecord, TX_DIR, + &ts->tx_admitted_ba_record, TX_DIR, DELBA_REASON_TIMEOUT); } =20 diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl819= 2e/rtl819x_TS.h index f2bd53268e3a..40b0ed4fefaf 100644 --- a/drivers/staging/rtl8192e/rtl819x_TS.h +++ b/drivers/staging/rtl8192e/rtl819x_TS.h @@ -26,7 +26,7 @@ struct tx_ts_record { struct ts_common_info TsCommonInfo; u16 TxCurSeq; struct ba_record TxPendingBARecord; - struct ba_record TxAdmittedBARecord; + struct ba_record tx_admitted_ba_record; u8 add_ba_req_in_progress; u8 add_ba_req_delayed; u8 using_ba; diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index 039f070aadd1..0e59a3155c4a 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -105,7 +105,7 @@ static void ResetTxTsEntry(struct tx_ts_record *ts) ts->add_ba_req_delayed =3D false; ts->using_ba =3D false; ts->disable_add_ba =3D false; - rtllib_reset_ba_entry(&ts->TxAdmittedBARecord); + rtllib_reset_ba_entry(&ts->tx_admitted_ba_record); rtllib_reset_ba_entry(&ts->TxPendingBARecord); } =20 @@ -134,7 +134,7 @@ void rtllib_ts_init(struct rtllib_device *ieee) =20 timer_setup(&pTxTS->TxPendingBARecord.timer, rtllib_ba_setup_timeout, 0); - timer_setup(&pTxTS->TxAdmittedBARecord.timer, + timer_setup(&pTxTS->tx_admitted_ba_record.timer, rtllib_tx_ba_inact_timeout, 0); =20 ResetTxTsEntry(pTxTS); diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 2ef617a55995..51a8286abd18 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -294,7 +294,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, netdev_info(ieee->dev, "%s: can't get TS\n", __func__); return; } - if (!ts->TxAdmittedBARecord.b_valid) { + if (!ts->tx_admitted_ba_record.b_valid) { if (ieee->wpa_ie_len && (ieee->pairwise_key_type =3D=3D KEY_TYPE_NA)) { ; @@ -305,7 +305,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, } goto FORCED_AGG_SETTING; } else if (!ts->using_ba) { - if (SN_LESS(ts->TxAdmittedBARecord.ba_start_seq_ctrl.field.seq_num, + if (SN_LESS(ts->tx_admitted_ba_record.ba_start_seq_ctrl.field.seq_num, (ts->TxCurSeq + 1) % 4096)) ts->using_ba =3D true; else --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4AC8C4167B for ; Mon, 27 Nov 2023 05:36:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232361AbjK0Fgf (ORCPT ); Mon, 27 Nov 2023 00:36:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231144AbjK0FgT (ORCPT ); Mon, 27 Nov 2023 00:36:19 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3C4C9181 for ; Sun, 26 Nov 2023 21:36:24 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1ce28faa92dso27611085ad.2 for ; Sun, 26 Nov 2023 21:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063383; x=1701668183; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7t+OYK182Y2YaDvus2aSQWjkkPId6oQnfxA8XGPoAC0=; b=YZJ5SHcl7aUmFDcJULk+rV3l+J4R4IeqMqvWwXlgCLxt4LaQ5YhOb2V+BClr6H7LrR Fkfy0/VZKEWt3eX3HDLJgOvZAazWm2DQH7Wn2RDEkHOvrAxPCrtcsknF1wlgw1fuyBQK ELbFS5+mOWL+WXyOgu5VFa9eOwtCo9MHcOu8DtMbFJzMlH+R4nEg/OhOzJDDdVrsx1+i MZowScH6oiU+sHhGLgdN8mNSHZcy1MW3auaInPzUH0TzqydlsDwJPWvFw9PanlfZ3nkW x/MzvzVoX4kmgrmqgfHBWT/1d4pp3HPFxEIyp/lo2QGPQcVgB0WZB8MJ1uiGg+c5DlFW DQ7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063383; x=1701668183; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7t+OYK182Y2YaDvus2aSQWjkkPId6oQnfxA8XGPoAC0=; b=UqZGd9cMunC1GiR77CQwNz4j5UfLB7qHRJUjixOxQ5phFFX7GK93Dp3xOHqujChigD eN2ja89PKQ5OdRJySvoDvKMSWONTp7MlXjM+duJ6358hwboafHVhFYCH6oE1xd8PfBnu pBe+Hn3wuJNT+T1H5y3jmRcqoQ1vCkyHWj5VFrg1rK1KlWJusDQonQZKz8AD2U190FoD Md/0c+SooHHTsq8sICaQW3XJqOygX07agpX1p7v8V79mQkH4RfOjnUMb5O7VUhutvDFh XKxQ+5sv3bvcZcvnrUv/YMEToFYM0NdfrvFNZXX45vvU76sJjWu1JhzOLUdBO0tISwJP /FAw== X-Gm-Message-State: AOJu0Yx7ZVME2TEmaIM0rxu6sbCDQWvVn3S5bCSRZkzJOoqtYLxhddKz gNNvQeve0lY8+ZaeNwP/zh1+MQ== X-Google-Smtp-Source: AGHT+IE57QNdCEPZbFQdAjj4hB6nPCp4P/v3sfj6qw9fmnuQ8lkMcFbQ3JqOoxc7Wvl2rp47jrRATw== X-Received: by 2002:a17:902:a9c5:b0:1cf:b55d:a11d with SMTP id b5-20020a170902a9c500b001cfb55da11dmr4353516plr.24.1701063383569; Sun, 26 Nov 2023 21:36:23 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:23 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 06/15] Staging: rtl8192e: Rename variable TxPendingBARecord Date: Sun, 26 Nov 2023 21:42:56 -0800 Message-ID: <20231127054305.148276-7-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable TxPendingBARecord to tx_pending_ba_record to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 12 ++++++------ drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index db529559592b..51deab720e76 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -26,7 +26,7 @@ static void deactivate_ba_entry(struct rtllib_device *iee= e, struct ba_record *ba static u8 tx_ts_delete_ba(struct rtllib_device *ieee, struct tx_ts_record = *ts) { struct ba_record *admitted_ba =3D &ts->tx_admitted_ba_record; - struct ba_record *pending_ba =3D &ts->TxPendingBARecord; + struct ba_record *pending_ba =3D &ts->tx_pending_ba_record; u8 send_del_ba =3D false; =20 if (pending_ba->b_valid) { @@ -345,7 +345,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) } =20 ts->add_ba_req_in_progress =3D false; - pending_ba =3D &ts->TxPendingBARecord; + pending_ba =3D &ts->tx_pending_ba_record; pAdmittedBA =3D &ts->tx_admitted_ba_record; =20 if (pAdmittedBA->b_valid) { @@ -464,7 +464,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct = sk_buff *skb) void rtllib_ts_init_add_ba(struct rtllib_device *ieee, struct tx_ts_record= *ts, u8 policy, u8 overwrite_pending) { - struct ba_record *ba =3D &ts->TxPendingBARecord; + struct ba_record *ba =3D &ts->tx_pending_ba_record; =20 if (ba->b_valid && !overwrite_pending) return; @@ -496,7 +496,7 @@ void rtllib_ts_init_del_ba(struct rtllib_device *ieee, rtllib_send_DELBA(ieee, pTsCommonInfo->addr, (ts->tx_admitted_ba_record.b_valid) ? (&ts->tx_admitted_ba_record) : - (&ts->TxPendingBARecord), + (&ts->tx_pending_ba_record), TxRxSelect, DELBA_REASON_END_BA); } else if (TxRxSelect =3D=3D RX_DIR) { struct rx_ts_record *ts =3D @@ -511,11 +511,11 @@ void rtllib_ts_init_del_ba(struct rtllib_device *ieee, void rtllib_ba_setup_timeout(struct timer_list *t) { struct tx_ts_record *ts =3D from_timer(ts, t, - TxPendingBARecord.timer); + tx_pending_ba_record.timer); =20 ts->add_ba_req_in_progress =3D false; ts->add_ba_req_delayed =3D true; - ts->TxPendingBARecord.b_valid =3D false; + ts->tx_pending_ba_record.b_valid =3D false; } =20 void rtllib_tx_ba_inact_timeout(struct timer_list *t) diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl819= 2e/rtl819x_TS.h index 40b0ed4fefaf..fdd5f1a2e835 100644 --- a/drivers/staging/rtl8192e/rtl819x_TS.h +++ b/drivers/staging/rtl8192e/rtl819x_TS.h @@ -25,7 +25,7 @@ struct ts_common_info { struct tx_ts_record { struct ts_common_info TsCommonInfo; u16 TxCurSeq; - struct ba_record TxPendingBARecord; + struct ba_record tx_pending_ba_record; struct ba_record tx_admitted_ba_record; u8 add_ba_req_in_progress; u8 add_ba_req_delayed; diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index 0e59a3155c4a..ed14e8e1ed93 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -106,7 +106,7 @@ static void ResetTxTsEntry(struct tx_ts_record *ts) ts->using_ba =3D false; ts->disable_add_ba =3D false; rtllib_reset_ba_entry(&ts->tx_admitted_ba_record); - rtllib_reset_ba_entry(&ts->TxPendingBARecord); + rtllib_reset_ba_entry(&ts->tx_pending_ba_record); } =20 static void ResetRxTsEntry(struct rx_ts_record *ts) @@ -132,7 +132,7 @@ void rtllib_ts_init(struct rtllib_device *ieee) pTxTS->num =3D count; timer_setup(&pTxTS->TsAddBaTimer, TsAddBaProcess, 0); =20 - timer_setup(&pTxTS->TxPendingBARecord.timer, rtllib_ba_setup_timeout, + timer_setup(&pTxTS->tx_pending_ba_record.timer, rtllib_ba_setup_timeout, 0); timer_setup(&pTxTS->tx_admitted_ba_record.timer, rtllib_tx_ba_inact_timeout, 0); --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15F1EC4167B for ; Mon, 27 Nov 2023 05:36:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232209AbjK0Fgj (ORCPT ); Mon, 27 Nov 2023 00:36:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231314AbjK0FgU (ORCPT ); Mon, 27 Nov 2023 00:36:20 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42D86189 for ; Sun, 26 Nov 2023 21:36:25 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1cfae5ca719so13902145ad.0 for ; Sun, 26 Nov 2023 21:36:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063385; x=1701668185; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tVZx2znymTutkOywVzUkt2j2sn+uTemk2vkexBlkB8A=; b=lXtH+WCTPNK3SmWE65BNYyNLduRpJx2uRYYQ95vbOQch4/go5rmy+K/rT5FZ7g8lUT A+aenF8Dg1rJUbSUAIWwPLZ3iLc5jAQJCrbz5PxTNTokyeacDp90VN10ugZ4JvQjsjMb P0vNvzedBa0fahDmmzDBinXTuUr2idTRhgLb96arIWRqy8UzzZEoIJNaLvSjZZQWhU20 retcC4C628eL9+1D43YrrAGyjlw+uYn8ZOcmXPW46Ibz/C0FPIRneyah/XuVEfvKrZsI DQNjIZ/2MSuAMOy3TTLlY7AetUonfZQYfDB3WdlBAm9K3XXXPMqVvSfEftq0DEb68y8I tvYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063385; x=1701668185; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tVZx2znymTutkOywVzUkt2j2sn+uTemk2vkexBlkB8A=; b=mPeDq4011MnHSB6w/wUj+EQp/pQ7yQOD8gseZ1m4mW60Tfswi/TfT2Gyr+bOtrSke/ aabztaDG7v9k5F4ZsvW5og1DvigDKitFSGDMWrwpY+3FVrqmqFg8aNyMjKLBqqnL+2xv IRTdwHYgxu9kTFffJG6h9UFZQ53pJh5gB1f0gi4DMq2NSn/vflv5/sfz+8UEPm+xN4/K +M19g3mNN5+fA+f66FNsoZuuIWd/wKIyvUmEcSSpdKRrj/eRP/ipMVuoAoOVh20hLYZ2 piZe33qrqnCf+nZBPPWFLcQ68srWdTjNEJ3aAa5QZPOg3u+qpxNjBFRan0kHEarS1iq3 brew== X-Gm-Message-State: AOJu0Yz7qaNUFMk83JPuQUTrWdR0BV09+t4a7g+10ALRZzqA3Vf1DeXV yZLkbA16b4J3wPEP+BBZi3EDXw== X-Google-Smtp-Source: AGHT+IFgTjNmDfa98uCeE9DnBvPC5kZubca/TiaCBOiEBfJvfJgqdUncaAbgjCkb8hDdxr4iO7033A== X-Received: by 2002:a17:902:ec85:b0:1cf:a9c4:7f4b with SMTP id x5-20020a170902ec8500b001cfa9c47f4bmr9325205plg.24.1701063384760; Sun, 26 Nov 2023 21:36:24 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:24 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 07/15] Staging: rtl8192e: Rename variable pDialogToken Date: Sun, 26 Nov 2023 21:42:57 -0800 Message-ID: <20231127054305.148276-8-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable pDialogToken to dialog_token to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 51deab720e76..78da79ebd775 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -215,7 +215,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) { struct ieee80211_hdr_3addr *req =3D NULL; u16 rc =3D 0; - u8 *dst =3D NULL, *pDialogToken =3D NULL, *tag =3D NULL; + u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; struct ba_record *ba =3D NULL; union ba_param_set *pBaParamSet =3D NULL; u16 *pBaTimeoutVal =3D NULL; @@ -238,7 +238,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) tag =3D (u8 *)req; dst =3D (u8 *)(&req->addr2[0]); tag +=3D sizeof(struct ieee80211_hdr_3addr); - pDialogToken =3D tag + 2; + dialog_token =3D tag + 2; pBaParamSet =3D (union ba_param_set *)(tag + 3); pBaTimeoutVal =3D (u16 *)(tag + 5); pBaStartSeqCtrl =3D (union sequence_control *)(req + 7); @@ -271,7 +271,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) rtllib_FlushRxTsPendingPkts(ieee, ts); =20 deactivate_ba_entry(ieee, ba); - ba->dialog_token =3D *pDialogToken; + ba->dialog_token =3D *dialog_token; ba->ba_param_set =3D *pBaParamSet; ba->ba_timeout_value =3D *pBaTimeoutVal; ba->ba_start_seq_ctrl =3D *pBaStartSeqCtrl; @@ -293,7 +293,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) =20 BA.ba_param_set =3D *pBaParamSet; BA.ba_timeout_value =3D *pBaTimeoutVal; - BA.dialog_token =3D *pDialogToken; + BA.dialog_token =3D *dialog_token; BA.ba_param_set.field.ba_policy =3D BA_POLICY_IMMEDIATE; rtllib_send_ADDBARsp(ieee, dst, &BA, rc); return 0; @@ -305,7 +305,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) struct ieee80211_hdr_3addr *rsp =3D NULL; struct ba_record *pending_ba, *pAdmittedBA; struct tx_ts_record *ts =3D NULL; - u8 *dst =3D NULL, *pDialogToken =3D NULL, *tag =3D NULL; + u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; u16 *status_code =3D NULL, *pBaTimeoutVal =3D NULL; union ba_param_set *pBaParamSet =3D NULL; u16 reason_code; @@ -320,7 +320,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) tag =3D (u8 *)rsp; dst =3D (u8 *)(&rsp->addr2[0]); tag +=3D sizeof(struct ieee80211_hdr_3addr); - pDialogToken =3D tag + 2; + dialog_token =3D tag + 2; status_code =3D (u16 *)(tag + 3); pBaParamSet =3D (union ba_param_set *)(tag + 5); pBaTimeoutVal =3D (u16 *)(tag + 7); @@ -353,7 +353,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) __func__); return -1; } else if (!pending_ba->b_valid || - (*pDialogToken !=3D pending_ba->dialog_token)) { + (*dialog_token !=3D pending_ba->dialog_token)) { netdev_warn(ieee->dev, "%s(): ADDBA Rsp. BA invalid, DELBA!\n", __func__); @@ -374,7 +374,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) goto OnADDBARsp_Reject; } =20 - pAdmittedBA->dialog_token =3D *pDialogToken; + pAdmittedBA->dialog_token =3D *dialog_token; pAdmittedBA->ba_timeout_value =3D *pBaTimeoutVal; pAdmittedBA->ba_start_seq_ctrl =3D pending_ba->ba_start_seq_ctrl; pAdmittedBA->ba_param_set =3D *pBaParamSet; --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EEB7C4167B for ; Mon, 27 Nov 2023 05:36:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229765AbjK0Fgn (ORCPT ); Mon, 27 Nov 2023 00:36:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229509AbjK0FgV (ORCPT ); Mon, 27 Nov 2023 00:36:21 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C24918E for ; Sun, 26 Nov 2023 21:36:26 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1cfae5ca719so13902225ad.0 for ; Sun, 26 Nov 2023 21:36:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063385; x=1701668185; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7IN7Uz/ApgY1f3u5IU30JsgnfKyUE/XtB4TY8u0u2IE=; b=d97KayVXdvR/FWwj99cYcoaTjpo3yqJAyXPiwUj/ZKdvRGdWbyeSKx7F2j+PMqVsL8 +4p+vc876H3barusarVNngIUi6drTbjWvcBgW5MbXYOcvoN7s22DRWSHMzY8XbFA6lNr x36d+17mMTdIrQuHdMKIFbNQ/H3RPvM/BBqej0eluIQF4N6fcUyam0y9ybuGJToDfeeH 8FhmmlfGiwjBIiiZOpdAgMH0tklFB9GQ+JYFNqX/EKXggHulw1xRJW4t7PpHn3Hrn9KV jfRWAPt0JlAZ/xHNL01DLsO8k9cIOsR+agPciKeqG3FbMmJqJ7sQW4ob/PF50n8mBTgR Fz3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063385; x=1701668185; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7IN7Uz/ApgY1f3u5IU30JsgnfKyUE/XtB4TY8u0u2IE=; b=Rim5BIJOt9O2M4ZEOb7OiryKUK4KQSRWoFTe3y7Ebk/HFW4L2g7O0ywFhPil/uP1Od cvI4g+A/s5GZQNtqGcvsBjkIZGu6lTY6PsFr8DD5w5HF5HnAs8bB4hEvOsyt0KX35XxD y+RwUzpZrJ2ZdYctrghzG1D5ShOnsWGaNohT5KK9XTDkYSqn1C9ZrbFd/iVJt9XxQqcS UdQx9EF+mbbHa6Yf1wd+4Ru5LciWtEB6v66Cfsc8XU9hKxLzDght5lFsnBsToZ0GTMwk 1jmVZ3+QEWwm3hZWmMiDPG+n/NXs+fleQzz9MrE1TFirNs1kftSxMCq6smOefEftzDLn /fDA== X-Gm-Message-State: AOJu0YxHXOEmNK24hee5WBxQyDehzKezX2NwBHsF6QedjJzR+qtN1MaY A4O4h423TPklfD8BchUsfXTp7Q== X-Google-Smtp-Source: AGHT+IHB8qLA1itApM0KaYIbMULLjPaTaLcTr8nkQl51KE5AUYBOL3RWSteixe/bb0DBDbIRYuEjgw== X-Received: by 2002:a17:902:d488:b0:1cf:c518:fa3a with SMTP id c8-20020a170902d48800b001cfc518fa3amr2470988plg.23.1701063385660; Sun, 26 Nov 2023 21:36:25 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:25 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 08/15] Staging: rtl8192e: Rename variable pTsCommonInfo Date: Sun, 26 Nov 2023 21:42:58 -0800 Message-ID: <20231127054305.148276-9-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable pTsCommonInfo to ts_common_info to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +++++----- drivers/staging/rtl8192e/rtl819x_TSProc.c | 14 +++++++------- drivers/staging/rtl8192e/rtllib.h | 2 +- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 78da79ebd775..d11cbe3bbb31 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -485,24 +485,24 @@ void rtllib_ts_init_add_ba(struct rtllib_device *ieee= , struct tx_ts_record *ts, } =20 void rtllib_ts_init_del_ba(struct rtllib_device *ieee, - struct ts_common_info *pTsCommonInfo, + struct ts_common_info *ts_common_info, enum tr_select TxRxSelect) { if (TxRxSelect =3D=3D TX_DIR) { struct tx_ts_record *ts =3D - (struct tx_ts_record *)pTsCommonInfo; + (struct tx_ts_record *)ts_common_info; =20 if (tx_ts_delete_ba(ieee, ts)) - rtllib_send_DELBA(ieee, pTsCommonInfo->addr, + rtllib_send_DELBA(ieee, ts_common_info->addr, (ts->tx_admitted_ba_record.b_valid) ? (&ts->tx_admitted_ba_record) : (&ts->tx_pending_ba_record), TxRxSelect, DELBA_REASON_END_BA); } else if (TxRxSelect =3D=3D RX_DIR) { struct rx_ts_record *ts =3D - (struct rx_ts_record *)pTsCommonInfo; + (struct rx_ts_record *)ts_common_info; if (rx_ts_delete_ba(ieee, ts)) - rtllib_send_DELBA(ieee, pTsCommonInfo->addr, + rtllib_send_DELBA(ieee, ts_common_info->addr, &ts->rx_admitted_ba_record, TxRxSelect, DELBA_REASON_END_BA); } diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index ed14e8e1ed93..2e6b705437d9 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -91,10 +91,10 @@ static void TsAddBaProcess(struct timer_list *t) netdev_dbg(ieee->dev, "%s(): ADDBA Req is started\n", __func__); } =20 -static void ResetTsCommonInfo(struct ts_common_info *pTsCommonInfo) +static void ResetTsCommonInfo(struct ts_common_info *ts_common_info) { - eth_zero_addr(pTsCommonInfo->addr); - memset(&pTsCommonInfo->tspec, 0, sizeof(struct qos_tsinfo)); + eth_zero_addr(ts_common_info->addr); + memset(&ts_common_info->tspec, 0, sizeof(struct qos_tsinfo)); } =20 static void ResetTxTsEntry(struct tx_ts_record *ts) @@ -211,16 +211,16 @@ static struct ts_common_info *SearchAdmitTRStream(str= uct rtllib_device *ieee, return NULL; } =20 -static void MakeTSEntry(struct ts_common_info *pTsCommonInfo, u8 *addr, +static void MakeTSEntry(struct ts_common_info *ts_common_info, u8 *addr, struct qos_tsinfo *pTSPEC) { - if (!pTsCommonInfo) + if (!ts_common_info) return; =20 - memcpy(pTsCommonInfo->addr, addr, 6); + memcpy(ts_common_info->addr, addr, 6); =20 if (pTSPEC) - memcpy((u8 *)(&(pTsCommonInfo->tspec)), (u8 *)pTSPEC, + memcpy((u8 *)(&(ts_common_info->tspec)), (u8 *)pTSPEC, sizeof(struct qos_tsinfo)); } =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 77ae259eab35..5f372554d424 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1787,7 +1787,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struc= t sk_buff *skb); void rtllib_ts_init_add_ba(struct rtllib_device *ieee, struct tx_ts_record= *ts, u8 policy, u8 overwrite_pending); void rtllib_ts_init_del_ba(struct rtllib_device *ieee, - struct ts_common_info *pTsCommonInfo, + struct ts_common_info *ts_common_info, enum tr_select TxRxSelect); void rtllib_ba_setup_timeout(struct timer_list *t); void rtllib_tx_ba_inact_timeout(struct timer_list *t); --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A81A3C4167B for ; Mon, 27 Nov 2023 05:36:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232416AbjK0Fgr (ORCPT ); Mon, 27 Nov 2023 00:36:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231658AbjK0FgX (ORCPT ); Mon, 27 Nov 2023 00:36:23 -0500 Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30358131 for ; Sun, 26 Nov 2023 21:36:27 -0800 (PST) Received: by mail-pl1-x62c.google.com with SMTP id d9443c01a7336-1cfd04a6e49so2948175ad.0 for ; Sun, 26 Nov 2023 21:36:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063386; x=1701668186; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dnWmbSD77bZFfBCr2C5cF8GBPNk3SBRZbqkEH4Q4DFY=; b=C5DC+bbwR+oBVZg2XtK/24utG0D3Cw9mSC3FuZg0+4LqhZtDWtzdb5JMEbS4VXbz6M HxOVFZOPe/aHwzavDvd1+BdUb6sO7mJamDGqi3zY4O4RVtmjQLZShnTpQADKp/Knk87S BRxwx+HMul8M9qEcb4TAZi8IoYkfV9FxRwXy1+NU+6sgJmdPDBbVakwKxPC4A9QfOsdm mx/rB8BNfvlp9gUpKA4oowDdWqJsiCITnfsXLK/ROCJk8LuBzzwBA0mtu64ozh/BXncW yr2oEnAuqEJx3p1NDEXn925MuDcaSOL+nFvhQqCq+qiIjNf2noSRXpjs1qOBbatcklRT Bm+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063386; x=1701668186; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dnWmbSD77bZFfBCr2C5cF8GBPNk3SBRZbqkEH4Q4DFY=; b=jLCcO4dVGTBJN9EdhacaYXskUwI+Uq9RPMtk9c2agxm8VBbdd8Vn1HCtD5F3YF8WTr 5ia1OPGHuJUuXzudN1J62xOnZaNHtsvPdhmVB/LKqsXHswQt70tnxxTrAsr7WlsedIaq nu6BzOaYahvg7t+UnD1VoL3L0MbWl/qa5OeOCSCVbVJnDX49tz3tI4gbzgPsAt7mBxBf r5SZaCaqFzsBO0DTGR/3p9BieLY8K8yTuVFOxyVWHhqvPVwxMC+J/LuEqxaOjVDm97gm J++qphHTuG0zOm55WK+yzZc3ycbuSurc8kTiN1YGBR3El+M+tepsrKdnT2E/iNqQ3wzP 5I8g== X-Gm-Message-State: AOJu0Yy905C1LU8Ajwtcaljk4GUc1FeY6FhZogA55ZfpPQ/dPe5Txa2G VEJD7T02nfVrUH5FGaJMYDE1ig== X-Google-Smtp-Source: AGHT+IEhKJ19eBREPey/YsreiDKMqly62ClQzzPUbIbQxPlO5yC8nHUg9ET24Ff1ZstcsMmqXStOVg== X-Received: by 2002:a17:903:1245:b0:1cf:6675:b313 with SMTP id u5-20020a170903124500b001cf6675b313mr15105151plh.22.1701063386692; Sun, 26 Nov 2023 21:36:26 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:26 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 09/15] Staging: rtl8192e: Rename variable TxCurSeq Date: Sun, 26 Nov 2023 21:42:59 -0800 Message-ID: <20231127054305.148276-10-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable TxCurSeq to tx_cur_seq to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index d11cbe3bbb31..328947fc058c 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -477,7 +477,7 @@ void rtllib_ts_init_add_ba(struct rtllib_device *ieee, = struct tx_ts_record *ts, ba->ba_param_set.field.tid =3D ts->TsCommonInfo.tspec.ucTSID; ba->ba_param_set.field.buffer_size =3D 32; ba->ba_timeout_value =3D 0; - ba->ba_start_seq_ctrl.field.seq_num =3D (ts->TxCurSeq + 3) % 4096; + ba->ba_start_seq_ctrl.field.seq_num =3D (ts->tx_cur_seq + 3) % 4096; =20 activate_ba_entry(ba, BA_SETUP_TIMEOUT); =20 diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl819= 2e/rtl819x_TS.h index fdd5f1a2e835..4ab712634b4b 100644 --- a/drivers/staging/rtl8192e/rtl819x_TS.h +++ b/drivers/staging/rtl8192e/rtl819x_TS.h @@ -24,7 +24,7 @@ struct ts_common_info { =20 struct tx_ts_record { struct ts_common_info TsCommonInfo; - u16 TxCurSeq; + u16 tx_cur_seq; struct ba_record tx_pending_ba_record; struct ba_record tx_admitted_ba_record; u8 add_ba_req_in_progress; diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index 2e6b705437d9..e06e563ae718 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -100,7 +100,7 @@ static void ResetTsCommonInfo(struct ts_common_info *ts= _common_info) static void ResetTxTsEntry(struct tx_ts_record *ts) { ResetTsCommonInfo(&ts->TsCommonInfo); - ts->TxCurSeq =3D 0; + ts->tx_cur_seq =3D 0; ts->add_ba_req_in_progress =3D false; ts->add_ba_req_delayed =3D false; ts->using_ba =3D false; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 51a8286abd18..92e5be85148e 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -306,7 +306,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, goto FORCED_AGG_SETTING; } else if (!ts->using_ba) { if (SN_LESS(ts->tx_admitted_ba_record.ba_start_seq_ctrl.field.seq_num, - (ts->TxCurSeq + 1) % 4096)) + (ts->tx_cur_seq + 1) % 4096)) ts->using_ba =3D true; else goto FORCED_AGG_SETTING; @@ -500,8 +500,8 @@ static u16 rtllib_query_seqnum(struct rtllib_device *ie= ee, struct sk_buff *skb, if (!rtllib_get_ts(ieee, (struct ts_common_info **)(&ts), dst, skb->priority, TX_DIR, true)) return 0; - seqnum =3D ts->TxCurSeq; - ts->TxCurSeq =3D (ts->TxCurSeq + 1) % 4096; + seqnum =3D ts->tx_cur_seq; + ts->tx_cur_seq =3D (ts->tx_cur_seq + 1) % 4096; return seqnum; } return 0; --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3193EC4167B for ; Mon, 27 Nov 2023 05:37:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232437AbjK0Fgz (ORCPT ); Mon, 27 Nov 2023 00:36:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231237AbjK0FgY (ORCPT ); Mon, 27 Nov 2023 00:36:24 -0500 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BCDA1B6 for ; Sun, 26 Nov 2023 21:36:29 -0800 (PST) Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-5c2ad6a5515so1007149a12.2 for ; Sun, 26 Nov 2023 21:36:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063388; x=1701668188; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wn+SPjvCPtSLlzTnlY099QE9bYM53ql+/mB40G+ws6Y=; b=KQAyij6wDBvQ5Jd4JPkBcuB0Zy5KonjrGspYmlwW0RYrEjNFbgS2q/Igd0oL5mMlFP ezrpApv+Uq1wU7+GF5cVa9mLV1Yc7u+4ZsdgolkcGhCcQb0sEYMlxVxYgjTFTmRPO71X 8XL77tamJYop09ltTwip+PaKt4MjlRQPTxl8hyel0P8iJA/yRLme6lqbziDyxEqblnoG X2IKMTcls1EWhwf5ZAEbpySrTSSpj06vw6ZfItjul1HO1eo6qMflbW8uBMTOj1LhK5GM E92KLUDQ3XX16H/QKBBehuxcWT3WXh+jzyaiT6BAc6W2jM6juuteIq+mrSMGls+iWgmV Y71A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063388; x=1701668188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wn+SPjvCPtSLlzTnlY099QE9bYM53ql+/mB40G+ws6Y=; b=J4kWPM70ER7i5q01XkbrARkKewayp+z35DkKFm2qnNXCrjwb7HWJWjm+F/6EIfA1dr jGt5j0d0ytbl+MEmVwCyl4P+mbz6VGF4lwK+Zn2zQHgirfKa5k8ZZLgtVdnRRNLR67QW JetGATwKpwmtDiAStd3dHYBRNzFA3j57PUbERMyxz1CjBWAu3gJlFqhKKVWHQAyWtUjH oU8UIyCGb71ztcuInF8QN3eMYBHiIMh3aPHsMqR4Gpm4l1jxsFv9JOOhn87/Fadhr0KL 0Tzn2yESZqDgDRaFkPGqHsyeklhKoCghRyV01oWD+IEosVYfMBVdAU8wOpLg4vc/tCMd CDYA== X-Gm-Message-State: AOJu0YztzQS/T7boLdoE0xUqRpqCwfV0ubfOmpv3EbkazdNABdqlOaQc ecA7kgh+lP8NDG6oq0mvNAUE8w== X-Google-Smtp-Source: AGHT+IG0xQP2toGzHlRIhECM2hmUB67kjEwko7EwyI04YY4RSvtctedIYN/3QUnzDAUPFlegfWeQvA== X-Received: by 2002:a05:6a20:1587:b0:185:a3d6:7bda with SMTP id h7-20020a056a20158700b00185a3d67bdamr10611887pzj.39.1701063388371; Sun, 26 Nov 2023 21:36:28 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:28 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 10/15] Staging: rtl8192e: Rename variable TsAddBaTimer Date: Sun, 26 Nov 2023 21:43:00 -0800 Message-ID: <20231127054305.148276-11-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable TsAddBaTimer to ts_add_ba_timer to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 2 +- drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 328947fc058c..2053feb51f61 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -455,7 +455,7 @@ int rtllib_rx_DELBA(struct rtllib_device *ieee, struct = sk_buff *skb) ts->using_ba =3D false; ts->add_ba_req_in_progress =3D false; ts->add_ba_req_delayed =3D false; - del_timer_sync(&ts->TsAddBaTimer); + del_timer_sync(&ts->ts_add_ba_timer); tx_ts_delete_ba(ieee, ts); } return 0; diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl819= 2e/rtl819x_TS.h index 4ab712634b4b..8e22c717fb27 100644 --- a/drivers/staging/rtl8192e/rtl819x_TS.h +++ b/drivers/staging/rtl8192e/rtl819x_TS.h @@ -31,7 +31,7 @@ struct tx_ts_record { u8 add_ba_req_delayed; u8 using_ba; u8 disable_add_ba; - struct timer_list TsAddBaTimer; + struct timer_list ts_add_ba_timer; u8 num; }; =20 diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index e06e563ae718..f96538f3e4ee 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -82,7 +82,7 @@ static void RxPktPendingTimeout(struct timer_list *t) =20 static void TsAddBaProcess(struct timer_list *t) { - struct tx_ts_record *ts =3D from_timer(ts, t, TsAddBaTimer); + struct tx_ts_record *ts =3D from_timer(ts, t, ts_add_ba_timer); u8 num =3D ts->num; struct rtllib_device *ieee =3D container_of(ts, struct rtllib_device, TxTsRecord[num]); @@ -130,7 +130,7 @@ void rtllib_ts_init(struct rtllib_device *ieee) =20 for (count =3D 0; count < TOTAL_TS_NUM; count++) { pTxTS->num =3D count; - timer_setup(&pTxTS->TsAddBaTimer, TsAddBaProcess, 0); + timer_setup(&pTxTS->ts_add_ba_timer, TsAddBaProcess, 0); =20 timer_setup(&pTxTS->tx_pending_ba_record.timer, rtllib_ba_setup_timeout, 0); @@ -356,7 +356,7 @@ static void RemoveTsEntry(struct rtllib_device *ieee, } else { struct tx_ts_record *pTxTS =3D (struct tx_ts_record *)pTs; =20 - del_timer_sync(&pTxTS->TsAddBaTimer); + del_timer_sync(&pTxTS->ts_add_ba_timer); } } =20 @@ -438,11 +438,11 @@ void TsStartAddBaProcess(struct rtllib_device *ieee, = struct tx_ts_record *pTxTS) =20 if (pTxTS->add_ba_req_delayed) { netdev_dbg(ieee->dev, "Start ADDBA after 60 sec!!\n"); - mod_timer(&pTxTS->TsAddBaTimer, jiffies + + mod_timer(&pTxTS->ts_add_ba_timer, jiffies + msecs_to_jiffies(TS_ADDBA_DELAY)); } else { netdev_dbg(ieee->dev, "Immediately Start ADDBA\n"); - mod_timer(&pTxTS->TsAddBaTimer, jiffies + 10); + mod_timer(&pTxTS->ts_add_ba_timer, jiffies + 10); } } else { netdev_dbg(ieee->dev, "BA timer is already added\n"); --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C165C4167B for ; Mon, 27 Nov 2023 05:37:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232383AbjK0Fg7 (ORCPT ); Mon, 27 Nov 2023 00:36:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231527AbjK0Fg0 (ORCPT ); Mon, 27 Nov 2023 00:36:26 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 511DDD64 for ; Sun, 26 Nov 2023 21:36:30 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1cfc35090b0so6057385ad.1 for ; Sun, 26 Nov 2023 21:36:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063389; x=1701668189; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2j4VzOuBt+uyczV2meq0MpY0uQbt9u8nczliuiE+crw=; b=J70kFCAkkhHHYw1T+CrXre7DazsSgDjM0roo3txJb+XKywphSFkGsU4LODKV44sbyt o6CmphSCD5HZC+IEb5WhbhNkOWqFHSEWI9gLLl2Lfefy8sZW9P5FU5Tefvgg74X1lRvR vXgPtgZws/4v9C4vCcjXz4bgCxHkRHaQWVN3iMCRjY2z17fnkp1WLaolHAy+Nj9KgxSe /WjFA/PDE0PQ77LV2isqm3oEwgtQMpsV/TS2TE3aYV3dZWaoZx7iOGeCzXBUmoIsGqU7 dcp9+hjHX2tXtNathmxUhfuBUtlaPtA0AvOyO8573+sfBw5uJBV+CHgD4iN94by8sv1/ DvGw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063389; x=1701668189; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2j4VzOuBt+uyczV2meq0MpY0uQbt9u8nczliuiE+crw=; b=egtlxw+q80S1MmqRdrogZbNSGhRAby3e+wvHL+JZ7iFlCUnLYI4t2v+3+s8myR9b7c C3lAjjebxVnCm5VrOHELgCAMgVKwO3ctm1jmo4F72rHQBna9yzeLHX7rZwLOCTdyvSLp gFYR4EJk0ZrdGUAYtcNAEOTLBPyxRlb3ZraMQe+PI2lFOJrbWmsjAnKu1DynHKV2AG+P 268xph+LdhbWa+Ci4j4Qq1J/7yzjSiE+W5RIxS2xhFIBXQ81HIXKA27q8Ld2XfkHC7IZ fl3cUFv7gDBmUJIudbEIlr2MP4+ZgSWAszNjxjsjbMWEyvjlCJoP0CGlNsl/zAqk8Tcj KOVA== X-Gm-Message-State: AOJu0YwhiESWvZql2Oze1BESg+V7efwZzaCH+6pPgKNnALWzfWOAWB7G B5bt1T91pycyp7Hf+IgdMJXxvQ== X-Google-Smtp-Source: AGHT+IEYUvkttzAlThLW0Vcf5ln7MhtBjPrK2U2R9yrbD0YOHyjjEnCg0+nKVMALiObt7GRANPPgOg== X-Received: by 2002:a17:902:ab1d:b0:1cf:50a0:566d with SMTP id ik29-20020a170902ab1d00b001cf50a0566dmr8890369plb.7.1701063389492; Sun, 26 Nov 2023 21:36:29 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:29 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 11/15] Staging: rtl8192e: Rename variable DelbaParamSet Date: Sun, 26 Nov 2023 21:43:01 -0800 Message-ID: <20231127054305.148276-12-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable DelbaParamSet to del_ba_param_set to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 2053feb51f61..bd037069d4f3 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -127,7 +127,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_devic= e *ieee, u8 *dst, struct ba_record *ba, enum tr_select TxRxSelect, u16 reason_code) { - union delba_param_set DelbaParamSet; + union delba_param_set del_ba_param_set; struct sk_buff *skb =3D NULL; struct ieee80211_hdr_3addr *del_ba =3D NULL; u8 *tag =3D NULL; @@ -137,10 +137,10 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_dev= ice *ieee, u8 *dst, netdev_dbg(ieee->dev, "%s(): reason_code(%d) sentd to: %pM\n", __func__, reason_code, dst); =20 - memset(&DelbaParamSet, 0, 2); + memset(&del_ba_param_set, 0, 2); =20 - DelbaParamSet.field.initiator =3D (TxRxSelect =3D=3D TX_DIR) ? 1 : 0; - DelbaParamSet.field.tid =3D ba->ba_param_set.field.tid; + del_ba_param_set.field.initiator =3D (TxRxSelect =3D=3D TX_DIR) ? 1 : 0; + del_ba_param_set.field.tid =3D ba->ba_param_set.field.tid; =20 skb =3D dev_alloc_skb(len + sizeof(struct ieee80211_hdr_3addr)); if (!skb) @@ -160,7 +160,7 @@ static struct sk_buff *rtllib_DELBA(struct rtllib_devic= e *ieee, u8 *dst, *tag++ =3D ACT_CAT_BA; *tag++ =3D ACT_DELBA; =20 - put_unaligned_le16(DelbaParamSet.short_data, tag); + put_unaligned_le16(del_ba_param_set.short_data, tag); tag +=3D 2; =20 put_unaligned_le16(reason_code, tag); --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D8D1C4167B for ; Mon, 27 Nov 2023 05:37:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232461AbjK0FhD (ORCPT ); Mon, 27 Nov 2023 00:37:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231931AbjK0Fgb (ORCPT ); Mon, 27 Nov 2023 00:36:31 -0500 Received: from mail-pl1-x62e.google.com (mail-pl1-x62e.google.com [IPv6:2607:f8b0:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34A2A184 for ; Sun, 26 Nov 2023 21:36:31 -0800 (PST) Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-1cfc2d03b3aso4394025ad.1 for ; Sun, 26 Nov 2023 21:36:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063390; x=1701668190; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wRGlPinq49hmId5T7GGWMwmGcH6Fr21H2t959wvL11c=; b=d/D75T/q56Q6dYrAO3JsUFFmfV70GMi0AHg+PlgO/JxusdNcAH804t3HupoL0GR6Iz MFSDb2LyS2tMxJLRLPh6OfQi3y5BJu4KSczjcYGvzIKbsC5hOBCJybkjGKV7jIY9A3F1 Y5c+67C9bgNu7VyFoMr+DQDfs+v+MC3MGMgS8mETTpJnlRW3qOhdae+WeF6RevMd6tLZ 3XRYZYbAkz4lGh/lmhIBm6ASrCAiAQJsuPCybtHO8zC+zfabq2mYKRTgtRaxjFujtG1B HLICZn6KvSJ1K6F6Tnd/s9Bipm/JfytHQ4r59aHY67ynPXeA/rthQ5dSDcyAf81JeZH7 zqqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063390; x=1701668190; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wRGlPinq49hmId5T7GGWMwmGcH6Fr21H2t959wvL11c=; b=VB0Np5RKfPcpRG9edjzDfhymIghqSMNy5aq91gvYZZFL4HtW8ailq9/HgFW0kttzm7 7O/+EkzoHl+Nb+dZsGOsgHsvPQD1FV2OO/1+xWPW04N7B30jdY1SSBq2dwZBfB5SNfoj b0osehwKs/Xn04wEGZ696RuNQiOVUObsPZF+7tp4ooqX/HrC7vNh2jCdxzX8AVv7eg34 /HOD99GG1WI3qNmqstVeFQpTGi8G93hcO9tjULCcuSHWYwd8R43oHmpllaze5hfrt/ox Ay7nKHy7I8GnYgmTq7B22VkgPPFOkrA/u6Ni7mnYvIgl/YTUfmHaDaYzbdWijxCqxLml ZHFg== X-Gm-Message-State: AOJu0YxckLZaUGQOaTWQBHW3On0ci+D77T6GOB5phizqH/EOn2QAK4tF aG62OMliXMxXgeADY+ZG87tc6Q== X-Google-Smtp-Source: AGHT+IGALDll4IeJDU4dTVXoQihuuXYJuf0E0LL+K3imBQayxVKQC1VDR8/nm/kaQU8omQQWVgsYxA== X-Received: by 2002:a17:903:1d2:b0:1cf:ad61:7a67 with SMTP id e18-20020a17090301d200b001cfad617a67mr8258718plh.32.1701063390670; Sun, 26 Nov 2023 21:36:30 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:30 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 12/15] Staging: rtl8192e: Rename variable pBaParamSet Date: Sun, 26 Nov 2023 21:43:02 -0800 Message-ID: <20231127054305.148276-13-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable pBaParamSet to ba_param_set to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 24 +++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index bd037069d4f3..7074a01ad2e8 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -217,7 +217,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) u16 rc =3D 0; u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; struct ba_record *ba =3D NULL; - union ba_param_set *pBaParamSet =3D NULL; + union ba_param_set *ba_param_set =3D NULL; u16 *pBaTimeoutVal =3D NULL; union sequence_control *pBaStartSeqCtrl =3D NULL; struct rx_ts_record *ts =3D NULL; @@ -239,7 +239,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) dst =3D (u8 *)(&req->addr2[0]); tag +=3D sizeof(struct ieee80211_hdr_3addr); dialog_token =3D tag + 2; - pBaParamSet =3D (union ba_param_set *)(tag + 3); + ba_param_set =3D (union ba_param_set *)(tag + 3); pBaTimeoutVal =3D (u16 *)(tag + 5); pBaStartSeqCtrl =3D (union sequence_control *)(req + 7); =20 @@ -254,14 +254,14 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, st= ruct sk_buff *skb) goto OnADDBAReq_Fail; } if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)(pBaParamSet->field.tid), RX_DIR, true)) { + (u8)(ba_param_set->field.tid), RX_DIR, true)) { rc =3D ADDBA_STATUS_REFUSED; netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); goto OnADDBAReq_Fail; } ba =3D &ts->rx_admitted_ba_record; =20 - if (pBaParamSet->field.ba_policy =3D=3D BA_POLICY_DELAYED) { + if (ba_param_set->field.ba_policy =3D=3D BA_POLICY_DELAYED) { rc =3D ADDBA_STATUS_INVALID_PARAM; netdev_warn(ieee->dev, "%s(): BA Policy is not correct\n", __func__); @@ -272,7 +272,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) =20 deactivate_ba_entry(ieee, ba); ba->dialog_token =3D *dialog_token; - ba->ba_param_set =3D *pBaParamSet; + ba->ba_param_set =3D *ba_param_set; ba->ba_timeout_value =3D *pBaTimeoutVal; ba->ba_start_seq_ctrl =3D *pBaStartSeqCtrl; =20 @@ -291,7 +291,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) { struct ba_record BA; =20 - BA.ba_param_set =3D *pBaParamSet; + BA.ba_param_set =3D *ba_param_set; BA.ba_timeout_value =3D *pBaTimeoutVal; BA.dialog_token =3D *dialog_token; BA.ba_param_set.field.ba_policy =3D BA_POLICY_IMMEDIATE; @@ -307,7 +307,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) struct tx_ts_record *ts =3D NULL; u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; u16 *status_code =3D NULL, *pBaTimeoutVal =3D NULL; - union ba_param_set *pBaParamSet =3D NULL; + union ba_param_set *ba_param_set =3D NULL; u16 reason_code; =20 if (skb->len < sizeof(struct ieee80211_hdr_3addr) + 9) { @@ -322,7 +322,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) tag +=3D sizeof(struct ieee80211_hdr_3addr); dialog_token =3D tag + 2; status_code =3D (u16 *)(tag + 3); - pBaParamSet =3D (union ba_param_set *)(tag + 5); + ba_param_set =3D (union ba_param_set *)(tag + 5); pBaTimeoutVal =3D (u16 *)(tag + 7); =20 if (!ieee->current_network.qos_data.active || @@ -338,7 +338,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) } =20 if (!rtllib_get_ts(ieee, (struct ts_common_info **)&ts, dst, - (u8)(pBaParamSet->field.tid), TX_DIR, false)) { + (u8)(ba_param_set->field.tid), TX_DIR, false)) { netdev_warn(ieee->dev, "%s(): can't get TS\n", __func__); reason_code =3D DELBA_REASON_UNKNOWN_BA; goto OnADDBARsp_Reject; @@ -367,7 +367,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) } =20 if (*status_code =3D=3D ADDBA_STATUS_SUCCESS) { - if (pBaParamSet->field.ba_policy =3D=3D BA_POLICY_DELAYED) { + if (ba_param_set->field.ba_policy =3D=3D BA_POLICY_DELAYED) { ts->add_ba_req_delayed =3D true; deactivate_ba_entry(ieee, pAdmittedBA); reason_code =3D DELBA_REASON_END_BA; @@ -377,7 +377,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) pAdmittedBA->dialog_token =3D *dialog_token; pAdmittedBA->ba_timeout_value =3D *pBaTimeoutVal; pAdmittedBA->ba_start_seq_ctrl =3D pending_ba->ba_start_seq_ctrl; - pAdmittedBA->ba_param_set =3D *pBaParamSet; + pAdmittedBA->ba_param_set =3D *ba_param_set; deactivate_ba_entry(ieee, pAdmittedBA); activate_ba_entry(pAdmittedBA, *pBaTimeoutVal); } else { @@ -393,7 +393,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) { struct ba_record BA; =20 - BA.ba_param_set =3D *pBaParamSet; + BA.ba_param_set =3D *ba_param_set; rtllib_send_DELBA(ieee, dst, &BA, TX_DIR, reason_code); return 0; } --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6719DC4167B for ; Mon, 27 Nov 2023 05:37:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232471AbjK0FhH (ORCPT ); Mon, 27 Nov 2023 00:37:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36842 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232388AbjK0Fgh (ORCPT ); Mon, 27 Nov 2023 00:36:37 -0500 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8849D10DA for ; Sun, 26 Nov 2023 21:36:32 -0800 (PST) Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1cfb4d28c43so10274955ad.1 for ; Sun, 26 Nov 2023 21:36:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063392; x=1701668192; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8PM44Sv5UeHigK85eZavancsIZjjcHcgvzRmLXENl9Y=; b=Q5DcejIxIrZTg5SNwPI3283VvYO8o1XkWrgA6LDyiaOAotV61JCLAqu1vL79DiAKG+ vv+FGMHRoPisSAwLow80x3qTmTzUddHD88QzZi6Zk8TvsPv0xTdQnkBdzUi+ed41CxU4 C2PEkF4rh922XP94tsZzbNx5YrfDdISVgS5vuw6XC2vYyB3j3GXyTr8Vn0J3mBkjJL9U maj57hiBJbO9iufvmnBgJyihhn0sDRm3uKpkk1l2BbRFsIDkuGvhEqfYv1LySJfXa/fK sQ9wVvg+Kjo55VI8Zb5d5oMcoiC93N1pZUcO4bsynGADzuhsGNUI1jA1CDrym8eo8TiF YeDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063392; x=1701668192; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8PM44Sv5UeHigK85eZavancsIZjjcHcgvzRmLXENl9Y=; b=ugYnyuhcpNoHcZhVuA5u/gKqXd+XmhZKd6kUAa8ZYD4F0DxeezOKACIfDjz6cqkFwT /APRsWQFwHyHUY7tt1Tl84Aju6b8ZJv69XmhGSDLXecH24eYG+//Hh7bD+ff1scI9QJo Q32QvqedrNtGUvzoCEB/gfgtI15NfjwDIb7420aV47nanAfev7P8xc6/dpJWPv8UVa/1 KxZdOUz1yVpy0W/E+E+/XQ/1kuZsf96lHKnEFFAQ8vu3XLCD20C4cusAiUsiodsrsJ3g WFOAM7Aalmbm79kQdspIhYUGfMp1dHuLnJP9oE58Gyp7krKDYZOaRizfEMiXNwV33Oy3 L/DQ== X-Gm-Message-State: AOJu0YxHRwT9Y14xBCqfa2NeLxeK3hk84brbHO3a+1hAJOQfwESyNNrw PGDoh73ZNcat+Se44PsnN5kK0NZUmmPTZioMg00= X-Google-Smtp-Source: AGHT+IFP7ca8LnS/ff2C5FxTGyRUwr0BTpndq+nmeSNpa6zzaFA2shgCbOSShnZbIQKF3odmIc6JkA== X-Received: by 2002:a17:902:db0d:b0:1cf:cc0d:9600 with SMTP id m13-20020a170902db0d00b001cfcc0d9600mr2677263plx.24.1701063391864; Sun, 26 Nov 2023 21:36:31 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:31 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 13/15] Staging: rtl8192e: Rename variable pBaTimeoutVal Date: Sun, 26 Nov 2023 21:43:03 -0800 Message-ID: <20231127054305.148276-14-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable pBaTimeoutVal to ba_timeout_value to fix checkpatch warning Avoid CamelCase, and make the name consistent with variables of same name/type. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 7074a01ad2e8..964029df310e 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -218,7 +218,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; struct ba_record *ba =3D NULL; union ba_param_set *ba_param_set =3D NULL; - u16 *pBaTimeoutVal =3D NULL; + u16 *ba_timeout_value =3D NULL; union sequence_control *pBaStartSeqCtrl =3D NULL; struct rx_ts_record *ts =3D NULL; =20 @@ -240,7 +240,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) tag +=3D sizeof(struct ieee80211_hdr_3addr); dialog_token =3D tag + 2; ba_param_set =3D (union ba_param_set *)(tag + 3); - pBaTimeoutVal =3D (u16 *)(tag + 5); + ba_timeout_value =3D (u16 *)(tag + 5); pBaStartSeqCtrl =3D (union sequence_control *)(req + 7); =20 if (!ieee->current_network.qos_data.active || @@ -273,7 +273,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) deactivate_ba_entry(ieee, ba); ba->dialog_token =3D *dialog_token; ba->ba_param_set =3D *ba_param_set; - ba->ba_timeout_value =3D *pBaTimeoutVal; + ba->ba_timeout_value =3D *ba_timeout_value; ba->ba_start_seq_ctrl =3D *pBaStartSeqCtrl; =20 if (ieee->GetHalfNmodeSupportByAPsHandler(ieee->dev) || @@ -292,7 +292,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) struct ba_record BA; =20 BA.ba_param_set =3D *ba_param_set; - BA.ba_timeout_value =3D *pBaTimeoutVal; + BA.ba_timeout_value =3D *ba_timeout_value; BA.dialog_token =3D *dialog_token; BA.ba_param_set.field.ba_policy =3D BA_POLICY_IMMEDIATE; rtllib_send_ADDBARsp(ieee, dst, &BA, rc); @@ -306,7 +306,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) struct ba_record *pending_ba, *pAdmittedBA; struct tx_ts_record *ts =3D NULL; u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; - u16 *status_code =3D NULL, *pBaTimeoutVal =3D NULL; + u16 *status_code =3D NULL, *ba_timeout_value =3D NULL; union ba_param_set *ba_param_set =3D NULL; u16 reason_code; =20 @@ -323,7 +323,7 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) dialog_token =3D tag + 2; status_code =3D (u16 *)(tag + 3); ba_param_set =3D (union ba_param_set *)(tag + 5); - pBaTimeoutVal =3D (u16 *)(tag + 7); + ba_timeout_value =3D (u16 *)(tag + 7); =20 if (!ieee->current_network.qos_data.active || !ieee->ht_info->current_ht_support || @@ -375,11 +375,11 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, st= ruct sk_buff *skb) } =20 pAdmittedBA->dialog_token =3D *dialog_token; - pAdmittedBA->ba_timeout_value =3D *pBaTimeoutVal; + pAdmittedBA->ba_timeout_value =3D *ba_timeout_value; pAdmittedBA->ba_start_seq_ctrl =3D pending_ba->ba_start_seq_ctrl; pAdmittedBA->ba_param_set =3D *ba_param_set; deactivate_ba_entry(ieee, pAdmittedBA); - activate_ba_entry(pAdmittedBA, *pBaTimeoutVal); + activate_ba_entry(pAdmittedBA, *ba_timeout_value); } else { ts->add_ba_req_delayed =3D true; ts->disable_add_ba =3D true; --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5E86C4167B for ; Mon, 27 Nov 2023 05:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232494AbjK0FhN (ORCPT ); Mon, 27 Nov 2023 00:37:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42658 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232406AbjK0Fgi (ORCPT ); Mon, 27 Nov 2023 00:36:38 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B32710F6 for ; Sun, 26 Nov 2023 21:36:34 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1cf80a7be0aso31484705ad.1 for ; Sun, 26 Nov 2023 21:36:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063393; x=1701668193; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AtJK7mZuXOY4guA3qIV1p7LNy/r3mdWBevupreTz+OE=; b=WCdMBOCLDEN3u7Qza5dh3iPofgEtv4lfDCqdCo7bHQXD/8r9wblDC0bKmuxIcIhwuQ GZuAIRu143UC7VXxN4EV9+f64H9Hd96Of5w5NtrVaed3jiTwjmg//gxdhh7O0zfEr0mF qCfHaBbblys0JdFG0678fDcddy5I1J1+1E4gc06GOdhY0Wl/1QAnbuZowh/jpqXkLs1D EVmV0QnsC2zW/ewUyhSoUpAiNa9SS1ljSpjG0acOe1Wqz2YrvDK7r+Q844lx0SOoGKDz /Fz4zkrK6EBIDACDY50PTw8GbOn5/VoiNPX+gWmXo+MekZ59tubgshzG3VD8+ZC/zk3D JCUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063393; x=1701668193; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AtJK7mZuXOY4guA3qIV1p7LNy/r3mdWBevupreTz+OE=; b=nJH8v/ySjdtWrchnR/7z2qm0Asy8ImLNM2V/rwygVpODbPjy9vSgDvtCiAGe7vUncD nguT9Bst4ZV4HNAdD00pOW2DAq+MmtHYRcjJAf4zwRFi3mJJFPTgnLuwrUyUe4AwzVeY hl3diMZVoCDK3yttRTp2toxJQIBVHVND+ObDrdxv9mf3bKdSE3H21wT4MAWl7GweHTWo k/pbs0RDNf6wGQOa56mL5c/0PYK14HLEdydVbpXncwnDARM81MzpVl7lZV2zPqbOS4qP uSwDtZtMwnj0hkcUNS8Cf4lnh3HKF01m5ds8vY29q039XC6TU9D5pi5tzLeQSynG+aRS +k5g== X-Gm-Message-State: AOJu0Yx3myI5BbC8aD0G175nWYPoAP5hXnefZ7VaqdxupRIFKrC6mz6E SiZI3UFOuG90OOpSN1GpoQ2ccQ== X-Google-Smtp-Source: AGHT+IFXlVDHEwAHNFRKsqffoUtfvXLUe5l1y2FnOIdBYfL9VJdypsffTSG4o7KRc9BzrmANrieclQ== X-Received: by 2002:a17:902:e80e:b0:1cf:daca:2b5e with SMTP id u14-20020a170902e80e00b001cfdaca2b5emr134321plg.38.1701063393392; Sun, 26 Nov 2023 21:36:33 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:32 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 14/15] Staging: rtl8192e: Rename variable pAdmittedBA Date: Sun, 26 Nov 2023 21:43:04 -0800 Message-ID: <20231127054305.148276-15-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable pAdmittedBA to admitted_ba to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index 964029df310e..b00d0f7c7517 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -303,7 +303,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, stru= ct sk_buff *skb) int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb) { struct ieee80211_hdr_3addr *rsp =3D NULL; - struct ba_record *pending_ba, *pAdmittedBA; + struct ba_record *pending_ba, *admitted_ba; struct tx_ts_record *ts =3D NULL; u8 *dst =3D NULL, *dialog_token =3D NULL, *tag =3D NULL; u16 *status_code =3D NULL, *ba_timeout_value =3D NULL; @@ -346,9 +346,9 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, stru= ct sk_buff *skb) =20 ts->add_ba_req_in_progress =3D false; pending_ba =3D &ts->tx_pending_ba_record; - pAdmittedBA =3D &ts->tx_admitted_ba_record; + admitted_ba =3D &ts->tx_admitted_ba_record; =20 - if (pAdmittedBA->b_valid) { + if (admitted_ba->b_valid) { netdev_dbg(ieee->dev, "%s(): ADDBA response already admitted\n", __func__); return -1; @@ -369,17 +369,17 @@ int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, st= ruct sk_buff *skb) if (*status_code =3D=3D ADDBA_STATUS_SUCCESS) { if (ba_param_set->field.ba_policy =3D=3D BA_POLICY_DELAYED) { ts->add_ba_req_delayed =3D true; - deactivate_ba_entry(ieee, pAdmittedBA); + deactivate_ba_entry(ieee, admitted_ba); reason_code =3D DELBA_REASON_END_BA; goto OnADDBARsp_Reject; } =20 - pAdmittedBA->dialog_token =3D *dialog_token; - pAdmittedBA->ba_timeout_value =3D *ba_timeout_value; - pAdmittedBA->ba_start_seq_ctrl =3D pending_ba->ba_start_seq_ctrl; - pAdmittedBA->ba_param_set =3D *ba_param_set; - deactivate_ba_entry(ieee, pAdmittedBA); - activate_ba_entry(pAdmittedBA, *ba_timeout_value); + admitted_ba->dialog_token =3D *dialog_token; + admitted_ba->ba_timeout_value =3D *ba_timeout_value; + admitted_ba->ba_start_seq_ctrl =3D pending_ba->ba_start_seq_ctrl; + admitted_ba->ba_param_set =3D *ba_param_set; + deactivate_ba_entry(ieee, admitted_ba); + activate_ba_entry(admitted_ba, *ba_timeout_value); } else { ts->add_ba_req_delayed =3D true; ts->disable_add_ba =3D true; --=20 2.39.2 From nobody Wed Dec 17 12:34:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B90ACC4167B for ; Mon, 27 Nov 2023 05:37:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231998AbjK0FhY (ORCPT ); Mon, 27 Nov 2023 00:37:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231849AbjK0Fgj (ORCPT ); Mon, 27 Nov 2023 00:36:39 -0500 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A4BF1733 for ; Sun, 26 Nov 2023 21:36:35 -0800 (PST) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-1cfcc9b3b5cso4477885ad.0 for ; Sun, 26 Nov 2023 21:36:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1701063394; x=1701668194; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zrOmN5h7Hp9zhTp9GrVqL3qhDYZcamqD4piT786f28U=; b=H8TTMSYSjcugVaakFKpf0qqR/bOnLLRsEuSXhQTtdM5Pzk406MiuK3tvU2y0lBBh48 EcC+ElQkgnlfBdRHeIUJODzVkrMb+m3PjC/1e8rsX3FAB8jaKrdhXnnFRLZ3bPAj5yeE dbNZ3kEzs4VAquvN5lgPZ9WLsSZqb75hZQ2pKlAUVtBgo3rKAOiaDwYQYbVqCD7YV8V2 SpTIc8YTEigB0vnHDYQBMFZDLQj69UzHiqofNGFaObvjcR6k/pMRfU3rL/7cuqc/j6vM Lr1nmU0upEDuXfzrGWjN4qCKkRZmB2thDTwRE7uhhvIIDQxFWSqcO+P6jk+wlhCaz2Sa ZtuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701063394; x=1701668194; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zrOmN5h7Hp9zhTp9GrVqL3qhDYZcamqD4piT786f28U=; b=HTj6cq5k48UljsU4Mu65DQv/PFocl3LZF13ieuyvhsOxOTTI0P7QCwtg7+CRRVgk0d HzKcFZlICILjFAQxVBfCuLD4zbNeynOzBAHHpqM7W0wY6wD9FvoKWG+bWgWxYVT2+ozj JJWlJxpKdqMRYIGNr/J192YH2JHsdL/e6+lbbn1qbyuS4VjDpACMvXsES+hlGmS7O2l9 aPjXQJgo32MOruwmH8jStvZ5mD51ALYcTF0z/NqEQyOlcDBXrXtb8WxEmhsrRIFeui9u zSbu4oXD9pBLDEMktQcLFuejuHlxGFt+YtMxPhyNrOTMJwSYwR/3/VMqdAPGon31Oyhk vDYg== X-Gm-Message-State: AOJu0YxgIJnIqsMm8cAb+04Cn0cQm15cma55/zLl5ll2vwVcc7BUPwU/ Nl6KD/I62uQLY7TWMsD9SEmFEw== X-Google-Smtp-Source: AGHT+IHKWM5PNkHMdgW7GOMibQDlx4FTE9/Ju8V8e7vWg7P8uTMRAzIYK0dviMay6bdBd9R6o3ewfw== X-Received: by 2002:a17:903:11c8:b0:1cc:511d:eb43 with SMTP id q8-20020a17090311c800b001cc511deb43mr13690297plh.61.1701063394559; Sun, 26 Nov 2023 21:36:34 -0800 (PST) Received: from basil.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id b6-20020a170902ed0600b001cc3875e658sm7300465pld.303.2023.11.26.21.36.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Nov 2023 21:36:34 -0800 (PST) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH 15/15] Staging: rtl8192e: Rename variable TsCommonInfo Date: Sun, 26 Nov 2023 21:43:05 -0800 Message-ID: <20231127054305.148276-16-tdavies@darkphysics.net> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231127054305.148276-1-tdavies@darkphysics.net> References: <20231127054305.148276-1-tdavies@darkphysics.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Rename variable TsCommonInfo to ts_common_info to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies --- drivers/staging/rtl8192e/rtl819x_BAProc.c | 6 +++--- drivers/staging/rtl8192e/rtl819x_TS.h | 2 +- drivers/staging/rtl8192e/rtl819x_TSProc.c | 6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rt= l8192e/rtl819x_BAProc.c index b00d0f7c7517..58a950ef77ce 100644 --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c @@ -474,14 +474,14 @@ void rtllib_ts_init_add_ba(struct rtllib_device *ieee= , struct tx_ts_record *ts, ba->dialog_token++; ba->ba_param_set.field.amsdu_support =3D 0; ba->ba_param_set.field.ba_policy =3D policy; - ba->ba_param_set.field.tid =3D ts->TsCommonInfo.tspec.ucTSID; + ba->ba_param_set.field.tid =3D ts->ts_common_info.tspec.ucTSID; ba->ba_param_set.field.buffer_size =3D 32; ba->ba_timeout_value =3D 0; ba->ba_start_seq_ctrl.field.seq_num =3D (ts->tx_cur_seq + 3) % 4096; =20 activate_ba_entry(ba, BA_SETUP_TIMEOUT); =20 - rtllib_send_ADDBAReq(ieee, ts->TsCommonInfo.addr, ba); + rtllib_send_ADDBAReq(ieee, ts->ts_common_info.addr, ba); } =20 void rtllib_ts_init_del_ba(struct rtllib_device *ieee, @@ -525,7 +525,7 @@ void rtllib_tx_ba_inact_timeout(struct timer_list *t) struct rtllib_device *ieee =3D container_of(ts, struct rtllib_device, TxTsRecord[ts->num]); tx_ts_delete_ba(ieee, ts); - rtllib_send_DELBA(ieee, ts->TsCommonInfo.addr, + rtllib_send_DELBA(ieee, ts->ts_common_info.addr, &ts->tx_admitted_ba_record, TX_DIR, DELBA_REASON_TIMEOUT); } diff --git a/drivers/staging/rtl8192e/rtl819x_TS.h b/drivers/staging/rtl819= 2e/rtl819x_TS.h index 8e22c717fb27..31f7cfbb3aa5 100644 --- a/drivers/staging/rtl8192e/rtl819x_TS.h +++ b/drivers/staging/rtl8192e/rtl819x_TS.h @@ -23,7 +23,7 @@ struct ts_common_info { }; =20 struct tx_ts_record { - struct ts_common_info TsCommonInfo; + struct ts_common_info ts_common_info; u16 tx_cur_seq; struct ba_record tx_pending_ba_record; struct ba_record tx_admitted_ba_record; diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index f96538f3e4ee..bec73bc53dd0 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -99,7 +99,7 @@ static void ResetTsCommonInfo(struct ts_common_info *ts_c= ommon_info) =20 static void ResetTxTsEntry(struct tx_ts_record *ts) { - ResetTsCommonInfo(&ts->TsCommonInfo); + ResetTsCommonInfo(&ts->ts_common_info); ts->tx_cur_seq =3D 0; ts->add_ba_req_in_progress =3D false; ts->add_ba_req_delayed =3D false; @@ -138,7 +138,7 @@ void rtllib_ts_init(struct rtllib_device *ieee) rtllib_tx_ba_inact_timeout, 0); =20 ResetTxTsEntry(pTxTS); - list_add_tail(&pTxTS->TsCommonInfo.List, + list_add_tail(&pTxTS->ts_common_info.List, &ieee->Tx_TS_Unused_List); pTxTS++; } @@ -292,7 +292,7 @@ bool rtllib_get_ts(struct rtllib_device *ieee, struct t= s_common_info **ppTS, struct tx_ts_record *tmp =3D container_of(*ppTS, struct tx_ts_record, - TsCommonInfo); + ts_common_info); ResetTxTsEntry(tmp); } else { struct rx_ts_record *ts =3D --=20 2.39.2