From nobody Wed Dec 17 15:36:52 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FDCC61DF4 for ; Fri, 24 Nov 2023 08:39:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345068AbjKXIjV (ORCPT ); Fri, 24 Nov 2023 03:39:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42660 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231531AbjKXIjQ (ORCPT ); Fri, 24 Nov 2023 03:39:16 -0500 Received: from cmccmta1.chinamobile.com (cmccmta6.chinamobile.com [111.22.67.139]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id E7D7191; Fri, 24 Nov 2023 00:39:18 -0800 (PST) X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from spf.mail.chinamobile.com (unknown[10.188.0.87]) by rmmx-syy-dmz-app01-12001 (RichMail) with SMTP id 2ee165606133b13-1a3e1; Fri, 24 Nov 2023 16:39:15 +0800 (CST) X-RM-TRANSID: 2ee165606133b13-1a3e1 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain.localdomain (unknown[10.54.5.252]) by rmsmtp-syy-appsvr08-12008 (RichMail) with SMTP id 2ee8656061300df-0d1c1; Fri, 24 Nov 2023 16:39:15 +0800 (CST) X-RM-TRANSID: 2ee8656061300df-0d1c1 From: zhaimingbing To: Namhyung Kim , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Sean Christopherson , Li Dong Cc: linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, zhaimingbing Subject: [PATCH] perf help:Fail check on dynamic allocation Date: Fri, 24 Nov 2023 16:39:10 +0800 Message-Id: <20231124083910.10169-1-zhaimingbing@cmss.chinamobile.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Return NULL if dynamic allocation failed. Signed-off-by: zhaimingbing --- tools/perf/builtin-help.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools/perf/builtin-help.c b/tools/perf/builtin-help.c index b2a368ae2..e89734dbb 100644 --- a/tools/perf/builtin-help.c +++ b/tools/perf/builtin-help.c @@ -196,6 +196,9 @@ static void add_man_viewer(const char *name) while (*p) p =3D &((*p)->next); *p =3D zalloc(sizeof(**p) + len + 1); + if(!*p) + return NULL; + strcpy((*p)->name, name); } =20 @@ -211,6 +214,8 @@ static void do_add_man_viewer_info(const char *name, const char *value) { struct man_viewer_info_list *new =3D zalloc(sizeof(*new) + len + 1); + if(!new) + return NULL; =20 strncpy(new->name, name, len); new->info =3D strdup(value); --=20 2.33.0