From nobody Wed Dec 17 19:00:28 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC126C61D85 for ; Thu, 23 Nov 2023 22:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230294AbjKWWNk (ORCPT ); Thu, 23 Nov 2023 17:13:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbjKWWN0 (ORCPT ); Thu, 23 Nov 2023 17:13:26 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE1B110D0 for ; Thu, 23 Nov 2023 14:13:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700777611; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7MuULYoz5ao+rLNA+YbUecP2cAJXv6WyavKrHjMaHS4=; b=N5vrvuTS1sPYcdT+cCZ3vQHFtX0dE5FOp6XmnK6NUU41W25BSVQoU1NVsdJBmfflWqWCFX YFCJT/gRXsUO2HhFZ37r8Sf2ziqj3R7N5jka8wvzsq/sqlNLc5zughSY5lJwxx69V1qf+e C4sbbrJgjuz76GMxfnFzm36mBecU960= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-695-Q5LmLyhONca7s1lakKbPhg-1; Thu, 23 Nov 2023 17:13:29 -0500 X-MC-Unique: Q5LmLyhONca7s1lakKbPhg-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-332e41ed0b4so571516f8f.3 for ; Thu, 23 Nov 2023 14:13:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700777607; x=1701382407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7MuULYoz5ao+rLNA+YbUecP2cAJXv6WyavKrHjMaHS4=; b=g7HMCdelWokJfFWVeklyf6hFvoX2vgEzvaLTMy1g3/f2TKPXuCOePJeomGEkeBNfxU Si5h7MROka7+yp1Wq7yEkVCeynUNO4GtZqKmaNqse+XrGw7oPaxTv2b2EwuTi+PMYRP6 IYDQF4UCXd4IJGSwbct0C0ycxpuiaW0a4KMYeFFST2AErzQQavN54DoZ7+dYmpTdIDAf JNIRvcSf8GMuSSly2Sh9jIgtgEZk26uC5svB95IOFKYFOOdu/VyrdZHnzJxmSA63Tk1h eYw87k+BGQkic48lPpwRe6+LWcwKN2ith9S4NaagE+hVY7zIgTa6TXkDn5Fin4/ElgsR A+uw== X-Gm-Message-State: AOJu0Yx1uKLjuJEeS7H9A3Rdj9edNTxRfMypj8G3+jj40BuIwU4uaz6z o/cLIzF6UqAhp9+ACc6/vAZgi6vAKTDZ7PrmUaimKjLYBmhyrK/K5t2+o0JxwEikw/TPBTY2h4U NAMez+46GqAqZ1Wn7QiKexo+uwCOl310gzHdTCnx5wUuHCYncCF64AOp3lT0oH2cbKhLNKIFuVw Y66KyAVdE= X-Received: by 2002:a5d:40c8:0:b0:332:e777:a8d4 with SMTP id b8-20020a5d40c8000000b00332e777a8d4mr565989wrq.36.1700777607690; Thu, 23 Nov 2023 14:13:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IFbblMAN+hzDoQaplfSW1Ls9XUsnDbl4YuadfKrIq6lj50fMHkQHToWy2rbRvbEJLq7TAFUoA== X-Received: by 2002:a5d:40c8:0:b0:332:e777:a8d4 with SMTP id b8-20020a5d40c8000000b00332e777a8d4mr565964wrq.36.1700777607350; Thu, 23 Nov 2023 14:13:27 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id s7-20020a5d5107000000b00332c6a52040sm2681153wrt.100.2023.11.23.14.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 14:13:27 -0800 (PST) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Maxime Ripard , Zack Rusin , Thomas Zimmermann , Pekka Paalanen , Bilal Elmoussaoui , Simon Ser , Erico Nunes , Sima Vetter , Javier Martinez Canillas , Daniel Vetter , David Airlie , Jonathan Corbet , Maarten Lankhorst , dri-devel@lists.freedesktop.org, linux-doc@vger.kernel.org Subject: [PATCH v4 5/5] drm/todo: Add entry about implementing buffer age for damage tracking Date: Thu, 23 Nov 2023 23:13:04 +0100 Message-ID: <20231123221315.3579454-6-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231123221315.3579454-1-javierm@redhat.com> References: <20231123221315.3579454-1-javierm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Currently, only damage tracking for frame damage is supported. If a driver needs to do buffer damage (e.g: the framebuffer attached to plane's state has changed since the last page-flip), the damage helpers just fallback to a full plane update. Add en entry in the TODO about implementing buffer age or any other damage accumulation algorithm for buffer damage handling. Suggested-by: Simon Ser Signed-off-by: Javier Martinez Canillas Reviewed-by: Simon Ser Reviewed-by: Thomas Zimmermann Reviewed-by: Zack Rusin Acked-by: Sima Vetter --- Changes in v4: - Reference the &drm_plane_state.ignore_damage_clips and the damage helpers in the buffer damage TODO entry (Sima Vetter). Documentation/gpu/todo.rst | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst index b62c7fa0c2bc..503d57c75215 100644 --- a/Documentation/gpu/todo.rst +++ b/Documentation/gpu/todo.rst @@ -782,6 +782,29 @@ Contact: Hans de Goede =20 Level: Advanced =20 +Buffer age or other damage accumulation algorithm for buffer damage +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D + +Drivers that do per-buffer uploads, need a buffer damage handling (rather = than +frame damage like drivers that do per-plane or per-CRTC uploads), but ther= e is +no support to get the buffer age or any other damage accumulation algorith= m. + +For this reason, the damage helpers just fallback to a full plane update i= f the +framebuffer attached to a plane has changed since the last page-flip. Driv= ers +set &drm_plane_state.ignore_damage_clips to true as indication to +drm_atomic_helper_damage_iter_init() and drm_atomic_helper_damage_iter_nex= t() +helpers that the damage clips should be ignored. + +This should be improved to get damage tracking properly working on drivers= that +do per-buffer uploads. + +More information about damage tracking and references to learning material= s can +be found in :ref:`damage_tracking_properties`. + +Contact: Javier Martinez Canillas + +Level: Advanced + Outside DRM =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =20 --=20 2.41.0