From nobody Wed Dec 17 19:00:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3C18C61D85 for ; Thu, 23 Nov 2023 22:13:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbjKWWN3 (ORCPT ); Thu, 23 Nov 2023 17:13:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230013AbjKWWNW (ORCPT ); Thu, 23 Nov 2023 17:13:22 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 918E210D1 for ; Thu, 23 Nov 2023 14:13:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700777607; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eevPmuhRFAgVhLHOGTOOcRfbcoEzUftUVXb0Oh9ok7w=; b=XrVBv3AqLvNGaf15QiXuDYaXp7+w1htPBpJNE/Zn7qs64OqTUrq7xCWMA9vXBmDyDl3UUP Ht01vtT9QgSWrrMjfIf0ofkJfikM9ue7RjAl22N08yu194HX+ioPSxpWlYW+UguS6VFngm J9P/c9h+DnfC52SFTiFAoduOo4Xg+ok= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-vjnvqvc3OO6esU69qhtU4A-1; Thu, 23 Nov 2023 17:13:26 -0500 X-MC-Unique: vjnvqvc3OO6esU69qhtU4A-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-40b349b990fso6276235e9.3 for ; Thu, 23 Nov 2023 14:13:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700777604; x=1701382404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eevPmuhRFAgVhLHOGTOOcRfbcoEzUftUVXb0Oh9ok7w=; b=mRQGqiPnghjHo7RgaCdGpdj+k5XTMsRNEoUya59XXLU2U99FHBxnoULLIl4wiSousX ddpCp4/+ODaDI71m1O4jSUnqYKMcqdEfM5Ic+xkMFykvmRfQOAc4rRl4YxThTCLqksvV G1XGpRKL2aIsoEWtuQUjhOje3fPNYDh3HFjXrAKGOVP8EKdttxkmgg0yxVqGDIsTrcug T1vGW0TKyZmCzfQzjaxP/FIJg9yO6x+GVHJoUDzbCyEv+xDq9ewb35lo/edLPrbBpJbZ 5qpQ1DrZlKDsZyoSNU2nU36d06ulOLOxfRd/QuPRpxc2a9db9B6athxA2owSOXcpvwoZ FVPA== X-Gm-Message-State: AOJu0YxUiw2sxgmWKKrC0JckpghrJP3OTpsxmymG0ci7I30SkqSlONsJ TM73WiHLOCWpwwsWog9pYv0F1H3p/7A4UhrEgz4iR6WTXQDwSAqeqtzaf3mrHFfUEnsGwQ6ZBCc IQlcRkDiAzcvB+3C1udqWLu9YI79rYEfsw/ks9ksVi0gzJa2EtoBF61iQ3WWpcGjf75wNM80y3y nmP3lCEV4= X-Received: by 2002:a05:600c:138e:b0:40b:3605:acda with SMTP id u14-20020a05600c138e00b0040b3605acdamr646923wmf.25.1700777604124; Thu, 23 Nov 2023 14:13:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6aWgfy8x/Q5jWLkQk58MrIjsjFwETk6FGO3Io9BSfMMwRCBkkQZXEsO4x5dsaE1onwWQGvg== X-Received: by 2002:a05:600c:138e:b0:40b:3605:acda with SMTP id u14-20020a05600c138e00b0040b3605acdamr646901wmf.25.1700777603855; Thu, 23 Nov 2023 14:13:23 -0800 (PST) Received: from localhost (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id z11-20020a05600c0a0b00b00405c7591b09sm3180629wmp.35.2023.11.23.14.13.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 14:13:22 -0800 (PST) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Maxime Ripard , Zack Rusin , Thomas Zimmermann , Pekka Paalanen , Bilal Elmoussaoui , Simon Ser , Erico Nunes , Sima Vetter , Javier Martinez Canillas , Daniel Vetter , David Airlie , Maarten Lankhorst , VMware Graphics Reviewers , dri-devel@lists.freedesktop.org Subject: [PATCH v4 3/5] drm/vmwgfx: Disable damage clipping if FB changed since last page-flip Date: Thu, 23 Nov 2023 23:13:02 +0100 Message-ID: <20231123221315.3579454-4-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231123221315.3579454-1-javierm@redhat.com> References: <20231123221315.3579454-1-javierm@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The driver does per-buffer uploads and needs to force a full plane update if the plane's attached framebuffer has change since the last page-flip. Suggested-by: Sima Vetter Signed-off-by: Javier Martinez Canillas Reviewed-by: Thomas Zimmermann Reviewed-by: Zack Rusin Acked-by: Sima Vetter --- (no changes since v2) Changes in v2: - Set struct drm_plane_state .ignore_damage_clips in vmwgfx plane's .atomic_check instead of using a different helpers (Thomas Zimmermann). drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c b/drivers/gpu/drm/vmwgfx/v= mwgfx_kms.c index 818b7f109f53..f9364bf222e3 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_kms.c @@ -837,10 +837,21 @@ int vmw_du_primary_plane_atomic_check(struct drm_plan= e *plane, { struct drm_plane_state *new_state =3D drm_atomic_get_new_plane_state(stat= e, plane); + struct drm_plane_state *old_state =3D drm_atomic_get_old_plane_state(stat= e, + plane); struct drm_crtc_state *crtc_state =3D NULL; struct drm_framebuffer *new_fb =3D new_state->fb; + struct drm_framebuffer *old_fb =3D old_state->fb; int ret; =20 + /* + * Ignore damage clips if the framebuffer attached to the plane's state + * has changed since the last plane update (page-flip). In this case, a + * full plane update should happen because uploads are done per-buffer. + */ + if (old_fb !=3D new_fb) + new_state->ignore_damage_clips =3D true; + if (new_state->crtc) crtc_state =3D drm_atomic_get_new_crtc_state(state, new_state->crtc); --=20 2.41.0