From nobody Mon Dec 29 20:15:31 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4176C61D97 for ; Thu, 23 Nov 2023 16:57:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345398AbjKWQ5s (ORCPT ); Thu, 23 Nov 2023 11:57:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345231AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C1F0D69 for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-0004zM-HJ; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54c-Nx; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozE-EW; Thu, 23 Nov 2023 17:56:58 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Krzysztof Kozlowski , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 03/18] mfd: exynos-lpass: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:31 +0100 Message-ID: <20231123165627.492259-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1928; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=hnM9lEd75w6pk/CQsI0uo+SpHXcPuNXW4NABO1kOboo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4Q/qyjvQ43nqvF9ocHlWxZZXet54OMT5aOkA uSKIuL0GwGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EPwAKCRCPgPtYfRL+ TknVB/4uSQ0b234ec72Txk+Vlps9O8AcJebgCma7EmgW5jEYa1OPXCGpHeQJsDnbKtDGS1zoliO /rJZGKGn6mpl03yOiScaZ3/U7LRw4+0XBVdlQOzNLx0NBFlGlraSE/SJT6BdfddFa+d8zj4L0qT pjH7I+orwLRpLIzFaN3DkM7nbLjhz6CvN5q3B4HZ56/aJMnvLBhbej5nC/We7R9JZ7LjhXfkgAL 64vjTOVPe/1ZX9CWT+2h/z+IAPm16jKiRTC9Hvo1mSupnH5ZfLU784ktR+aOV4f6Ir9g1AQKiMM Vb5KOHn2nL4JVXd1ylKWriSiPxUtz650GTAMakowHelSx4rG X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/exynos-lpass.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c index 1506d8d352b1..e58990c85ed8 100644 --- a/drivers/mfd/exynos-lpass.c +++ b/drivers/mfd/exynos-lpass.c @@ -137,7 +137,7 @@ static int exynos_lpass_probe(struct platform_device *p= dev) return devm_of_platform_populate(dev); } =20 -static int exynos_lpass_remove(struct platform_device *pdev) +static void exynos_lpass_remove(struct platform_device *pdev) { struct exynos_lpass *lpass =3D platform_get_drvdata(pdev); =20 @@ -146,8 +146,6 @@ static int exynos_lpass_remove(struct platform_device *= pdev) if (!pm_runtime_status_suspended(&pdev->dev)) exynos_lpass_disable(lpass); regmap_exit(lpass->top); - - return 0; } =20 static int __maybe_unused exynos_lpass_suspend(struct device *dev) @@ -187,7 +185,7 @@ static struct platform_driver exynos_lpass_driver =3D { .of_match_table =3D exynos_lpass_of_match, }, .probe =3D exynos_lpass_probe, - .remove =3D exynos_lpass_remove, + .remove_new =3D exynos_lpass_remove, }; module_platform_driver(exynos_lpass_driver); =20 --=20 2.42.0