From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11413C5AD4C for ; Thu, 23 Nov 2023 16:57:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230056AbjKWQ5Q (ORCPT ); Thu, 23 Nov 2023 11:57:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345140AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7F0CDD46 for ; Thu, 23 Nov 2023 08:57:04 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0c-0004z4-Mw; Thu, 23 Nov 2023 17:56:58 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54W-6j; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0b-006oz6-Tm; Thu, 23 Nov 2023 17:56:57 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Linus Walleij , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 01/18] mfd: ab8500-sysctrl: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:29 +0100 Message-ID: <20231123165627.492259-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1805; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=GS/UqHACqLFCxsb5xvMGweNluQ8cR4neHNMyqaMRa+A=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4Q8Pj9Sc/wSXZDMbwzL63aYnjZfexGCMhFLF N+Wdhi9HoyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EPAAKCRCPgPtYfRL+ ThPdB/9f+Oj9hJK9NQybB41yGJvXzMIFj7Y8br+9cK9ocBHzrv4K7Kr0AzVw2ZFitdmQ+nYcs3O E/iMaKg0LCkOAUrTWi7lVUoKCVuW4uDJxBDnNxOFR08TaEuCCEZfO8Gx98J3nXsrQtOQp1gi6wo Pnm5a5F11ePtKNv/9U4brWz5qqC0wlOtvWvZx/PtT9/SbhgLPetfFw16RM1/mYuISR4/pTF6ILI FqHGj8caN09Knp0pMJdUbE9aQQcQpYQwCFjSOTQ+VyY1FSWZFTFVv1ULELcIXo3B1osTNG0V0+1 vp6DmhDpDqYv22iB9B7HlflLK8YdnfaYmZiONZr1qyV9m8d8 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Acked-by: Linus Walleij Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/ab8500-sysctrl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/ab8500-sysctrl.c b/drivers/mfd/ab8500-sysctrl.c index eeeb62415f53..ce81fcb785d0 100644 --- a/drivers/mfd/ab8500-sysctrl.c +++ b/drivers/mfd/ab8500-sysctrl.c @@ -140,14 +140,12 @@ static int ab8500_sysctrl_probe(struct platform_devic= e *pdev) return 0; } =20 -static int ab8500_sysctrl_remove(struct platform_device *pdev) +static void ab8500_sysctrl_remove(struct platform_device *pdev) { sysctrl_dev =3D NULL; =20 if (pm_power_off =3D=3D ab8500_power_off) pm_power_off =3D NULL; - - return 0; } =20 static const struct of_device_id ab8500_sysctrl_match[] =3D { @@ -161,7 +159,7 @@ static struct platform_driver ab8500_sysctrl_driver =3D= { .of_match_table =3D ab8500_sysctrl_match, }, .probe =3D ab8500_sysctrl_probe, - .remove =3D ab8500_sysctrl_remove, + .remove_new =3D ab8500_sysctrl_remove, }; =20 static int __init ab8500_sysctrl_init(void) --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4721C61D97 for ; Thu, 23 Nov 2023 16:57:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345311AbjKWQ5W (ORCPT ); Thu, 23 Nov 2023 11:57:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33224 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229970AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F5F0D48 for ; Thu, 23 Nov 2023 08:57:05 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0c-0004z6-SO; Thu, 23 Nov 2023 17:56:58 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54Z-FD; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozA-5t; Thu, 23 Nov 2023 17:56:58 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Benson Leung , Guenter Roeck , chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 02/18] mfd: cros_ec_dev: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:30 +0100 Message-ID: <20231123165627.492259-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1720; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=LCw3bj2aWliMJeRhvUQKWZ55KhVQThCiahgEmDcwN4c=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4Q9cxZ+4UCl/GvDKW8mubt9953vOUXfszBV1 wxXWkcEyzCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EPQAKCRCPgPtYfRL+ TnSGCACPvoDxVg9509CpoLILWkjmQePD3RgHtDcRoR7vpXswXCrpfuxJ0LgJhErkN9IMJwHLJCZ n5MH/d47hy4AAlYyGpVfRdJDAaId5dQHOIC6qcmZh8IUKbJ+I4oFt5ReW2XRjvPZJD6SuE/HMIn m97u6S+ZX0DD7ELI5VFlmtH8lyt3zN6niBuAvpMc5aR0l+yGGUDuxto0cg1r19oGht93TgQUZJB bnuZFTb6XFh/A0ewm4kADppa6R23xUdDqI+I9J/wv1rF5Q8uOnVPQLBHM4jfZ9uqdEz7dNbHoPb BKvxqOcnohoCSeEKMHyyLOhGrMIytQKUsZ4X3M/BFwQ42KxY X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/cros_ec_dev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c index 79d393b602bf..603b1cd52785 100644 --- a/drivers/mfd/cros_ec_dev.c +++ b/drivers/mfd/cros_ec_dev.c @@ -288,13 +288,12 @@ static int ec_device_probe(struct platform_device *pd= ev) return retval; } =20 -static int ec_device_remove(struct platform_device *pdev) +static void ec_device_remove(struct platform_device *pdev) { struct cros_ec_dev *ec =3D dev_get_drvdata(&pdev->dev); =20 mfd_remove_devices(ec->dev); device_unregister(&ec->class_dev); - return 0; } =20 static const struct platform_device_id cros_ec_id[] =3D { @@ -309,7 +308,7 @@ static struct platform_driver cros_ec_dev_driver =3D { }, .id_table =3D cros_ec_id, .probe =3D ec_device_probe, - .remove =3D ec_device_remove, + .remove_new =3D ec_device_remove, }; =20 static int __init cros_ec_dev_init(void) --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4176C61D97 for ; Thu, 23 Nov 2023 16:57:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345398AbjKWQ5s (ORCPT ); Thu, 23 Nov 2023 11:57:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345231AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C1F0D69 for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-0004zM-HJ; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54c-Nx; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozE-EW; Thu, 23 Nov 2023 17:56:58 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Krzysztof Kozlowski , Alim Akhtar , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 03/18] mfd: exynos-lpass: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:31 +0100 Message-ID: <20231123165627.492259-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1928; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=hnM9lEd75w6pk/CQsI0uo+SpHXcPuNXW4NABO1kOboo=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4Q/qyjvQ43nqvF9ocHlWxZZXet54OMT5aOkA uSKIuL0GwGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EPwAKCRCPgPtYfRL+ TknVB/4uSQ0b234ec72Txk+Vlps9O8AcJebgCma7EmgW5jEYa1OPXCGpHeQJsDnbKtDGS1zoliO /rJZGKGn6mpl03yOiScaZ3/U7LRw4+0XBVdlQOzNLx0NBFlGlraSE/SJT6BdfddFa+d8zj4L0qT pjH7I+orwLRpLIzFaN3DkM7nbLjhz6CvN5q3B4HZ56/aJMnvLBhbej5nC/We7R9JZ7LjhXfkgAL 64vjTOVPe/1ZX9CWT+2h/z+IAPm16jKiRTC9Hvo1mSupnH5ZfLU784ktR+aOV4f6Ir9g1AQKiMM Vb5KOHn2nL4JVXd1ylKWriSiPxUtz650GTAMakowHelSx4rG X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/exynos-lpass.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/exynos-lpass.c b/drivers/mfd/exynos-lpass.c index 1506d8d352b1..e58990c85ed8 100644 --- a/drivers/mfd/exynos-lpass.c +++ b/drivers/mfd/exynos-lpass.c @@ -137,7 +137,7 @@ static int exynos_lpass_probe(struct platform_device *p= dev) return devm_of_platform_populate(dev); } =20 -static int exynos_lpass_remove(struct platform_device *pdev) +static void exynos_lpass_remove(struct platform_device *pdev) { struct exynos_lpass *lpass =3D platform_get_drvdata(pdev); =20 @@ -146,8 +146,6 @@ static int exynos_lpass_remove(struct platform_device *= pdev) if (!pm_runtime_status_suspended(&pdev->dev)) exynos_lpass_disable(lpass); regmap_exit(lpass->top); - - return 0; } =20 static int __maybe_unused exynos_lpass_suspend(struct device *dev) @@ -187,7 +185,7 @@ static struct platform_driver exynos_lpass_driver =3D { .of_match_table =3D exynos_lpass_of_match, }, .probe =3D exynos_lpass_probe, - .remove =3D exynos_lpass_remove, + .remove_new =3D exynos_lpass_remove, }; module_platform_driver(exynos_lpass_driver); =20 --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C174C5AD4C for ; Thu, 23 Nov 2023 16:57:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230430AbjKWQ5i (ORCPT ); Thu, 23 Nov 2023 11:57:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345208AbjKWQ5E (ORCPT ); Thu, 23 Nov 2023 11:57:04 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50963D64 for ; Thu, 23 Nov 2023 08:57:08 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-0004zQ-Dl; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0c-00B54g-UL; Thu, 23 Nov 2023 17:56:58 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozI-L1; Thu, 23 Nov 2023 17:56:58 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 04/18] mfd: fsl-imx25-tsadc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:32 +0100 Message-ID: <20231123165627.492259-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1657; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=H9E4DQumuJYM4xGNsjymKWQwrBqvaE1jdcSqA7stR1c=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtT4FocGfaaOewzxfHtil1sf2aDbr83dc66GIdswU79qe vUGZsFORmMWBkYuBlkxRRb7xjWZVlVykZ1r/12GGcTKBDKFgYtTACbCls/+z646rGhr3C5Bjiks tW/fztmy8prXz8TGDv5Fv1UupnQfCV7jfkixwfaWSoN7z5ZWjd0/1e/ZNvH8k19+S137VH6C7Cl FhijdjHs6p8Ks+hgFItikJWRiTyasrTul9Gzt2tfxEpqppwy0vj5dIRWl9/h13+xQ7ZslW4Wb3n C8Nly/v4J1Z1zirq0xrXXLj0uc3bRDK3DTh8s8bT/kBcI8OXbNv57JL7F2VrihxckViQbCoU9qK 7juPDu1ef1vu3sTi+dnL7lW6v0mSO+0kvWEFc2cf2K49HQXzrRbPLmWXTM+RfSi5xMhqfXckYLF nxenrHE048m68tzQ4Pm0xgvTgv4WLHgbsKKnYu2V6DUdAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/fsl-imx25-tsadc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/fsl-imx25-tsadc.c b/drivers/mfd/fsl-imx25-tsadc.c index 089c2ce615b6..74f38bf3778f 100644 --- a/drivers/mfd/fsl-imx25-tsadc.c +++ b/drivers/mfd/fsl-imx25-tsadc.c @@ -194,11 +194,9 @@ static int mx25_tsadc_probe(struct platform_device *pd= ev) return ret; } =20 -static int mx25_tsadc_remove(struct platform_device *pdev) +static void mx25_tsadc_remove(struct platform_device *pdev) { mx25_tsadc_unset_irq(pdev); - - return 0; } =20 static const struct of_device_id mx25_tsadc_ids[] =3D { @@ -213,7 +211,7 @@ static struct platform_driver mx25_tsadc_driver =3D { .of_match_table =3D mx25_tsadc_ids, }, .probe =3D mx25_tsadc_probe, - .remove =3D mx25_tsadc_remove, + .remove_new =3D mx25_tsadc_remove, }; module_platform_driver(mx25_tsadc_driver); =20 --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1706C61D97 for ; Thu, 23 Nov 2023 16:57:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345139AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229462AbjKWQ4z (ORCPT ); Thu, 23 Nov 2023 11:56:55 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37587BC for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-0004zR-IT; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0d-00B54k-66; Thu, 23 Nov 2023 17:56:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0c-006ozM-TS; Thu, 23 Nov 2023 17:56:58 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 05/18] mfd: hi655x-pmic: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:33 +0100 Message-ID: <20231123165627.492259-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1778; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=dI9I7gz8/r2ZcPCua/AplnWUDrg6g0W/Uk6MlFqZHHs=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RB+83Rz11Z6/NItwJ0/Z2CF9epAbSH3zyAJ bGInwhPFXeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EQQAKCRCPgPtYfRL+ TkNtB/wOctIRHw/GpGBKwLcWP5+UlhVikKuLUUUSBgs3bn3C+ji2CoY2cc56deEZZE4k5Fd7MGM /ae9HmULVtrQu6GSj25QNZna4hagUvC/NNFcDNbJ30cMxve4yqWRilnBqKKV5Napyc1dFgwiiGE cKT+l2u9f2FN1qHCxvW/ATkHT6zlXJPkUcJqhV1IMHRPN/q71spl8z3K9gsI0mmY1S3PnN9IsXk v3GqUubRdIGafZl75/bHxHOMkXRNLF+sXhdbNeJ9dRzO77PI71gbn+QtRzrAAdlOa+N44N20QA6 JAMBUPoxPHrt25mXDUnYv1y92yIivSmpLYmHoZYw9oRCkAa9 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/hi655x-pmic.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/hi655x-pmic.c b/drivers/mfd/hi655x-pmic.c index 8feae8d8fd9d..042109304db4 100644 --- a/drivers/mfd/hi655x-pmic.c +++ b/drivers/mfd/hi655x-pmic.c @@ -144,13 +144,12 @@ static int hi655x_pmic_probe(struct platform_device *= pdev) return 0; } =20 -static int hi655x_pmic_remove(struct platform_device *pdev) +static void hi655x_pmic_remove(struct platform_device *pdev) { struct hi655x_pmic *pmic =3D platform_get_drvdata(pdev); =20 regmap_del_irq_chip(gpiod_to_irq(pmic->gpio), pmic->irq_data); mfd_remove_devices(&pdev->dev); - return 0; } =20 static const struct of_device_id hi655x_pmic_match[] =3D { @@ -165,7 +164,7 @@ static struct platform_driver hi655x_pmic_driver =3D { .of_match_table =3D hi655x_pmic_match, }, .probe =3D hi655x_pmic_probe, - .remove =3D hi655x_pmic_remove, + .remove_new =3D hi655x_pmic_remove, }; module_platform_driver(hi655x_pmic_driver); =20 --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E85CC624B4 for ; Thu, 23 Nov 2023 16:57:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345171AbjKWQ5B (ORCPT ); Thu, 23 Nov 2023 11:57:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 720E8D42 for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0d-000503-Rr; Thu, 23 Nov 2023 17:56:59 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0d-00B54n-FI; Thu, 23 Nov 2023 17:56:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozQ-6D; Thu, 23 Nov 2023 17:56:59 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 06/18] mfd: intel-lpss-acpi: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:34 +0100 Message-ID: <20231123165627.492259-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1698; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Sme7QalM7Fxz+h2W/iOt36fGZfq+w2Qz9J3kQwKy1O8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RCnfCgkDJiIE25/oCfSiIzC5NO848BrtAnH ZyBqiDPe++JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EQgAKCRCPgPtYfRL+ ToMQB/9Usf5Erf+yrIvwTJja/sV0wyLm7NbGOq/oPD0A6ULzpXEPJXuTuLFzeI+pUQ1izKzIpXX drtfihdCoaAjmIpQ2xlGLJF68i4FohnxMOUI53PnpT2LX7AzWA+g+EUiuldK/u1JmsPMf1kJNLG eiQDV7FQ5EhP+eZbiHSddN3ddK1mR99Ps+2lGCxnuq8/5fmdYe/56ds/hkTJu6fR2yIogyVbQWx AHBac4/+1LERCvnSy4ZkCsdy5K12f3VcJiPMX11dl/8BKpKzC+bnxraJTr24FHc8QtIY4faIWKr r39ArH582zRPo5wsmp1wUA2YZcJkh9BoWu7DNoISukGYB1gT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/intel-lpss-acpi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/intel-lpss-acpi.c b/drivers/mfd/intel-lpss-acpi.c index 212818aef93e..5184fd1a5df1 100644 --- a/drivers/mfd/intel-lpss-acpi.c +++ b/drivers/mfd/intel-lpss-acpi.c @@ -198,19 +198,17 @@ static int intel_lpss_acpi_probe(struct platform_devi= ce *pdev) return 0; } =20 -static int intel_lpss_acpi_remove(struct platform_device *pdev) +static void intel_lpss_acpi_remove(struct platform_device *pdev) { intel_lpss_remove(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } =20 static INTEL_LPSS_PM_OPS(intel_lpss_acpi_pm_ops); =20 static struct platform_driver intel_lpss_acpi_driver =3D { .probe =3D intel_lpss_acpi_probe, - .remove =3D intel_lpss_acpi_remove, + .remove_new =3D intel_lpss_acpi_remove, .driver =3D { .name =3D "intel-lpss", .acpi_match_table =3D intel_lpss_acpi_ids, --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60E18C5AD4C for ; Thu, 23 Nov 2023 16:57:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345196AbjKWQ5D (ORCPT ); Thu, 23 Nov 2023 11:57:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229519AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF8D2D46 for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00051H-6o; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0d-00B54t-Or; Thu, 23 Nov 2023 17:56:59 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozU-Fw; Thu, 23 Nov 2023 17:56:59 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 07/18] mfd: kempld-core: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:35 +0100 Message-ID: <20231123165627.492259-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1898; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=KmijBtfkuKurQFpbpsAneLTGXJS1Jnusah8kZowlcJE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RDkwUEr6r4st/+YMwIR6Z1awsT9exPwbnm+ tzt0Lu8yw2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EQwAKCRCPgPtYfRL+ Ttn6B/4ufQ06c+9PQx3uvAkc7ww5TKk0Z7pNN69ibei2pGdkYQWM+s0VKB7rz0SBrWrltLOR/6G FKF61LS1f3IlHxPf5cplsK0Dcb7K15gmy7wdJ7C+un3FEA6ISQMk2ZwGQklHzCRuWn+pudJJJYR Zac1NvgcYdSWbl/CArFuX1NIa7gLd1z4S3b/5mMtDqtMsMEDeweLqu+7Li0nbqxvD77uzi7tDd+ JrVmtmMrTMJWT2wJ7fj5/Et0pFFXkonZrXjw2t2hg9TNuPjDeYbx1D7c2mBi63weorU0GFCIRXg +34765A/6ijn9ryLfJ0JdzdATOibqh0YhNhNCp1JqkusDJGE X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/kempld-core.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c index 33c6cfe9fe42..67af36a38913 100644 --- a/drivers/mfd/kempld-core.c +++ b/drivers/mfd/kempld-core.c @@ -535,7 +535,7 @@ static int kempld_probe(struct platform_device *pdev) return kempld_detect_device(pld); } =20 -static int kempld_remove(struct platform_device *pdev) +static void kempld_remove(struct platform_device *pdev) { struct kempld_device_data *pld =3D platform_get_drvdata(pdev); const struct kempld_platform_data *pdata =3D dev_get_platdata(pld->dev); @@ -544,8 +544,6 @@ static int kempld_remove(struct platform_device *pdev) =20 mfd_remove_devices(&pdev->dev); pdata->release_hardware_mutex(pld); - - return 0; } =20 #ifdef CONFIG_ACPI @@ -563,7 +561,7 @@ static struct platform_driver kempld_driver =3D { .acpi_match_table =3D ACPI_PTR(kempld_acpi_table), }, .probe =3D kempld_probe, - .remove =3D kempld_remove, + .remove_new =3D kempld_remove, }; =20 static const struct dmi_system_id kempld_dmi_table[] __initconst =3D { --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38017C5AD4C for ; Thu, 23 Nov 2023 16:57:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345149AbjKWQ47 (ORCPT ); Thu, 23 Nov 2023 11:56:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229526AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EF8F6D48 for ; Thu, 23 Nov 2023 08:57:01 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00053N-Du; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B54x-03; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozY-NM; Thu, 23 Nov 2023 17:56:59 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 08/18] mfd: mcp-sa11x0: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:36 +0100 Message-ID: <20231123165627.492259-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1942; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=306Da8DHDzuEHmAs2DmBNmnh5FVbLXfhEvcGFu1AvDA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RE0iIvzSXUDoJ9ZVZKIf15IRopeUzfSOp0C 53AfyWitiyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ERAAKCRCPgPtYfRL+ ThT6B/9e+FvsnumNbUow1hEZHP3FjwjB8jAayEvtkeFQjLORjXL3V8rrtg6gyvW06tlteUyI3AP ALV4nxz7WfRe+LQuqpIULBW9FPfCUh4QO1wouqvS5/8aTmpQ0RKDqaPefNheRW7Wy+FLR+aGfED dYdfjqmHC6Oco4ZwXl945p6b/P80IGkyhPLmc1/lY1q7UboFwhTpYsb1mZfltVDLH+Vt+NBkKDG BH8tfcw40gVGwgVprukoLzsRqbgw3w5tNCZcyPq2dJOaWvLLrXPr0j+aqw/5Eo61WjysE1WOIe1 sRdbMD74i8uGKm7orHjTJ2raUv4mzZbhYItGuEFV1PjyJG0k X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/mcp-sa11x0.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/mcp-sa11x0.c b/drivers/mfd/mcp-sa11x0.c index 1c9831b78cf9..3883e472b739 100644 --- a/drivers/mfd/mcp-sa11x0.c +++ b/drivers/mfd/mcp-sa11x0.c @@ -232,7 +232,7 @@ static int mcp_sa11x0_probe(struct platform_device *dev) return ret; } =20 -static int mcp_sa11x0_remove(struct platform_device *dev) +static void mcp_sa11x0_remove(struct platform_device *dev) { struct mcp *mcp =3D platform_get_drvdata(dev); struct mcp_sa11x0 *m =3D priv(mcp); @@ -251,8 +251,6 @@ static int mcp_sa11x0_remove(struct platform_device *de= v) mcp_host_free(mcp); release_mem_region(mem1->start, resource_size(mem1)); release_mem_region(mem0->start, resource_size(mem0)); - - return 0; } =20 static int mcp_sa11x0_suspend(struct device *dev) @@ -288,7 +286,7 @@ static const struct dev_pm_ops mcp_sa11x0_pm_ops =3D { =20 static struct platform_driver mcp_sa11x0_driver =3D { .probe =3D mcp_sa11x0_probe, - .remove =3D mcp_sa11x0_remove, + .remove_new =3D mcp_sa11x0_remove, .driver =3D { .name =3D DRIVER_NAME, .pm =3D pm_sleep_ptr(&mcp_sa11x0_pm_ops), --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5F00C61D97 for ; Thu, 23 Nov 2023 16:58:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232908AbjKWQ5w (ORCPT ); Thu, 23 Nov 2023 11:57:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345245AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6157DD7E for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00054w-Mw; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B550-8E; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0d-006ozc-VH; Thu, 23 Nov 2023 17:56:59 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 09/18] mfd: mxs-lradc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:37 +0100 Message-ID: <20231123165627.492259-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1686; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=GNK+c3Abifs5Um4n3RL+YvkDdPV3heWsrI7W1ir+IZ8=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RFCaJ6YKeIfgaSRYJ+VtntxTS1jxS1g3H7Y y1ZQd/hUJeJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ERQAKCRCPgPtYfRL+ ThjMCACQ4bf1a2PidPYlIeCGasO6BuOXhwT/Cb+640lGH78lqfL+3RaGVeFJRiCjV7hEnbuTIIU 6rAvOIPQzMmMbhyJXQz6f7955w5316eIHcoAJQONjqYWLnPRST6/t+4+O/kCMDaH8Mm+1b+8h87 cjbIy/E4SCLP1I1F1LCMfDQe6nvxntOqEPn/Xy9H0bg0gFvSKZVpJdcTcQ7+rSl0g1rOwldkA7w t7OsdALFnZblnxDLCOK267TDs5rC9O8HraKUOSw4Cu8+fzdQLO16pJwk5DM3XWTiNKvuvlelg5y oOmoCo9yd7Vg8R2b6C4skR0i9fL3yuxaxe9B7kHlZhAXrK3n X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/mxs-lradc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/mxs-lradc.c b/drivers/mfd/mxs-lradc.c index ec1b356562b9..73893890b50a 100644 --- a/drivers/mfd/mxs-lradc.c +++ b/drivers/mfd/mxs-lradc.c @@ -230,13 +230,11 @@ static int mxs_lradc_probe(struct platform_device *pd= ev) return ret; } =20 -static int mxs_lradc_remove(struct platform_device *pdev) +static void mxs_lradc_remove(struct platform_device *pdev) { struct mxs_lradc *lradc =3D platform_get_drvdata(pdev); =20 clk_disable_unprepare(lradc->clk); - - return 0; } =20 static struct platform_driver mxs_lradc_driver =3D { @@ -245,7 +243,7 @@ static struct platform_driver mxs_lradc_driver =3D { .of_match_table =3D mxs_lradc_dt_ids, }, .probe =3D mxs_lradc_probe, - .remove =3D mxs_lradc_remove, + .remove_new =3D mxs_lradc_remove, }; module_platform_driver(mxs_lradc_driver); =20 --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A5F9C624B4 for ; Thu, 23 Nov 2023 16:57:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345145AbjKWQ51 (ORCPT ); Thu, 23 Nov 2023 11:57:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345168AbjKWQ5B (ORCPT ); Thu, 23 Nov 2023 11:57:01 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F13ED41 for ; Thu, 23 Nov 2023 08:57:07 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0e-00055n-Ts; Thu, 23 Nov 2023 17:57:00 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B554-FM; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0e-006ozg-6J; Thu, 23 Nov 2023 17:57:00 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 10/18] mfd: omap-usb-host: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:38 +0100 Message-ID: <20231123165627.492259-11-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1815; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=UItv2bTQ3oxGDvzjFaeeuB8LovhLd6RvQdqam8Wvj/k=; b=owGbwMvMwMXY3/A7olbonx/jabUkhtT4FrdX+9Y1c5bNCI5KLtC4IL7OM9Ot6i5ncor2vJQm3 n0/mgQ7GY1ZGBi5GGTFFFnsG9dkWlXJRXau/XcZZhArE8gUBi5OAZhIdB4Hw/aa/LJzO5oepxgd 23O8jSknwynepZ/h0ZJXTzmC97Rc983bvjBhRaKAsv53lld7m35+NVy6S9LuuJdi4NTJKje/MM8 SN8usCXvfGrS0qmit/MSlq7K12/eX26X81g+JcHnXcKhs+oylpsbPTUO9+NOEOfLvvFCVeL9W/v yN1a+0MvqL0jf18Rdk5WzRcPCY1apr8V/5z9PwQ2dU3jXc8ZoiuMj2o2TX0kSfzkeivme8HUxCf bOLpW+6+R9bMf/qDom0zbO+v1izNiHswkyR0voEEZma0z8uxLpcWh12/t22HTO6p6b29IoH3pGd c3nTlqNt6b3d69/OL2Cc1xxyg11LdelB9Vz9oiehaouLAQ== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/omap-usb-host.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c index 78f1bb55dbc0..ebc62033db16 100644 --- a/drivers/mfd/omap-usb-host.c +++ b/drivers/mfd/omap-usb-host.c @@ -816,13 +816,12 @@ static int usbhs_omap_remove_child(struct device *dev= , void *data) * * Reverses the effect of usbhs_omap_probe(). */ -static int usbhs_omap_remove(struct platform_device *pdev) +static void usbhs_omap_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); =20 /* remove children */ device_for_each_child(&pdev->dev, NULL, usbhs_omap_remove_child); - return 0; } =20 static const struct dev_pm_ops usbhsomap_dev_pm_ops =3D { @@ -845,7 +844,7 @@ static struct platform_driver usbhs_omap_driver =3D { .of_match_table =3D usbhs_omap_dt_ids, }, .probe =3D usbhs_omap_probe, - .remove =3D usbhs_omap_remove, + .remove_new =3D usbhs_omap_remove, }; =20 MODULE_AUTHOR("Keshava Munegowda "); --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DC57C5AD4C for ; Thu, 23 Nov 2023 16:57:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345341AbjKWQ5c (ORCPT ); Thu, 23 Nov 2023 11:57:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345185AbjKWQ5B (ORCPT ); Thu, 23 Nov 2023 11:57:01 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7C30D5E for ; Thu, 23 Nov 2023 08:57:07 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0f-000572-6L; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0e-00B559-OK; Thu, 23 Nov 2023 17:57:00 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0e-006ozk-FA; Thu, 23 Nov 2023 17:57:00 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 11/18] mfd: omap-usb-tll: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:39 +0100 Message-ID: <20231123165627.492259-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1867; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=6grJxx2LHRITrZAbOAlfmI+2kXgEuMJigw1AAr3yPog=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RIFwziiGXsZn1On1/MovUspXu733lLnlJFD RweOUzkJcaJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESAAKCRCPgPtYfRL+ TvoiB/420e3zD2ZZI9dSb9u1sLR6OEJ63GxYAc51glsm6MAZhyys0dNzjVte35LL+w8oHPQKf79 4WA6Ugt2sTgD9fOcRoPM0wv35ApqXwf6dYwBdISkQVFIUcMsql5XWbJ6zlSSEIooEl9Q+lgjvsQ zRuiAm0/psL39x8zoXNCYJzoif+fi8lZp5xUlsrnXbLYqV7qlhM2cRwIdYWGM3q96tuWxtrTl2w IvN+uykum8DzDcXeG0WNKJQAQL2jCkl35Kafzzs9WauOkBpu1/6FaDAdzrv1p+3PD0Ci2mYLFK0 uSpw69ugywtV/QdI/BEKquIyLcjVxfKTRoGUDf6YR4D4LK8S X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/omap-usb-tll.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c index 906353735c78..b6303ddb013b 100644 --- a/drivers/mfd/omap-usb-tll.c +++ b/drivers/mfd/omap-usb-tll.c @@ -270,7 +270,7 @@ static int usbtll_omap_probe(struct platform_device *pd= ev) * * Reverses the effect of usbtll_omap_probe(). */ -static int usbtll_omap_remove(struct platform_device *pdev) +static void usbtll_omap_remove(struct platform_device *pdev) { struct usbtll_omap *tll =3D platform_get_drvdata(pdev); int i; @@ -287,7 +287,6 @@ static int usbtll_omap_remove(struct platform_device *p= dev) } =20 pm_runtime_disable(&pdev->dev); - return 0; } =20 static const struct of_device_id usbtll_omap_dt_ids[] =3D { @@ -303,7 +302,7 @@ static struct platform_driver usbtll_omap_driver =3D { .of_match_table =3D usbtll_omap_dt_ids, }, .probe =3D usbtll_omap_probe, - .remove =3D usbtll_omap_remove, + .remove_new =3D usbtll_omap_remove, }; =20 int omap_tll_init(struct usbhs_omap_platform_data *pdata) --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD1DAC5AD4C for ; Thu, 23 Nov 2023 16:57:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345259AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229930AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2509DD53 for ; Thu, 23 Nov 2023 08:57:02 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0f-00057i-D2; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0f-00B55D-0Z; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0e-006ozo-Ns; Thu, 23 Nov 2023 17:57:00 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 12/18] mfd: pcf50633-adc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:40 +0100 Message-ID: <20231123165627.492259-13-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1835; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=FtAnMobifYM32sw3SvUnyTDhNGwr52N00NU39uqq4PY=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RJMlhOsi8S7zcdLMJJGez9KN5J7DTm4Ovzc h33JyjXZYOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESQAKCRCPgPtYfRL+ TsSrCACGgOBx/tuJ6VjMhZrKaZ5Q4ORmRr+AKmZ/Jdi25XfzGMxN/QVvYjz4MZIcgK32AbMhuI+ lpzQq5URbuFHW6IUTN6TJj+/ttUcpwjyZt0nZ05mH8upuNsv0f61od4P2RErgPI22odTknb45NU AsK4vOceNV9AWvjJwkGeJFVmMo/DGJ4kHYOQVeliQmEZKdR8I5KlJbWHIfTdHiD9o6JFekGRDNa C4iM72L7ALHRA7LJSZwPf4BezOAqkNl0zR20e3n3ubAOAst4R25Q6gdq3E/MbxnKvh/F8gK/ZE2 5g7BkpUNuzlwXzz6rSI+ErdEhGIaQvol7QNcZNAQr8/hIs2u X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/pcf50633-adc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/pcf50633-adc.c b/drivers/mfd/pcf50633-adc.c index 191b1bc6141c..ab55906f91f9 100644 --- a/drivers/mfd/pcf50633-adc.c +++ b/drivers/mfd/pcf50633-adc.c @@ -218,7 +218,7 @@ static int pcf50633_adc_probe(struct platform_device *p= dev) return 0; } =20 -static int pcf50633_adc_remove(struct platform_device *pdev) +static void pcf50633_adc_remove(struct platform_device *pdev) { struct pcf50633_adc *adc =3D platform_get_drvdata(pdev); int i, head; @@ -236,8 +236,6 @@ static int pcf50633_adc_remove(struct platform_device *= pdev) kfree(adc->queue[i]); =20 mutex_unlock(&adc->queue_mutex); - - return 0; } =20 static struct platform_driver pcf50633_adc_driver =3D { @@ -245,7 +243,7 @@ static struct platform_driver pcf50633_adc_driver =3D { .name =3D "pcf50633-adc", }, .probe =3D pcf50633_adc_probe, - .remove =3D pcf50633_adc_remove, + .remove_new =3D pcf50633_adc_remove, }; =20 module_platform_driver(pcf50633_adc_driver); --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46013C5AD4C for ; Thu, 23 Nov 2023 16:58:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345487AbjKWQ6A (ORCPT ); Thu, 23 Nov 2023 11:58:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345305AbjKWQ5Q (ORCPT ); Thu, 23 Nov 2023 11:57:16 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67B2710E5 for ; Thu, 23 Nov 2023 08:57:11 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0f-00058H-Lr; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0f-00B55H-8o; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0e-006ozs-W1; Thu, 23 Nov 2023 17:57:01 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 13/18] mfd: qcom-pm8xxx: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:41 +0100 Message-ID: <20231123165627.492259-14-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1720; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=kmmW3jQ8i81KFfqYxB0Ki4v/E6hUWk+ecQRLAZOVMi0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RKkkPvevqUyzElWksaJzFiy57xDrcoz/rI+ 5duKyqUVSGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESgAKCRCPgPtYfRL+ Tos1CACw6arTk6jUW66Qko52akt9RHWRZbEU2z8w3FWnWDZ8FtMaRviddYr5vLNJkH8REHMKo59 luR8nZFEKsyzNBUKWMOFKsuY48gaVCYtOBgvZceoEGfAZK+DwX4gW6rw68yxAcIXsxZFV9fvfCa fkSK4SOlXt0J49eWjKFFKah99rcOD4wrm5Q9ODvI7ASlwEGgW6/8f8iU7Y2D+v33zFwmVbDqPLQ rumhqaQFkSFO9l+2yWuOvTIq7boaWo/vVwzev02a+2yt+MNeQBJLhaU080mT2KeMl+KAiLr3T7/ 74ZxAAx+1HKJIcTOFil15pq6m5TYfI9DKo7N1HeRwwgKQDIy X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Reviewed-by: Konrad Dybcio Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/qcom-pm8xxx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c index 07c531bd1236..8b6285f687da 100644 --- a/drivers/mfd/qcom-pm8xxx.c +++ b/drivers/mfd/qcom-pm8xxx.c @@ -585,19 +585,17 @@ static int pm8xxx_remove_child(struct device *dev, vo= id *unused) return 0; } =20 -static int pm8xxx_remove(struct platform_device *pdev) +static void pm8xxx_remove(struct platform_device *pdev) { struct pm_irq_chip *chip =3D platform_get_drvdata(pdev); =20 device_for_each_child(&pdev->dev, NULL, pm8xxx_remove_child); irq_domain_remove(chip->irqdomain); - - return 0; } =20 static struct platform_driver pm8xxx_driver =3D { .probe =3D pm8xxx_probe, - .remove =3D pm8xxx_remove, + .remove_new =3D pm8xxx_remove, .driver =3D { .name =3D "pm8xxx-core", .of_match_table =3D pm8xxx_id_table, --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77971C5AD4C for ; Thu, 23 Nov 2023 16:57:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345220AbjKWQ5J (ORCPT ); Thu, 23 Nov 2023 11:57:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbjKWQ44 (ORCPT ); Thu, 23 Nov 2023 11:56:56 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74297D54 for ; Thu, 23 Nov 2023 08:57:03 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0f-00058S-UF; Thu, 23 Nov 2023 17:57:01 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0f-00B55M-Ht; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0f-006ozw-8s; Thu, 23 Nov 2023 17:57:01 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 14/18] mfd: sm501: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:42 +0100 Message-ID: <20231123165627.492259-15-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1850; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zg/2ZKivK3j/zzzpz8S6gtZj3g6k3uJ+o38xadR7Krk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RLVqlKlHQf/icLBp7mzF2JWyccRJ6kaVxD9 ZxwFFiBXvyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ESwAKCRCPgPtYfRL+ TpMwB/9Z7joueqrSTQ5o2Xb8R/dCAHqRR6UsmAR1YjWLq5pL1Rzpa8Gak2wetFc/nIU07qJdR7K QIe0DrE6Okv/OJUP5UVMdmr/pqRssuBnIPIZuKW43frusnGnaFvuDzX3/8l2GroW8zjPZ7ARjqx NKPlVjfutyeDb1+XH+rKXRR6lMuaLtVpeIMiALs2iKUFti3W9iSGd//bbEEbscyBkE9A3r82GOu iehYZd3xSfylBtB92N7zDDcgFVPWblukIYYrVTofG+LgS2U2zfGmu6UVE71Y2jU5KFREXnbcMEW 7XMoLoEi4jYdH+NA52nVtRDFVTHs6UCWwO+eJZZV2IPvjnQr X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/sm501.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c index 28027982cf69..b3592982a83b 100644 --- a/drivers/mfd/sm501.c +++ b/drivers/mfd/sm501.c @@ -1667,7 +1667,7 @@ static void sm501_pci_remove(struct pci_dev *dev) pci_disable_device(dev); } =20 -static int sm501_plat_remove(struct platform_device *dev) +static void sm501_plat_remove(struct platform_device *dev) { struct sm501_devdata *sm =3D platform_get_drvdata(dev); =20 @@ -1675,8 +1675,6 @@ static int sm501_plat_remove(struct platform_device *= dev) iounmap(sm->regs); =20 release_mem_region(sm->io_res->start, 0x100); - - return 0; } =20 static const struct pci_device_id sm501_pci_tbl[] =3D { @@ -1707,7 +1705,7 @@ static struct platform_driver sm501_plat_driver =3D { .of_match_table =3D of_sm501_match_tbl, }, .probe =3D sm501_plat_probe, - .remove =3D sm501_plat_remove, + .remove_new =3D sm501_plat_remove, .suspend =3D pm_sleep_ptr(sm501_plat_suspend), .resume =3D pm_sleep_ptr(sm501_plat_resume), }; --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1535EC5AD4C for ; Thu, 23 Nov 2023 16:58:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345222AbjKWQ54 (ORCPT ); Thu, 23 Nov 2023 11:57:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345253AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EE9410C9 for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0g-00058f-7S; Thu, 23 Nov 2023 17:57:02 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0f-00B55Q-Qq; Thu, 23 Nov 2023 17:57:01 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0f-006p00-HW; Thu, 23 Nov 2023 17:57:01 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 15/18] mfd: stm32-timers: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:43 +0100 Message-ID: <20231123165627.492259-16-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1913; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=jVkK8Ke5hsybq+hJya3Qt2KaRP0LWkU08638E+yF+OA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RMWnS+kDacKKlH4v2Liesd5r6OzwvKBRTf0 42Nudp3EaOJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ETAAKCRCPgPtYfRL+ Tg51B/4iQeyWsKcZqQxzJ9EpqzADAmrRSQK1J+YgDkC/ssJwOFwFHeKS9ufGTLQZjueDdMviNqX VhZdoCQGRNaPOJGESuecYhuxZuAMuRX8wH9ekGMyx5PJLMf8Eo0kjpy8BNPewRkuvpasgc3ZRiR cOXatNi6ahOcob8Sw52RwHZJpyzqqLLhWt5AKCh2amYBpEo5uWwt192cGOffMLfw7C+sJXQXFzE pey/6uHGKQPofLnGxcpA987g/L1rQeaZFlqP97/GpwMozfiDxicqhDQGWCWf1Rse8p5j3qe7x0v fnP2lJ0Drk67B4wBR3zTU3eQMwcXGlO43rUPuXsSIhW0pukC X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/stm32-timers.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c index a656a1c186a8..9fd13d88950c 100644 --- a/drivers/mfd/stm32-timers.c +++ b/drivers/mfd/stm32-timers.c @@ -306,7 +306,7 @@ static int stm32_timers_probe(struct platform_device *p= dev) return ret; } =20 -static int stm32_timers_remove(struct platform_device *pdev) +static void stm32_timers_remove(struct platform_device *pdev) { struct stm32_timers *ddata =3D platform_get_drvdata(pdev); =20 @@ -316,8 +316,6 @@ static int stm32_timers_remove(struct platform_device *= pdev) */ of_platform_depopulate(&pdev->dev); stm32_timers_dma_remove(&pdev->dev, ddata); - - return 0; } =20 static const struct of_device_id stm32_timers_of_match[] =3D { @@ -328,7 +326,7 @@ MODULE_DEVICE_TABLE(of, stm32_timers_of_match); =20 static struct platform_driver stm32_timers_driver =3D { .probe =3D stm32_timers_probe, - .remove =3D stm32_timers_remove, + .remove_new =3D stm32_timers_remove, .driver =3D { .name =3D "stm32-timers", .of_match_table =3D stm32_timers_of_match, --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC01C5AD4C for ; Thu, 23 Nov 2023 16:57:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345282AbjKWQ5L (ORCPT ); Thu, 23 Nov 2023 11:57:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345133AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 043CCBC for ; Thu, 23 Nov 2023 08:57:04 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0g-00058l-E4; Thu, 23 Nov 2023 17:57:02 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0g-00B55U-1W; Thu, 23 Nov 2023 17:57:02 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0f-006p04-Ok; Thu, 23 Nov 2023 17:57:01 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 16/18] mfd: ti_am335x_tscadc: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:44 +0100 Message-ID: <20231123165627.492259-17-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1826; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=958CZe9ea6jlgCw+DhNvLHgJQMdn3TTMy73VrfjhS7g=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RNzUp+O1Q5mU1TkWEfA3LmuaPzBLdiln56y PSSEKex4f6JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ETQAKCRCPgPtYfRL+ TurkCACzAHQ8fH88QHgqOLqaNePjWA12uL4ORz6rDd/07Qql/Ocfh960J2cC1A9UR/xfVcUw5M1 xRz2DM97OMdCUYi6zn7jATB7wZ5HQbgdf4GWEN8PZOdNZdExU+Da70xA3G2ftNnvOBDYQ9Xpjjl LcIX/J36/F15n0ewUYD93CLn5i9eZOlbn8cZwF1aM7Vu6jp38egkaQbS5r9O9TmiEgHEjzytFjD 1dwiHTLqpkoExD/kLDpsEO1eT/FTDc8pB8BlE0IwT1ozQ+GMTCceLq9L/28LGwj0Pw59DT8Ll0O ocPFfGmV7OYX/MmBSfr301ogvoJCLRoWcetR7uv8ixprikzT X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/ti_am335x_tscadc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index b88eb70c17b3..4bbd542d753e 100644 --- a/drivers/mfd/ti_am335x_tscadc.c +++ b/drivers/mfd/ti_am335x_tscadc.c @@ -298,7 +298,7 @@ static int ti_tscadc_probe(struct platform_device *pdev) return err; } =20 -static int ti_tscadc_remove(struct platform_device *pdev) +static void ti_tscadc_remove(struct platform_device *pdev) { struct ti_tscadc_dev *tscadc =3D platform_get_drvdata(pdev); =20 @@ -308,8 +308,6 @@ static int ti_tscadc_remove(struct platform_device *pde= v) pm_runtime_disable(&pdev->dev); =20 mfd_remove_devices(tscadc->dev); - - return 0; } =20 static int __maybe_unused ti_tscadc_can_wakeup(struct device *dev, void *d= ata) @@ -381,7 +379,7 @@ static struct platform_driver ti_tscadc_driver =3D { .of_match_table =3D ti_tscadc_dt_ids, }, .probe =3D ti_tscadc_probe, - .remove =3D ti_tscadc_remove, + .remove_new =3D ti_tscadc_remove, =20 }; =20 --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 373E5C61D97 for ; Thu, 23 Nov 2023 16:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345269AbjKWQ5T (ORCPT ); Thu, 23 Nov 2023 11:57:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345145AbjKWQ46 (ORCPT ); Thu, 23 Nov 2023 11:56:58 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49236D42 for ; Thu, 23 Nov 2023 08:57:04 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0g-00058v-MR; Thu, 23 Nov 2023 17:57:02 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0g-00B55X-9s; Thu, 23 Nov 2023 17:57:02 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0g-006p08-0j; Thu, 23 Nov 2023 17:57:02 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 17/18] mfd: tps65911-comparator: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:45 +0100 Message-ID: <20231123165627.492259-18-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1926; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=DS/bp0Y0SVGN2rxRjkqNDXNDiJW5c7dknT63m3wnUL0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RPuliNKk8BbKe9n0XXWQ4RFLhS0vJCQB6pC DrWE2WIpRuJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+ETwAKCRCPgPtYfRL+ Tq/hB/9U5uK3C/E0qQE1XN08NxkYDjSWNC4dbR5jjSSKuRmoMI8gTsSDNv3DoPuc4gnWelJuKC6 Ma9cm4OjpqmKbLrWJJrDz7gm1TZFnm8uVKpCrciM9LIcI4HJdN7UXIAeRDerSf7WxM6A72fzT+E jKhDQa2EQuYmy17k5vZdAqXtL8qNDSghg2l+miMezfZi8Dx1Er7k2Rqa2x2k8mHYTT4gk815wc+ CfpMKMaOCBNY3/S1Kf7lDYrt51v8Btv2mV0+UDPV/vmbsV41oUjKJzRfog+A5D1ktSXUXHmS4LO ku+89U/RF+v0wvHHfu4G2TJtB6Dlygj8IsH14ELnJ3TqSUcy X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/tps65911-comparator.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/tps65911-comparator.c b/drivers/mfd/tps65911-compa= rator.c index 8f4210075913..f206a9c50e9d 100644 --- a/drivers/mfd/tps65911-comparator.c +++ b/drivers/mfd/tps65911-comparator.c @@ -140,15 +140,13 @@ static int tps65911_comparator_probe(struct platform_= device *pdev) return ret; } =20 -static int tps65911_comparator_remove(struct platform_device *pdev) +static void tps65911_comparator_remove(struct platform_device *pdev) { struct tps65910 *tps65910; =20 tps65910 =3D dev_get_drvdata(pdev->dev.parent); device_remove_file(&pdev->dev, &dev_attr_comp2_threshold); device_remove_file(&pdev->dev, &dev_attr_comp1_threshold); - - return 0; } =20 static struct platform_driver tps65911_comparator_driver =3D { @@ -156,7 +154,7 @@ static struct platform_driver tps65911_comparator_drive= r =3D { .name =3D "tps65911-comparator", }, .probe =3D tps65911_comparator_probe, - .remove =3D tps65911_comparator_remove, + .remove_new =3D tps65911_comparator_remove, }; =20 static int __init tps65911_comparator_init(void) --=20 2.42.0 From nobody Mon Dec 29 18:32:08 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1DCCC5AD4C for ; Thu, 23 Nov 2023 16:57:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232869AbjKWQ5o (ORCPT ); Thu, 23 Nov 2023 11:57:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345236AbjKWQ5F (ORCPT ); Thu, 23 Nov 2023 11:57:05 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46C6AD7D for ; Thu, 23 Nov 2023 08:57:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6D0h-00059B-0C; Thu, 23 Nov 2023 17:57:03 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r6D0g-00B55c-Jp; Thu, 23 Nov 2023 17:57:02 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r6D0g-006p0C-AV; Thu, 23 Nov 2023 17:57:02 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Lee Jones Cc: Tony Lindgren , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH v2 18/18] mfd: twl4030-audio: Convert to platform remove callback returning void Date: Thu, 23 Nov 2023 17:56:46 +0100 Message-ID: <20231123165627.492259-19-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> References: <20231123165627.492259-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1723; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=DEtnBZo9+Rw2avXE1cyu5z7dDDmV5UUxzQ8KgZxe55o=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlX4RQBLGaD9pFfd1Eg7BbBRcTWakbniKn95iPB cQ9N7fsf4uJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZV+EUAAKCRCPgPtYfRL+ Tvh2B/0YkRZYVT9s0hWo0DjSZZuxSkD8Rl/758nwco+aLXlRzC2A5W4oAkrVaSs/LvQj18zku32 Cz8tHBwDUbpykspjmGEkFpG7PLPVEgOUBxsDSuhRfN7zacoZG0jk6x0+ySCHaR1zh7Zh3BoVbfz Z6UCyw5jTTtm19/VJN++oB0/dGja6F2LBPCt1ajKF1aDm9rv43NN0yKyx877d3Z2CsJEEJ6ObE7 LZurYaIlvvCSCVkrfCeiZcGoIEqEcsO+qQsITI+A18Y3AHozwZUFYQNo/P+D30gwA0Hr61Ksg+i 4mjJQeq8mV5dA0YKds3GTIIy9h1u4KMGBWkWRtXVnVVYxo6j X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig --- drivers/mfd/twl4030-audio.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/twl4030-audio.c b/drivers/mfd/twl4030-audio.c index 88002f8941e5..d436ddf661da 100644 --- a/drivers/mfd/twl4030-audio.c +++ b/drivers/mfd/twl4030-audio.c @@ -258,12 +258,10 @@ static int twl4030_audio_probe(struct platform_device= *pdev) return ret; } =20 -static int twl4030_audio_remove(struct platform_device *pdev) +static void twl4030_audio_remove(struct platform_device *pdev) { mfd_remove_devices(&pdev->dev); twl4030_audio_dev =3D NULL; - - return 0; } =20 static const struct of_device_id twl4030_audio_of_match[] =3D { @@ -278,7 +276,7 @@ static struct platform_driver twl4030_audio_driver =3D { .of_match_table =3D twl4030_audio_of_match, }, .probe =3D twl4030_audio_probe, - .remove =3D twl4030_audio_remove, + .remove_new =3D twl4030_audio_remove, }; =20 module_platform_driver(twl4030_audio_driver); --=20 2.42.0