From nobody Mon Dec 29 20:12:30 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6803C5AD4C for ; Thu, 23 Nov 2023 14:43:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345886AbjKWOns (ORCPT ); Thu, 23 Nov 2023 09:43:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345876AbjKWOnp (ORCPT ); Thu, 23 Nov 2023 09:43:45 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B883DD48 for ; Thu, 23 Nov 2023 06:43:50 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id D58623200A2D; Thu, 23 Nov 2023 09:43:49 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 23 Nov 2023 09:43:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1700750629; x= 1700837029; bh=GA437atRox2oPURIGiXlxqMebZt5ndNZI36HbZNzvG4=; b=f sE/QkLKNixyVnObR0dRRFx/WXcgU6HLcunrQl7/eimp90EcFnIrj1wj3SELkEZAy /edQ8SuRrMS3T6RF4J/xmVjV91ZpneSGj9MnLPnTl/F24WY76eEXEoQtg+QB8DRw Px9HVNHYndGEiUJ/G80YaoqYR31LnwEQyU11pfRXO+hai5CIllx6T8rOT9gOmS4F XwPyzVZn8t/6DouuoO0XcBGGtq7jVuBpjlZNxptWhJ+7PdtFRkmLg15OBhYhbmyl xxbeRaOIWcX7vNh4ePEINmoKiLv21ffxi7JKS/+S/UnF9NdBtDIxpCSA3iQwb4D1 0FcNLE53GNevioKRaz6Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1700750629; x= 1700837029; bh=GA437atRox2oPURIGiXlxqMebZt5ndNZI36HbZNzvG4=; b=T NtkENEOmgFf3EFbriwHH1eVY6TDir3fWe0Ougw8jvdRyckAc48OgRjk7BEer+B1h HJyRBW6kQyk+1l/TkvHfYPtshKF65nvBzdlYs+Cj9pwqb9HL9FVab5PM1TL+LJOO neB6sDthyfxThFKwzNnrOSeFD4vyIzOYn2xBP/2WVzdYpdbF4zbGlhTGEvAv7nfc itGKmcMzJ57MFGv4tUf5dUhpUNpJryBMmlg+M0YVrlInRBOhuKi095/hI9TEDWG/ /uqDhWqzkXu74Be1PrzDbtpRG5K9tpzrxm7qxsJh9AzhT8PfEHvPBIgqJ+oEoAkH qb3G0DRZ56iAegnP4Km5g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Nov 2023 09:43:48 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 1/5] staging: rtl8192e: renamed variable HTMcsToDataRate Date: Thu, 23 Nov 2023 09:43:33 -0500 Message-ID: <20231123144337.13112-2-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231123144337.13112-1-garyrookard@fastmail.org> References: <20231123144337.13112-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Renamed variable from Pascal/CamelCase to Snake case the variable HTMcsToDataRate. HTMcsToDataRate -> ht_mcs_to_data_rate Linux Kernel coding style (cleanup), checkpatch Avoid CamelCase. Driver/module rtl8192e compiles. Signed-off-by: Gary Rookard Tested-by: Philipp Hortmann --- v3: Corrected versioning from v1 -> v3, includes change history. v2: v2 was skipped over..v3 corrects this. v1: Style and compile issues, asked to redo. drivers/staging/rtl8192e/rtl819x_HTProc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index e607bccc079a..280e335cbb6d 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -103,7 +103,7 @@ void ht_update_default_setting(struct rtllib_device *ie= ee) ht_info->rx_reorder_pending_time =3D 30; } =20 -static u16 HTMcsToDataRate(struct rtllib_device *ieee, u8 nMcsRate) +static u16 ht_mcs_to_data_rate(struct rtllib_device *ieee, u8 nMcsRate) { struct rt_hi_throughput *ht_info =3D ieee->ht_info; =20 @@ -422,8 +422,8 @@ u8 HTGetHighestMCSRate(struct rtllib_device *ieee, u8 *= pMCSRateSet, bitMap =3D availableMcsRate[i]; for (j =3D 0; j < 8; j++) { if ((bitMap % 2) !=3D 0) { - if (HTMcsToDataRate(ieee, (8 * i + j)) > - HTMcsToDataRate(ieee, mcsRate)) + if (ht_mcs_to_data_rate(ieee, (8 * i + j)) > + ht_mcs_to_data_rate(ieee, mcsRate)) mcsRate =3D 8 * i + j; } bitMap >>=3D 1; --=20 2.41.0 From nobody Mon Dec 29 20:12:30 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1CEDC61DF7 for ; Thu, 23 Nov 2023 14:44:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345878AbjKWOn4 (ORCPT ); Thu, 23 Nov 2023 09:43:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33068 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345864AbjKWOnu (ORCPT ); Thu, 23 Nov 2023 09:43:50 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1677BA4 for ; Thu, 23 Nov 2023 06:43:56 -0800 (PST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 360913200A3F; Thu, 23 Nov 2023 09:43:55 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 23 Nov 2023 09:43:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1700750634; x= 1700837034; bh=1+7AvHJjIM3thaE/1epeB6XcVD1TVhLtKMuA2cV98x0=; b=A kQxzzfeh3TLofcDvbbsV0jqn2P2BA+jpGHZOXofQZ0MVwFhyrC3ZU+UgWzd1J0Nh eXroOMbWQZWVZSaNZGMX102rqaKDXYy1AL9/yvfgJJmsRpI1ix8C9cnavlf8CCpL OqyruE+X+SqDZkpamthfTHJ094BKUdxKUcYdBauD9AxjUo2YKurP426pf6AgsKQ5 MUGeg0zKvDlKj8bt5Utb/xyVVslWokch0hOPvE6gkcFAfOcD9I+xcKBYEV+s3V8z HrudkiJ9s5cjXVr8XnXP5WARyWIvVJ83XyAwVi2jiUsWzqdXzS72geRqPeYU+aZ6 1wxYQuKIb0G9AiY4FoR1Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1700750634; x= 1700837034; bh=1+7AvHJjIM3thaE/1epeB6XcVD1TVhLtKMuA2cV98x0=; b=P i4sCD+sqVoHBS+4/EaGpFALOcIg8Xa6Z7ts/yCTyDB8LTEZkkS8K+rKjl7zyDbRV TS5Sx6vlJ4UR9NDT66KVBs8S6UzxFCBwyYml0Ub5kzo3F5aTAPVBko+6SUJlyZn8 +63JuqcjHHtCXPcLdEPsglmI3JwQSluRLzXr6Q+5vUZF27jozM/tMjjY4bkdvAxW Dk3NrTvIWzM/B9PK6EOxR1J84Uia/8++IFdXxCXg4ugknX7ioBeHrIU/b3qheNPu sOgCq2U3rC71xlIIl5Rt9skJtcGCkUaFmvfRHexAvwZ0mKkXtEwCyqSIAWV8g5KZ 6hQ+KhLw5uhDxT6rW4WnQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Nov 2023 09:43:54 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 2/5] staging: rtl8192e: renamed variable TXCountToDataRate Date: Thu, 23 Nov 2023 09:43:34 -0500 Message-ID: <20231123144337.13112-3-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231123144337.13112-1-garyrookard@fastmail.org> References: <20231123144337.13112-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Renamed from Pascal/CamelCase to Snake case the variable TXCountToDataRate. TXCountToDataRate -> tx_count_to_data_rate Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. Driver/module rtl8192e compiles. Signed-off-by: Gary Rookard Tested-by: Philipp Hortmann --- v3: Corrected versioning from v1 -> v3, includes change history. v2: v2 was skipped over..v3 corrects this. v1 Style and compile issues, asked to redo. drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_softmac_wx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 280e335cbb6d..fb8294f31a60 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -114,7 +114,7 @@ static u16 ht_mcs_to_data_rate(struct rtllib_device *ie= ee, u8 nMcsRate) return MCS_DATA_RATE[is40MHz][isShortGI][(nMcsRate & 0x7f)]; } =20 -u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate) +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate) { u16 CCKOFDMRate[12] =3D {0x02, 0x04, 0x0b, 0x16, 0x0c, 0x12, 0x18, 0x24, 0x30, 0x48, 0x60, 0x6c}; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index d2cf3cfaaaba..0226a69f40c3 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1783,7 +1783,7 @@ extern u16 MCS_DATA_RATE[2][2][77]; u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame); void HTResetIOTSetting(struct rt_hi_throughput *ht_info); bool IsHTHalfNmodeAPs(struct rtllib_device *ieee); -u16 TxCountToDataRate(struct rtllib_device *ieee, u8 nDataRate); +u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate); int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb); int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb); int rtllib_rx_DELBA(struct rtllib_device *ieee, struct sk_buff *skb); diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging= /rtl8192e/rtllib_softmac_wx.c index f32584291704..28aba1d610f7 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c @@ -208,7 +208,7 @@ int rtllib_wx_get_rate(struct rtllib_device *ieee, { u32 tmp_rate; =20 - tmp_rate =3D TxCountToDataRate(ieee, + tmp_rate =3D tx_count_to_data_rate(ieee, ieee->softmac_stats.CurrentShowTxate); wrqu->bitrate.value =3D tmp_rate * 500000; =20 --=20 2.41.0 From nobody Mon Dec 29 20:12:30 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D4E5C61DF7 for ; Thu, 23 Nov 2023 14:44:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345858AbjKWOoH (ORCPT ); Thu, 23 Nov 2023 09:44:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345905AbjKWOoA (ORCPT ); Thu, 23 Nov 2023 09:44:00 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 972A4D6E for ; Thu, 23 Nov 2023 06:44:04 -0800 (PST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id AC2AE3200A2D; Thu, 23 Nov 2023 09:44:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 23 Nov 2023 09:44:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1700750643; x= 1700837043; bh=2+oCaAJMz2K+v99Rw3IHlg2+n9lVGfZLcZHc+W8P+GY=; b=A cIxC/V0Md1kHOullpFMoe3xHyCziytcRjiSFuvolVNfOZPijJvBiWcMgrXnblNuH nIbCcH21BnaNSTXpDzpKZiZpo5AZjOPN9gWDLBYKV4MJ+Vlmr50F6RxKTH2DI6ZV CXqpMQ9G16RM/guAz2LlSjEUTo35A5fCiabCujC1l0Rpn0CoSokSqvbBAvbQ4hd7 OZz/FJyGlhukVFQo3I80WOIxg67EzOAOAhzqfCE8f4Wayhy4RMhs0dA3jgSt0ikz Yq2D/AgOxJgBw0WQOgkYHl2TOxbd+rb4gsR1bf8JmV86VM92d3s8rzi0bbqT+AE+ 8v5KcFj4rDUSN6+sU573A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1700750643; x= 1700837043; bh=2+oCaAJMz2K+v99Rw3IHlg2+n9lVGfZLcZHc+W8P+GY=; b=Y SlzWTSPOTp7izPAW4yi7TOtPUejcyem4+j00+fyRcTObuR1LJeq35foNCCkXHVVR hHKzPc4XDJ1YUcsmP4jsf8SPuq2GS0mdss+10rvYEfMLwAVJvjFFAxizfdAWUu0q 06ZaexNYieG/p/NxX7yviB89bnRyBc06VbGrxJTk5R0OFn0nzNfusOudjpVxykbu +0h9oqFfw25y2DPL9VFusX41kLSHO6DFeWjvfzxIRZKgFtDjuPC9Xu9fEp9nt9hE fXmW2MyVVrosexnwD9N3oQ4BgKXH3ePM7W67jjydG5bQwL91KTuaeRhl3yG4qNF+ R6sFsZjSdlHzLixmlaSwg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Nov 2023 09:44:02 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 3/5] staging: rtl8192e: renamed variable IsHTHalfNmodeAPs Date: Thu, 23 Nov 2023 09:43:35 -0500 Message-ID: <20231123144337.13112-4-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231123144337.13112-1-garyrookard@fastmail.org> References: <20231123144337.13112-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Renamed from Pascal/CamelCase to Snake case the variable IsHTHalfNmodeAPs. ISHTHalfNmodeAPs -> is_ht_half_nmode_aps Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. Driver/module rtl8192e compiles. Signed-off-by: Gary Rookard Tested-by: Philipp Hortmann --- v3: Corrected versioning from v1 -> v3, includes change history. v2: v2 was skipped over..v3 corrects this. v1: Style and compile issues, asked to redo. drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_softmac.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index fb8294f31a60..0993263c13d3 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -139,7 +139,7 @@ u16 tx_count_to_data_rate(struct rtllib_device *ieee, = u8 nDataRate) return MCS_DATA_RATE[is40MHz][isShortGI][nDataRate & 0xf]; } =20 -bool IsHTHalfNmodeAPs(struct rtllib_device *ieee) +bool is_ht_half_nmode_aps(struct rtllib_device *ieee) { bool retValue =3D false; struct rtllib_network *net =3D &ieee->current_network; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 0226a69f40c3..6b549629087b 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1782,7 +1782,7 @@ extern u8 MCS_FILTER_ALL[]; extern u16 MCS_DATA_RATE[2][2][77]; u8 HTCCheck(struct rtllib_device *ieee, u8 *pFrame); void HTResetIOTSetting(struct rt_hi_throughput *ht_info); -bool IsHTHalfNmodeAPs(struct rtllib_device *ieee); +bool is_ht_half_nmode_aps(struct rtllib_device *ieee); u16 tx_count_to_data_rate(struct rtllib_device *ieee, u8 nDataRate); int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb); int rtllib_rx_ADDBARsp(struct rtllib_device *ieee, struct sk_buff *skb); diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rt= l8192e/rtllib_softmac.c index 42d652fe8601..89bc38774fa7 100644 --- a/drivers/staging/rtl8192e/rtllib_softmac.c +++ b/drivers/staging/rtl8192e/rtllib_softmac.c @@ -1872,7 +1872,7 @@ static void rtllib_rx_auth_resp(struct rtllib_device = *ieee, struct sk_buff *skb) ieee->softmac_stats.rx_auth_rs_ok++; if (!(ieee->ht_info->iot_action & HT_IOT_ACT_PURE_N_MODE)) { if (!ieee->GetNmodeSupportBySecCfg(ieee->dev)) { - if (IsHTHalfNmodeAPs(ieee)) { + if (is_ht_half_nmode_aps(ieee)) { bSupportNmode =3D true; bHalfSupportNmode =3D true; } else { --=20 2.41.0 From nobody Mon Dec 29 20:12:30 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 560EAC61DF7 for ; Thu, 23 Nov 2023 14:44:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345876AbjKWOoU (ORCPT ); Thu, 23 Nov 2023 09:44:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345899AbjKWOoM (ORCPT ); Thu, 23 Nov 2023 09:44:12 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A49D8D4A for ; Thu, 23 Nov 2023 06:44:19 -0800 (PST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id BA2EB3200AA9; Thu, 23 Nov 2023 09:44:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 23 Nov 2023 09:44:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1700750658; x= 1700837058; bh=/b4ZzXmogOrXx8ItQTm69B3Pdlitd1fiL+X/xKkaPfc=; b=A EJ4u3vqysIBumCKAgqG9eWqFAwJZj/dY1bdJ5v6pqMnP9xEc/Q2H+SQBRYWquRgz YczvXVPRiFFv+aQrf4dFkmhRB8/khhPuLBsuurAMC2G+TXj086LGxLsNRQsl3wso qmgPbN9Z5LIW1jtXkBP6vNWEfgnLSUyQizjS7hUzpA2PG6A1l5Qay9LoXXODs3tb dQn/09Ojvy3tir/ZMeaXRWuRHClQXjoIVkDJD3Tu7TcQ0uCJWlvct3bxXPgmfjbb Xp0KPkgiWOgp+NvBK9wPR4QJ3q5G/V8B1FJmRRf1EtBVgbM80Vf2Eb02/+HCtPaB g1DKr2zkOzlhYu88dtplg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1700750658; x= 1700837058; bh=/b4ZzXmogOrXx8ItQTm69B3Pdlitd1fiL+X/xKkaPfc=; b=m RHmmJJmAu0/eij3VmR3SKDVpYeiiaV8DYeGH91gVfQAG9/qDa7Yp2y+lW4ImRrvf DnOVV7xuwOjqEMlNJeQTcZOXe+c390BWYHPq50YVOIgEL06NqFD3eMXrvcO8RNw0 0tsjAcH3hh58aRXcIhDROmhWduxEem8CD7b2KmqDXxHnh0Jh7CwJb6KWKZTxUNCb NDyr7xEZMK0dm+fu/uNMwYL7hGQK+tLBf1nN7NiHqb/wLXhjAArV6RTnBeFmPJDn wypM9QJ/qMCKxFeOMl8lzCPFVCev4Ym4MrgoIxnNCC/Q66WAVgsqWlKps6Kkhk9N 6UQccRUjPAsSh8T8u0Pdg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Nov 2023 09:44:17 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 4/5] staging: rtl8192e: renamed variable HTIOTPeerDetermine Date: Thu, 23 Nov 2023 09:43:36 -0500 Message-ID: <20231123144337.13112-5-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231123144337.13112-1-garyrookard@fastmail.org> References: <20231123144337.13112-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Renamed from Pascal/CamelCase to Snake case the variable HTIOTPeerDetermine. HTIOTPeerDetermine -> ht_iot_peer_determine Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. Driver/module rtl8192e compiles. Signed-off-by: Gary Rookard Tested-by: Philipp Hortmann --- v3: Corrected versioning from v1 -> v3, includes change history. v2: v2 was skipped over..v3 corrects this. v1: Style and compile issues, asked to redo. drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 0993263c13d3..0873c19ca051 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -164,7 +164,7 @@ bool is_ht_half_nmode_aps(struct rtllib_device *ieee) return retValue; } =20 -static void HTIOTPeerDetermine(struct rtllib_device *ieee) +static void ht_iot_peer_determine(struct rtllib_device *ieee) { struct rt_hi_throughput *ht_info =3D ieee->ht_info; struct rtllib_network *net =3D &ieee->current_network; @@ -672,7 +672,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device= *ieee, ht_info->RT2RT_HT_Mode =3D (enum rt_ht_capability)0; } =20 - HTIOTPeerDetermine(ieee); + ht_iot_peer_determine(ieee); =20 ht_info->iot_action =3D 0; bIOTAction =3D HTIOTActIsMgntUseCCK6M(ieee, pNetwork); --=20 2.41.0 From nobody Mon Dec 29 20:12:30 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9DFAC5AD4C for ; Thu, 23 Nov 2023 14:45:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345879AbjKWOpF (ORCPT ); Thu, 23 Nov 2023 09:45:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345861AbjKWOpC (ORCPT ); Thu, 23 Nov 2023 09:45:02 -0500 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFB561B3 for ; Thu, 23 Nov 2023 06:45:09 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id B5A233200A9C; Thu, 23 Nov 2023 09:45:08 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 23 Nov 2023 09:45:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1700750708; x= 1700837108; bh=tAugLoT/cPPoDO0Am/a0BT8u3Z35YCoGxKsBr3EXnro=; b=M QtI/AN/OWFiH6tb7WLOTkYq2+aUox/YLpAaGreo3QXK83UmUbsJoBiFHx3sa2HDX posoADBbrUE8qmSYugyYRh2L9cMcmkRhkSILa6HKDaUGaqVcQmAo3fucLcSNApAt JxExn15ZkrWhwv3ImYK3YP0nhO98Ujy4M1rMw/fvVFe5JEBZU1h3CuyUwPy+co/n XUbxMXFRSC7dmxnuuo+y3YLdkdRmiGG5bIJcA1bN4KDp9cyd+K/Jhnt1QluMOkHV mo45OeABQ2DwvKUdfTbt1WYwezFvUHKdznD8+c82P8SprU+n0cPSFIevDgf7eUIt pTWfxfELfozEPXpY/rwOw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1700750708; x= 1700837108; bh=tAugLoT/cPPoDO0Am/a0BT8u3Z35YCoGxKsBr3EXnro=; b=u GhkX2IzPqAziu5NrED4YvksIa8Fa0q8lHWf5LdQfI3cIeViAkvHnTN2Q1ne1w8Cs NX4ik4/js08HYBVIBc2+Cafhjsjlds12/+pgf3pIMKr30xxrHMjjGkDSiJiWUeNC gKSfEoQPLAEzHlrV5boTPWgXns40FSxEz6EX4s4X9ZWiT3eU85Q6Z0kAsXfpqe4v yHl1IKmUMxGuvPuWdj448cpYVmcBkUs5sLDgfxmBUb9argPEBpFBIxoWnHsu4/+x u5X1qMtLmPLwAxRq5U6Un81rTuvA7gMtWRJCHFuABMCSVmhy+QuwBBk9QOF6fPp2 hwjGJ2dCyQaVxSvDuN22g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrudehfedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvfevufffkffojghfggfgsedtke ertdertddtnecuhfhrohhmpefirghrhicutfhoohhkrghrugcuoehgrghrhihrohhokhgr rhgusehfrghsthhmrghilhdrohhrgheqnecuggftrfgrthhtvghrnhepkeeuvdffueduke egieeuffejhefgkeetfeehueelfeduuefgveellefhfefgjedvnecuvehluhhsthgvrhfu ihiivgepudenucfrrghrrghmpehmrghilhhfrhhomhepghgrrhihrhhoohhkrghrugesfh grshhtmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: ifd194980:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 23 Nov 2023 09:45:07 -0500 (EST) From: Gary Rookard To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Gary Rookard Subject: [PATCH v3 5/5] staging: rtl8192e: renamed variable HTIOTActIsMgntUseCCK6M Date: Thu, 23 Nov 2023 09:43:37 -0500 Message-ID: <20231123144337.13112-6-garyrookard@fastmail.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231123144337.13112-1-garyrookard@fastmail.org> References: <20231123144337.13112-1-garyrookard@fastmail.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Renamed from Pascal/CamelCase to Snake case the variable HTIOTActIsMgntUseCCK6M. HTIOTActIsMgntUseCCK6M -> ht_iot_act_is_mgnt_use_cck_6m Linux kernel coding style (cleanup), checkpatch Avoid CamelCase. Driver/module rtl8192e compiles. Signed-off-by: Gary Rookard Tested-by: Philipp Hortmann --- v3: Corrected versioning fron v1 -> v3, includes change history. v2: v2 was Skipped over..v3 corrects this. v1: Style and compile issues, asked to redo. drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 0873c19ca051..f43249fd78d7 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -207,7 +207,7 @@ static void ht_iot_peer_determine(struct rtllib_device = *ieee) netdev_dbg(ieee->dev, "IOTPEER: %x\n", ht_info->IOTPeer); } =20 -static u8 HTIOTActIsMgntUseCCK6M(struct rtllib_device *ieee, +static u8 ht_iot_act_is_mgnt_use_cck_6m(struct rtllib_device *ieee, struct rtllib_network *network) { u8 retValue =3D 0; @@ -675,7 +675,7 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device= *ieee, ht_iot_peer_determine(ieee); =20 ht_info->iot_action =3D 0; - bIOTAction =3D HTIOTActIsMgntUseCCK6M(ieee, pNetwork); + bIOTAction =3D ht_iot_act_is_mgnt_use_cck_6m(ieee, pNetwork); if (bIOTAction) ht_info->iot_action |=3D HT_IOT_ACT_MGNT_USE_CCK_6M; bIOTAction =3D HTIOTActIsCCDFsync(ieee); --=20 2.41.0