From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37800C5AD4C for ; Thu, 23 Nov 2023 09:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232504AbjKWJkt (ORCPT ); Thu, 23 Nov 2023 04:40:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232474AbjKWJkm (ORCPT ); Thu, 23 Nov 2023 04:40:42 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80E92D41; Thu, 23 Nov 2023 01:40:47 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a02d91ab199so82413266b.0; Thu, 23 Nov 2023 01:40:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732446; x=1701337246; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wi4R483zknpMUwj3cvaLHx1vmpa1j9N3buw1XNODPJU=; b=SZ0US6wJvhCsJ+lGb5Ez5s0ViOWv3eK1VNTmyJ55EjaZda2L/1A7W/f0tl45aM3rJT GUIJqKirQkvF97fr5Wp+ofbVsGRGvnXnoaPtxaRh38Gp4G/keA9wqQzNlanyOp/ELQD0 MPt3XnZ5gg/io5gI8LZStazTf5gpmTGHNIksF3cuPVKleBGspBME3N5C019RrjvAFgDH CTg0vBpSi+ntPT65FDGTl5Qftd18V2qgxeqNC+UN4PbmL3N6wrL0iR/gjID9r9wv+vFS ljaSkNH9q/65OcBG5jAhXvX4cTFSIFf8yeQ7ADWWosyqzMtPUx1nItpyT7GFrspSAvyo H/GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732446; x=1701337246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Wi4R483zknpMUwj3cvaLHx1vmpa1j9N3buw1XNODPJU=; b=jPWeN1RQ1fxqZTNVM05beDfnDHp6nPikTUBSz90/H9hnAXD55BvSiwPsWOEg5OTEMC 3mkInWPVLlSaUbYKBDeSRSrglbQUnldEYBLMIvM6iWlz538HzONjA6rP4AayVOMxMwk8 MPRU5tf66dKaGl2/R6hYKqpY18dE5SNWkBDBoLOBtjiKqbyL/fyffcDHpWkxQ0tMd5GI BRINuMQkWdm61sopZYiF81YsYX2fVl9Cqem7VKvb13/r2sEWkRDikOSRFbyhJpYMfWw5 VFBR8wwWlmDFaYRbgejT3QglO+5R4/xvA/TeDTjFBCREvImrpDIuA8NWXKt7FV8ufDia 8KNQ== X-Gm-Message-State: AOJu0YxQ+H4mwDSiMhZ0yNNqre3L5a0bcv137n84Ti4J8cJxFhNi7l6x vMRtNmgsK9i/VjkNZqTuMmI= X-Google-Smtp-Source: AGHT+IEtwKDYnzg1xKgfKy0ud4LFwlV0rfc9uAkIx75F9WsQAVnCrYCvhXmBXTNqAzq4Kf4OfYEh4Q== X-Received: by 2002:a17:906:7c57:b0:9fc:9b28:7ffc with SMTP id g23-20020a1709067c5700b009fc9b287ffcmr3285748ejp.17.1700732445589; Thu, 23 Nov 2023 01:40:45 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:45 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sandy Huang Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:21 +0100 Message-ID: <20231123094040.592-2-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Heiko Stuebner Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/rockchip/inno_hdmi.c | 1 - drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchi= p/inno_hdmi.c index 6e5b922a1..a7739b27c 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct= inno_hdmi *hdmi) init_completion(&i2c->cmp); =20 adap =3D &i2c->adap; - adap->class =3D I2C_CLASS_DDC; adap->owner =3D THIS_MODULE; adap->dev.parent =3D hdmi->dev; adap->dev.of_node =3D hdmi->dev->of_node; diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockc= hip/rk3066_hdmi.c index fa6e592e0..7a3f71aa2 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(stru= ct rk3066_hdmi *hdmi) init_completion(&i2c->cmpltn); =20 adap =3D &i2c->adap; - adap->class =3D I2C_CLASS_DDC; adap->owner =3D THIS_MODULE; adap->dev.parent =3D hdmi->dev; adap->dev.of_node =3D hdmi->dev->of_node; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CDB8C61D85 for ; Thu, 23 Nov 2023 09:41:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233071AbjKWJkx (ORCPT ); Thu, 23 Nov 2023 04:40:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232766AbjKWJkm (ORCPT ); Thu, 23 Nov 2023 04:40:42 -0500 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42C10D44; Thu, 23 Nov 2023 01:40:48 -0800 (PST) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-548f74348f7so935828a12.2; Thu, 23 Nov 2023 01:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732447; x=1701337247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=H76sh9TJa21kiF09BweriFrW/UpEK7sOhe75l5gn76g=; b=P6jsYGK+PkGCtqcrsOkv/NvaKGPptDbS0hmIdsWyEigfD4B0YQu1ulFB67U0jTIg3E +wCorITWSXEIlvEjli0drGFFc3i2JRndKy+1xufl+KV1XmCmDVXo72HwbC5S7EYgEaNS dTXV7lsTdDI8pi+G8DnEHtwpN1Lp9kNf7IIo3RPpLlUfz3zbQzlwTURSdXHrCYb9Qn0v 8HGTAf4kHdxSKmx/BXP7XD9x0BVXMuZuAbkBhuQG1mQT9RE3cpQBxvRkKciwy0nt3/wJ Ef/oDRXm0OFSln5dholtwdIOG6HwMc3TGEnZbangYYurg89UgeaZy4a4hnywRPGXXRkR I1jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732447; x=1701337247; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=H76sh9TJa21kiF09BweriFrW/UpEK7sOhe75l5gn76g=; b=Ow+2n3H8KANk94UmPTvDl+0zXB1G+cUSoNOQ9OkN7Lk5lRrQpiKI3PIZ5/Bk3OBDcT BFClPNxxdH9CM86aXqNMwvzUuNCM14Ih5/jlpxCE3svshx9tSGgXVddDWOe3PUIuR7he j8gJVIo2dddsl6nmSda+3Q85jXZ4Tw8uy3yuuMZ+0CJ6WKh5Kg6LUXHKNLbFcVQ2Wqlk VdQLRg/fiWfUNKZc9p6DBlzTYAvmB+YOppTqJeG25B/O5Iaf5TiokiqbkEaqV5kEE25r YtHq5WX4HVd+VVUkmnCpWbDSBrDDXmAp4qZF6OQcEtVVkQB/P5aNkreYjh56Mhmoqrds 1n+w== X-Gm-Message-State: AOJu0Yy8gP5vSnCP7GjBY4ZUb+aI1f/Yw86LTSvqa2kUitrNYcSSp9MG xevqe2beYKViCuq0FW/uvFQ= X-Google-Smtp-Source: AGHT+IEn690wfubKb/UyQpCV8u5r9s/J7YoDjXMPpmRF+BSrF8lwfJHZHGsK4X3ZCynniFHKeVNcKA== X-Received: by 2002:a17:906:14d:b0:9e0:5d5c:aa6d with SMTP id 13-20020a170906014d00b009e05d5caa6dmr3302730ejh.20.1700732446363; Thu, 23 Nov 2023 01:40:46 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:46 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Thomas Zimmermann , Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:22 +0100 Message-ID: <20231123094040.592-3-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mgag200/mgag200_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_i2c.c b/drivers/gpu/drm/mgag20= 0/mgag200_i2c.c index 0c48bdf3e..423eb302b 100644 --- a/drivers/gpu/drm/mgag200/mgag200_i2c.c +++ b/drivers/gpu/drm/mgag200/mgag200_i2c.c @@ -106,7 +106,6 @@ int mgag200_i2c_init(struct mga_device *mdev, struct mg= a_i2c_chan *i2c) i2c->data =3D BIT(info->i2c.data_bit); i2c->clock =3D BIT(info->i2c.clock_bit); i2c->adapter.owner =3D THIS_MODULE; - i2c->adapter.class =3D I2C_CLASS_DDC; i2c->adapter.dev.parent =3D dev->dev; i2c->dev =3D dev; i2c_set_adapdata(&i2c->adapter, i2c); From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FBA3C5AD4C for ; Thu, 23 Nov 2023 09:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233023AbjKWJlC (ORCPT ); Thu, 23 Nov 2023 04:41:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232847AbjKWJkn (ORCPT ); Thu, 23 Nov 2023 04:40:43 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D41983; Thu, 23 Nov 2023 01:40:49 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a013d22effcso79256566b.2; Thu, 23 Nov 2023 01:40:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732447; x=1701337247; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jjxI0Bhxo2VvjdWdUiaiba2vg3SpmPuRCWUjk40Qtf4=; b=j2/H56+ZwIFVlZup3UwVyk6iSD77UAlOjrxEVIe29S6lG65BJ5uAAi43kuOxK/AACp 7CqA1XxkITHR52EGjZb4Pyip54dczO8R/epUIWEN8FlWC4V5oZxS5MkBI7ANk6AVUlKk HQz3wuHyqm1IDDmQ8guwD4KJC04Po3/ZooctSYjz5qbq2CqXH7kSe7fY+Ji91uD0Fyr/ sXfKsWxWPRzDImrNvN/co4tHyKfSBJwN4ydHbe6uU5DnTFPMkriMjKD69trZj6FNzP4N X6+cmwCxVezZ7gFSQjVZyDQp54am9xUhgxoqkyB1qt35lHzZ4BVXIKwW4nSkwTj0P7d/ 9PJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732447; x=1701337247; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jjxI0Bhxo2VvjdWdUiaiba2vg3SpmPuRCWUjk40Qtf4=; b=LeLlZqTLT/V2k4Tsqv3zOXUB9rwtBAl3294Bj0Hqre1Je8FOjGKvL8zNcTDQGu8k/l 9KWtBHlPQcWG/W6tg1/1RTnfsm82ZavNS+0k4On3CqhMXmZTkHfn6inDAtfh+7jBrFus SthS+o3t+2Bb32LQGF+xwHlHcI65TGd20w8Pwn0kfhaydO0p3g/33RPq8VWowJi0xlXv W2qCgRDmN/w4VzUvUZlnIDGv6PtLaq7ihkK4bElCcyeciQt6QLT0O+9V17eVXTOaKkxz HpAGFS5pzjQL9v7hHzuLVjAFv+tVzW0AX6tSk0wyQ95/xXr6J/Re9aJpqKQ98R1Pcgm3 ygHw== X-Gm-Message-State: AOJu0YyvCFpnU/JAj171g2jiACopLRInl58CB8+5VzS1z1z+EPKAPGvj GAivX8LpMmV/ujvcaa7kJ7E= X-Google-Smtp-Source: AGHT+IECDb65WJFfHKu5SLZ2mOzLFfopB3AUFOLDwQ98H15uIbQ5s5jWEv8KNWp+97LCJrRr5q5rCA== X-Received: by 2002:a17:907:9087:b0:9bf:63b2:b6e2 with SMTP id ge7-20020a170907908700b009bf63b2b6e2mr3326670ejb.26.1700732447203; Thu, 23 Nov 2023 01:40:47 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:46 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Harry Wentland Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Leo Li , Rodrigo Siqueira , Alex Deucher , =?UTF-8?q?Christian=20K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v5 03/20] drm/amd/display: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:23 +0100 Message-ID: <20231123094040.592-4-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Harry Wentland Acked-by: Alex Deucher Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- v2: - adjust tag in commit subject --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gp= u/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 6f99f6754..ae1edc6ab 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7529,7 +7529,6 @@ create_i2c(struct ddc_service *ddc_service, if (!i2c) return NULL; i2c->base.owner =3D THIS_MODULE; - i2c->base.class =3D I2C_CLASS_DDC; i2c->base.dev.parent =3D &adev->pdev->dev; i2c->base.algo =3D &amdgpu_dm_i2c_algo; snprintf(i2c->base.name, sizeof(i2c->base.name), "AMDGPU DM i2c hw bus %d= ", link_index); From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E99A5C5AD4C for ; Thu, 23 Nov 2023 09:41:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232915AbjKWJk5 (ORCPT ); Thu, 23 Nov 2023 04:40:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232854AbjKWJkn (ORCPT ); Thu, 23 Nov 2023 04:40:43 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17C05BA; Thu, 23 Nov 2023 01:40:50 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-9fd0059a967so341008766b.1; Thu, 23 Nov 2023 01:40:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732448; x=1701337248; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SLxIO8jymMsGgax9WMIUOf53Q8UCr/7PCCK8+C8vDXQ=; b=KRT6B5vNb9OZULnQ00nQuAakY609BlZAiS4YXcROouyRv/7TkV0a5KpDTN++L+vZZs e4u2Rt2l0OKLrtQgtsGyIsaPQzuWR6eeAqSm71gEzU0FxQWX+Fqb+FE3hSXuZ4uzndrC T6gUay806gaoyKUNcmH9uit8KUNTJtyu+HfHgGjhsUhXcn6pu3SRFZ7dNh29IU2hj0qD 9lW9L8m9QnY4l1UjWLcf1K1JmlxqG7e5u5SyAZ1oj/3n80YgF6T+wcy3Qe3uRJNLHkLE YWzp/NsZvWOE9tVAewFjEtKBk+yaA+FzL1Fv9DLUjL+PeH4n9nTPqTzJGuQ+tZ9gmqd1 vbKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732448; x=1701337248; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SLxIO8jymMsGgax9WMIUOf53Q8UCr/7PCCK8+C8vDXQ=; b=xUBP9mgihqxaNMYDqTMxdMDsxSZi+RK92M6VqyKz3/MLsQaSsTUC3lRgTqqpgDTOfx KFHkB5EtorjmPFGZlWCTQDNE1tJcrtiGJt2+q0TuA0rETi9KHR2Kh+91yNzyUx7hawae dwhK1nJGPDT5JHEgsifdj7xmgoUOAXnw5bmvznR0mWBrFEoC2Y5SKzC9L4lAvipI8H5h caKMu/S0eOsIUDO5FdJb3nYwIF5Os8IWqZYRIbvxrPmfgoLw2fjmlyS7vBKSOpABaDOa dyidd1YdLl6j3T4x18QIMKOOWR5TnePvon/1BepffwY++VH4aklRStG+7ZcMEoHuITHO tKUQ== X-Gm-Message-State: AOJu0YySMAEW5Yq8YeFMMf6CthenJA8+FOJoVmprvjMeb0jvNuqeIGxu GtvVVq0K1c89H74HAJ/PVVs= X-Google-Smtp-Source: AGHT+IHAAgtMNPgGG8plHKbnTsqENUj/FChwDuBx+Jt1UJ0zF6uKp2U1sG6bXy9dBnLTJPdZkoeP/A== X-Received: by 2002:a17:906:78c:b0:a04:e1e7:d14c with SMTP id l12-20020a170906078c00b00a04e1e7d14cmr1773863ejc.32.1700732448312; Thu, 23 Nov 2023 01:40:48 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:47 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maxime Ripard Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Chen-Yu Tsai , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jernej Skrabec , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH v5 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:24 +0100 Message-ID: <20231123094040.592-5-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jernej Skrabec Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c b/drivers/gpu/drm/sun4i= /sun4i_hdmi_i2c.c index d1a65a921..f5f62eb0e 100644 --- a/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c +++ b/drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c @@ -302,7 +302,6 @@ int sun4i_hdmi_i2c_create(struct device *dev, struct su= n4i_hdmi *hdmi) return -ENOMEM; =20 adap->owner =3D THIS_MODULE; - adap->class =3D I2C_CLASS_DDC; adap->algo =3D &sun4i_hdmi_i2c_algorithm; strscpy(adap->name, "sun4i_hdmi_i2c adapter", sizeof(adap->name)); i2c_set_adapdata(adap, hdmi); From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F07EDC624B4 for ; Thu, 23 Nov 2023 09:41:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234691AbjKWJlG (ORCPT ); Thu, 23 Nov 2023 04:41:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232787AbjKWJko (ORCPT ); Thu, 23 Nov 2023 04:40:44 -0500 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B02F8CB; Thu, 23 Nov 2023 01:40:50 -0800 (PST) Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-9fd0059a967so341013466b.1; Thu, 23 Nov 2023 01:40:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732449; x=1701337249; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qvHXeOl9LDkuvADN7QZ3xhK0GHlO5gQYDZefl63t5jE=; b=QT5Zx0xjlKBFQFSdf6/WfoaeV6yfuDcOxuxxLtgtKRgeZdcQ4PwJSqaLLqrDA2+rKz a+lj/QakBerplMn6+BRIDup85YF2iI4UttD9LcdoqJqF3bxILWfYm/wyLVVpAwhphlR0 w4PIps911JCHGt7KyiBhTeaqFhhzfzsfvfrOvAcZck25dST0J4QB/cRMdyZ3OOUgejon u/UOG8Sy95JFEi1KlCsiRr3xgT1CSMaySh6UcxNoxNL/ZpJ1Gk8AOx4kVbdXYaRocnWk Mfh+cuVBBY7uPA1sDKlhRiJr9GnRLKvw3UoeHFrivnH26y0jfwLXSQws190llOZRfFaA mWhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732449; x=1701337249; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qvHXeOl9LDkuvADN7QZ3xhK0GHlO5gQYDZefl63t5jE=; b=kS3hBBr/muHbaEkWLx+jY1bboRl3rPaqz2WGiTjzaDyzEbcaMAJn2e6FjRWZ+rpgy+ 4COvBEp6yChBf7wDHN0uug4QKBMMCG7TJ2MuF57Vf+7YLmVmI2LaOIMnz4bkgAszX+cY 3Z0DMxqkwX5v0Koea6B8MhyZH6zhBNsDiweKEUohquXH4ZoBfJYRyY5h1vIeY2A7m5HG cZqu/Tk0f52cuY2lkEngLUkaQh6fwe6wdByX0Nq/0GHV11GAPujn4aZ1ndeTbDH2j5Wz G/s4oCXcLQFHgbq+W1MZWSlj57vw42+I6LupLYutAQGF5D8z9LA8l8RNJOHAFEzS0xnX Tl7Q== X-Gm-Message-State: AOJu0YwExOnWK/OTXOP1+DA/ZPS8aTBkIkdVCnV9F+eKVTCvh83Zth2q HnjNk013tkERQBG2ixgxi20= X-Google-Smtp-Source: AGHT+IE+Nr8u8YtY1qrwt9z7+2FQgdGwO8TfYUwKqW78GiAu5HXb3TRPaqDDQPPM8YSMZBIRnZFVyQ== X-Received: by 2002:a17:906:3299:b0:9ae:659f:4d2f with SMTP id 25-20020a170906329900b009ae659f4d2fmr2095489ejw.26.1700732449059; Thu, 23 Nov 2023 01:40:49 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:48 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Helge Deller Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v5 05/20] drivers/video/fbdev: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:25 +0100 Message-ID: <20231123094040.592-6-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- v3: - fix compile error --- drivers/video/fbdev/i740fb.c | 1 - drivers/video/fbdev/matrox/i2c-matroxfb.c | 15 +++++---------- drivers/video/fbdev/s3fb.c | 1 - drivers/video/fbdev/tdfxfb.c | 1 - drivers/video/fbdev/tridentfb.c | 1 - 5 files changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/video/fbdev/i740fb.c b/drivers/video/fbdev/i740fb.c index 1897e65ab..9b74dae71 100644 --- a/drivers/video/fbdev/i740fb.c +++ b/drivers/video/fbdev/i740fb.c @@ -163,7 +163,6 @@ static int i740fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner =3D THIS_MODULE; - par->ddc_adapter.class =3D I2C_CLASS_DDC; par->ddc_adapter.algo_data =3D &par->ddc_algo; par->ddc_adapter.dev.parent =3D info->device; par->ddc_algo.setsda =3D i740fb_ddc_setsda; diff --git a/drivers/video/fbdev/matrox/i2c-matroxfb.c b/drivers/video/fbde= v/matrox/i2c-matroxfb.c index e2e4705e3..bb048e14b 100644 --- a/drivers/video/fbdev/matrox/i2c-matroxfb.c +++ b/drivers/video/fbdev/matrox/i2c-matroxfb.c @@ -100,8 +100,7 @@ static const struct i2c_algo_bit_data matrox_i2c_algo_t= emplate =3D }; =20 static int i2c_bus_reg(struct i2c_bit_adapter* b, struct matrox_fb_info* m= info,=20 - unsigned int data, unsigned int clock, const char *name, - int class) + unsigned int data, unsigned int clock, const char *name) { int err; =20 @@ -112,7 +111,6 @@ static int i2c_bus_reg(struct i2c_bit_adapter* b, struc= t matrox_fb_info* minfo, snprintf(b->adapter.name, sizeof(b->adapter.name), name, minfo->fbcon.node); i2c_set_adapdata(&b->adapter, b); - b->adapter.class =3D class; b->adapter.algo_data =3D &b->bac; b->adapter.dev.parent =3D &minfo->pcidev->dev; b->bac =3D matrox_i2c_algo_template; @@ -160,27 +158,24 @@ static void* i2c_matroxfb_probe(struct matrox_fb_info= * minfo) { case MGA_2164: err =3D i2c_bus_reg(&m2info->ddc1, minfo, DDC1B_DATA, DDC1B_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; default: err =3D i2c_bus_reg(&m2info->ddc1, minfo, DDC1_DATA, DDC1_CLK, - "DDC:fb%u #0", I2C_CLASS_DDC); + "DDC:fb%u #0"); break; } if (err) goto fail_ddc1; if (minfo->devflags.dualhead) { - err =3D i2c_bus_reg(&m2info->ddc2, minfo, - DDC2_DATA, DDC2_CLK, - "DDC:fb%u #1", I2C_CLASS_DDC); + err =3D i2c_bus_reg(&m2info->ddc2, minfo, DDC2_DATA, DDC2_CLK, "DDC:fb%u= #1"); if (err =3D=3D -ENODEV) { printk(KERN_INFO "i2c-matroxfb: VGA->TV plug detected, DDC unavailable.= \n"); } else if (err) printk(KERN_INFO "i2c-matroxfb: Could not register secondary output i2c= bus. Continuing anyway.\n"); /* Register maven bus even on G450/G550 */ - err =3D i2c_bus_reg(&m2info->maven, minfo, - MAT_DATA, MAT_CLK, "MAVEN:fb%u", 0); + err =3D i2c_bus_reg(&m2info->maven, minfo, MAT_DATA, MAT_CLK, "MAVEN:fb%= u"); if (err) printk(KERN_INFO "i2c-matroxfb: Could not register Maven i2c bus. Conti= nuing anyway.\n"); else { diff --git a/drivers/video/fbdev/s3fb.c b/drivers/video/fbdev/s3fb.c index 589b349cb..07722a5ea 100644 --- a/drivers/video/fbdev/s3fb.c +++ b/drivers/video/fbdev/s3fb.c @@ -252,7 +252,6 @@ static int s3fb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner =3D THIS_MODULE; - par->ddc_adapter.class =3D I2C_CLASS_DDC; par->ddc_adapter.algo_data =3D &par->ddc_algo; par->ddc_adapter.dev.parent =3D info->device; par->ddc_algo.setsda =3D s3fb_ddc_setsda; diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 22aa95313..51ebe7835 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -1267,7 +1267,6 @@ static int tdfxfb_setup_ddc_bus(struct tdfxfb_i2c_cha= n *chan, const char *name, =20 strscpy(chan->adapter.name, name, sizeof(chan->adapter.name)); chan->adapter.owner =3D THIS_MODULE; - chan->adapter.class =3D I2C_CLASS_DDC; chan->adapter.algo_data =3D &chan->algo; chan->adapter.dev.parent =3D dev; chan->algo.setsda =3D tdfxfb_ddc_setsda; diff --git a/drivers/video/fbdev/tridentfb.c b/drivers/video/fbdev/tridentf= b.c index 816d40b6f..516cf2a18 100644 --- a/drivers/video/fbdev/tridentfb.c +++ b/drivers/video/fbdev/tridentfb.c @@ -274,7 +274,6 @@ static int tridentfb_setup_ddc_bus(struct fb_info *info) strscpy(par->ddc_adapter.name, info->fix.id, sizeof(par->ddc_adapter.name)); par->ddc_adapter.owner =3D THIS_MODULE; - par->ddc_adapter.class =3D I2C_CLASS_DDC; par->ddc_adapter.algo_data =3D &par->ddc_algo; par->ddc_adapter.dev.parent =3D info->device; if (is_oldclock(par->chip_id)) { /* not sure if this check is OK */ --=20 2.42.1 From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EADC9C61D85 for ; Thu, 23 Nov 2023 09:41:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234981AbjKWJlM (ORCPT ); Thu, 23 Nov 2023 04:41:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232839AbjKWJkp (ORCPT ); Thu, 23 Nov 2023 04:40:45 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EB6F1A4; Thu, 23 Nov 2023 01:40:51 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-548d60a4d60so849427a12.2; Thu, 23 Nov 2023 01:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732450; x=1701337250; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T4xwkZlQCS57rh5cLLkPqLJtM9ewQjK5YT1ZnNRRYzc=; b=L+nUW6joC/xY5dKblIyi4QUSjOUDmSummlD50kmpmvnKsbLdts8gvFnkTVBCnuFb/6 jvDUa+mU2fT5xI13X5qdHyN5GQOVeAdMmfUcO3fqx//OrrwIhVCdvEcvqArpJUswQJDR 0gOntavuQvMPOYMnSzGJHxph/9PRf3M5thVawQ3/a16iW76ZG39QWiWhsoMF3q8b+/9L wcL/iCpZEZFsnofPAv+FSwKyKy6SzD4Ij0UFboPXlnuizKZbpAYr9yE6V1mP3qjt+yPj mRZZ2gHW+B+y5QIRW5aHleiJ0D2AQN2kdp5Zzz99w6ojS9u4lYpE99LIhDT6WInoSazG PVFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732450; x=1701337250; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T4xwkZlQCS57rh5cLLkPqLJtM9ewQjK5YT1ZnNRRYzc=; b=qbHUg3pHITKq/O33T+GjhyKJQt34XgwKqR/DXK3BNGZc1B3My1jalA2R1IC2Uf6p6f HQW9G8Jqn5qVeCAJnBnxOI1AWF2+SEiucu7Wtux3z+7Q9eVHfkoi+e6XbDSr0id4GlQ3 ykCfCv0Gxbd8adRfwFdjBQ/qvbSrFQfgzQ/Sy1hdt5/CdPeOwwlZ2KXPBdL7mdLkD16k +meK4Kdjap2F6VVRFb+YA/neyGVBKoMl2cW/QbY/Ck2wqx48Mve1KIhRZvUoTUSFSx1i kOo2/UCt8cAzkuVGuSSdBUz1khzTPouPK7Mi4Hxtylcy70O6n/0PEwoN7AuvVNa3+RD4 6onQ== X-Gm-Message-State: AOJu0YyQ0MHsCh4qypVKADA8FGC9xpJTEQANL+6OqOdZidZ9b1Nza+Cj nKRmMsAHWj3rME+oWlGoqCo= X-Google-Smtp-Source: AGHT+IHb38lKBzahmB3scsQJ4G9h8mrxfVKAwJLraoLG53oT4I/ucTZBBGxcgUItZfDjTqSw8rrB4w== X-Received: by 2002:a17:906:7197:b0:9e3:5c27:8862 with SMTP id h23-20020a170906719700b009e35c278862mr3223427ejk.27.1700732449746; Thu, 23 Nov 2023 01:40:49 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:49 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Daniel Vetter Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v5 06/20] drivers/video/fbdev/core/fb_ddc.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:26 +0100 Message-ID: <20231123094040.592-7-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/core/fb_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/core/fb_ddc.c b/drivers/video/fbdev/core/f= b_ddc.c index 8bf5f2f54..e25143219 100644 --- a/drivers/video/fbdev/core/fb_ddc.c +++ b/drivers/video/fbdev/core/fb_ddc.c @@ -116,7 +116,6 @@ unsigned char *fb_ddc_read(struct i2c_adapter *adapter) algo_data->setsda(algo_data->data, 1); algo_data->setscl(algo_data->data, 1); =20 - adapter->class |=3D I2C_CLASS_DDC; return edid; } From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F22EAC636CB for ; Thu, 23 Nov 2023 09:41:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235215AbjKWJlR (ORCPT ); Thu, 23 Nov 2023 04:41:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjKWJkp (ORCPT ); Thu, 23 Nov 2023 04:40:45 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F187D40; Thu, 23 Nov 2023 01:40:52 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9fa45e75ed9so88625966b.1; Thu, 23 Nov 2023 01:40:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732451; x=1701337251; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bJZTY7Ppscmc7/agjAjlMp0CjMt1Rvl0KUPChAkdlBw=; b=mweEUmqUjNz/PHkFEfe7yagVBSBd2Ap1rqhUBed+JpOdE24d3n3U5BbFgCy3KG16dQ KQSf4nbBTAHjTXZVe/wYqkGJACJltQ8cNhmMfdeFtviwJ7ntoZDz1LnmT41MKPMFVk1j ow9R0UVyzi3M0JXoPFjYUsm9iqaQ9slMLNdWghhEkwe3JxkqUpXoEOawvUmIpDE6LZYK R8qvcryl9uIwktJsdjfhc9hxI2Mj3BQyEoPkd9geiS3ef26w0wqFns+cxDLXa4pC0w48 hN+2rMqnrUOmJGJQhJX8yPGkDKXoubDe075/FPX8BC64XUr8AfNpvjuPVpG1UfaVjXlv jRrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732451; x=1701337251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bJZTY7Ppscmc7/agjAjlMp0CjMt1Rvl0KUPChAkdlBw=; b=w2JXyJEW8fUI+r9rbJn2G+dPwTielIg4a1UCcDscruCpkIdCQ0beHTcct59qnMD9lc C6T4Blm/exZpnZe4lUAcwWe2IdLXt+Hfrm1ktgU0tFpaPkZSBvO7gddVWoUessqaJ+NL /9I+a3M5OW8CpEgcYYg1XliAhKerPjydd89foRXL92AHzEZuersN8LYsexyqT4/DSiIp s1TDGjQH3+intese7rvacwwMMNprvrU9AyVmdW0NQTucFqymdBMqBwlXRv/04Q/ZWOan Tf8iR3ZOzV70mg1HyFV+OH9NiYpH7bIP2OrHIr+HmRFceuylK2P9Jlwy50hR1Ol5pIV5 E4Bg== X-Gm-Message-State: AOJu0Yy8jZSYrg9FfUVQ7ucqj1fkpp2FYLlGctVAAhsY/N4T6tc8cJC3 VwsYpgUXFopwGk6biu/x5YY= X-Google-Smtp-Source: AGHT+IHzN7AwPcm/sO9dy22vICRd2Xk4zJMeYsib0E7Fgzi8vCiMlpZC9C+ucr3iLv4APW5MC35HAA== X-Received: by 2002:a17:907:371:b0:a02:9700:bf53 with SMTP id rs17-20020a170907037100b00a029700bf53mr3303778ejb.46.1700732450616; Thu, 23 Nov 2023 01:40:50 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:50 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Alex Deucher Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , =?UTF-8?q?Christian=20K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v5 07/20] drivers/gpu/drm: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:27 +0100 Message-ID: <20231123094040.592-8-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 1 - drivers/gpu/drm/radeon/radeon_i2c.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/= amdgpu/amdgpu_i2c.c index 82608df43..d79cb13e1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c @@ -175,7 +175,6 @@ struct amdgpu_i2c_chan *amdgpu_i2c_create(struct drm_de= vice *dev, =20 i2c->rec =3D *rec; i2c->adapter.owner =3D THIS_MODULE; - i2c->adapter.class =3D I2C_CLASS_DDC; i2c->adapter.dev.parent =3D dev->dev; i2c->dev =3D dev; i2c_set_adapdata(&i2c->adapter, i2c); diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/r= adeon_i2c.c index 314d066e6..3d174390a 100644 --- a/drivers/gpu/drm/radeon/radeon_i2c.c +++ b/drivers/gpu/drm/radeon/radeon_i2c.c @@ -918,7 +918,6 @@ struct radeon_i2c_chan *radeon_i2c_create(struct drm_de= vice *dev, =20 i2c->rec =3D *rec; i2c->adapter.owner =3D THIS_MODULE; - i2c->adapter.class =3D I2C_CLASS_DDC; i2c->adapter.dev.parent =3D dev->dev; i2c->dev =3D dev; i2c_set_adapdata(&i2c->adapter, i2c); From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54A79C5AD4C for ; Thu, 23 Nov 2023 09:41:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235006AbjKWJl3 (ORCPT ); Thu, 23 Nov 2023 04:41:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232873AbjKWJkr (ORCPT ); Thu, 23 Nov 2023 04:40:47 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26D61BA; Thu, 23 Nov 2023 01:40:53 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a02cc476581so80118266b.2; Thu, 23 Nov 2023 01:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732451; x=1701337251; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NE3vmdF0wanDhCYGlSWZub+/X2exFV1gowAmEM/g0Pw=; b=XF6Yf/8y9yAjqNPNJn4LCtc1KnxkywrRMBJwkAv+VdzFe9rMpNApJD4SZU5EoAJ0z/ DecJ8R//xKs4kN1Qa4iIL5o+XlrpcEojjJZTtJD3EgyMn9H4ejyo40M/4f0NLbyg4NEp Na5ivFczRP8/nkuWptprIhjivKcCrHzoZ7mO+0cZ7fgmSAy//x+F3UgBgX+HQ/Wvw/Q9 YKrxMND9O9ZZQF46nGlIRB7fxeBj2xHjlkOtvI5QskaHGB2u4NTvKDD2KFPxZ77nT4Wd gaa55Z/G4ea5DjGFaJWpkzyJw/KYzWB8SboDmKkrNQu9P8uvtPL+IvAQjFV715UH4oXm Xgtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732451; x=1701337251; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NE3vmdF0wanDhCYGlSWZub+/X2exFV1gowAmEM/g0Pw=; b=SAAGkGQ6mbZnOUPIYRNXIA3biX7Pwkh9fCpvqOq49IklZ8JUvpo2JyU44LEVs5sA9r +LbrmjtCY41sRJlNhfseTk09Wm/8spffMwT8WLCj87q9PNGUVICBMUc9LwvOT7nqA61L g45kZDR2EYxA3nVPPHdkmKK/9V5FGt8xGOn5x7x2WHkcKuU3uokGUUWePDiCBmORvPnT DPgk4EFfcFlPabpt8CAYN2KvDwUv8vJ6ZjtwCN3wle7Sak6gL+pg6GYIsNPIZw0W3m10 Hhl6K5sT2lD/L6pb77ZEOO0bMiFrUnteOi3bRI0fNDcqYLocwhrVMsCbfLKDzKMwuXTm wfgw== X-Gm-Message-State: AOJu0YzHuZXI4rPNX3+kXpUshiQzLU4Mh7n8TwRsx5tFCnyfv+dEU03t DjydwPW5Op6Iq7SNTVYLzkI= X-Google-Smtp-Source: AGHT+IEsOmKWsqrRI9wn8tyepMe2HWVZeZdZCX+kXs5QK5xUIlIuKwnFMGVkK2jR0mQNB43pWbZGag== X-Received: by 2002:a17:907:30d0:b0:9fe:6508:a051 with SMTP id vl16-20020a17090730d000b009fe6508a051mr1921733ejb.71.1700732451429; Thu, 23 Nov 2023 01:40:51 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:51 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Sui Jingfeng Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:28 +0100 Message-ID: <20231123094040.592-9-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit Reviewed-by: Sui Jingfeng --- drivers/gpu/drm/loongson/lsdc_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/loongson/lsdc_i2c.c b/drivers/gpu/drm/loongson= /lsdc_i2c.c index 9625d0b1d..ce90c2553 100644 --- a/drivers/gpu/drm/loongson/lsdc_i2c.c +++ b/drivers/gpu/drm/loongson/lsdc_i2c.c @@ -154,7 +154,6 @@ int lsdc_create_i2c_chan(struct drm_device *ddev, adapter =3D &li2c->adapter; adapter->algo_data =3D &li2c->bit; adapter->owner =3D THIS_MODULE; - adapter->class =3D I2C_CLASS_DDC; adapter->dev.parent =3D ddev->dev; adapter->nr =3D -1; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DB30C5AD4C for ; Thu, 23 Nov 2023 09:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235267AbjKWJle (ORCPT ); Thu, 23 Nov 2023 04:41:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232939AbjKWJkr (ORCPT ); Thu, 23 Nov 2023 04:40:47 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CF62D53; Thu, 23 Nov 2023 01:40:54 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a03a9009572so79629666b.3; Thu, 23 Nov 2023 01:40:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732452; x=1701337252; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YSszigu6T9QU12VdWtO4WfxwIpZgiTTUkpWgQw1TPZ8=; b=OVwoZwglOywb8LudcE8l9Taw5B91vDI/Xx3E86YoRfHBu5WwPbvMDHC0uuqJN6qNgf KbUr2NIaSRqqaPC3j6razei9CupS3d/Qr6jwLGBusdcbtkru6uu7BK7uncvYZiYBYiW0 9+GmK0elaZ8SDLsBEhz9+4sJJYNbDJwTZnUNk1DGEBHYd3/OIw0yq+O4bYrIqv6+/6zF RII2JWLwNoyAy/jeRUjJz7H3m5eZmv2wlbA9zK1mgc8XAVPG+OZaH1uZ4WetsIYKMCe/ /7U408NBQhoO0cwj+OYEuat+S1urdbqbPbJLSREAZUc4y7XQB3wZTgeLZ7j3MZDmTbPy QccQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732452; x=1701337252; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YSszigu6T9QU12VdWtO4WfxwIpZgiTTUkpWgQw1TPZ8=; b=H0Aa2ixMRRp2uYVJ0UA/yGa2dNxKS90UT9ua1SjzcuTDPIk4xng2y3tmWN2PGx8qIg aEGBK7qPd9wbF30cndQDOWE4kKtWW00OMuSqFNmXbAjkuTWBy/K6CR4f0axVxsgaHDhm eBnyP4b6BSpFU6SyqgmfRDvicaWUo9GotFqCfH6ihf0nsuPdKbmOkZhBQ+Yab5Pp7ste NztcdxLSqSgJIft9/iQJB5OQ6h4AJGd/o+udLlgm+T8hp9DB9ZagTXoP7yi2Ncnq9rvg desaqUm0ocx2nLqcjWsBshlcggW7WHr5SbcXu0FhYSc6Is7B/DgI8FwSAQ3KdbNyY6MJ wZ9Q== X-Gm-Message-State: AOJu0YwgEFfmNO8FiWOoBpmW45X7wd51zHBxfTuI2YOe2X2R8g4Aj/DE 05XBDuZcWZE0xByfzJTLu8k= X-Google-Smtp-Source: AGHT+IEFgOtT3lal4jlY4JZycrJ9xFNnfqhiTE1G5PpC/tUinLgJ+nSg0oiXXan59RSRf9SexqP77g== X-Received: by 2002:a17:906:209:b0:a02:9c3d:6de7 with SMTP id 9-20020a170906020900b00a029c3d6de7mr3506760ejd.13.1700732452416; Thu, 23 Nov 2023 01:40:52 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:51 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Florian Tobias Schandinat Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v5 09/20] drivers/video/fbdev/via/via_i2c.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:29 +0100 Message-ID: <20231123094040.592-10-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/via/via_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/via/via_i2c.c b/drivers/video/fbdev/via/vi= a_i2c.c index c35e530e0..582502810 100644 --- a/drivers/video/fbdev/via/via_i2c.c +++ b/drivers/video/fbdev/via/via_i2c.c @@ -201,7 +201,6 @@ static int create_i2c_bus(struct i2c_adapter *adapter, sprintf(adapter->name, "viafb i2c io_port idx 0x%02x", adap_cfg->ioport_index); adapter->owner =3D THIS_MODULE; - adapter->class =3D I2C_CLASS_DDC; adapter->algo_data =3D algo; if (pdev) adapter->dev.parent =3D &pdev->dev; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5C77C61D85 for ; Thu, 23 Nov 2023 09:41:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235118AbjKWJli (ORCPT ); Thu, 23 Nov 2023 04:41:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233995AbjKWJkz (ORCPT ); Thu, 23 Nov 2023 04:40:55 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26FC01A4; Thu, 23 Nov 2023 01:40:54 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a013d22effcso79270466b.2; Thu, 23 Nov 2023 01:40:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732453; x=1701337253; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1X2LDaMbB0c5HZoTNyhIjHAhgnohEDN3uV01ROjEnUc=; b=D0aDHZ6GvGqBNZyanabWGNj9zDgGbkkjWPxW3QCsS0g4G3eIuqN8hsj91YkgbcDm90 Dr2YRdN2djdgcsUPjEDHqR/nm9CrKcPXi74tqT3B9L/0qRipn0VM43J/faMcAiZZFLNv el31maAxsj5ba7rJNsvFgdoyuErKiG5G9aL4gM5/FB4bL+IMd6l7f33gqEm8ZHHFJd3d 8DOYph1l9DwAy8+2nSMQRikv4KByTCHuMVcuPApbb+1h8mOJfLs2fds2Dxq2QnraNEWy r+i0t/kyzp6A97tju3a35qv53I4KTO+YTzf3780IES1uTvIxJY1RBAREvO3IpowxMaD2 ci5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732453; x=1701337253; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1X2LDaMbB0c5HZoTNyhIjHAhgnohEDN3uV01ROjEnUc=; b=j7xhLO8o4Dipjsf8zjT+isfcUm27Wohyc1Nhv68Yw/WHG348dyn1smBrLeEbf1jrKh m33Uf2hz32t24vQDgWrkww7vv3fIKrnr9nEIZKMaccVpFloefUrPXnTrmJykhInJEFrv 6spEFAyiPjmFjz08o5DHjCa+Wry04S7b1nlyQKTn1PBD5yevLduTN2bn6dkr4Txmm2GV 1VHFwKshXf6Ss8T4nvkMH23RHI9ky967sXH5ziOV/RCsa+MqIGjqfhglgGXAiwISc9Jq psXORKA8wePMbmHrKUVXoVIrxzczm2mSuw3fem42NsiMoteTTT9QrS5ZT6hS6gGCPaa/ yeug== X-Gm-Message-State: AOJu0YytPhZXXuJU3JpIftQmqssyO3wKaFdivm6QJu8QvYx5VrNPunCt e2fRdMD6YcdFbH74gJoCdaekw2Zlwnw= X-Google-Smtp-Source: AGHT+IG2ldSIvJkPOWRUMwqptBELwha4P3UEDAWFeFhYxPAf0Hq1Cr63BHUft7JxbUZhAWi2pEm5Tg== X-Received: by 2002:a17:907:9382:b0:a00:9550:b08b with SMTP id cm2-20020a170907938200b00a009550b08bmr3262185ejc.24.1700732453321; Thu, 23 Nov 2023 01:40:53 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:52 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Russell King Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v5 10/20] drivers/video/fbdev/cyber2000fb.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:30 +0100 Message-ID: <20231123094040.592-11-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/cyber2000fb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2= 000fb.c index 52105dc1a..79775deda 100644 --- a/drivers/video/fbdev/cyber2000fb.c +++ b/drivers/video/fbdev/cyber2000fb.c @@ -1234,7 +1234,6 @@ static int cyber2000fb_setup_ddc_bus(struct cfb_info = *cfb) strscpy(cfb->ddc_adapter.name, cfb->fb.fix.id, sizeof(cfb->ddc_adapter.name)); cfb->ddc_adapter.owner =3D THIS_MODULE; - cfb->ddc_adapter.class =3D I2C_CLASS_DDC; cfb->ddc_adapter.algo_data =3D &cfb->ddc_algo; cfb->ddc_adapter.dev.parent =3D cfb->fb.device; cfb->ddc_algo.setsda =3D cyber2000fb_ddc_setsda; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39263C61D85 for ; Thu, 23 Nov 2023 09:41:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234138AbjKWJlo (ORCPT ); Thu, 23 Nov 2023 04:41:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234053AbjKWJkz (ORCPT ); Thu, 23 Nov 2023 04:40:55 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0686D40; Thu, 23 Nov 2023 01:40:55 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-9ffb5a4f622so85767366b.0; Thu, 23 Nov 2023 01:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732454; x=1701337254; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jkXe0QoGE+tlThXBz0xEA+Tvx0TKZmjc+38hqplAd1o=; b=GuLMxXsGoVW8n+01SueQcdlKIo/H5UOxqybayr853DB4se2zsuzBN3dHeVt+3/arVu bDQJ3k6swS/CSltIKsttcEr3OXsNOAysdPmQXjaNtrlszgCqzlFEHg1RDJyzduTHhGDt XKeqiE6AmZ5CKl3ja8gUm/QPLBsu2XhkLbxNDloBbk+8E05e1OicB+lOMyVgXTr3w1oA R2lPIDfpzWat9AbvLy52YQ2XMudoewFxgpifk1waC6KL5tjMGP/kpDM1TwJEod6zq/aU v1xPl8Hswv+CtvW0Q2p+9cL8LMG9W181Pn1efwZk4SpvQIJhfY/S/uT8wkSgMIHE7k/B mm/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732454; x=1701337254; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jkXe0QoGE+tlThXBz0xEA+Tvx0TKZmjc+38hqplAd1o=; b=kK2x6ao9UBo5DV4D2pEjUvquwJIcm3aX0vr2/kxACVQdkCOC5JELRzJNC8NjpxN4pw ERlPchdc4n6GIcb0hJG/t00mAqIQfLV3BLDqm/x1lN9AfaK3YqMemwG2YoBKB+U4LUnt Omqv29avDYK/hKnxLzOqb/T3HpwMW2zO+Hx5nFfqhWBi5Rynpze4OWgaqVtIkD9fTHYN pqq92mwey0CjxaKPhNGVTKTccAo/g0FP/2BbOOPD2vbvcqt6hKu0tkotkc6o27REJlUS sb2z/72ZQ+aXSUN/AtzshoCCaeDr5qF5nFlj2Q383vCQvKe0214+fTYbaMhoJpzhTNfF 7bMQ== X-Gm-Message-State: AOJu0YwmZT9w7F/e0vdQl7jnoGKw2BL+gPAGj1n77I8Dw2tjF5I1KWOB 3ko0K2fPlXK4I5uIdeMcjuo= X-Google-Smtp-Source: AGHT+IGBaET/BPE0zfZXGFTIbLxGAcu/efNvrnEKBMMHB3R5g6zx8yTuME8af3epmG7VUmfNUgxQ8A== X-Received: by 2002:a17:906:a38f:b0:a01:ae5c:f9b1 with SMTP id k15-20020a170906a38f00b00a01ae5cf9b1mr3755311ejz.40.1700732454188; Thu, 23 Nov 2023 01:40:54 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:53 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Andrzej Hajda Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:31 +0100 Message-ID: <20231123094040.592-12-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: Neil Armstrong Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/br= idge/synopsys/dw-hdmi.c index 52d91a0df..aca5bb086 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -515,7 +515,6 @@ static struct i2c_adapter *dw_hdmi_i2c_adapter(struct d= w_hdmi *hdmi) init_completion(&i2c->cmp); =20 adap =3D &i2c->adap; - adap->class =3D I2C_CLASS_DDC; adap->owner =3D THIS_MODULE; adap->dev.parent =3D hdmi->dev; adap->algo =3D &dw_hdmi_algorithm; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 243E1C5AD4C for ; Thu, 23 Nov 2023 09:41:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235182AbjKWJlt (ORCPT ); Thu, 23 Nov 2023 04:41:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234105AbjKWJkz (ORCPT ); Thu, 23 Nov 2023 04:40:55 -0500 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF627D66; Thu, 23 Nov 2023 01:40:56 -0800 (PST) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-548d1f8b38bso987000a12.3; Thu, 23 Nov 2023 01:40:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732455; x=1701337255; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ibtPu02kEx2LQ9A0jvCmJB7jA/c3boGIvN0NginjoG8=; b=ax06D3ToerZNkEYfVMdZ2GCQJOdfiLST55aBuVlXbhRqwp8znHX+SZzviHsbfdgE6O jtUrf3shJRwfCl2ThjcHBPiUrq+YYrBf3zXfTvHx7HwFXVONowhL6jSsi5plYu5ZJNsK Tm7LwvnBl8KbwJ0VU4YG8ekenYVgzCSfLXbitofqDLZdl9/9HPtA0UWBbYxvTWWKyGks xRELYQJO9jbEHR4dNcjmWS6vWq2pDqpiEYhALibqdgiBIUfR6tgLnkf48MADGNglatDI m5hPnG1b6rfbQjYczfp1q4Mp5+3hjejo5cYOjNe96RPq1+E1TNS2u1PFSwkCDqcU2fZL qPTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732455; x=1701337255; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ibtPu02kEx2LQ9A0jvCmJB7jA/c3boGIvN0NginjoG8=; b=BJ4qgODzNc+e7negr5hYssJse3ecZU2wPup02HuToGoH+2CGuyVv3y4SZf7ujrVwd5 Sl6lufs/8MSDQOH+7F4xx80mfW93vPg0iAMBjjTeA3awFronId6FtpXSMma1IkgDvTwt pis84v5yVaMOmrO0akae3deq6FiG92pgEMui/jhlZ1eWQOW9N+Nc8aIfgvQMvgFh+vYA FTuYusZDSmp4TO9NqlKCJdEIx8UWk96SQjNcGVhp1UZiW6YQPQbRMRzsj3pD3YrlgpWO QaGvwkDKkpQl7s0O8veBio6KUYl7IFWYcn5l9c3MiydtQwTn4UkT4TrzCG2oLsaPHAl+ WfWw== X-Gm-Message-State: AOJu0YzzlgdzGChZDPZuzVH68QurnxOnFMb+AJ9AihioVQSv6znH7BjU L2vlC4YpfeZp2REbVP1Jk48= X-Google-Smtp-Source: AGHT+IEhOkC6xnGbAR37vpV6MkHztMHFrS18pW2+Z/6tkJJXSA5ZZsQMtb3qt5G6Cp1hpv+vQnc4XQ== X-Received: by 2002:a17:906:51d5:b0:9bf:7ae7:fd6c with SMTP id v21-20020a17090651d500b009bf7ae7fd6cmr3174848ejk.10.1700732455026; Thu, 23 Nov 2023 01:40:55 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:54 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Chun-Kuang Hu Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , AngeloGioacchino Del Regno , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Thomas Zimmermann Subject: [PATCH v5 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:32 +0100 Message-ID: <20231123094040.592-13-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: AngeloGioacchino Del Regno Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/medi= atek/mtk_hdmi_ddc.c index d675c954b..54e46e440 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c @@ -297,7 +297,6 @@ static int mtk_hdmi_ddc_probe(struct platform_device *p= dev) =20 strscpy(ddc->adap.name, "mediatek-hdmi-ddc", sizeof(ddc->adap.name)); ddc->adap.owner =3D THIS_MODULE; - ddc->adap.class =3D I2C_CLASS_DDC; ddc->adap.algo =3D &mtk_hdmi_ddc_algorithm; ddc->adap.retries =3D 3; ddc->adap.dev.of_node =3D dev->of_node; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B96CC61D85 for ; Thu, 23 Nov 2023 09:42:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235237AbjKWJl4 (ORCPT ); Thu, 23 Nov 2023 04:41:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234607AbjKWJkz (ORCPT ); Thu, 23 Nov 2023 04:40:55 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4733FD68; Thu, 23 Nov 2023 01:40:57 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a02d91ab199so82436066b.0; Thu, 23 Nov 2023 01:40:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732456; x=1701337256; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4GQVLU0yIdzvkWpe6EOtR/8b+D+v0ZubEgK+LbytqFk=; b=fjWwVPsUARNs/VHoDvw+mL4gcuTLMp87TVPPHIXI4vRAwPTQf1iHkbSebo6UJRon04 tPCZjQBz4+0S+YCvq4bvmPjqshFlAE2+okqWk0w9H3YaY/9BhDOSZ5cgk8ngIQ8kdYUd ephbv23hFWXKs9BaAw+RSy+6BXnRNE1IJdafCfKBpv+4mtNSpJo4NexAhH0uOz5oCl3S KSEWFoGsHn3sLePq+be9kkERR7OOJeYZSnjY212XtJVG7YU1ExkdP1a8DvTxO6lZ2Fyo 1rSxOd+jLAvQmkFMyEZloLl0ckLnQmySRIdEl88n+mLX0oV83YntN7i1/RENesFf2Imc v2bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732456; x=1701337256; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4GQVLU0yIdzvkWpe6EOtR/8b+D+v0ZubEgK+LbytqFk=; b=hgu9yuraYqQohUH32EqSrDp6cdSjFuQqC90twdC95t/aTMvzbgJyWfgQSjSwSOEgJO bRtK3uT9tWLVAgzRRySNUcRThNqd9rDHCDEvjH4VsUYw3YkJt+hFmK/bUC7lpY5O1zf4 PfXHfkKV1LQofZPH+jEYVqfdGI8pOA6i+hb5HWoibcyfjMa6TC6Pb1dqPQmsZ6zoDKbE a9rsRLdNFveaevxMkIPLiF50YgZguIOG99P6C21doUoX+nl+7RAskPEw3sxAKgi62Vwn DA/Jlgq1P6vzD85jwivfH4/UtWnXgEVHdxKl787dG/KuY5LhsvQbaFbzrBIRzYvDMefy ed2Q== X-Gm-Message-State: AOJu0Yx2yGuFGK3WW/Fvz4LA20QkH5eILXlC25RT+ykWxJ1Yw3gud3jK yFLmetk+Hbc7pMKixt8Dnhc= X-Google-Smtp-Source: AGHT+IFW7oGp/sxqiNU9T6YyLWfXmVFxlR+ROFim07r/08bufC+IIaX6Uvxyofr/jhfjkQUrN3Ji5Q== X-Received: by 2002:a17:906:1855:b0:a00:8706:c82b with SMTP id w21-20020a170906185500b00a008706c82bmr3269223eje.47.1700732455722; Thu, 23 Nov 2023 01:40:55 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:55 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maik Broemme Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Helge Deller , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v5 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:33 +0100 Message-ID: <20231123094040.592-14-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Helge Deller Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/video/fbdev/intelfb/intelfb_i2c.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/video/fbdev/intelfb/intelfb_i2c.c b/drivers/video/fbde= v/intelfb/intelfb_i2c.c index 3300bd31d..f24c7cb4c 100644 --- a/drivers/video/fbdev/intelfb/intelfb_i2c.c +++ b/drivers/video/fbdev/intelfb/intelfb_i2c.c @@ -99,8 +99,7 @@ static int intelfb_gpio_getsda(void *data) =20 static int intelfb_setup_i2c_bus(struct intelfb_info *dinfo, struct intelfb_i2c_chan *chan, - const u32 reg, const char *name, - int class) + const u32 reg, const char *name) { int rc; =20 @@ -108,7 +107,6 @@ static int intelfb_setup_i2c_bus(struct intelfb_info *d= info, chan->reg =3D reg; snprintf(chan->adapter.name, sizeof(chan->adapter.name), "intelfb %s", name); - chan->adapter.class =3D class; chan->adapter.owner =3D THIS_MODULE; chan->adapter.algo_data =3D &chan->algo; chan->adapter.dev.parent =3D &chan->dinfo->pdev->dev; @@ -144,8 +142,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *din= fo) dinfo->output[i].type =3D INTELFB_OUTPUT_ANALOG; =20 /* setup the DDC bus for analog output */ - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, - "CRTDDC_A", I2C_CLASS_DDC); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOA, "CRTDDC_A"= ); i++; =20 /* need to add the output busses for each device @@ -159,10 +156,8 @@ void intelfb_create_i2c_busses(struct intelfb_info *di= nfo) case INTEL_855GM: case INTEL_865G: dinfo->output[i].type =3D INTELFB_OUTPUT_DVO; - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, - GPIOD, "DVODDC_D", I2C_CLASS_DDC); - intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "DVOI2C_E", 0); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].ddc_bus, GPIOD, "DVODDC_D= "); + intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, GPIOE, "DVOI2C_E= "); i++; break; case INTEL_915G: @@ -176,7 +171,7 @@ void intelfb_create_i2c_busses(struct intelfb_info *din= fo) /* SDVO ports have a single control bus - 2 devices */ dinfo->output[i].type =3D INTELFB_OUTPUT_SDVO; intelfb_setup_i2c_bus(dinfo, &dinfo->output[i].i2c_bus, - GPIOE, "SDVOCTRL_E", 0); + GPIOE, "SDVOCTRL_E"); /* TODO: initialize the SDVO */ /* I830SDVOInit(pScrn, i, DVOB); */ i++; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD50FC5AD4C for ; Thu, 23 Nov 2023 09:42:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235253AbjKWJmB (ORCPT ); Thu, 23 Nov 2023 04:42:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234686AbjKWJkz (ORCPT ); Thu, 23 Nov 2023 04:40:55 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42199D72; Thu, 23 Nov 2023 01:40:58 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-9fa45e75ed9so88638866b.1; Thu, 23 Nov 2023 01:40:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732457; x=1701337257; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=clBWu+ZkOHv5aLxF4Jumr7Rdkfthd/rp2JM9TiGQIuQ=; b=Nt2Q063xHLxk0zpMYkopuHqXGTDi+RnvKZdZDL8qQbHhN4xgIJLY4pmAZGfFS8sPz8 nT0JsohlKhtFcV7nA55I6NLegVWTg3A1hoGrUl/idRQ77BbPL6vuf+mJ61QZkGDz5q3r MBQOPBcOkrslZQuznKrGXlE9KFZXQPunQlpftL/+LFULRo4Ngi8AdT6GnOvo7GfwlAgl Fo4Lkp93TBWETEsPXbJdaJF3qBqBB63RVuLOv1Q39rIXifXsm1UR6H+NvLV/NxMHCvaZ IKUVMzYaMbuWlA10E5Ctlz5HPWb7J0q6izcHy4qLY46RsLAMoYMTD/WKU9AUH+W4y6gu ZP2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732457; x=1701337257; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=clBWu+ZkOHv5aLxF4Jumr7Rdkfthd/rp2JM9TiGQIuQ=; b=bFpwORXjaBkul4+E+ZjwuIWiJ+iKVF4oWFtvZkzbfv035uI3j1BH5WnMNcN6azb8DD 4hN3YBznR42MLOkrvST5e3DZztym/B3pPjRA0jkY8ccXGWDbVPc/8X5/QgM87GPKtt79 wuPfGypvx4KE2Iy90fdk8lLCWCw8S5tSyFyWGWRgBAhGSZtOGn6uw4Q9a6HYhUuO4Z+w OQTjsfAxUNRLmrtGr99JIaKWf9vC9f+H/p3O3pbOPRONagE/qyiYmNgSQI8nfpvazHQu HQJojP8JqB6jt3XX2ZwTjCEgFhqJk7OBdDdIf3blEWwYea/u3da8uY4WpGmJLcH8um+t yhsw== X-Gm-Message-State: AOJu0Ywlw+NBRdnm8AW46GAsd+IlsOFSWeJHvxPyVkJPMw88BQ6KmEFV qEqYkj9QmRsyeHMVWuYzmBg= X-Google-Smtp-Source: AGHT+IHq8vY/hRvfYfdj8oyzjE1msXHk0E43hTKOhiKHBd9IaWBYhWspiL+jJRvOCphRN+F9o76e6Q== X-Received: by 2002:a17:907:9207:b0:9fa:ca0c:ac42 with SMTP id ka7-20020a170907920700b009faca0cac42mr3054539ejb.64.1700732456620; Thu, 23 Nov 2023 01:40:56 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:56 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Rob Clark Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Thomas Zimmermann Subject: [PATCH v5 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:34 +0100 Message-ID: <20231123094040.592-15-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Dmitry Baryshkov Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/msm/hdmi/hdmi_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c b/drivers/gpu/drm/msm/hdmi= /hdmi_i2c.c index de182c004..7aa500d24 100644 --- a/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c +++ b/drivers/gpu/drm/msm/hdmi/hdmi_i2c.c @@ -249,7 +249,6 @@ struct i2c_adapter *msm_hdmi_i2c_init(struct hdmi *hdmi) =20 =20 i2c->owner =3D THIS_MODULE; - i2c->class =3D I2C_CLASS_DDC; snprintf(i2c->name, sizeof(i2c->name), "msm hdmi i2c"); i2c->dev.parent =3D &hdmi->pdev->dev; i2c->algo =3D &msm_hdmi_i2c_algorithm; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75757C61D85 for ; Thu, 23 Nov 2023 09:42:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235239AbjKWJmH (ORCPT ); Thu, 23 Nov 2023 04:42:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232769AbjKWJk4 (ORCPT ); Thu, 23 Nov 2023 04:40:56 -0500 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE4C310C9; Thu, 23 Nov 2023 01:40:59 -0800 (PST) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-a00b01955acso88959166b.1; Thu, 23 Nov 2023 01:40:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732458; x=1701337258; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Rr795psFWS5/sYRWa84NPLDqDZJaWExrkcgD8My4bAU=; b=NsZnwxxbgvsLoGXtWq7K3MaAIo3fkH8xflFJ1htX97WWInGV5v04Hq8c02JvPrXryA P5wP2ZgwIdCfX/APfGe7+KSUSrs38aKh7BDfUshOXJKWN+cMpKg+ruB1YLU/qzLKhm9J wjMaUNV86J/rDQkErPqD8QyrgSC9rsnUMldrMmFhI4C98wprwn5yj9Z1J5wl0ouEok2K jxj3HgJ9p4R1I+w6vTD30r+L3PjSCHHs8Q6KWm2y3PJeeX4dOzGOveEudWPVNHkSjeqY YUwTHPXhyLfxoW4z3DGiXGDpPTjXejXGOPdixqM/gNYr0rIym0eOzzCYPOwLOMuG2ErQ J2cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732458; x=1701337258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rr795psFWS5/sYRWa84NPLDqDZJaWExrkcgD8My4bAU=; b=kefIH8mAdB0rf4+MBUBKUBqnroP833UxrEdQnvibL8CdsT9mamPsQTajDRc/leWvo4 oQpew0B9vXQjcRaQ6k6RJCJv1ihThyPTwOI9nc/IYnEJqODLKWkD15PTChOhvkNSARtC 4BP1qITjgZwUz2haorl+QLQMdNH73Ml9mfOpOPw/Pgfkkr9Dp13DUttCjb1MVCB3ew4J WEbFYu0Q6dAwjd4JeAyIJwxjObRKm4KrSDAp595agqgJc2En5IJg/0JVVSwKmGSCbrxL eICKH3CA2Wa2I5huna3DTpjDrkwPMFS+Ho38FBd0oDndrsklORr/x4isei4zb/pw5cWm nY2Q== X-Gm-Message-State: AOJu0Yz3F7OoNI7RDGdY9JQp0C2K//Fws0bR+14D3YBvxLiQHTfyvq39 3rfApUXmro1waezhd4QnB+Y= X-Google-Smtp-Source: AGHT+IEG/JB/o9MucSUuFgW0Hx/NQMaV9GLQLv3jnO/TXJE6jD5ckNqjKF0YzoqBA/n4IjpIuJ4Oqw== X-Received: by 2002:a17:906:4ed2:b0:9fa:a075:c329 with SMTP id i18-20020a1709064ed200b009faa075c329mr3506046ejv.61.1700732457677; Thu, 23 Nov 2023 01:40:57 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:57 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Jani Nikula Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jani Nikula , Thomas Zimmermann Subject: [PATCH v5 15/20] drivers/gpu/drm/i915/display: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:35 +0100 Message-ID: <20231123094040.592-16-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Jani Nikula Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit Reviewed-by: Andi Shyti --- drivers/gpu/drm/i915/display/intel_gmbus.c | 1 - drivers/gpu/drm/i915/display/intel_sdvo.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_gmbus.c b/drivers/gpu/drm/i= 915/display/intel_gmbus.c index 40d7b6f3f..e9e4dcf34 100644 --- a/drivers/gpu/drm/i915/display/intel_gmbus.c +++ b/drivers/gpu/drm/i915/display/intel_gmbus.c @@ -899,7 +899,6 @@ int intel_gmbus_setup(struct drm_i915_private *i915) } =20 bus->adapter.owner =3D THIS_MODULE; - bus->adapter.class =3D I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "i915 gmbus %s", gmbus_pin->name); diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i9= 15/display/intel_sdvo.c index a636f42ce..5e64d1baf 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -3311,7 +3311,6 @@ intel_sdvo_init_ddc_proxy(struct intel_sdvo_ddc *ddc, ddc->ddc_bus =3D ddc_bus; =20 ddc->ddc.owner =3D THIS_MODULE; - ddc->ddc.class =3D I2C_CLASS_DDC; snprintf(ddc->ddc.name, I2C_NAME_SIZE, "SDVO %c DDC%d", port_name(sdvo->base.port), ddc_bus); ddc->ddc.dev.parent =3D &pdev->dev; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23F31C5AD4C for ; Thu, 23 Nov 2023 09:42:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235284AbjKWJmN (ORCPT ); Thu, 23 Nov 2023 04:42:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234999AbjKWJk4 (ORCPT ); Thu, 23 Nov 2023 04:40:56 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADEB810CF; Thu, 23 Nov 2023 01:41:00 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-a002562bd8bso135524166b.0; Thu, 23 Nov 2023 01:41:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732458; x=1701337258; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Pq+FEnQba7Sk+IX5HM84oJaaaLkn3lu8uiYE4NrIrFw=; b=fQ5A0zqCst/xtjHsSgPmt1rCFNsbOWd3YRJQ3gQRYNcaBsY9RJbu28Eip1orCYrHfA IKyRuY/c3qqiNr+HdAVIgMpUxjwV/uWpyjYH/zmALwRc7TLxj6X1iJs12VnbsFDOp/LJ rL/onbKmDUUfIYbS1upJn21YSUutXkN7SGdSAiNJUjDfxzsxFSvgArH0hqLG6f1CuAGC m2y6pjV2fuuBAqjP6KB0SSEzGoAqKhcCSgPGmyfOUhJ2P+OKIz3i6BF8jWUyAfALnUQl qyYcCcTCfVREg8qX2UegJijmQYyksiwz8Ru4onwcs0EnM0akDmh5E0usdC3tdq8pXBk9 B9Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732458; x=1701337258; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Pq+FEnQba7Sk+IX5HM84oJaaaLkn3lu8uiYE4NrIrFw=; b=mOHLh7o4k7B/d2//uL25lr+jzkJb37Kv8McWgS26lvtDuEc5MslHU6hKB2rmbWrHWQ ewUP6m2ZDcZegHRvTWu5fIkH8IwoHcL4NYvFn3AEnVjC5nYbP8CyM+327611AFuL7IZI 61Zt2eOoncFPEz2uWIHuWcweUo5kdqgl4F0WGdZoiNtSkcflARvmC4OCyAK6fwE+8JTl O0Dp4QZwZy0Ca18hqp/fYMtZI3rQnD3bGem1qiNJfE+es459u+joEhBJkxg99ggwGbm0 xhG8Hh2zxTVEq24eJmW6Ze7zLhq9iEjBH2Wn52gCN8xaGImYarihk3SVxrat3ZnEEdFs OkBA== X-Gm-Message-State: AOJu0Yxi6hvtunOPtx2aLacAXqdJUWNzJ8UQXuZPMaVMBaXAsTq+/a+S BicrjRjJ/E6wLqIsLiOyGW0= X-Google-Smtp-Source: AGHT+IHo0GBiadovOU1BBR1oWkASv65VH9/WnHAU5a3ZhwF8MBuNzgNR/J1hpFuh5wSinOqeTq7u8w== X-Received: by 2002:a17:906:78c:b0:a04:e1e7:d14c with SMTP id l12-20020a170906078c00b00a04e1e7d14cmr1774196ejc.32.1700732458571; Thu, 23 Nov 2023 01:40:58 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:58 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Xinliang Liu Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Tian Tao , Xinwei Kong , Sumit Semwal , Yongqin Liu , John Stultz , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:36 +0100 Message-ID: <20231123094040.592-17-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/= drm/hisilicon/hibmc/hibmc_drm_i2c.c index 410bd019b..e6e48651c 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c @@ -81,7 +81,6 @@ int hibmc_ddc_create(struct drm_device *drm_dev, struct hibmc_connector *connector) { connector->adapter.owner =3D THIS_MODULE; - connector->adapter.class =3D I2C_CLASS_DDC; snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus"); connector->adapter.dev.parent =3D drm_dev->dev; i2c_set_adapdata(&connector->adapter, connector); From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C244C5AD4C for ; Thu, 23 Nov 2023 09:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344017AbjKWJmT (ORCPT ); Thu, 23 Nov 2023 04:42:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235103AbjKWJk5 (ORCPT ); Thu, 23 Nov 2023 04:40:57 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23262BA; Thu, 23 Nov 2023 01:41:01 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-54a945861c6so930698a12.3; Thu, 23 Nov 2023 01:41:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732459; x=1701337259; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bqROwQG7N3qrkO1+o2zNL4maIfyYwDDg69jSMCtjk0o=; b=YcZ2kT8o0amxp7yzda3BKjoxqUfndekc9RHOUhsMw69tTOUwFcY+CPSZDqqWUztLmU dxsKq5RthFoB8XjTN6xSEYaiJYgDu04/kOGfcW5ABsnXaYkoIx2k5u9FhZMrQFYftvtP YuxJWp+OQRWNdRce8r4KR3n1NL+jkwC0rUFeCNFYbQWehyFTlHTrmMfp3ssqFyJIQkDx hVuHYCY3VGDfK26eKrAfHri+QFHjkXm5UWAfuW5Od/leOs6DyZVd0ZTMGqGaxfbOyClp D3tYEhSzDjToEZURYideJdWm1woihPwsDEh/iRC8XSCV9KFNdeEtQ0Y+o6jefBMW9nDU b3NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732459; x=1701337259; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bqROwQG7N3qrkO1+o2zNL4maIfyYwDDg69jSMCtjk0o=; b=rxsCuGE0SLWJdFPaRUUqYs8IUTVOClwbFeqPB+LJ4Clwbb+zRKozJfW39pNYRJDvXj snDAbzey3KxUwmY1LrWkWxvohL6qfx5YmyhfkRwa2iws+E91JHTtoHjx1kKICJ6/j9i0 RJztH0YIAqKW++ZVVJl3wCj2Fs2URRzJu9IRgi0gvs8NRswxCWgdRPlES8xoWzfbanGm HSzEsSVsyFcrh0UAf+G6xKO4e61I1QDZbpqWm8UvbnSxbrFFg/BGPicJH1a/ZuKTju1C eLFBRgON7hwVqvDY0DMO4N3qPtvjYPmkS10a8OhRqcMDVv1uHDTKzRsmXI7Nbniex1Ae FE/Q== X-Gm-Message-State: AOJu0YzUeS9yjagzZ16kTUu0mPeOyVw6eeBmF/K8ckQTcvwH0dhtdB9S XVO1bcY/LAPcwqnvd/RlLJM= X-Google-Smtp-Source: AGHT+IFzDKDdw9ToYZGoNPeCiTiYjGf6iU2HQh3DpjZwk9f0pHAhcqea5zBWX9e6oLqquOqcr6+iMA== X-Received: by 2002:a17:906:28d:b0:a00:131c:bc3e with SMTP id 13-20020a170906028d00b00a00131cbc3emr3342294ejf.11.1700732459394; Thu, 23 Nov 2023 01:40:59 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:59 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Dave Airlie Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Thomas Zimmermann , Jocelyn Falempe , Maarten Lankhorst , Maxime Ripard , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 17/20] drivers/gpu/drm/ast/ast_i2c.c: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:37 +0100 Message-ID: <20231123094040.592-18-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Reviewed-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/ast/ast_i2c.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/ast/ast_i2c.c b/drivers/gpu/drm/ast/ast_i2c.c index 0e845e7ac..e5d3f7121 100644 --- a/drivers/gpu/drm/ast/ast_i2c.c +++ b/drivers/gpu/drm/ast/ast_i2c.c @@ -120,7 +120,6 @@ struct ast_i2c_chan *ast_i2c_create(struct drm_device *= dev) return NULL; =20 i2c->adapter.owner =3D THIS_MODULE; - i2c->adapter.class =3D I2C_CLASS_DDC; i2c->adapter.dev.parent =3D dev->dev; i2c->dev =3D dev; i2c_set_adapdata(&i2c->adapter, i2c); From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A684C5AD4C for ; Thu, 23 Nov 2023 09:42:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235304AbjKWJmZ (ORCPT ); Thu, 23 Nov 2023 04:42:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234394AbjKWJlF (ORCPT ); Thu, 23 Nov 2023 04:41:05 -0500 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 916B2D7F; Thu, 23 Nov 2023 01:41:02 -0800 (PST) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9fcfd2a069aso85735666b.1; Thu, 23 Nov 2023 01:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732461; x=1701337261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lHDf4R0aqtCOREGjSJoba2ofOslBc7XL2VIsmReJ8Yw=; b=mLYaAzuY0hlXq0Z/dJENUjyRIYQPMILDifjY2bcd0JSOQ1bU0MD41cMHibIuo4uWE4 IoYny+Nbe5NGGFQAe6mAa5GjgptMhV0lNS09wvJWnfZvgIVRtOUxTWX3dlJdfR35+lpF hQQ008hkRWfu+pjLsOvYFD90vnHV9ZSB24NZrF8uNMpmVaoQoH3s1irr1qMOYRCAR8T8 ouzbLk2bbARG/+RjtOIK6rPGmNCDEorbN+jNiLvYh0xp/gIuXn6FJcwsvYxlwY01UqoQ lwCNqWhMtno5KdrIhhb5E51AIDTbAYlJYigQeeBkDehGOwFgTQcNuyuk6GRbwEr16Mc7 sZpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732461; x=1701337261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lHDf4R0aqtCOREGjSJoba2ofOslBc7XL2VIsmReJ8Yw=; b=s/6Kb2dbHcZrGYsOTOxkeK5zn/mmkbDLawWE6rqdqF7stfK92qPKMhUWIMJ8zACMjO Zu/CxM06Jbp8Vg4TD6FMwxQyg7Mjc0l/wHbdLf4s3Owt1OqZurbNfPKlLdLg/Ds2KSEJ w9LBkCAicTOFKDAsQZ1klxM4XDJCouf6MDJKVZ1MdlKfFH/y2rY/3UHjlOCOa41gj3ke fBiWye1F7POTrxKn/Hryyj9tsqjDJpm4+CBT/kpVR5xTCNR2ykvgCBCaL3PIJ6vGXCva XPaG7INNELOcm/6KLy3NggheZsdXzgA3E9EVL61RfdzQEmZv1pZHhhzRLH0AWN1k/Ddi NTyQ== X-Gm-Message-State: AOJu0Yxt9W5sk6d6RDaWSPZR/3S8thuH0L7BdNduPH8q0QBaH528aLl0 zuAU8PfQQ6yZbyhYgfZ9ASo= X-Google-Smtp-Source: AGHT+IEwScrsHwrV5UGKEZ7+DczopxJBuohCG5m5Mpc0AmS7jPDAA//6e5U/+0AoBHxE87JZKJXzdA== X-Received: by 2002:a17:907:2915:b0:9c3:1d7e:f5b5 with SMTP id eq21-20020a170907291500b009c31d7ef5b5mr2676823ejc.20.1700732460355; Thu, 23 Nov 2023 01:41:00 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.40.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:40:59 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Patrik Jakobsson Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 18/20] drivers/gpu/drm/gma500: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:38 +0100 Message-ID: <20231123094040.592-19-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 1 - drivers/gpu/drm/gma500/intel_gmbus.c | 1 - drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c | 1 - drivers/gpu/drm/gma500/psb_intel_sdvo.c | 1 - 4 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/gma500/cdv_intel_dp.c b/drivers/gpu/drm/gma500= /cdv_intel_dp.c index 8992a9507..dd1eb7e98 100644 --- a/drivers/gpu/drm/gma500/cdv_intel_dp.c +++ b/drivers/gpu/drm/gma500/cdv_intel_dp.c @@ -855,7 +855,6 @@ cdv_intel_dp_i2c_init(struct gma_connector *connector, =20 memset(&intel_dp->adapter, '\0', sizeof (intel_dp->adapter)); intel_dp->adapter.owner =3D THIS_MODULE; - intel_dp->adapter.class =3D I2C_CLASS_DDC; strncpy (intel_dp->adapter.name, name, sizeof(intel_dp->adapter.name) - 1= ); intel_dp->adapter.name[sizeof(intel_dp->adapter.name) - 1] =3D '\0'; intel_dp->adapter.algo_data =3D &intel_dp->algo; diff --git a/drivers/gpu/drm/gma500/intel_gmbus.c b/drivers/gpu/drm/gma500/= intel_gmbus.c index 09cedabf4..aa4550985 100644 --- a/drivers/gpu/drm/gma500/intel_gmbus.c +++ b/drivers/gpu/drm/gma500/intel_gmbus.c @@ -411,7 +411,6 @@ int gma_intel_setup_gmbus(struct drm_device *dev) struct intel_gmbus *bus =3D &dev_priv->gmbus[i]; =20 bus->adapter.owner =3D THIS_MODULE; - bus->adapter.class =3D I2C_CLASS_DDC; snprintf(bus->adapter.name, sizeof(bus->adapter.name), "gma500 gmbus %s", diff --git a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c b/drivers/gpu/drm/g= ma500/oaktrail_hdmi_i2c.c index fc9a34ed5..6daa6669e 100644 --- a/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c +++ b/drivers/gpu/drm/gma500/oaktrail_hdmi_i2c.c @@ -168,7 +168,6 @@ static struct i2c_adapter oaktrail_hdmi_i2c_adapter =3D= { .name =3D "oaktrail_hdmi_i2c", .nr =3D 3, .owner =3D THIS_MODULE, - .class =3D I2C_CLASS_DDC, .algo =3D &oaktrail_hdmi_i2c_algorithm, }; =20 diff --git a/drivers/gpu/drm/gma500/psb_intel_sdvo.c b/drivers/gpu/drm/gma5= 00/psb_intel_sdvo.c index d6fd5d726..e4f914dec 100644 --- a/drivers/gpu/drm/gma500/psb_intel_sdvo.c +++ b/drivers/gpu/drm/gma500/psb_intel_sdvo.c @@ -2426,7 +2426,6 @@ psb_intel_sdvo_init_ddc_proxy(struct psb_intel_sdvo *= sdvo, struct drm_device *dev) { sdvo->ddc.owner =3D THIS_MODULE; - sdvo->ddc.class =3D I2C_CLASS_DDC; snprintf(sdvo->ddc.name, I2C_NAME_SIZE, "SDVO DDC proxy"); sdvo->ddc.dev.parent =3D dev->dev; sdvo->ddc.algo_data =3D sdvo; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCCFFC61D85 for ; Thu, 23 Nov 2023 09:42:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344348AbjKWJm2 (ORCPT ); Thu, 23 Nov 2023 04:42:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235124AbjKWJlF (ORCPT ); Thu, 23 Nov 2023 04:41:05 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D7910E2; Thu, 23 Nov 2023 01:41:02 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-a02d12a2444so84052666b.3; Thu, 23 Nov 2023 01:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732461; x=1701337261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aq+Z35kBN2Z5WfXGmAWrEgYrcQFVHuODhyHjoCApg/g=; b=XXuguf7/roAvoYRK64dg8BBV5JIWYbblgPznxzJX3RmGcQ46NYIPyK2lWg4+Pl2J2Z Vl7gkFH6jmK3ebcSJkSTTXJJq60Ks1yQwIf4BtH3E9nNJ48NUiFvo0rmwykx5jAFK5gS Okhgt9fufdzXewzx1TqgoZ5fcxYA8aA3+DBvu1gtebEu9mdO2mok8Qpz75tKXNEOV9g6 l6ltYmil3aqI1sk/SZYbovTXRmHqwu08AC+ezbpFmfTC7vPmtjoR77OUADJ9z9fq1nz/ JV930W+TxK6hbkA2q0fMFLt9+MM9P25MqWy0dw6CvMjDeDkCj4rHZoO/yYWKYwBeWERZ nPQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732461; x=1701337261; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aq+Z35kBN2Z5WfXGmAWrEgYrcQFVHuODhyHjoCApg/g=; b=SWiur/BQvFO6XKhRUFPzoQuLXt4rhC110QkhCFH1xj8Gi6coSrEPPbbz0SMme6DAs9 919A7XfXthpVSc2QdZL2cOJEzu/oIYslay4/T4YiX2KACWxp4LxdpvwEB1PbLwvonEHx P1UTDCiQQhDSbvMxHhTSfxGEHOBHQKzP3lkv82NQJj9kYvy0h7DVyIdzxNN9kBbPxt/m DvINbRB4hwh3s5x+GIuW45mfWa1O0pbTdtCCbXF/ipBP1ydBraQrbiXBuaU7+6xfqLOn z9BfkVBhcrdV7EQUIleandatVARlWdmfZiRa1sBOwPibn8eWNopX/lLt0n+6fT6aDWGg Sp3A== X-Gm-Message-State: AOJu0Yyuyh2vbk4c63cEV9piZRSUH6klpsgsYk9D0v+j4UgyYAH19mAc /oy6uV7/0ujQp2WxRrWuFiM= X-Google-Smtp-Source: AGHT+IEV+7/puW0dt9JkKFWNyuf9FB8n8CqRgv0YKKalYf/l6B4ZXh/aBJaazGmziZBUrdXnlZahBA== X-Received: by 2002:a17:906:74c7:b0:a01:8957:7c75 with SMTP id z7-20020a17090674c700b00a0189577c75mr3683442ejl.11.1700732461099; Thu, 23 Nov 2023 01:41:01 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.41.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:41:00 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang , Maarten Lankhorst Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Alex Deucher Subject: [PATCH v5 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:39 +0100 Message-ID: <20231123094040.592-20-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Acked-by: Alex Deucher Acked-by: Thomas Zimmermann Signed-off-by: Heiner Kallweit --- drivers/gpu/drm/display/drm_dp_helper.c | 1 - drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/disp= lay/drm_dp_helper.c index f3680f4e6..ac901f4b4 100644 --- a/drivers/gpu/drm/display/drm_dp_helper.c +++ b/drivers/gpu/drm/display/drm_dp_helper.c @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux) if (!aux->ddc.algo) drm_dp_aux_init(aux); =20 - aux->ddc.class =3D I2C_CLASS_DDC; aux->ddc.owner =3D THIS_MODULE; aux->ddc.dev.parent =3D aux->dev; =20 diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/dr= m/display/drm_dp_mst_topology.c index 0e0d0e76d..4376e2c1f 100644 --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_= mst_port *port) aux->ddc.algo_data =3D aux; aux->ddc.retries =3D 3; =20 - aux->ddc.class =3D I2C_CLASS_DDC; aux->ddc.owner =3D THIS_MODULE; /* FIXME: set the kdev of the port's connector as parent */ aux->ddc.dev.parent =3D parent_dev; From nobody Thu Nov 14 05:25:00 2024 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16AE4C5AD4C for ; Thu, 23 Nov 2023 09:42:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234061AbjKWJmd (ORCPT ); Thu, 23 Nov 2023 04:42:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235191AbjKWJlI (ORCPT ); Thu, 23 Nov 2023 04:41:08 -0500 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABC84D50; Thu, 23 Nov 2023 01:41:03 -0800 (PST) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-548b54ed16eso899757a12.0; Thu, 23 Nov 2023 01:41:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732462; x=1701337262; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xoOuxVfYX3lHdi36PKjYbl3tsLm17OpynR1y+9rBRUM=; b=njKKRA1xeZ0YPPMTB9xB3fUKJ9aCj4TrC51CWaENnDqPGU8di8X3WBiAslbmRbFFt9 goHIsDNXzchKvUQ/zdOX0a1IA3XvdcCfjeC/KN46y1ysbGzywzKq3PuJECAZHhxtGiLo G2QQ0+U0DHnmgVrgNjg3Y1Uo/8PR3WQNwIUWzzQpV8Qjw4fy3xLimerLI52kAPzu+wev eK3D7qI1VXjYwThjgaR6n2rEJNDnPGcwUe7MOqsI9ZnFixYN/jEaTQHfgIwmXTRl0ANW AJwvZL4TRezK7rAnGpELy7t96SY2lxffEfIn597LbV8M2XgkL0HPF/gQSV9nRK7SMwHr bdAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732462; x=1701337262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xoOuxVfYX3lHdi36PKjYbl3tsLm17OpynR1y+9rBRUM=; b=HLKbzzfbEZ2J5KV5llYxY2LIuhoyQPldLL5xYCuLnUH76d1EjFn5JRQlZvFFtLp73o t3PKfso+mcqaT41ytAhx9ibgitfbVumnfCXhmkIUTfuVUQ6Tki+HNiUbMVKTWrb00D/G qHZu+N7cqCkNLI4eXE+3Qmv3VKZh/waofz6rEBZ4H+4CWlwnKsT7thwqvig7BxJ8q2i4 M+rAJX2tHdUAiSSXf5j5IeMOoPZGQiWPhF4bhwSsC11KCSVKedUfVgCUplg0lQC2ltsF 9njM35ce9zL5KNPCfjD4HCavvD1o7h3zUnAye3nIecKEY0IvMl0pSmgDEkjIB6vdVu3U 2Uyw== X-Gm-Message-State: AOJu0YwXTp4TnYU3NLWAUZfk5azdP6hTnD6C+jfHjqriyVy7yus7deqq g67pb6hTHAkFB/oTwyijXogNkZERp/E= X-Google-Smtp-Source: AGHT+IF2ce8O4Dy0JVMTvh8ywPgv8CHjTNcsicVHS4uyWnf5FWv5HXbuEkjOnpvoMHQySO7ke4A8Qg== X-Received: by 2002:a17:906:8a:b0:a03:d8ea:a264 with SMTP id 10-20020a170906008a00b00a03d8eaa264mr3680644ejc.2.1700732462058; Thu, 23 Nov 2023 01:41:02 -0800 (PST) Received: from zotac.lan. (dynamic-2a01-0c23-c0f2-3200-2223-08ff-fe18-0310.c23.pool.telefonica.de. [2a01:c23:c0f2:3200:2223:8ff:fe18:310]) by smtp.gmail.com with ESMTPSA id s9-20020a1709066c8900b009e5ce1acb01sm546199ejr.103.2023.11.23.01.41.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Nov 2023 01:41:01 -0800 (PST) From: Heiner Kallweit To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, Heiner Kallweit , linux-kernel@vger.kernel.org Subject: [PATCH v5 20/20] include/linux/i2c.h: remove I2C_CLASS_DDC support Date: Thu, 23 Nov 2023 10:40:40 +0100 Message-ID: <20231123094040.592-21-hkallweit1@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20231123094040.592-1-hkallweit1@gmail.com> References: <20231123094040.592-1-hkallweit1@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC. Class-based device auto-detection is a legacy mechanism and shouldn't be used in new code. So we can remove this class completely now. Preferably this series should be applied via the i2c tree. Signed-off-by: Heiner Kallweit --- include/linux/i2c.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 0dae9db27..d029aade3 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -850,7 +850,6 @@ static inline void i2c_mark_adapter_resumed(struct i2c_= adapter *adap) =20 /* i2c adapter classes (bitmask) */ #define I2C_CLASS_HWMON (1<<0) /* lm_sensors, ... */ -#define I2C_CLASS_DDC (1<<3) /* DDC bus on graphics adapters */ #define I2C_CLASS_SPD (1<<7) /* Memory modules */ /* Warn users that the adapter doesn't support classes anymore */ #define I2C_CLASS_DEPRECATED (1<<8)