From nobody Wed Dec 17 19:00:32 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87655C27C40 for ; Wed, 22 Nov 2023 22:19:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344661AbjKVWTO (ORCPT ); Wed, 22 Nov 2023 17:19:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235239AbjKVWTL (ORCPT ); Wed, 22 Nov 2023 17:19:11 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDF191993 for ; Wed, 22 Nov 2023 14:18:45 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6237DC433B6; Wed, 22 Nov 2023 22:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700691524; bh=LxBGHdJ2v9bdua30Gg+KKEVoYaWNReAP/fHM99MgfLg=; h=From:To:Cc:Subject:Date:From; b=ZoJh6dBQME/k9NdDqkjJ5mDfVWRFJQhjrrCElROlyU1JHn/mAUQLFKfiCq2kfvfc/ 9q1MHs7St+bQVxjHJMruozUyeIb7BIN2GtTtLetF6d55QUScqXGo/tXY+/Ob0JsyIi 4Q1Vp+3mUeIt2OZdnIOYyiGbH1f+VhHF7LqQxyNhkOlU10X8W3lFK6MoPmkjmvpDWR A/qmfrWGLZ4MMbMTZrlJj/Ucx/szFxhKP1YiJPjIHlcPuvQUYHxLTo0y6QeAOo6K8T cXcff1M3qSfsQrP9/Tw4785yc2oru+lW1H0Ho9jauIvK/X/IrDL1F++WlwD79Sr9q/ Ti9tuiIdPxSDg== From: Arnd Bergmann To: Sandy Huang , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Johan Jonker Cc: Arnd Bergmann , Kees Cook , Douglas Anderson , Azeem Shaikh , =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/rockchip: rk3066_hdmi: include drm/drm_atomic.h Date: Wed, 22 Nov 2023 23:18:29 +0100 Message-Id: <20231122221838.3164349-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Arnd Bergmann Without this header, the newly added code fails to build: drivers/gpu/drm/rockchip/rk3066_hdmi.c: In function 'rk3066_hdmi_encoder_en= able': drivers/gpu/drm/rockchip/rk3066_hdmi.c:397:22: error: implicit declaration = of function 'drm_atomic_get_new_connector_state'; did you mean 'drm_atomic_= helper_connector_reset'? [-Werror=3Dimplicit-function-declaration] 397 | conn_state =3D drm_atomic_get_new_connector_state(state, &h= dmi->connector); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | drm_atomic_helper_connector_reset drivers/gpu/drm/rockchip/rk3066_hdmi.c:397:20: error: assignment to 'struct= drm_connector_state *' from 'int' makes pointer from integer without a cas= t [-Werror=3Dint-conversion] 397 | conn_state =3D drm_atomic_get_new_connector_state(state, &h= dmi->connector); | ^ drivers/gpu/drm/rockchip/rk3066_hdmi.c:401:22: error: implicit declaration = of function 'drm_atomic_get_new_crtc_state'; did you mean 'drm_atomic_helpe= r_swap_state'? [-Werror=3Dimplicit-function-declaration] 401 | crtc_state =3D drm_atomic_get_new_crtc_state(state, conn_st= ate->crtc); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | drm_atomic_helper_swap_state drivers/gpu/drm/rockchip/rk3066_hdmi.c:401:20: error: assignment to 'struct= drm_crtc_state *' from 'int' makes pointer from integer without a cast [-W= error=3Dint-conversion] 401 | crtc_state =3D drm_atomic_get_new_crtc_state(state, conn_st= ate->crtc); | ^ Fixes: ae3436a5e7c2 ("drm/rockchip: rk3066_hdmi: Switch encoder hooks to at= omic") Signed-off-by: Arnd Bergmann Acked-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockc= hip/rk3066_hdmi.c index 0e7aae341960..7d561c5a650f 100644 --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c @@ -4,6 +4,7 @@ * Zheng Yang */ =20 +#include #include #include #include --=20 2.39.2