From nobody Sun Feb 8 09:53:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77C5EC61D9C for ; Wed, 22 Nov 2023 10:02:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235233AbjKVKCQ (ORCPT ); Wed, 22 Nov 2023 05:02:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbjKVKCN (ORCPT ); Wed, 22 Nov 2023 05:02:13 -0500 Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85C1BD65; Wed, 22 Nov 2023 02:02:07 -0800 (PST) Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 48C2C120079; Wed, 22 Nov 2023 13:02:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 48C2C120079 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1700647325; bh=ihuwRMROZNg9AMfolsXNCx/0gG4LGfVCgQWgEVIDo1o=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=eyXlTCLL30waDgk1VVuibAcFiArPDA/QsTD9s6PVmHQgZDaoOl0J7HEhacQSCGzdW KpC4kNieIjEFxfS7rrl1N/XnW2xeSyvlnB3irz28yZu5koLfNmBdv3XgUW1/8bDNC2 UhUCooBWv1c8a7wGw4dtmVhFcjNzEEQ/8olZIuSXqZCPfxpqDW/7qoyGEUt+yKxmS6 OEek66LqWv/XAvLl+yqIg3FJ4LbryZ/luWoFIc5d8EH0xClBLML70hedhn3PrHyfjv DUMuF6145cZGNl7EV41++Y5LhnIxWkV/utXAwWS1AZ+8VYlsDl+KNWaRRcab96J6Wy GqtyrCw9DvGyw== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Wed, 22 Nov 2023 13:02:05 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 22 Nov 2023 13:02:04 +0300 From: Dmitry Rokosov To: , , , , , , , CC: , , , , , , Dmitry Rokosov Subject: [PATCH v2 1/2] mm: memcg: print out cgroup name in the memcg tracepoints Date: Wed, 22 Nov 2023 13:01:55 +0300 Message-ID: <20231122100156.6568-2-ddrokosov@salutedevices.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20231122100156.6568-1-ddrokosov@salutedevices.com> References: <20231122100156.6568-1-ddrokosov@salutedevices.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 181525 [Nov 22 2023] X-KSMG-AntiSpam-Version: 6.0.0.2 X-KSMG-AntiSpam-Envelope-From: ddrokosov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 3 0.3.3 e5c6a18a9a9bff0226d530c5b790210c0bd117c8, {Tracking_from_domain_doesnt_match_to}, salutedevices.com:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;p-i-exch-sc-m01.sberdevices.ru:5.0.1,7.1.1;100.64.160.123:7.1.2, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/11/22 05:48:00 #22499758 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Sometimes it is necessary to understand in which memcg tracepoint event occurred. The function cgroup_name() is a useful tool for this purpose. To integrate cgroup_name() into the existing memcg tracepoints, this patch introduces a new tracepoint template for the begin() and end() events, utilizing static __array() to store the cgroup name. Signed-off-by: Dmitry Rokosov --- include/trace/events/vmscan.h | 77 +++++++++++++++++++++++++++++------ mm/vmscan.c | 10 ++--- 2 files changed, 70 insertions(+), 17 deletions(-) diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h index d2123dd960d5..9b49cd120ae9 100644 --- a/include/trace/events/vmscan.h +++ b/include/trace/events/vmscan.h @@ -141,19 +141,47 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template,= mm_vmscan_direct_reclaim_b ); =20 #ifdef CONFIG_MEMCG -DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_memcg_recl= aim_begin, =20 - TP_PROTO(int order, gfp_t gfp_flags), +DECLARE_EVENT_CLASS(mm_vmscan_memcg_reclaim_begin_template, =20 - TP_ARGS(order, gfp_flags) + TP_PROTO(int order, gfp_t gfp_flags, const struct mem_cgroup *memcg), + + TP_ARGS(order, gfp_flags, memcg), + + TP_STRUCT__entry( + __field(int, order) + __field(unsigned long, gfp_flags) + __array(char, name, NAME_MAX + 1) + ), + + TP_fast_assign( + __entry->order =3D order; + __entry->gfp_flags =3D (__force unsigned long)gfp_flags; + cgroup_name(memcg->css.cgroup, + __entry->name, + sizeof(__entry->name)); + ), + + TP_printk("order=3D%d gfp_flags=3D%s memcg=3D%s", + __entry->order, + show_gfp_flags(__entry->gfp_flags), + __entry->name) ); =20 -DEFINE_EVENT(mm_vmscan_direct_reclaim_begin_template, mm_vmscan_memcg_soft= limit_reclaim_begin, +DEFINE_EVENT(mm_vmscan_memcg_reclaim_begin_template, mm_vmscan_memcg_recla= im_begin, =20 - TP_PROTO(int order, gfp_t gfp_flags), + TP_PROTO(int order, gfp_t gfp_flags, const struct mem_cgroup *memcg), =20 - TP_ARGS(order, gfp_flags) + TP_ARGS(order, gfp_flags, memcg) +); + +DEFINE_EVENT(mm_vmscan_memcg_reclaim_begin_template, mm_vmscan_memcg_softl= imit_reclaim_begin, + + TP_PROTO(int order, gfp_t gfp_flags, const struct mem_cgroup *memcg), + + TP_ARGS(order, gfp_flags, memcg) ); + #endif /* CONFIG_MEMCG */ =20 DECLARE_EVENT_CLASS(mm_vmscan_direct_reclaim_end_template, @@ -181,19 +209,44 @@ DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, m= m_vmscan_direct_reclaim_end ); =20 #ifdef CONFIG_MEMCG -DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_reclai= m_end, =20 - TP_PROTO(unsigned long nr_reclaimed), +DECLARE_EVENT_CLASS(mm_vmscan_memcg_reclaim_end_template, =20 - TP_ARGS(nr_reclaimed) + TP_PROTO(unsigned long nr_reclaimed, const struct mem_cgroup *memcg), + + TP_ARGS(nr_reclaimed, memcg), + + TP_STRUCT__entry( + __field(unsigned long, nr_reclaimed) + __array(char, name, NAME_MAX + 1) + ), + + TP_fast_assign( + __entry->nr_reclaimed =3D nr_reclaimed; + cgroup_name(memcg->css.cgroup, + __entry->name, + sizeof(__entry->name)); + ), + + TP_printk("nr_reclaimed=3D%lu memcg=3D%s", + __entry->nr_reclaimed, + __entry->name) ); =20 -DEFINE_EVENT(mm_vmscan_direct_reclaim_end_template, mm_vmscan_memcg_softli= mit_reclaim_end, +DEFINE_EVENT(mm_vmscan_memcg_reclaim_end_template, mm_vmscan_memcg_reclaim= _end, =20 - TP_PROTO(unsigned long nr_reclaimed), + TP_PROTO(unsigned long nr_reclaimed, const struct mem_cgroup *memcg), =20 - TP_ARGS(nr_reclaimed) + TP_ARGS(nr_reclaimed, memcg) ); + +DEFINE_EVENT(mm_vmscan_memcg_reclaim_end_template, mm_vmscan_memcg_softlim= it_reclaim_end, + + TP_PROTO(unsigned long nr_reclaimed, const struct mem_cgroup *memcg), + + TP_ARGS(nr_reclaimed, memcg) +); + #endif /* CONFIG_MEMCG */ =20 TRACE_EVENT(mm_shrink_slab_start, diff --git a/mm/vmscan.c b/mm/vmscan.c index 1080209a568b..45780952f4b5 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -7088,8 +7088,8 @@ unsigned long mem_cgroup_shrink_node(struct mem_cgrou= p *memcg, sc.gfp_mask =3D (gfp_mask & GFP_RECLAIM_MASK) | (GFP_HIGHUSER_MOVABLE & ~GFP_RECLAIM_MASK); =20 - trace_mm_vmscan_memcg_softlimit_reclaim_begin(sc.order, - sc.gfp_mask); + trace_mm_vmscan_memcg_softlimit_reclaim_begin(sc.order, sc.gfp_mask, + memcg); =20 /* * NOTE: Although we can get the priority field, using it @@ -7100,7 +7100,7 @@ unsigned long mem_cgroup_shrink_node(struct mem_cgrou= p *memcg, */ shrink_lruvec(lruvec, &sc); =20 - trace_mm_vmscan_memcg_softlimit_reclaim_end(sc.nr_reclaimed); + trace_mm_vmscan_memcg_softlimit_reclaim_end(sc.nr_reclaimed, memcg); =20 *nr_scanned =3D sc.nr_scanned; =20 @@ -7134,13 +7134,13 @@ unsigned long try_to_free_mem_cgroup_pages(struct m= em_cgroup *memcg, struct zonelist *zonelist =3D node_zonelist(numa_node_id(), sc.gfp_mask); =20 set_task_reclaim_state(current, &sc.reclaim_state); - trace_mm_vmscan_memcg_reclaim_begin(0, sc.gfp_mask); + trace_mm_vmscan_memcg_reclaim_begin(0, sc.gfp_mask, memcg); noreclaim_flag =3D memalloc_noreclaim_save(); =20 nr_reclaimed =3D do_try_to_free_pages(zonelist, &sc); =20 memalloc_noreclaim_restore(noreclaim_flag); - trace_mm_vmscan_memcg_reclaim_end(nr_reclaimed); + trace_mm_vmscan_memcg_reclaim_end(nr_reclaimed, memcg); set_task_reclaim_state(current, NULL); =20 return nr_reclaimed; --=20 2.36.0 From nobody Sun Feb 8 09:53:22 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4B39C61D9C for ; Wed, 22 Nov 2023 10:02:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343761AbjKVKCX (ORCPT ); Wed, 22 Nov 2023 05:02:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235130AbjKVKCN (ORCPT ); Wed, 22 Nov 2023 05:02:13 -0500 Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBC8ED6A; Wed, 22 Nov 2023 02:02:07 -0800 (PST) Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id 2BF7912007A; Wed, 22 Nov 2023 13:02:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru 2BF7912007A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=salutedevices.com; s=mail; t=1700647326; bh=gpgaCxHlI+b2COEC+6FpbgcB+0fsnGeeLl3cqShaJqM=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=U2cR+jnyFbVSzokJr22L16YfRk74aZVdMuKPLIDW3i2hdsMEGqhTka7lSAcD1g7oN z2fv1tAsNgBKodod7yLz0WGHRNZ8gq8n1M5u4/xt0vAf/N8fubkhsGuVdxTJJ60mEh khZTlInYrQnkPAqvmUR8tsBUNwLEF9LklqKdr9RH8xu5M3kZAIyIJ+45UK4zy0vUHM RFmVf4Ms267OyFVzFgAJXCHnIvGz5UB96iFfP3MHVwODner3M1vXSvnbdsyG+zCAyF bM12FaKE4cwOJPq3reOyAsKTYOA1t3jxeLOtSpSDEb0yBRXobevAbGBHsbZONIlxba qXQIQhmVNh7yQ== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Wed, 22 Nov 2023 13:02:06 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.40; Wed, 22 Nov 2023 13:02:05 +0300 From: Dmitry Rokosov To: , , , , , , , CC: , , , , , , Dmitry Rokosov Subject: [PATCH v2 2/2] mm: memcg: introduce new event to trace shrink_memcg Date: Wed, 22 Nov 2023 13:01:56 +0300 Message-ID: <20231122100156.6568-3-ddrokosov@salutedevices.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20231122100156.6568-1-ddrokosov@salutedevices.com> References: <20231122100156.6568-1-ddrokosov@salutedevices.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 181525 [Nov 22 2023] X-KSMG-AntiSpam-Version: 6.0.0.2 X-KSMG-AntiSpam-Envelope-From: ddrokosov@salutedevices.com X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 3 0.3.3 e5c6a18a9a9bff0226d530c5b790210c0bd117c8, {Tracking_from_domain_doesnt_match_to}, salutedevices.com:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;p-i-exch-sc-m01.sberdevices.ru:5.0.1,7.1.1;100.64.160.123:7.1.2, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/11/22 05:48:00 #22499758 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The shrink_memcg flow plays a crucial role in memcg reclamation. Currently, it is not possible to trace this point from non-direct reclaim paths. However, direct reclaim has its own tracepoint, so there is no issue there. In certain cases, when debugging memcg pressure, developers may need to identify all potential requests for memcg reclamation including kswapd(). The patchset introduces the tracepoints mm_vmscan_memcg_shrink_{begin|end}() to address this problem. Example of output in the kswapd context (non-direct reclaim): kswapd0-39 [001] ..... 240.356378: mm_vmscan_memcg_shrink_begin:= order=3D0 gfp_flags=3DGFP_KERNEL memcg=3Dtest kswapd0-39 [001] ..... 240.356396: mm_vmscan_memcg_shrink_end: n= r_reclaimed=3D0 memcg=3Dtest kswapd0-39 [001] ..... 240.356420: mm_vmscan_memcg_shrink_begin:= order=3D0 gfp_flags=3DGFP_KERNEL memcg=3Dtest kswapd0-39 [001] ..... 240.356454: mm_vmscan_memcg_shrink_end: n= r_reclaimed=3D1 memcg=3Dtest kswapd0-39 [001] ..... 240.356479: mm_vmscan_memcg_shrink_begin:= order=3D0 gfp_flags=3DGFP_KERNEL memcg=3Dtest kswapd0-39 [001] ..... 240.356506: mm_vmscan_memcg_shrink_end: n= r_reclaimed=3D4 memcg=3Dtest kswapd0-39 [001] ..... 240.356525: mm_vmscan_memcg_shrink_begin:= order=3D0 gfp_flags=3DGFP_KERNEL memcg=3Dtest kswapd0-39 [001] ..... 240.356593: mm_vmscan_memcg_shrink_end: n= r_reclaimed=3D11 memcg=3Dtest kswapd0-39 [001] ..... 240.356614: mm_vmscan_memcg_shrink_begin:= order=3D0 gfp_flags=3DGFP_KERNEL memcg=3Dtest kswapd0-39 [001] ..... 240.356738: mm_vmscan_memcg_shrink_end: n= r_reclaimed=3D25 memcg=3Dtest kswapd0-39 [001] ..... 240.356790: mm_vmscan_memcg_shrink_begin:= order=3D0 gfp_flags=3DGFP_KERNEL memcg=3Dtest kswapd0-39 [001] ..... 240.357125: mm_vmscan_memcg_shrink_end: n= r_reclaimed=3D53 memcg=3Dtest Signed-off-by: Dmitry Rokosov --- include/trace/events/vmscan.h | 14 ++++++++++++++ mm/vmscan.c | 11 +++++++++++ 2 files changed, 25 insertions(+) diff --git a/include/trace/events/vmscan.h b/include/trace/events/vmscan.h index 9b49cd120ae9..cb39b4f0dca9 100644 --- a/include/trace/events/vmscan.h +++ b/include/trace/events/vmscan.h @@ -182,6 +182,13 @@ DEFINE_EVENT(mm_vmscan_memcg_reclaim_begin_template, m= m_vmscan_memcg_softlimit_r TP_ARGS(order, gfp_flags, memcg) ); =20 +DEFINE_EVENT(mm_vmscan_memcg_reclaim_begin_template, mm_vmscan_memcg_shrin= k_begin, + + TP_PROTO(int order, gfp_t gfp_flags, const struct mem_cgroup *memcg), + + TP_ARGS(order, gfp_flags, memcg) +); + #endif /* CONFIG_MEMCG */ =20 DECLARE_EVENT_CLASS(mm_vmscan_direct_reclaim_end_template, @@ -247,6 +254,13 @@ DEFINE_EVENT(mm_vmscan_memcg_reclaim_end_template, mm_= vmscan_memcg_softlimit_rec TP_ARGS(nr_reclaimed, memcg) ); =20 +DEFINE_EVENT(mm_vmscan_memcg_reclaim_end_template, mm_vmscan_memcg_shrink_= end, + + TP_PROTO(unsigned long nr_reclaimed, const struct mem_cgroup *memcg), + + TP_ARGS(nr_reclaimed, memcg) +); + #endif /* CONFIG_MEMCG */ =20 TRACE_EVENT(mm_shrink_slab_start, diff --git a/mm/vmscan.c b/mm/vmscan.c index 45780952f4b5..6d89b39d9a91 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -6461,6 +6461,12 @@ static void shrink_node_memcgs(pg_data_t *pgdat, str= uct scan_control *sc) */ cond_resched(); =20 +#ifdef CONFIG_MEMCG + trace_mm_vmscan_memcg_shrink_begin(sc->order, + sc->gfp_mask, + memcg); +#endif + mem_cgroup_calculate_protection(target_memcg, memcg); =20 if (mem_cgroup_below_min(target_memcg, memcg)) { @@ -6491,6 +6497,11 @@ static void shrink_node_memcgs(pg_data_t *pgdat, str= uct scan_control *sc) shrink_slab(sc->gfp_mask, pgdat->node_id, memcg, sc->priority); =20 +#ifdef CONFIG_MEMCG + trace_mm_vmscan_memcg_shrink_end(sc->nr_reclaimed - reclaimed, + memcg); +#endif + /* Record the group's reclaim efficiency */ if (!sc->proactive) vmpressure(sc->gfp_mask, memcg, false, --=20 2.36.0