From nobody Wed Dec 17 20:44:42 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B62C61D96 for ; Wed, 22 Nov 2023 08:52:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234943AbjKVIw6 (ORCPT ); Wed, 22 Nov 2023 03:52:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231388AbjKVIwz (ORCPT ); Wed, 22 Nov 2023 03:52:55 -0500 Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83C83109 for ; Wed, 22 Nov 2023 00:52:50 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=11;SR=0;TI=SMTPD_---0VwvISgh_1700643160; Received: from localhost(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0VwvISgh_1700643160) by smtp.aliyun-inc.com; Wed, 22 Nov 2023 16:52:48 +0800 From: Jiapeng Chong To: jani.nikula@linux.intel.com Cc: joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tvrtko.ursulin@linux.intel.com, airlied@gmail.com, daniel@ffwll.ch, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jiapeng Chong , Abaci Robot Subject: [PATCH] drm/i915/psr: Fix unsigned expression compared with zero Date: Wed, 22 Nov 2023 16:52:39 +0800 Message-Id: <20231122085239.89046-1-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The entry_setup_frames is defined as u8 type, else(entry_setup_frames < 0) is invalid. At the same time, the return value of function intel_psr_entry_setup_frames is also of type int. so modified its type to int. ./drivers/gpu/drm/i915/display/intel_psr.c:1336:5-23: WARNING: Unsigned exp= ression compared with zero: entry_setup_frames >=3D 0. Reported-by: Abaci Robot Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D7610 Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/i915/display/intel_psr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i91= 5/display/intel_psr.c index 8d180132a74b..204da50e3f28 100644 --- a/drivers/gpu/drm/i915/display/intel_psr.c +++ b/drivers/gpu/drm/i915/display/intel_psr.c @@ -1319,7 +1319,7 @@ static bool _psr_compute_config(struct intel_dp *inte= l_dp, { struct drm_i915_private *dev_priv =3D dp_to_i915(intel_dp); const struct drm_display_mode *adjusted_mode =3D &crtc_state->hw.adjusted= _mode; - u8 entry_setup_frames; + int entry_setup_frames; =20 /* * Current PSR panels don't work reliably with VRR enabled --=20 2.20.1.7.g153144c