From nobody Sat Feb 7 14:05:53 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 010B8C072A2 for ; Wed, 22 Nov 2023 03:30:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343620AbjKVDa7 (ORCPT ); Tue, 21 Nov 2023 22:30:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39668 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343642AbjKVDas (ORCPT ); Tue, 21 Nov 2023 22:30:48 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF8F9D6F for ; Tue, 21 Nov 2023 19:30:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700623841; x=1732159841; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=l8mKiuMBoMj92zKyDcAwd723ed3hnwwboBhJ8sse7us=; b=KoCXRkn3I3jEqOHOpuBkxmPX6V5YgMQxaowr6X8F7mP8XbHStGHpSv6w EvMMVBccFXUVq7FdrMaepP0iiT2ScvYO0mtimnEk+4dciEUzHsgwLTlXU h9IjqqFv4JXuUchsm6KG689XFFfQq3RXE5Lou3QEr2ZA7lG4iDt42xJLl whCkcYayCo1DlnRGdhA0ba8LYqEP2HkzvaYESpPPWyC777e1OERj96ojW fsX48WSL+GGA7bqx+eCkl32F84mOU/+MrfxdIouCHemVfVZDBzuGoiZtz YKM7opJUeMYM0glMRk/1T9FnuLnbIQTB3/jZhKLleWctl8NTKNoHaNb82 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10901"; a="391742807" X-IronPort-AV: E=Sophos;i="6.04,217,1695711600"; d="scan'208";a="391742807" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 19:30:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,217,1695711600"; d="scan'208";a="8090194" Received: from allen-box.sh.intel.com ([10.239.159.127]) by orviesa002.jf.intel.com with ESMTP; 21 Nov 2023 19:30:40 -0800 From: Lu Baolu To: Joerg Roedel Cc: mohd.syazwan.abdul.halim@intel.com, Kunwu Chan , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH 7/7] iommu/vt-d: Set variable intel_dirty_ops to static Date: Wed, 22 Nov 2023 11:26:08 +0800 Message-Id: <20231122032608.165144-8-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231122032608.165144-1-baolu.lu@linux.intel.com> References: <20231122032608.165144-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Kunwu Chan Fix the following warning: drivers/iommu/intel/iommu.c:302:30: warning: symbol 'intel_dirty_ops' was not declared. Should it be static? This variable is only used in its defining file, so it should be static. Fixes: f35f22cc760e ("iommu/vt-d: Access/Dirty bit support for SS domains") Signed-off-by: Kunwu Chan Reviewed-by: Jason Gunthorpe Reviewed-by: Joao Martins Link: https://lore.kernel.org/r/20231120101025.1103404-1-chentao@kylinos.cn Signed-off-by: Lu Baolu --- drivers/iommu/intel/iommu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c index 68f121c28fbf..897159dba47d 100644 --- a/drivers/iommu/intel/iommu.c +++ b/drivers/iommu/intel/iommu.c @@ -299,7 +299,7 @@ static int iommu_skip_te_disable; #define IDENTMAP_AZALIA 4 =20 const struct iommu_ops intel_iommu_ops; -const struct iommu_dirty_ops intel_dirty_ops; +static const struct iommu_dirty_ops intel_dirty_ops; =20 static bool translation_pre_enabled(struct intel_iommu *iommu) { @@ -4929,7 +4929,7 @@ static int intel_iommu_read_and_clear_dirty(struct io= mmu_domain *domain, return 0; } =20 -const struct iommu_dirty_ops intel_dirty_ops =3D { +static const struct iommu_dirty_ops intel_dirty_ops =3D { .set_dirty_tracking =3D intel_iommu_set_dirty_tracking, .read_and_clear_dirty =3D intel_iommu_read_and_clear_dirty, }; --=20 2.34.1