From nobody Wed Dec 17 23:06:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DAD4C5ACB3 for ; Tue, 21 Nov 2023 10:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233832AbjKUKgs (ORCPT ); Tue, 21 Nov 2023 05:36:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233830AbjKUKgm (ORCPT ); Tue, 21 Nov 2023 05:36:42 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3BC9D138 for ; Tue, 21 Nov 2023 02:36:34 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A1583C43391; Tue, 21 Nov 2023 10:36:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700562993; bh=Br1SkmNs2wmxWtCfzlRvkihDMx+ev4HQgVz58LlvuJg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eqM9ioDnWDYdrf47n7Fr+BtuSZC4Gg/CsWiMHkyqPmowW5WVa/Ramv6XL7VXoQvjd 2Vv8xGBifzOwiM2JapDt2wMFF6AarpQtr9G5AAuDYM1zsbaRo7tUhRtpbMrDtfprMG dKEkkfct6vdxIhhrZ8m/3fm72yeTiAqEtPsTgQdKQif6cEnhh6CRrIsm6mLjqZaRjq 3bK4LCrSBYOauRyZSTZLAUoAD6HUrRzradOR604vaD+TZOCmtLzMuoJ2mzJlhoxBq+ n/y9/z0YPsAuhrKn+o/wGZFe1FoCMEGwKjux/V3uNQXhTpa1eU31k/4U9IdckLiqt5 RVCYBp9a68BLw== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: [PATCH 1/6] tty: con3215: drop raw3215_info::ubuffer Date: Tue, 21 Nov 2023 11:36:21 +0100 Message-ID: <20231121103626.17772-2-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231121103626.17772-1-jirislaby@kernel.org> References: <20231121103626.17772-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" clang-struct [1] found raw3215_info::ubuffer unused. It's actually not used since 2004 when we switched to kernel buffers. [1] https://github.com/jirislaby/clang-struct Signed-off-by: Jiri Slaby (SUSE) Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Alexander Gordeev Cc: Christian Borntraeger Cc: Sven Schnelle Cc: linux-s390@vger.kernel.org Acked-by: Alexander Gordeev Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/s390/char/con3215.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c index 99361618c31f..34bc343dcfcc 100644 --- a/drivers/s390/char/con3215.c +++ b/drivers/s390/char/con3215.c @@ -89,7 +89,6 @@ struct raw3215_info { wait_queue_head_t empty_wait; /* wait queue for flushing */ struct timer_list timer; /* timer for delayed output */ int line_pos; /* position on the line (for tabs) */ - char ubuffer[80]; /* copy_from_user buffer */ }; =20 /* array of 3215 devices structures */ --=20 2.42.1 From nobody Wed Dec 17 23:06:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA1EC54FB9 for ; Tue, 21 Nov 2023 10:36:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233896AbjKUKgx (ORCPT ); Tue, 21 Nov 2023 05:36:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233844AbjKUKgm (ORCPT ); Tue, 21 Nov 2023 05:36:42 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 218EB123 for ; Tue, 21 Nov 2023 02:36:36 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A90DC433C9; Tue, 21 Nov 2023 10:36:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700562995; bh=ePkHUZAKxjj2Jg7Kd1bP4Zaca9R79v2WfPvnz48hE58=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nSr8LW23lkduPYNmLdvejeBcSGnX9RJR0zXrL9jAmtu1B5ILBicrMjDEy/tRd+NjK 4lHDLPMlklSJFPU++1VqEuDxFqh5/TAZHGhBMCPDeSLnBTmTh9C3gTNVPdzQAWugto QGz0ZTh+MtevAO69oPRBC/JKG5rjDd1HIQlCzyWmddz7mPRVFJiF27rR5i387P/JTR uVVS8K9ZSpE/Oi0P/vuUhYd1mMT8870Tw+lHIcB7gQtUXVYEX+GDenGe0JJTg/qwYB G4tgTJHIM+esBxeD40Y8/Ik+3m6vxIAAf/r3UpKFmdZS3vD9l0Pem7VT3NfNCLbRxt EgpYsk0KNj1Rg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Jiri Kosina , David Sterba Subject: [PATCH 2/6] tty: ipwireless: remove unused ipw_dev::attribute_memory Date: Tue, 21 Nov 2023 11:36:22 +0100 Message-ID: <20231121103626.17772-3-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231121103626.17772-1-jirislaby@kernel.org> References: <20231121103626.17772-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" clang-struct [1] found ipw_dev::attribute_memory unused. As far as I can see it was never used since the driver merge. Drop it. [1] https://github.com/jirislaby/clang-struct Signed-off-by: Jiri Slaby (SUSE) Cc: Jiri Kosina Cc: David Sterba Acked-by: David Sterba Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/tty/ipwireless/main.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/ipwireless/main.h b/drivers/tty/ipwireless/main.h index 73818bb64416..a5728a5b3f83 100644 --- a/drivers/tty/ipwireless/main.h +++ b/drivers/tty/ipwireless/main.h @@ -49,9 +49,6 @@ struct ipw_dev { =20 void __iomem *common_memory; =20 - /* Reference to attribute memory, containing CIS data */ - void *attribute_memory; - /* Hardware context */ struct ipw_hardware *hardware; /* Network layer context */ --=20 2.42.1 From nobody Wed Dec 17 23:06:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E83BC54FB9 for ; Tue, 21 Nov 2023 10:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233913AbjKUKg4 (ORCPT ); Tue, 21 Nov 2023 05:36:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233850AbjKUKgn (ORCPT ); Tue, 21 Nov 2023 05:36:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9818F199 for ; Tue, 21 Nov 2023 02:36:37 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32D06C433C8; Tue, 21 Nov 2023 10:36:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700562997; bh=FnTt1y4GBgdu68w8crsWeSKtB9fLgimiwg29HboN+SE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=F5+fcHhD47eYBb3BLeAuriqXUEjBh0WQEvFrsS7xm952S9hBAAgUCGcpZ1/NRL+sP QN/cLI2P+Mxt7+gXYvivW+aThT5lBEgY0G28YKGiLXZ/cz7clyWbFaVG+8/Cmgk67P kyGGkyFfriZbJnLyGilv+sOJ/BaS7tH33S337iNmPwI3TlyMfhHgTxAuK4BsZFrTWX 25r9tBqtSpEN+9p7PRKqX7uP/YpqM/S3WAgkaowK/mrT91eENnyeW2y9nEQ9J9cty+ vrYtYq3V1O7anljiFhI83xF4/+HRgSTMP4rMZPb9gfjUwLiupjGmvROCvXSxy6yI26 N0yFz+/RYzucQ== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 3/6] tty: jsm: remove unused members from struct board_ops Date: Tue, 21 Nov 2023 11:36:23 +0100 Message-ID: <20231121103626.17772-4-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231121103626.17772-1-jirislaby@kernel.org> References: <20231121103626.17772-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" clang-struct [1] found board_ops::get_uart_bytes_left() and ::send_immediate_char() unused. Both are only set but never called. And it has been like that since the git history, so drop both the members along with the cls+neo implementations. [1] https://github.com/jirislaby/clang-struct Signed-off-by: Jiri Slaby (SUSE) Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/jsm/jsm.h | 2 -- drivers/tty/serial/jsm/jsm_cls.c | 36 ---------------------------- drivers/tty/serial/jsm/jsm_neo.c | 40 -------------------------------- 3 files changed, 78 deletions(-) diff --git a/drivers/tty/serial/jsm/jsm.h b/drivers/tty/serial/jsm/jsm.h index 8489c07f4cd5..08a42f045ec8 100644 --- a/drivers/tty/serial/jsm/jsm.h +++ b/drivers/tty/serial/jsm/jsm.h @@ -115,8 +115,6 @@ struct board_ops { void (*send_start_character)(struct jsm_channel *ch); void (*send_stop_character)(struct jsm_channel *ch); void (*copy_data_from_queue_to_uart)(struct jsm_channel *ch); - u32 (*get_uart_bytes_left)(struct jsm_channel *ch); - void (*send_immediate_char)(struct jsm_channel *ch, unsigned char); }; =20 =20 diff --git a/drivers/tty/serial/jsm/jsm_cls.c b/drivers/tty/serial/jsm/jsm_= cls.c index 3fd57ac3ad81..1eda48964c0b 100644 --- a/drivers/tty/serial/jsm/jsm_cls.c +++ b/drivers/tty/serial/jsm/jsm_cls.c @@ -877,28 +877,6 @@ static void cls_uart_off(struct jsm_channel *ch) writeb(0, &ch->ch_cls_uart->ier); } =20 -/* - * cls_get_uarts_bytes_left. - * Returns 0 is nothing left in the FIFO, returns 1 otherwise. - * - * The channel lock MUST be held by the calling function. - */ -static u32 cls_get_uart_bytes_left(struct jsm_channel *ch) -{ - u8 left =3D 0; - u8 lsr =3D readb(&ch->ch_cls_uart->lsr); - - /* Determine whether the Transmitter is empty or not */ - if (!(lsr & UART_LSR_TEMT)) - left =3D 1; - else { - ch->ch_flags |=3D (CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM); - left =3D 0; - } - - return left; -} - /* * cls_send_break. * Starts sending a break thru the UART. @@ -916,18 +894,6 @@ static void cls_send_break(struct jsm_channel *ch) } } =20 -/* - * cls_send_immediate_char. - * Sends a specific character as soon as possible to the UART, - * jumping over any bytes that might be in the write queue. - * - * The channel lock MUST be held by the calling function. - */ -static void cls_send_immediate_char(struct jsm_channel *ch, unsigned char = c) -{ - writeb(c, &ch->ch_cls_uart->txrx); -} - struct board_ops jsm_cls_ops =3D { .intr =3D cls_intr, .uart_init =3D cls_uart_init, @@ -943,7 +909,5 @@ struct board_ops jsm_cls_ops =3D { .send_start_character =3D cls_send_start_character, .send_stop_character =3D cls_send_stop_character, .copy_data_from_queue_to_uart =3D cls_copy_data_from_queue_to_uart, - .get_uart_bytes_left =3D cls_get_uart_bytes_left, - .send_immediate_char =3D cls_send_immediate_char }; =20 diff --git a/drivers/tty/serial/jsm/jsm_neo.c b/drivers/tty/serial/jsm/jsm_= neo.c index 2bd640428970..1fa10f19368f 100644 --- a/drivers/tty/serial/jsm/jsm_neo.c +++ b/drivers/tty/serial/jsm/jsm_neo.c @@ -1309,25 +1309,6 @@ static void neo_uart_off(struct jsm_channel *ch) writeb(0, &ch->ch_neo_uart->ier); } =20 -static u32 neo_get_uart_bytes_left(struct jsm_channel *ch) -{ - u8 left =3D 0; - u8 lsr =3D readb(&ch->ch_neo_uart->lsr); - - /* We must cache the LSR as some of the bits get reset once read... */ - ch->ch_cached_lsr |=3D lsr; - - /* Determine whether the Transmitter is empty or not */ - if (!(lsr & UART_LSR_TEMT)) - left =3D 1; - else { - ch->ch_flags |=3D (CH_TX_FIFO_EMPTY | CH_TX_FIFO_LWM); - left =3D 0; - } - - return left; -} - /* Channel lock MUST be held by the calling function! */ static void neo_send_break(struct jsm_channel *ch) { @@ -1348,25 +1329,6 @@ static void neo_send_break(struct jsm_channel *ch) } } =20 -/* - * neo_send_immediate_char. - * - * Sends a specific character as soon as possible to the UART, - * jumping over any bytes that might be in the write queue. - * - * The channel lock MUST be held by the calling function. - */ -static void neo_send_immediate_char(struct jsm_channel *ch, unsigned char = c) -{ - if (!ch) - return; - - writeb(c, &ch->ch_neo_uart->txrx); - - /* flush write operation */ - neo_pci_posting_flush(ch->ch_bd); -} - struct board_ops jsm_neo_ops =3D { .intr =3D neo_intr, .uart_init =3D neo_uart_init, @@ -1382,6 +1344,4 @@ struct board_ops jsm_neo_ops =3D { .send_start_character =3D neo_send_start_character, .send_stop_character =3D neo_send_stop_character, .copy_data_from_queue_to_uart =3D neo_copy_data_from_queue_to_uart, - .get_uart_bytes_left =3D neo_get_uart_bytes_left, - .send_immediate_char =3D neo_send_immediate_char }; --=20 2.42.1 From nobody Wed Dec 17 23:06:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C41C54FB9 for ; Tue, 21 Nov 2023 10:36:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233935AbjKUKg7 (ORCPT ); Tue, 21 Nov 2023 05:36:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233829AbjKUKgo (ORCPT ); Tue, 21 Nov 2023 05:36:44 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E1D9D47 for ; Tue, 21 Nov 2023 02:36:39 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3C6AC433C7; Tue, 21 Nov 2023 10:36:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700562998; bh=gYNUG4npFwZVxiI0KAeDKVJO+CZmchirHrnJPjLRzrg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jL1qGK4L9thFFk/ZGqToKc4xbLb3qHBFTkNCUOSyhwIqdJgLb5SvApx1McOqjqYvY g0ZOaFMWTTczCN+tmQKQP6IV/yhzYFz7NhCl1MbgpUhDrKn3TY0akHXirl261UHQIS Jo1A87sobcOZLNI3+BXQkdco2DpqP31YCUreoRWsOcVsqHw0ESIX7HbIctVAYNwBAL cqC9qAGO2GjfmZdy8EylmCQ7jVzUidC/ygAmDA7xTbOf8nClHVOkf91lFrdcSE5pWh FJBPqDCfyJ/TmHmuV7nxlmZv7XLmfa3Mz2Oykwnaaae49HyDcpein9lPvv4tETyomr R8JsHFKpaAQHg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 4/6] tty: jsm: remove unused struct jsm_board members Date: Tue, 21 Nov 2023 11:36:24 +0100 Message-ID: <20231121103626.17772-5-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231121103626.17772-1-jirislaby@kernel.org> References: <20231121103626.17772-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" clang-struct [1] found jsm_board::type and ::jsm_board_entry unused. ::jsm_board_entry is unused since 614a7d6a76b7 ("fix up newly added jsm dri= ver") ::type was never used as far as I can tell. Even when the driver was introduced in the pre-git era. Remove them both. [1] https://github.com/jirislaby/clang-struct Signed-off-by: Jiri Slaby (SUSE) Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/jsm/jsm.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/tty/serial/jsm/jsm.h b/drivers/tty/serial/jsm/jsm.h index 08a42f045ec8..df55e5dc5afc 100644 --- a/drivers/tty/serial/jsm/jsm.h +++ b/drivers/tty/serial/jsm/jsm.h @@ -125,7 +125,6 @@ struct jsm_board { int boardnum; /* Board number: 0-32 */ =20 - int type; /* Type of board */ u8 rev; /* PCI revision ID */ struct pci_dev *pci_dev; u32 maxports; /* MAX ports this board can handle */ @@ -153,8 +152,6 @@ struct jsm_board u32 bd_dividend; /* Board/UARTs specific dividend */ =20 struct board_ops *bd_ops; - - struct list_head jsm_board_entry; }; =20 /************************************************************************ --=20 2.42.1 From nobody Wed Dec 17 23:06:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65345C54FB9 for ; Tue, 21 Nov 2023 10:37:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231936AbjKUKhB (ORCPT ); Tue, 21 Nov 2023 05:37:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233865AbjKUKgp (ORCPT ); Tue, 21 Nov 2023 05:36:45 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D75B912E for ; Tue, 21 Nov 2023 02:36:40 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40FEDC433C8; Tue, 21 Nov 2023 10:36:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700563000; bh=PIjehP0eqEivg3HZumQKAr0EcmBF9R7CYwR5clAojnM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YgqIBL2Ufsxh1KeTUFZMlePF4h591OjLcG2XY/DJ1xIXlWyOiwEvneE3uNzrZC6cR 3WyAveg2Cn+MOEgafZlZgiDAlKgHb2x2fTM7DHIQjpbraXHYqnI7bZgOK0rpmWEzOT BcS1GX1Bljd0VjLf59ycXDu7ZkYc72GpxpiIAIX8M148G2RZ2jpZXfJqRYmfreITX/ s2uhxrP86wsH98A0bI78KoBQwbzjJ/uJj8Oma2WEmlpu2rMQxJnp/MJLlWW1S75Nv0 zZfYRxIe0VHTv+VyGCI7dhy2IkcJXNfVNhbeRosFyNbNuCYBM1Lu9dRlbWRCGaH3f1 bOlcxpKm3tjFg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Kevin Cernekee Subject: [PATCH 5/6] tty: rp2: remove unused rp2_uart_port::ignore_rx Date: Tue, 21 Nov 2023 11:36:25 +0100 Message-ID: <20231121103626.17772-6-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231121103626.17772-1-jirislaby@kernel.org> References: <20231121103626.17772-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" clang-struct [1] found rp2_uart_port::ignore_rx unused. It was actually never used. Not even in introductory commit 7d9f49afa451 ("serial: rp2: New driver for Comtrol RocketPort 2 cards"). [1] https://github.com/jirislaby/clang-struct Signed-off-by: Jiri Slaby (SUSE) Cc: Kevin Cernekee Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/rp2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/tty/serial/rp2.c b/drivers/tty/serial/rp2.c index d46a81cddfcd..4132fcff7d4e 100644 --- a/drivers/tty/serial/rp2.c +++ b/drivers/tty/serial/rp2.c @@ -178,7 +178,6 @@ struct rp2_card; struct rp2_uart_port { struct uart_port port; int idx; - int ignore_rx; struct rp2_card *card; void __iomem *asic_base; void __iomem *base; --=20 2.42.1 From nobody Wed Dec 17 23:06:57 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88196C54FB9 for ; Tue, 21 Nov 2023 10:37:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233958AbjKUKhG (ORCPT ); Tue, 21 Nov 2023 05:37:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42936 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233817AbjKUKgr (ORCPT ); Tue, 21 Nov 2023 05:36:47 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A34F18C for ; Tue, 21 Nov 2023 02:36:42 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EF5FEC433C7; Tue, 21 Nov 2023 10:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700563002; bh=ZUbsMm06fEd3nF1lhwAHhD7S+m2Uiy8kDq+uaKpBn3o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DJS2/TLHg6Kc6CyARmWS+Z7QYMmd2Rx11qBg83meZSGR0y4cUwo3RvTZ0oX8WedYS 4zy5ksaJWE73HiL/d6Ig+JtZJ2t6G5tXuJcIoR5Re2O1NAqPe4XfP4h59EiU5I++Xj 4ImSAzcq2ucVD6OeHSAASpOVnsH0i+PP13ApE+691H+lgrUfZ/kxQWBepxWU+lRV9L /bouSem61tHv6tiUZ7//5f7/2fExefTtU0s7cmbE7LTwI8s1OGSeEie0QR/wphEv2o qaqPIk5exwAYZzuV9Q0Kyro0FbtTE2c/ZxMaX03CAAkvePf2t5QIyfn/Bn2iZHonMy FaOscFZQbSyLA== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" Subject: [PATCH 6/6] tty: serial_cs: remove unused struct serial_cfg_mem Date: Tue, 21 Nov 2023 11:36:26 +0100 Message-ID: <20231121103626.17772-7-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231121103626.17772-1-jirislaby@kernel.org> References: <20231121103626.17772-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" clang-struct [1] found struct serial_cfg_mem's members unused. In fact, the whole structure is unused since commit 6ae3b84d9793 ("serial_cs: use pcmcia_loop_config() and pre-determined values"). Drop it completely. [1] https://github.com/jirislaby/clang-struct Signed-off-by: Jiri Slaby (SUSE) Reviewed-by: Ilpo J=C3=A4rvinen --- drivers/tty/serial/8250/serial_cs.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/tty/serial/8250/serial_cs.c b/drivers/tty/serial/8250/= serial_cs.c index dc2ef05a10eb..2056aed46688 100644 --- a/drivers/tty/serial/8250/serial_cs.c +++ b/drivers/tty/serial/8250/serial_cs.c @@ -90,12 +90,6 @@ struct serial_info { const struct serial_quirk *quirk; }; =20 -struct serial_cfg_mem { - tuple_t tuple; - cisparse_t parse; - u_char buf[256]; -}; - /* * vers_1 5.0, "Brain Boxes", "2-Port RS232 card", "r6" * manfid 0x0160, 0x0104 --=20 2.42.1