From nobody Fri Dec 19 07:31:04 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D241C54FB9 for ; Tue, 21 Nov 2023 09:24:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233655AbjKUJYd (ORCPT ); Tue, 21 Nov 2023 04:24:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233647AbjKUJYK (ORCPT ); Tue, 21 Nov 2023 04:24:10 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2944198C for ; Tue, 21 Nov 2023 01:23:37 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84493C43391; Tue, 21 Nov 2023 09:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700558616; bh=1JqdGOcikIPraOhThJZ+ThwFEn9EMyadPHMefXFawKA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GUk3Q4MvpshxkULe4lihbL6fp+6TMQE2/jtMr44SuJZ4LsOSpjitlpSNDxWxryXBy S4leJUUt9h8blyDWxlpADZz2Wa0wuUJ9jQgyrSGrVywVDWmEVOnkpshjg6JGNkjJHm mpS9NIvi0zMTNdFEKoE3pwQDZB0ALDHfKHvkCn+GfJMRcZL5KJCchRW4i/yQxfNU06 Y2E2OixT655d+J+FJ2V6EPCdHDqgbA0kE+Uz375JLkTXB1C8nlvuvqpsWdYfrV+NWM fGnS0Mar/blbmEdtbwmgaSi5clQ4DxA6E4GEV/V4WvTOKnfbYsgw4N+U9nY89rJ6Wc euopvwHEcIOJg== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org Subject: [PATCH 17/17] tty: srmcons: make 'str_cr' const and non-array Date: Tue, 21 Nov 2023 10:22:58 +0100 Message-ID: <20231121092258.9334-18-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231121092258.9334-1-jirislaby@kernel.org> References: <20231121092258.9334-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" 'str_cr' contains a single character: \n. There is no need to declare it as array. Declare it as a variable, make it const and pass a pointer to it to callback_puts(). Signed-off-by: Jiri Slaby (SUSE) Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: linux-alpha@vger.kernel.org Reviewed-by: Ilpo J=C3=A4rvinen --- arch/alpha/kernel/srmcons.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/alpha/kernel/srmcons.c b/arch/alpha/kernel/srmcons.c index c6b821afbfd3..a6cff61706b5 100644 --- a/arch/alpha/kernel/srmcons.c +++ b/arch/alpha/kernel/srmcons.c @@ -91,7 +91,7 @@ srmcons_receive_chars(struct timer_list *t) static void srmcons_do_write(struct tty_port *port, const char *buf, int count) { - static char str_cr[1] =3D "\r"; + static const char str_cr =3D '\r'; size_t c; srmcons_result result; =20 @@ -119,7 +119,7 @@ srmcons_do_write(struct tty_port *port, const char *buf= , int count) } =20 while (need_cr) { - result.as_long =3D callback_puts(0, str_cr, 1); + result.as_long =3D callback_puts(0, &str_cr, 1); if (result.bits.c > 0) need_cr =3D false; } --=20 2.42.1