From nobody Fri Dec 19 07:31:04 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F2C6C54FB9 for ; Tue, 21 Nov 2023 09:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233651AbjKUJYK (ORCPT ); Tue, 21 Nov 2023 04:24:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233655AbjKUJXs (ORCPT ); Tue, 21 Nov 2023 04:23:48 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A96FB10E7 for ; Tue, 21 Nov 2023 01:23:27 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 841C4C433AB; Tue, 21 Nov 2023 09:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700558607; bh=A+gwjfR1YZFEn//O7QquhnOOdPgWP51q1cNT1xEbGz8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PCcVQCueYuWyDY4P/DEB7ksJqQttXRDIPuOZ7d1S9t+TY1NrMTLU+chfM1S6vlv+p WBd57pcx7EOKaym2OQcNLU7UHsd+qb/aAAsDtIkFG6hIChg838AvK6hstPgL1gFiLN FiXQmY6zoCqEKQPuyPESrYNhXJ6NsQb1ojKzz50bJUjUKJxAXZW0fYqvLaFHkEjCBp LSTeR5/RUtifDRKwQmwM+896CIvlaUn8mg8TS0FPcDdLxOxd+K9Lo7jqqeytBxSkHY qaJn/aoW6NRZPIMKquDInl67DpFnQFfRKdSx15MeAGPSiwYZxY8lvB2AnsUOJ8XAyb +0Nmw/Pstmt6Q== From: "Jiri Slaby (SUSE)" To: gregkh@linuxfoundation.org Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, "Jiri Slaby (SUSE)" , Richard Henderson , Ivan Kokshaysky , Matt Turner , linux-alpha@vger.kernel.org Subject: [PATCH 13/17] tty: srmcons: use 'buf' directly in srmcons_do_write() Date: Tue, 21 Nov 2023 10:22:54 +0100 Message-ID: <20231121092258.9334-14-jirislaby@kernel.org> X-Mailer: git-send-email 2.42.1 In-Reply-To: <20231121092258.9334-1-jirislaby@kernel.org> References: <20231121092258.9334-1-jirislaby@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" There is no need to have a separate iterator ('cur') through 'buf' in srmcons_do_write(). 'buf' can be used directly which simplifies the code a bit. Signed-off-by: Jiri Slaby (SUSE) Cc: Richard Henderson Cc: Ivan Kokshaysky Cc: Matt Turner Cc: linux-alpha@vger.kernel.org Reviewed-by: Richard Henderson --- arch/alpha/kernel/srmcons.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/arch/alpha/kernel/srmcons.c b/arch/alpha/kernel/srmcons.c index d6139dbae4ac..b68c5af083cd 100644 --- a/arch/alpha/kernel/srmcons.c +++ b/arch/alpha/kernel/srmcons.c @@ -94,24 +94,23 @@ srmcons_do_write(struct tty_port *port, const char *buf= , int count) static char str_cr[1] =3D "\r"; long c, remaining =3D count; srmcons_result result; - char *cur; int need_cr; =20 - for (cur =3D (char *)buf; remaining > 0; ) { + while (remaining > 0) { need_cr =3D 0; /*=20 * Break it up into reasonable size chunks to allow a chance * for input to get in */ for (c =3D 0; c < min_t(long, 128L, remaining) && !need_cr; c++) - if (cur[c] =3D=3D '\n') + if (buf[c] =3D=3D '\n') need_cr =3D 1; =09 while (c > 0) { - result.as_long =3D callback_puts(0, cur, c); + result.as_long =3D callback_puts(0, buf, c); c -=3D result.bits.c; remaining -=3D result.bits.c; - cur +=3D result.bits.c; + buf +=3D result.bits.c; =20 /* * Check for pending input iff a tty port was provided --=20 2.42.1