From nobody Thu Dec 18 18:09:22 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5349BC2BB3F for ; Mon, 20 Nov 2023 23:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232671AbjKTXvr (ORCPT ); Mon, 20 Nov 2023 18:51:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232590AbjKTXvm (ORCPT ); Mon, 20 Nov 2023 18:51:42 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 842F0C7 for ; Mon, 20 Nov 2023 15:51:39 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 25666C433C8; Mon, 20 Nov 2023 23:51:39 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.97-RC3) (envelope-from ) id 1r5E3W-00000002Po8-2Nff; Mon, 20 Nov 2023 18:51:54 -0500 Message-ID: <20231120235154.422970988@goodmis.org> User-Agent: quilt/0.67 Date: Mon, 20 Nov 2023 18:51:07 -0500 From: Steven Rostedt To: linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Naresh Kamboju , Linux Kernel Functional Testing Subject: [PATCH 2/2] eventfs: Do not invalidate dentry in create_file/dir_dentry() References: <20231120235105.834774147@goodmis.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: "Steven Rostedt (Google)" With the call to simple_recursive_removal() on the entire eventfs sub system when the directory is removed, it performs the d_invalidate on all the dentries when it is removed. There's no need to do clean ups when a dentry is being created while the directory is being deleted. As dentries are cleaned up by the simpler_recursive_removal(), trying to do d_invalidate() in these functions will cause the dentry to be invalidated twice, and crash the kernel. Link: https://lore.kernel.org/all/20231116123016.140576-1-naresh.kamboju@li= naro.org/ Fixes: 407c6726ca71 ("eventfs: Use simple_recursive_removal() to clean up d= entries") Reported-by: Mark Rutland Reported-by: Naresh Kamboju Reported-by: Linux Kernel Functional Testing Signed-off-by: Steven Rostedt (Google) --- fs/tracefs/event_inode.c | 19 ++++++------------- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index f239b2b507a4..3eb6c622a74d 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -326,7 +326,6 @@ create_file_dentry(struct eventfs_inode *ei, int idx, struct eventfs_attr *attr =3D NULL; struct dentry **e_dentry =3D &ei->d_children[idx]; struct dentry *dentry; - bool invalidate =3D false; =20 mutex_lock(&eventfs_mutex); if (ei->is_freed) { @@ -389,17 +388,14 @@ create_file_dentry(struct eventfs_inode *ei, int idx, * Otherwise it means two dentries exist with the same name. */ WARN_ON_ONCE(!ei->is_freed); - invalidate =3D true; + dentry =3D NULL; } mutex_unlock(&eventfs_mutex); =20 - if (invalidate) - d_invalidate(dentry); - - if (lookup || invalidate) + if (lookup) dput(dentry); =20 - return invalidate ? NULL : dentry; + return dentry; } =20 /** @@ -439,7 +435,6 @@ static struct dentry * create_dir_dentry(struct eventfs_inode *pei, struct eventfs_inode *ei, struct dentry *parent, bool lookup) { - bool invalidate =3D false; struct dentry *dentry =3D NULL; =20 mutex_lock(&eventfs_mutex); @@ -495,16 +490,14 @@ create_dir_dentry(struct eventfs_inode *pei, struct e= ventfs_inode *ei, * Otherwise it means two dentries exist with the same name. */ WARN_ON_ONCE(!ei->is_freed); - invalidate =3D true; + dentry =3D NULL; } mutex_unlock(&eventfs_mutex); - if (invalidate) - d_invalidate(dentry); =20 - if (lookup || invalidate) + if (lookup) dput(dentry); =20 - return invalidate ? NULL : dentry; + return dentry; } =20 /** --=20 2.42.0