From nobody Thu Dec 18 07:21:06 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3764C54FB9 for ; Mon, 20 Nov 2023 08:54:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232412AbjKTIyV (ORCPT ); Mon, 20 Nov 2023 03:54:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232268AbjKTIyS (ORCPT ); Mon, 20 Nov 2023 03:54:18 -0500 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 889A49F; Mon, 20 Nov 2023 00:54:14 -0800 (PST) Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id 9910763394DBD; Mon, 20 Nov 2023 16:54:05 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: tomas.winkler@intel.com, arnd@arndb.de, gregkh@linuxfoundation.org, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com Cc: Su Hui , alexander.usyskin@intel.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: [PATCH] misc: mei: client.c: fix some error code problem in mei_cl_write Date: Mon, 20 Nov 2023 16:53:45 +0800 Message-Id: <20231120085343.157381-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Clang static analyzer complains that value stored to 'rets' is never read. Remove some useless code, and let 'buf_len =3D -EOVERFLOW' to make sure we can return '-EOVERFLOW'. mei_msg_hdr_init() return negative error code, rets should be 'PTR_ERR(mei_hdr)' rather than '-PTR_ERR(mei_hdr)'. Fixes: 0cd7c01a60f8 ("mei: add support for mei extended header.") Fixes: 8c8d964ce90f ("mei: move hbuf_depth from the mei device to the hw mo= dules") Signed-off-by: Su Hui --- drivers/misc/mei/client.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c index 9c8fc87938a7..00dac0a47da0 100644 --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -2011,7 +2011,7 @@ ssize_t mei_cl_write(struct mei_cl *cl, struct mei_cl= _cb *cb, unsigned long time =20 mei_hdr =3D mei_msg_hdr_init(cb); if (IS_ERR(mei_hdr)) { - rets =3D -PTR_ERR(mei_hdr); + rets =3D PTR_ERR(mei_hdr); mei_hdr =3D NULL; goto err; } @@ -2020,19 +2020,17 @@ ssize_t mei_cl_write(struct mei_cl *cl, struct mei_= cl_cb *cb, unsigned long time =20 if (rets =3D=3D 0) { cl_dbg(dev, cl, "No flow control credentials: not sending.\n"); - rets =3D buf_len; goto out; } =20 if (!mei_hbuf_acquire(dev)) { cl_dbg(dev, cl, "Cannot acquire the host buffer: not sending.\n"); - rets =3D buf_len; goto out; } =20 hbuf_slots =3D mei_hbuf_empty_slots(dev); if (hbuf_slots < 0) { - rets =3D -EOVERFLOW; + buf_len =3D -EOVERFLOW; goto out; } =20 --=20 2.30.2