From nobody Tue Dec 30 08:11:19 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57EA4C5AD4C for ; Fri, 17 Nov 2023 16:44:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346121AbjKQQoh (ORCPT ); Fri, 17 Nov 2023 11:44:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231803AbjKQQof (ORCPT ); Fri, 17 Nov 2023 11:44:35 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 529B9A4; Fri, 17 Nov 2023 08:44:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700239472; x=1731775472; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=eIGdtsz/mNJhff6NvN0ClvX0hucp+LPmBNcUNRv5aF4=; b=A7m3wehVUjPCIEh2YFR44fEEZecUFMH9lS/yhKFa8X+QCKHnF0By8x+K OOMbK3bmWGjOuqJI+c2B+4oRzN+urC4G6mUHB5XeIBHadcleTJXg+DMy1 kDECHCmV8EmDoLMvsHddIWkXvYJvFFDF0ANLg4Uy8cALdK1hCLJFkFDjK +hQsV8Odh2mvdlthOlN2rw+l54x7L/TXLIg1/uYPCIjEt2IuHW22//NYs jLoOZGf6/VXPauBmt5f4BeDP8O0A1q//lYpJEXUU7Ykhp5EffBojykqdI SuCMLCsEdsUDur84i/9jDYiDaxSQiif3zTdncTzYk4PSYxpvMjA8jMeWg w==; X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="395255358" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="395255358" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 08:44:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10897"; a="759222042" X-IronPort-AV: E=Sophos;i="6.04,206,1695711600"; d="scan'208";a="759222042" Received: from sbahadur1-bxdsw.sj.intel.com ([10.232.237.139]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2023 08:44:31 -0800 From: Sachin Bahadur To: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH iwl-net v3] ice: Block PF reinit if attached to bond Date: Fri, 17 Nov 2023 08:44:27 -0800 Message-Id: <20231117164427.912563-1-sachin.bahadur@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" PF interface part of LAG should not allow driver reinit via devlink. The Bond config will be lost due to driver reinit. ice_devlink_reload_down is called before PF driver reinit. If PF is attached to bond, ice_devlink_reload_down returns error. Fixes: trailer Reviewed-by: Jacob Keller Signed-off-by: Sachin Bahadur --- drivers/net/ethernet/intel/ice/ice_devlink.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/intel/ice/ice_devlink.c b/drivers/net/eth= ernet/intel/ice/ice_devlink.c index f4e24d11ebd0..5fe88e949b09 100644 --- a/drivers/net/ethernet/intel/ice/ice_devlink.c +++ b/drivers/net/ethernet/intel/ice/ice_devlink.c @@ -457,6 +457,10 @@ ice_devlink_reload_down(struct devlink *devlink, bool = netns_change, "Remove all VFs before doing reinit\n"); return -EOPNOTSUPP; } + if (pf->lag && pf->lag->bonded) { + NL_SET_ERR_MSG_MOD(extack, "Remove all associated Bonds before doing re= init"); + return -EBUSY; + } ice_unload(pf); return 0; case DEVLINK_RELOAD_ACTION_FW_ACTIVATE: --=20 2.25.1