From nobody Tue Dec 30 15:15:15 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D20C9C4332F for ; Tue, 14 Nov 2023 09:38:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232526AbjKNJi2 (ORCPT ); Tue, 14 Nov 2023 04:38:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232245AbjKNJi1 (ORCPT ); Tue, 14 Nov 2023 04:38:27 -0500 Received: from cmccmta2.chinamobile.com (cmccmta6.chinamobile.com [111.22.67.139]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 288C418E; Tue, 14 Nov 2023 01:38:20 -0800 (PST) X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from spf.mail.chinamobile.com (unknown[10.188.0.87]) by rmmx-syy-dmz-app05-12005 (RichMail) with SMTP id 2ee565534009c5c-d14fe; Tue, 14 Nov 2023 17:38:17 +0800 (CST) X-RM-TRANSID: 2ee565534009c5c-d14fe X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from ubuntu.localdomain (unknown[10.54.5.255]) by rmsmtp-syy-appsvr05-12005 (RichMail) with SMTP id 2ee565534008686-5bf03; Tue, 14 Nov 2023 17:38:17 +0800 (CST) X-RM-TRANSID: 2ee565534008686-5bf03 From: zhujun2 To: shuah@kernel.org Cc: mathieu.desnoyers@efficios.com, zhujun2@cmss.chinamobile.com, ivan.orlov0322@gmail.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] selftests/media_tests: fix a resource leak Date: Tue, 14 Nov 2023 01:38:12 -0800 Message-Id: <20231114093812.7169-1-zhujun2@cmss.chinamobile.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 --- tools/testing/selftests/media_tests/media_device_open.c | 3 +++ tools/testing/selftests/media_tests/media_device_test.c | 3 +++ 2 files changed, 6 insertions(+) diff --git a/tools/testing/selftests/media_tests/media_device_open.c b/tool= s/testing/selftests/media_tests/media_device_open.c index 93183a37b133..2dfb2a11b148 100644 --- a/tools/testing/selftests/media_tests/media_device_open.c +++ b/tools/testing/selftests/media_tests/media_device_open.c @@ -70,6 +70,7 @@ int main(int argc, char **argv) fd =3D open(media_device, O_RDWR); if (fd =3D=3D -1) { printf("Media Device open errno %s\n", strerror(errno)); + close(fd); exit(-1); } =20 @@ -79,4 +80,6 @@ int main(int argc, char **argv) else printf("Media device model %s driver %s\n", mdi.model, mdi.driver); + + close(fd); } diff --git a/tools/testing/selftests/media_tests/media_device_test.c b/tool= s/testing/selftests/media_tests/media_device_test.c index 4b9953359e40..7cabb62535a7 100644 --- a/tools/testing/selftests/media_tests/media_device_test.c +++ b/tools/testing/selftests/media_tests/media_device_test.c @@ -79,6 +79,7 @@ int main(int argc, char **argv) fd =3D open(media_device, O_RDWR); if (fd =3D=3D -1) { printf("Media Device open errno %s\n", strerror(errno)); + close(fd); exit(-1); } =20 @@ -100,4 +101,6 @@ int main(int argc, char **argv) sleep(10); count--; } + + close(fd); } --=20 2.17.1