From nobody Wed Dec 31 00:42:56 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E04FC4167B for ; Sun, 12 Nov 2023 15:49:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231793AbjKLPtD (ORCPT ); Sun, 12 Nov 2023 10:49:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231640AbjKLPtB (ORCPT ); Sun, 12 Nov 2023 10:49:01 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C55082D6B; Sun, 12 Nov 2023 07:48:52 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C892EC433C7; Sun, 12 Nov 2023 15:48:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699804131; bh=/sz/PYVhkf2zzxhQ2AS2MPuC1i3bcGRyoZgRgbl0yvs=; h=From:To:Cc:Subject:Date:From; b=TYAtmcL5h5sHj8mFc51TxEbSrMgm7wg4xNuYEWAnXe1WInTzUE1FiIRCicrApwSMM UiW3q+us+Coh6Q/DFhVy3HGXkvxliycyngczJRVMPESmDkZGQ8Y/texneGFPTp/r6T eXBjv5fNBdkmZ9438Nh1l3mmnbtsuCEiGBpdmfe6+68F45IRpNq6ALItMOCjAJhcJx gVnmZTklLhBnpE3DYVLtwMZex1Avw4tK5AAqOXvdS9HrM08RL76JmEmS6nJYgyP2or ncTmKrP4GR7qRgfCRPf4hGPgmO6hqN8Qh0MOafpc4m5XIow9O8siR6HbXPo1MztygW 5ZVxAivs/iqQg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Philipp Stanner , Dave Airlie , Wolfram Sang , Sasha Levin , linux-i2c@vger.kernel.org Subject: [PATCH AUTOSEL 5.4] i2c: dev: copy userspace array safely Date: Sun, 12 Nov 2023 10:48:48 -0500 Message-ID: <20231112154848.229338-1-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.260 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Philipp Stanner [ Upstream commit cc9c54232f04aef3a5d7f64a0ece7df00f1aaa3d ] i2c-dev.c utilizes memdup_user() to copy a userspace array. This is done without an overflow check. Use the new wrapper memdup_array_user() to copy the array more safely. Suggested-by: Dave Airlie Signed-off-by: Philipp Stanner Signed-off-by: Wolfram Sang Signed-off-by: Sasha Levin --- drivers/i2c/i2c-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/i2c-dev.c b/drivers/i2c/i2c-dev.c index 7da6ca26a5f56..5669c8b56b264 100644 --- a/drivers/i2c/i2c-dev.c +++ b/drivers/i2c/i2c-dev.c @@ -451,8 +451,8 @@ static long i2cdev_ioctl(struct file *file, unsigned in= t cmd, unsigned long arg) if (rdwr_arg.nmsgs > I2C_RDWR_IOCTL_MAX_MSGS) return -EINVAL; =20 - rdwr_pa =3D memdup_user(rdwr_arg.msgs, - rdwr_arg.nmsgs * sizeof(struct i2c_msg)); + rdwr_pa =3D memdup_array_user(rdwr_arg.msgs, + rdwr_arg.nmsgs, sizeof(struct i2c_msg)); if (IS_ERR(rdwr_pa)) return PTR_ERR(rdwr_pa); =20 --=20 2.42.0