From nobody Wed Dec 31 02:41:50 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9607C4332F for ; Sat, 11 Nov 2023 15:45:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231284AbjKKPo3 (ORCPT ); Sat, 11 Nov 2023 10:44:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229797AbjKKPo2 (ORCPT ); Sat, 11 Nov 2023 10:44:28 -0500 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D9B42C4 for ; Sat, 11 Nov 2023 07:44:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699717465; x=1731253465; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=N61T92yXfW/0ymwwtf27YmFi1YNwp0sVTZf9lYAfMjs=; b=W4nnjKy0HjX7OauSEfM8WL7b1UuhphDf5/Wo1y/Q4V2NwdGxidMSDuRJ FsNxhOlfrBRKrUeKbIq3S+OkxeYn9h4xpx2DiDow66VNc3HcWllUymToV Txay3P6hlw5qIlbqqwORCZlSDE5DCNu2MPO5Gjo2rxJrZevbkkFFPfHdq x7np/wbGJSnhfwzwbAeK3FpqcZixeqXY2sw9NNy2s0tZaJkGyAgkdRdRU 8o1DQqgBCdAxdWbHO1LMtVj1sMdEOBqfK7ELZj5y2nEcSSFmNcfkYZzBq WnXXit5/xfHeqscIZnxWtEcEMc0HSw3Zl2+BwT1IhpRYAJeg0LtYrsKag A==; X-IronPort-AV: E=McAfee;i="6600,9927,10891"; a="11833007" X-IronPort-AV: E=Sophos;i="6.03,295,1694761200"; d="scan'208";a="11833007" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2023 07:44:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10891"; a="1095392438" X-IronPort-AV: E=Sophos;i="6.03,295,1694761200"; d="scan'208";a="1095392438" Received: from chenyu-dev.sh.intel.com ([10.239.62.164]) by fmsmga005.fm.intel.com with ESMTP; 11 Nov 2023 07:44:22 -0800 From: Chen Yu To: Peter Zijlstra , Ingo Molnar , Vincent Guittot , Juri Lelli Cc: linux-kernel@vger.kernel.org, Chen Yu Subject: [PATCH] sched/fair: Remove unnecessary 'curr' reset for pick_next_entity() Date: Sat, 11 Nov 2023 23:43:18 +0800 Message-Id: <20231111154318.87777-1-yu.c.chen@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" After commit 4c456c9ad334 ("sched/fair: Remove unused 'curr' argument from pick_next_entity()"), there is no need to reset 'curr' to NULL because it will not be used by pick_next_entity(). Signed-off-by: Chen Yu --- kernel/sched/fair.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 2048138ce54b..ddea1be43710 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -8198,8 +8198,6 @@ static struct task_struct *pick_task_fair(struct rq *= rq) if (curr) { if (curr->on_rq) update_curr(cfs_rq); - else - curr =3D NULL; =20 if (unlikely(check_cfs_rq_runtime(cfs_rq))) goto again; @@ -8249,8 +8247,6 @@ pick_next_task_fair(struct rq *rq, struct task_struct= *prev, struct rq_flags *rf if (curr) { if (curr->on_rq) update_curr(cfs_rq); - else - curr =3D NULL; =20 /* * This call to check_cfs_rq_runtime() will do the --=20 2.25.1