From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF7EEC4167B for ; Thu, 9 Nov 2023 20:29:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345183AbjKIU3P (ORCPT ); Thu, 9 Nov 2023 15:29:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345176AbjKIU3N (ORCPT ); Thu, 9 Nov 2023 15:29:13 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD42844BB for ; Thu, 9 Nov 2023 12:29:10 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeE-0002zX-SK; Thu, 09 Nov 2023 21:29:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeC-007rWX-Qx; Thu, 09 Nov 2023 21:29:04 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeC-00GGtP-Ht; Thu, 09 Nov 2023 21:29:04 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Jay Fang , Arnd Bergmann Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 01/12] bus: hisi_lpc: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:31 +0100 Message-ID: <20231109202830.4124591-2-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1825; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5AZNdjzJwHWz0slz9MDShONzNbivb6y7QJLchsJRFkk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUDvHN/cjdII1SSU5qZzP2524CDEuqVPHLnD/ Y6lU3Vv1juJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A7wAKCRCPgPtYfRL+ Tm9GB/4mE4RwhXz/CyJzR+mFdS6oldaSkbL0ziI1WpRhyQ6mwKF/uE6Qo6k1XGeUkLiNB2RpB5y Sf4DUeGKHwECLJ/rQ3kKPhpGO2oQN/vtmSOdpc65EpFHWKyEAXFkZ7oKUcbfB+rPptiXo3wQNQo hXzMJwssCkrtmN9NC43lra1MU+qoiD2glFkZi1E7gZLqEWXE+Qntxj4PSN++zWE3NaQiz0xl64B CxD6XrIOhPPWRvpQeUQcP7lkBVBifyr0b4HiSsg2zBfXQawRh7RAn2Tsj1BPxFyi9VihJq9yawf hpGsLG6K24/LN1y1bAgmcOefWFkl7kjiaD+FFduSWidFV7Pg X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. --- drivers/bus/hisi_lpc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/hisi_lpc.c b/drivers/bus/hisi_lpc.c index cdc4e38c113e..09340adbacc2 100644 --- a/drivers/bus/hisi_lpc.c +++ b/drivers/bus/hisi_lpc.c @@ -657,7 +657,7 @@ static int hisi_lpc_probe(struct platform_device *pdev) return ret; } =20 -static int hisi_lpc_remove(struct platform_device *pdev) +static void hisi_lpc_remove(struct platform_device *pdev) { struct device *dev =3D &pdev->dev; struct hisi_lpc_dev *lpcdev =3D dev_get_drvdata(dev); @@ -669,8 +669,6 @@ static int hisi_lpc_remove(struct platform_device *pdev) of_platform_depopulate(dev); =20 logic_pio_unregister_range(range); - - return 0; } =20 static const struct of_device_id hisi_lpc_of_match[] =3D { @@ -691,6 +689,6 @@ static struct platform_driver hisi_lpc_driver =3D { .acpi_match_table =3D hisi_lpc_acpi_match, }, .probe =3D hisi_lpc_probe, - .remove =3D hisi_lpc_remove, + .remove_new =3D hisi_lpc_remove, }; builtin_platform_driver(hisi_lpc_driver); --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FBF7C4332F for ; Thu, 9 Nov 2023 20:29:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345167AbjKIU3L (ORCPT ); Thu, 9 Nov 2023 15:29:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345159AbjKIU3J (ORCPT ); Thu, 9 Nov 2023 15:29:09 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1637544B6 for ; Thu, 9 Nov 2023 12:29:07 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeD-0002ze-Gr; Thu, 09 Nov 2023 21:29:05 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeD-007rWa-1m; Thu, 09 Nov 2023 21:29:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeC-00GGtT-Oq; Thu, 09 Nov 2023 21:29:04 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 02/12] bus: omap-ocp2scp: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:32 +0100 Message-ID: <20231109202830.4124591-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1751; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=FFKpIApq6M4HDMVMY1N4u4aY2zqamgYSCbjMD8II194=; b=owGbwMvMwMXY3/A7olbonx/jabUkhlRfhw/3I82cxO40Xj0o6Stap2DN4aX/8m24xqyYvLgP7 48suvCjk9GYhYGRi0FWTJHFvnFNplWVXGTn2n+XYQaxMoFMYeDiFICJHIrnYJiq6rqXJ1rUS6xR iOs/X88Ef1a1Cecdlxet4JzzoOXc4X1HOHUOOEp9kDc1/6PbyZtyImj/qzLJe95nRX3Ocv5/t9V rSh3HRu9XZowx5xZPl+WJV++pP9S91OjlqXLu35HpLsFuk+1NvU7Zzk3ynfq5yimT72XhreQei8 Pp4s2WGbE3eM1ltl1sCzt7bIFHtT3jew7P1Gzz8jVsua4NVywda6bu/v4t9GfDuotnJW+vMdmck r76RXjBco/wn1bLL2hXfO16kerab1M3zcUo5Oj2Kt7p3q/1+6zspUre+ctZ3GOJMam7EXM+a3X6 3vcNduw3G9ick+1V33Rxrdo4ycqt5PmPtgv5Bacjbs0DAA== X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. --- drivers/bus/omap-ocp2scp.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/omap-ocp2scp.c b/drivers/bus/omap-ocp2scp.c index e02d0656242b..7d7479ba0a75 100644 --- a/drivers/bus/omap-ocp2scp.c +++ b/drivers/bus/omap-ocp2scp.c @@ -84,12 +84,10 @@ static int omap_ocp2scp_probe(struct platform_device *p= dev) return ret; } =20 -static int omap_ocp2scp_remove(struct platform_device *pdev) +static void omap_ocp2scp_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); device_for_each_child(&pdev->dev, NULL, ocp2scp_remove_devices); - - return 0; } =20 #ifdef CONFIG_OF @@ -103,7 +101,7 @@ MODULE_DEVICE_TABLE(of, omap_ocp2scp_id_table); =20 static struct platform_driver omap_ocp2scp_driver =3D { .probe =3D omap_ocp2scp_probe, - .remove =3D omap_ocp2scp_remove, + .remove_new =3D omap_ocp2scp_remove, .driver =3D { .name =3D "omap-ocp2scp", .of_match_table =3D of_match_ptr(omap_ocp2scp_id_table), --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CC83C4167D for ; Thu, 9 Nov 2023 20:29:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345268AbjKIU3d (ORCPT ); Thu, 9 Nov 2023 15:29:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345220AbjKIU3V (ORCPT ); Thu, 9 Nov 2023 15:29:21 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41A92468F for ; Thu, 9 Nov 2023 12:29:15 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeD-0002zf-W9; Thu, 09 Nov 2023 21:29:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeD-007rWd-8G; Thu, 09 Nov 2023 21:29:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeC-00GGtX-VE; Thu, 09 Nov 2023 21:29:04 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Rob Herring , Jernej Skrabec , Laurentiu Tudor , Arnd Bergmann , Tony Lindgren , "Sicelo A. Mhlongo" Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 03/12] bus: omap_l3_smx: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:33 +0100 Message-ID: <20231109202830.4124591-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1746; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=zgJm1dlc/UlSS9zetmH5GbvsuMr4qHT3lQphrWzkAzU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUDyw8liF78LWnyhFZLru8PNsGZ1t5BmeLGyf 0BHYx1oYjSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A8gAKCRCPgPtYfRL+ TtsSB/4lgGCQ+t/mONA1F+XnD+DFwmTvwvTCbxyBHsoJ9uUpV+auNZ5K0B0WlzVfMqqDDQWazys Oewf+G4tvcZn3Cr/r7I65OEGZpM/A2wwR6DOr0Vxk49ASXpiik5DaTqrK0sBvMGD4Cpq5B2dFdC 9GTXCisMJb2Ocbbj7ssV5uKEl21yMzv+10pPDCwTLMmLXUk9s5aUB6nL/6o8knNMuPZEDLcmok8 RSuR67bbgUapNxOYgWFwZ9qu6Ra3XHKQlOiCLXQwroe4VqIEG/QCSm+7pGl1fkvC3rZKywWMKq9 185Eh8d+I+slva1fnPV5DRZvTdkYBaIESmhNSzh4SMNuOBs+ X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. Reviewed-by: Tony Lindgren --- drivers/bus/omap_l3_smx.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/omap_l3_smx.c b/drivers/bus/omap_l3_smx.c index 31774648be9d..ee6d29925e4d 100644 --- a/drivers/bus/omap_l3_smx.c +++ b/drivers/bus/omap_l3_smx.c @@ -261,7 +261,7 @@ static int omap3_l3_probe(struct platform_device *pdev) return ret; } =20 -static int omap3_l3_remove(struct platform_device *pdev) +static void omap3_l3_remove(struct platform_device *pdev) { struct omap3_l3 *l3 =3D platform_get_drvdata(pdev); =20 @@ -269,13 +269,11 @@ static int omap3_l3_remove(struct platform_device *pd= ev) free_irq(l3->debug_irq, l3); iounmap(l3->rt); kfree(l3); - - return 0; } =20 static struct platform_driver omap3_l3_driver =3D { .probe =3D omap3_l3_probe, - .remove =3D omap3_l3_remove, + .remove_new =3D omap3_l3_remove, .driver =3D { .name =3D "omap_l3_smx", .of_match_table =3D of_match_ptr(omap3_l3_match), --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DDE5C4167B for ; Thu, 9 Nov 2023 20:29:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345324AbjKIU3q (ORCPT ); Thu, 9 Nov 2023 15:29:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345226AbjKIU3c (ORCPT ); Thu, 9 Nov 2023 15:29:32 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7803444BC for ; Thu, 9 Nov 2023 12:29:20 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeD-0002zp-S5; Thu, 09 Nov 2023 21:29:05 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeD-007rWg-FB; Thu, 09 Nov 2023 21:29:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeD-00GGtb-61; Thu, 09 Nov 2023 21:29:05 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Arnd Bergmann , Andy Gross , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 04/12] bus: qcom-ssc-block-bus: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:34 +0100 Message-ID: <20231109202830.4124591-5-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=2068; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=wAGXyo4THEZ3YXfAy6+ytes/4cv/Fu7eWX0o6nDhAIA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUDzTrNcskF9F/f7KcEHQ1rf0f1wYIKKo0UFW olFqxNoc1mJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A8wAKCRCPgPtYfRL+ TgRsB/9KhxhY9k0o2+A6JUS7K5v6XNCj4Wzgont+kCkzwMz/YYOJdMy9/JnUbv14K6dc1O3Aww0 tt9LfxAfT3CFQc8WtA5pFIP365Ar9BwyOXvVONlNbJ4NzeuvU6xuKnMco+Q7Wa0cjGpmub+SeA8 2bp2L6R3EGe9KT/Fp9+CxNswZHItWHgw4EwSsEK5yneju39Hgdxiw6E3cdlUc30lR0+FRY07Q0u j0ua1Tpnwn4a+qwxCsziQscqxoXF9PQ770v79b+T2WARxVaZC0eVEC5gwe7mSne70eAIdw+AKnP duc01QYWIctEMduPOoAIKfLVrFc6MMbPFlY0pw328//49g3k X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. --- drivers/bus/qcom-ssc-block-bus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/qcom-ssc-block-bus.c b/drivers/bus/qcom-ssc-block-= bus.c index 3fef18a43c01..5931974a21fa 100644 --- a/drivers/bus/qcom-ssc-block-bus.c +++ b/drivers/bus/qcom-ssc-block-bus.c @@ -350,7 +350,7 @@ static int qcom_ssc_block_bus_probe(struct platform_dev= ice *pdev) return 0; } =20 -static int qcom_ssc_block_bus_remove(struct platform_device *pdev) +static void qcom_ssc_block_bus_remove(struct platform_device *pdev) { struct qcom_ssc_block_bus_data *data =3D platform_get_drvdata(pdev); =20 @@ -363,8 +363,6 @@ static int qcom_ssc_block_bus_remove(struct platform_de= vice *pdev) qcom_ssc_block_bus_pds_detach(&pdev->dev, data->pds, data->num_pds); pm_runtime_disable(&pdev->dev); pm_clk_destroy(&pdev->dev); - - return 0; } =20 static const struct of_device_id qcom_ssc_block_bus_of_match[] =3D { @@ -375,7 +373,7 @@ MODULE_DEVICE_TABLE(of, qcom_ssc_block_bus_of_match); =20 static struct platform_driver qcom_ssc_block_bus_driver =3D { .probe =3D qcom_ssc_block_bus_probe, - .remove =3D qcom_ssc_block_bus_remove, + .remove_new =3D qcom_ssc_block_bus_remove, .driver =3D { .name =3D "qcom-ssc-block-bus", .of_match_table =3D qcom_ssc_block_bus_of_match, --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DE09C4332F for ; Thu, 9 Nov 2023 20:29:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345314AbjKIU3n (ORCPT ); Thu, 9 Nov 2023 15:29:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345195AbjKIU3b (ORCPT ); Thu, 9 Nov 2023 15:29:31 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 935BE4787 for ; Thu, 9 Nov 2023 12:29:19 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeE-0002zu-E0; Thu, 09 Nov 2023 21:29:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeD-007rWk-LU; Thu, 09 Nov 2023 21:29:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeD-00GGtf-C6; Thu, 09 Nov 2023 21:29:05 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Arnd Bergmann , Greg Kroah-Hartman , Liu Ying , Geert Uytterhoeven , Luis Chamberlain , Nick Alcock , Rob Herring Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 05/12] bus: simple-pm-bus: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:35 +0100 Message-ID: <20231109202830.4124591-6-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1896; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Ox2UR96mQUBphpPQCu2afHS3QOH3355cCf293Z7ZMuU=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUD0TmHACrZZ3AsH1FRI415x4vDLXTNjGwR+W w452ENjBoCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A9AAKCRCPgPtYfRL+ TrRtB/sGslx73P03TonkbUftTqrJqMOyxQ4WC5pr+hCbarcjoCMF5U2yhaWGSQ1Ro0wgBDiveYk 0eI6j6BC9b4c+kIOs7vBwqPH2W2ms2L3A7kP6nZUAgxCJykdiCusTROwBKsVcIGIXCmUC9fjLRO dLr2vSJaM+I7TXkxaW7U2B7UxV0Cg+z5PrUXuQbkZXxC2RK5CDNYrxSO0z3i/D1nEV+qxAjzQiz oemf3SUqAMXVNqRpWG0k7NhhZVQZ28EO4HZskEZ9cim12E8/UYIbcEuszQ8X4rAUWNH8lkc1FWq DjTR6eFHVMmHFFsMxzSy6WRbZICUa8R8L710UnTCc7VGqs35 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. Reviewed-by: Geert Uytterhoeven --- drivers/bus/simple-pm-bus.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/bus/simple-pm-bus.c b/drivers/bus/simple-pm-bus.c index aafcc481de91..50870c827889 100644 --- a/drivers/bus/simple-pm-bus.c +++ b/drivers/bus/simple-pm-bus.c @@ -74,17 +74,16 @@ static int simple_pm_bus_probe(struct platform_device *= pdev) return 0; } =20 -static int simple_pm_bus_remove(struct platform_device *pdev) +static void simple_pm_bus_remove(struct platform_device *pdev) { const void *data =3D of_device_get_match_data(&pdev->dev); =20 if (pdev->driver_override || data) - return 0; + return; =20 dev_dbg(&pdev->dev, "%s\n", __func__); =20 pm_runtime_disable(&pdev->dev); - return 0; } =20 static int simple_pm_bus_runtime_suspend(struct device *dev) @@ -129,7 +128,7 @@ MODULE_DEVICE_TABLE(of, simple_pm_bus_of_match); =20 static struct platform_driver simple_pm_bus_driver =3D { .probe =3D simple_pm_bus_probe, - .remove =3D simple_pm_bus_remove, + .remove_new =3D simple_pm_bus_remove, .driver =3D { .name =3D "simple-pm-bus", .of_match_table =3D simple_pm_bus_of_match, --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3302BC4332F for ; Thu, 9 Nov 2023 20:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345301AbjKIU3k (ORCPT ); Thu, 9 Nov 2023 15:29:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345248AbjKIU3b (ORCPT ); Thu, 9 Nov 2023 15:29:31 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DB654784 for ; Thu, 9 Nov 2023 12:29:19 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeH-000307-0E; Thu, 09 Nov 2023 21:29:09 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeD-007rWn-TW; Thu, 09 Nov 2023 21:29:05 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeD-00GGtj-K5; Thu, 09 Nov 2023 21:29:05 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Arnd Bergmann , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 06/12] bus: sun50i-de2: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:36 +0100 Message-ID: <20231109202830.4124591-7-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1726; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=YjxQ9k2VhTNSjPuszXvrypquoQe61zCjR6hyAesl/x0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUD1h/FL212JBtXnUYvTOt6e/oAiPyWOeMRVg MwOBzqtJD2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A9QAKCRCPgPtYfRL+ TtAtB/40Cw1OEL2T46KLdtC6CPWjFjNclqSJ+qr/t4mj2hWDKwQtf0kTynpCe6dsTwfyifEPBfQ d3VgfUp1eO2NYm9OBdHXDl32gc0MDmOoNpdgDKlCc6aYawUN/noK27PmoPWdFuEcm1VyU9uMAuX sR5pS1cctbTPPozjbI4Y43ApHt0iatVbNW2jxyRqQW7Ac+Bi/tfW+R4g2VJqQ3O78mZ3dSY5MLt q7CyCWxnhD1PXANJFoeNMAgGd65yzDtNxJ66WOLbB/W5SkCO0WrqOoVNBIBUmsCU7nTUwhDZUVT hIhBabSoRtg8sz8beNoY1SfoJ4H6moejJnD+pPh8i+i+h+2g X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. Reviewed-by: Andre Przywara Reviewed-by: Jernej Skrabec --- drivers/bus/sun50i-de2.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/bus/sun50i-de2.c b/drivers/bus/sun50i-de2.c index 414f29cdedf0..3339311ce068 100644 --- a/drivers/bus/sun50i-de2.c +++ b/drivers/bus/sun50i-de2.c @@ -24,10 +24,9 @@ static int sun50i_de2_bus_probe(struct platform_device *= pdev) return 0; } =20 -static int sun50i_de2_bus_remove(struct platform_device *pdev) +static void sun50i_de2_bus_remove(struct platform_device *pdev) { sunxi_sram_release(&pdev->dev); - return 0; } =20 static const struct of_device_id sun50i_de2_bus_of_match[] =3D { @@ -37,7 +36,7 @@ static const struct of_device_id sun50i_de2_bus_of_match[= ] =3D { =20 static struct platform_driver sun50i_de2_bus_driver =3D { .probe =3D sun50i_de2_bus_probe, - .remove =3D sun50i_de2_bus_remove, + .remove_new =3D sun50i_de2_bus_remove, .driver =3D { .name =3D "sun50i-de2-bus", .of_match_table =3D sun50i_de2_bus_of_match, --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 852BAC4167B for ; Thu, 9 Nov 2023 20:30:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345220AbjKIUaH (ORCPT ); Thu, 9 Nov 2023 15:30:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345231AbjKIU3t (ORCPT ); Thu, 9 Nov 2023 15:29:49 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 334AE49F8 for ; Thu, 9 Nov 2023 12:29:28 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeH-00030C-0D; Thu, 09 Nov 2023 21:29:09 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeE-007rWs-6t; Thu, 09 Nov 2023 21:29:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeD-00GGtn-TH; Thu, 09 Nov 2023 21:29:05 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Arnd Bergmann , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Greg Kroah-Hartman , Hans de Goede , Laurentiu Tudor , Rob Herring , Yangtao Li , Yuan Can Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 07/12] bus: sunxi-rsb: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:37 +0100 Message-ID: <20231109202830.4124591-8-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1827; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Ljw1iocUr54lmlYHGt3emJtH6h+URgB1aeVfWaWuuQk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUD23dZO5dhS0cwcbsOoJZ0FDGjDEMqO4zgGJ m3BUYf5IC+JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A9gAKCRCPgPtYfRL+ TrHXB/0TOFve/dtvkisgJw9zkcCVDFLSsx+YLtqy1MqcS2oO79o1lTsMGekYQM6+DaRVZ7vqf+T ZBLt41FuXVbcWj5mLK+FrhBlEd73VtGrRCiUBXagwvLu3a1hNKzj394MjGLv+TMjtpN1RZmojdH 64CASdg19YDpS6KBNvJuKR1uvW/YD2Pg2Tz3/OL60r7Xdo0b5BjhjK3tnKRI81mtoSNMfymcOdB uGDz5C7eJbnlGen/U8W0Dgtp+jVmrz8mYo1hzYmclKIOFD8Ypdx3zaWErhBPPGMprnD9kW98UqB iv07DwwQaCkKLOx89X1FvLjKOyNoEkwbxaiX7waYUstQIa3s X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. Reviewed-by: Andre Przywara Reviewed-by: Jernej Skrabec --- drivers/bus/sunxi-rsb.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c index db0ed4e5d315..fd3e9d82340a 100644 --- a/drivers/bus/sunxi-rsb.c +++ b/drivers/bus/sunxi-rsb.c @@ -817,15 +817,13 @@ static int sunxi_rsb_probe(struct platform_device *pd= ev) return 0; } =20 -static int sunxi_rsb_remove(struct platform_device *pdev) +static void sunxi_rsb_remove(struct platform_device *pdev) { struct sunxi_rsb *rsb =3D platform_get_drvdata(pdev); =20 device_for_each_child(rsb->dev, NULL, sunxi_rsb_remove_devices); pm_runtime_disable(&pdev->dev); sunxi_rsb_hw_exit(rsb); - - return 0; } =20 static const struct dev_pm_ops sunxi_rsb_dev_pm_ops =3D { @@ -842,7 +840,7 @@ MODULE_DEVICE_TABLE(of, sunxi_rsb_of_match_table); =20 static struct platform_driver sunxi_rsb_driver =3D { .probe =3D sunxi_rsb_probe, - .remove =3D sunxi_rsb_remove, + .remove_new =3D sunxi_rsb_remove, .driver =3D { .name =3D RSB_CTRL_NAME, .of_match_table =3D sunxi_rsb_of_match_table, --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A5DC4332F for ; Thu, 9 Nov 2023 20:29:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345206AbjKIU3S (ORCPT ); Thu, 9 Nov 2023 15:29:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345188AbjKIU3O (ORCPT ); Thu, 9 Nov 2023 15:29:14 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D20A4686 for ; Thu, 9 Nov 2023 12:29:11 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeE-00030M-UT; Thu, 09 Nov 2023 21:29:06 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeE-007rWv-FX; Thu, 09 Nov 2023 21:29:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeE-00GGtr-6M; Thu, 09 Nov 2023 21:29:06 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Arnd Bergmann , Thierry Reding , Jonathan Hunter Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 08/12] bus: tegra-aconnect: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:38 +0100 Message-ID: <20231109202830.4124591-9-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1737; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=DCjzLmArjbIJmgPamQIMNlOs/ctX6rWbk9ESzC1W4p0=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUD4qCwJcPbaNAqXFcVETTV8fpOGPLhYz/HBV 3qBjiDFghSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A+AAKCRCPgPtYfRL+ TnudB/4y0ylnfR8RGKM3J73U2ukapU5VJE27ezW0BBv0q99gi/DvxL6BG/gf/qLmu/QKtjFVwuI w9XxhH35DErsI5m3HsqiBf5PM+nM2gsCwWNuNdyEVp7L3tdXMzHvjH2SlKCaeAFG4PA7dKgBXRd 28gR/EGQcKC07X2eweUoRmf6v0sSVsLES3fWxiN7D+mfVZzB7vcQIKfTVson87cQQ+x6zB3XrfI F9L9kN2S2Y6MQBFFXM/0sTtZnu8WSZu10bBMP2zhKi79HZOt76JXmRSlBRKBJSi5Dqhav2zaAFU hmmEbWaHxNd8kdfEUWNN0aqSVyRdeUur8hf1GX6Dqvcsn16j X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. --- drivers/bus/tegra-aconnect.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/tegra-aconnect.c b/drivers/bus/tegra-aconnect.c index ac58142301f4..de80008bff92 100644 --- a/drivers/bus/tegra-aconnect.c +++ b/drivers/bus/tegra-aconnect.c @@ -53,11 +53,9 @@ static int tegra_aconnect_probe(struct platform_device *= pdev) return 0; } =20 -static int tegra_aconnect_remove(struct platform_device *pdev) +static void tegra_aconnect_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - - return 0; } =20 static int tegra_aconnect_runtime_resume(struct device *dev) @@ -106,7 +104,7 @@ MODULE_DEVICE_TABLE(of, tegra_aconnect_of_match); =20 static struct platform_driver tegra_aconnect_driver =3D { .probe =3D tegra_aconnect_probe, - .remove =3D tegra_aconnect_remove, + .remove_new =3D tegra_aconnect_remove, .driver =3D { .name =3D "tegra-aconnect", .of_match_table =3D tegra_aconnect_of_match, --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6058C4332F for ; Thu, 9 Nov 2023 20:29:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345279AbjKIU3g (ORCPT ); Thu, 9 Nov 2023 15:29:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60848 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345200AbjKIU31 (ORCPT ); Thu, 9 Nov 2023 15:29:27 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8431A46AF for ; Thu, 9 Nov 2023 12:29:17 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeF-00030T-FL; Thu, 09 Nov 2023 21:29:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeE-007rWz-Mj; Thu, 09 Nov 2023 21:29:06 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeE-00GGtv-DS; Thu, 09 Nov 2023 21:29:06 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Arnd Bergmann , Thierry Reding , Jonathan Hunter , Rob Herring , Yangtao Li Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 09/12] bus: tegra-gmi: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:39 +0100 Message-ID: <20231109202830.4124591-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1763; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=VjQlvlUP0hSc0i1I5jF7v3psby2JMvMAnYEOoHbOgDg=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUD5GJFFr2+w/ToJXtwZlVXQtzp7LkRrRw5f5 SCYzSLnqbyJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A+QAKCRCPgPtYfRL+ TmaCCACk8lIKtzEjK+HIAmy1UCWEfkh0YtAjwGTgmHGLU/63Bzs7O4EfTlGSgI6CU/WpQd2Z/oT /r/xL1aY6REcPoenUxW+BVtSQcGtBqYiXndadbyVwVDaMqIILZ+56hBkVqu2hoJG/KHagY79d/r 0LldtrxEaP8JmC7P2WQTqBYgkzbRrSesWHx9Sj7SfuXNVDlNLQXsJCnhyu5AUn/1jiSgr6KrdlI XoMbVVk2TDz+BGcFcgVKGaiUM9ZPVDPNtY79OZ9Wmj4VVlEF5x9w2//Qe+beNHlNYEHSCX4sawO pLN2cuvrxwAWCgJJtmEa8vRbXy30siMExPdKvvHYZQdMUr7W X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. --- drivers/bus/tegra-gmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/tegra-gmi.c b/drivers/bus/tegra-gmi.c index 59919e99f7cc..f5d6414df9f2 100644 --- a/drivers/bus/tegra-gmi.c +++ b/drivers/bus/tegra-gmi.c @@ -258,14 +258,12 @@ static int tegra_gmi_probe(struct platform_device *pd= ev) return 0; } =20 -static int tegra_gmi_remove(struct platform_device *pdev) +static void tegra_gmi_remove(struct platform_device *pdev) { struct tegra_gmi *gmi =3D platform_get_drvdata(pdev); =20 of_platform_depopulate(gmi->dev); tegra_gmi_disable(gmi); - - return 0; } =20 static int __maybe_unused tegra_gmi_runtime_resume(struct device *dev) @@ -305,7 +303,7 @@ MODULE_DEVICE_TABLE(of, tegra_gmi_id_table); =20 static struct platform_driver tegra_gmi_driver =3D { .probe =3D tegra_gmi_probe, - .remove =3D tegra_gmi_remove, + .remove_new =3D tegra_gmi_remove, .driver =3D { .name =3D "tegra-gmi", .of_match_table =3D tegra_gmi_id_table, --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E73EC4332F for ; Thu, 9 Nov 2023 20:29:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345215AbjKIU3U (ORCPT ); Thu, 9 Nov 2023 15:29:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48290 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345181AbjKIU3O (ORCPT ); Thu, 9 Nov 2023 15:29:14 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25FC344B6 for ; Thu, 9 Nov 2023 12:29:12 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeF-00032b-I0; Thu, 09 Nov 2023 21:29:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeF-007rX3-3v; Thu, 09 Nov 2023 21:29:07 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeE-00GGu9-Qi; Thu, 09 Nov 2023 21:29:06 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Rob Herring , Laurentiu Tudor , Arnd Bergmann , Jernej Skrabec Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 10/12] bus: ti-pwmss: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:40 +0100 Message-ID: <20231109202830.4124591-11-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1571; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=IiUhWp+R9SDimNa6PMkD/UFH/SAwMLvdBfB4LRnQOD4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUD6GHJK2UFwCF/Nj5OAVtRMKGRi41NJClHLd QCvO1P2Y2WJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A+gAKCRCPgPtYfRL+ Tg4NB/wKQHLtuGfz4DBpdTgoDFZ9LgEa1BARbMLRGcjq++n46VI0Z3vZ3CNHHEwE/n8S21AKns8 4K10rjdJJrv0fzcZEo/y2NVMQH7o+P+kClY4E5xCpODZ5puAV52P0d9nl82XpNLQTmCoK7BpY1B Sxnja46qIh32/iUOWwfIKJBy14LDCD5Lr3UuH3OIScd8XHD8SgD2OqYWpIGxI86LTd0BSrowN8d WAQglBy+YHMkvSLwZTbjw5si0pCYCnqkbCjmVa+k9mM0BJegS368NPNsc9wUujkIIdw8qDFUZtP cSdkHJkzFNMScrNy5+FC1FtG61vq7A7yAB/iOZeSKXSGYR0h X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. --- drivers/bus/ti-pwmss.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/bus/ti-pwmss.c b/drivers/bus/ti-pwmss.c index 480a4de76cd4..4969c556e752 100644 --- a/drivers/bus/ti-pwmss.c +++ b/drivers/bus/ti-pwmss.c @@ -33,10 +33,9 @@ static int pwmss_probe(struct platform_device *pdev) return ret; } =20 -static int pwmss_remove(struct platform_device *pdev) +static void pwmss_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - return 0; } =20 static struct platform_driver pwmss_driver =3D { @@ -45,7 +44,7 @@ static struct platform_driver pwmss_driver =3D { .of_match_table =3D pwmss_of_match, }, .probe =3D pwmss_probe, - .remove =3D pwmss_remove, + .remove_new =3D pwmss_remove, }; =20 module_platform_driver(pwmss_driver); --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12EDDC4332F for ; Thu, 9 Nov 2023 20:29:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345228AbjKIU3Z (ORCPT ); Thu, 9 Nov 2023 15:29:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345168AbjKIU3P (ORCPT ); Thu, 9 Nov 2023 15:29:15 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4A3944BB for ; Thu, 9 Nov 2023 12:29:12 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeF-00033N-OC; Thu, 09 Nov 2023 21:29:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeF-007rX7-Aa; Thu, 09 Nov 2023 21:29:07 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeF-00GGuD-1O; Thu, 09 Nov 2023 21:29:07 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Arnd Bergmann , Tony Lindgren Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 11/12] bus: ti-sysc: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:41 +0100 Message-ID: <20231109202830.4124591-12-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1758; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=opTk4HTyURjB0GAHXubqOJ0QoyNNC03II0HWbr+XPDE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUD7++rpK6UFrsRtYltlQ1hWs00xrWDPQ+PR7 a0yuf2VwZCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A+wAKCRCPgPtYfRL+ TmE8B/4+R8UdQTyzVId2Y5KghT3jOlnVGcrlwPCYjGXUxBdn5orhi2SpN13OxnlaQcwfOTfyGhz wL9aJEod+w/fRiUVXvW9eDu90T9p9+0w8ZHpe0zV36adsT9hE6lqfyXDNmmOBCNxyia/LPIrfdZ D2jDnSXAHOLKKyXqLqvrVfTXneT4WFz0lkx/P5824KSHMfcZySPfqF+TAn8znuph3KrEc9aj2Tb SxX8sASUIE+NG2neTkASHaYKcsyL57R8lMOg2RC5UxCggM/6Jaq6gnrD4as3JpouexLwLjddOq8 N+GoHau3t/0hOzIVzVSYXhvvFpTzDtHIVlsSX+WgF7qfvSWj X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. Reviewed-by: Tony Lindgren --- drivers/bus/ti-sysc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c index d57bc066dce6..490841dbe0d8 100644 --- a/drivers/bus/ti-sysc.c +++ b/drivers/bus/ti-sysc.c @@ -3387,7 +3387,7 @@ static int sysc_probe(struct platform_device *pdev) return error; } =20 -static int sysc_remove(struct platform_device *pdev) +static void sysc_remove(struct platform_device *pdev) { struct sysc *ddata =3D platform_get_drvdata(pdev); int error; @@ -3412,8 +3412,6 @@ static int sysc_remove(struct platform_device *pdev) =20 unprepare: sysc_unprepare(ddata); - - return 0; } =20 static const struct of_device_id sysc_match[] =3D { @@ -3439,7 +3437,7 @@ MODULE_DEVICE_TABLE(of, sysc_match); =20 static struct platform_driver sysc_driver =3D { .probe =3D sysc_probe, - .remove =3D sysc_remove, + .remove_new =3D sysc_remove, .driver =3D { .name =3D "ti-sysc", .of_match_table =3D sysc_match, --=20 2.42.0 From nobody Tue Dec 30 22:52:26 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F29ACC4167D for ; Thu, 9 Nov 2023 20:29:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345182AbjKIU3N (ORCPT ); Thu, 9 Nov 2023 15:29:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345159AbjKIU3L (ORCPT ); Thu, 9 Nov 2023 15:29:11 -0500 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7594B3A98 for ; Thu, 9 Nov 2023 12:29:09 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1BeF-00035R-Ub; Thu, 09 Nov 2023 21:29:07 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r1BeF-007rXA-I3; Thu, 09 Nov 2023 21:29:07 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r1BeF-00GGuH-8y; Thu, 09 Nov 2023 21:29:07 +0100 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= To: Arnd Bergmann Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 12/12] bus: ts-nbus: Convert to platform remove callback returning void Date: Thu, 9 Nov 2023 21:28:42 +0100 Message-ID: <20231109202830.4124591-13-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0.586.gbc5204569f7d.dirty In-Reply-To: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> References: <20231109202830.4124591-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1828; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=JH5kPuzEZrv1BLWpBstXob4NKgRDBn8Mt+gM+m29Vns=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlTUD83Hvw2vn4606kwYrMwHfTvBMJmXhl8Ha7Z PXT4QIU/b2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZU1A/AAKCRCPgPtYfRL+ TnV9CACkna96FEvGPjHKbIWT91Mj1tUEBnRGMqCGqw6W/lo2aTrmHVcEQ5y3V6UmiZx3GmOhAce uIYXR5phGMB/MUEKwsoZXjULKr361Sopu1KPeszQXhK5Dp7YjMywGlaEEJgOWa5gUedsPZnNG0j udv+CJZOHwB5l8wvUZ2Uj+jljRxFVpUmsy+hxxgTuLIqUqpImDnKVg5LgLQlThTwVaHi9Vp+DZJ L/QauhUZv+Fkwv9bdSWAj0byGSz0qVSm/UDi65CYvfnH4uAyjLmmei4mCWXwJ9A6nliYqeainvb 655/wplAawGhq6iNdGbLv9DTgAftmEDa5twCkjhYa11IAfa5 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by tags for Jernej Skrabec that came in after I sent the PR. --- drivers/bus/ts-nbus.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/bus/ts-nbus.c b/drivers/bus/ts-nbus.c index 38c886dc2ed6..4fa932cb0915 100644 --- a/drivers/bus/ts-nbus.c +++ b/drivers/bus/ts-nbus.c @@ -331,7 +331,7 @@ static int ts_nbus_probe(struct platform_device *pdev) return 0; } =20 -static int ts_nbus_remove(struct platform_device *pdev) +static void ts_nbus_remove(struct platform_device *pdev) { struct ts_nbus *ts_nbus =3D dev_get_drvdata(&pdev->dev); =20 @@ -339,8 +339,6 @@ static int ts_nbus_remove(struct platform_device *pdev) mutex_lock(&ts_nbus->lock); pwm_disable(ts_nbus->pwm); mutex_unlock(&ts_nbus->lock); - - return 0; } =20 static const struct of_device_id ts_nbus_of_match[] =3D { @@ -351,7 +349,7 @@ MODULE_DEVICE_TABLE(of, ts_nbus_of_match); =20 static struct platform_driver ts_nbus_driver =3D { .probe =3D ts_nbus_probe, - .remove =3D ts_nbus_remove, + .remove_new =3D ts_nbus_remove, .driver =3D { .name =3D "ts_nbus", .of_match_table =3D ts_nbus_of_match, --=20 2.42.0