From nobody Wed Dec 17 03:48:14 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83CEDC4332F for ; Thu, 9 Nov 2023 08:41:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233608AbjKIIlY (ORCPT ); Thu, 9 Nov 2023 03:41:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233391AbjKIIlW (ORCPT ); Thu, 9 Nov 2023 03:41:22 -0500 X-Greylist: delayed 89132 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 09 Nov 2023 00:41:20 PST Received: from 7.mo583.mail-out.ovh.net (7.mo583.mail-out.ovh.net [178.32.124.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 228651FFB for ; Thu, 9 Nov 2023 00:41:20 -0800 (PST) Received: from director5.ghost.mail-out.ovh.net (unknown [10.109.146.50]) by mo583.mail-out.ovh.net (Postfix) with ESMTP id 7F24425099 for ; Thu, 9 Nov 2023 08:41:17 +0000 (UTC) Received: from ghost-submission-6684bf9d7b-vsp9x (unknown [10.110.115.108]) by director5.ghost.mail-out.ovh.net (Postfix) with ESMTPS id 30EBA1FD1C; Thu, 9 Nov 2023 08:41:15 +0000 (UTC) Received: from foxhound.fi ([37.59.142.103]) by ghost-submission-6684bf9d7b-vsp9x with ESMTPSA id y8qgBiubTGXYrAEAbsEDOA (envelope-from ); Thu, 09 Nov 2023 08:41:15 +0000 Authentication-Results: garm.ovh; auth=pass (GARM-103G00528d66f00-163d-49d8-8ce5-862fd5d6f579, 40AB3B8824D5DAA18E3B98848C0232F256E668F8) smtp.auth=jose.pekkarinen@foxhound.fi X-OVh-ClientIp: 213.216.210.65 From: =?UTF-8?q?Jos=C3=A9=20Pekkarinen?= To: evan.quan@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, skhan@linuxfoundation.org Cc: =?UTF-8?q?Jos=C3=A9=20Pekkarinen?= , airlied@gmail.com, daniel@ffwll.ch, jdelvare@suse.com, linux@roeck-us.net, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev Subject: [PATCH] drm/amd/pm: make power values signed Date: Thu, 9 Nov 2023 10:41:10 +0200 Message-Id: <20231109084110.4056-1-jose.pekkarinen@foxhound.fi> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 11181593452377646785 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: 0 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvkedruddvtddguddulecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecunecujfgurhephffvvefufffkofggtgfgsehtkeertdertdejnecuhfhrohhmpeflohhsrocurfgvkhhkrghrihhnvghnuceojhhoshgvrdhpvghkkhgrrhhinhgvnhesfhhogihhohhunhgurdhfiheqnecuggftrfgrthhtvghrnhepfedtleeuteeitedvtedtteeuieevudejfeffvdetfeekleehhfelleefteetjeejnecukfhppeduvdejrddtrddtrddupddvudefrddvudeirddvuddtrdeihedpfeejrdehledrudegvddruddtfeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeduvdejrddtrddtrddupdhmrghilhhfrhhomhepoehjohhsvgdrphgvkhhkrghrihhnvghnsehfohighhhouhhnugdrfhhiqedpnhgspghrtghpthhtohepuddprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdpoffvtefjohhsthepmhhoheekfedpmhhouggvpehsmhhtphhouhht Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following patch will convert the power values returned by amdgpu_hwmon_get_power to signed, fixing the following warnings reported by coccinelle: drivers/gpu/drm/amd/pm/amdgpu_pm.c:2801:5-8: WARNING: Unsigned expression c= ompared with zero: val < 0 drivers/gpu/drm/amd/pm/amdgpu_pm.c:2814:5-8: WARNING: Unsigned expression c= ompared with zero: val < 0 Signed-off-by: Jos=C3=A9 Pekkarinen --- drivers/gpu/drm/amd/pm/amdgpu_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/am= dgpu_pm.c index e7bb1d324084..913ff62d5d5e 100644 --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c @@ -2795,7 +2795,7 @@ static ssize_t amdgpu_hwmon_show_power_avg(struct dev= ice *dev, struct device_attribute *attr, char *buf) { - unsigned int val; + int val; =20 val =3D amdgpu_hwmon_get_power(dev, AMDGPU_PP_SENSOR_GPU_AVG_POWER); =20 @@ -2806,7 +2806,7 @@ static ssize_t amdgpu_hwmon_show_power_input(struct d= evice *dev, struct device_attribute *attr, char *buf) { - unsigned int val; + int val; =20 val =3D amdgpu_hwmon_get_power(dev, AMDGPU_PP_SENSOR_GPU_INPUT_POWER); =20 --=20 2.39.2