From nobody Wed Dec 31 16:22:12 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14D8DC4332F for ; Tue, 31 Oct 2023 14:44:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344384AbjJaOok (ORCPT ); Tue, 31 Oct 2023 10:44:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50136 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344319AbjJaOoj (ORCPT ); Tue, 31 Oct 2023 10:44:39 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 594AADA for ; Tue, 31 Oct 2023 07:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698763426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xXlUwrZ8a+TiVbwN/xlzrhXNH8IBziMOpwtSPkVcE7I=; b=GJ1iqCbApRyL0eJNzcCjKXNxC6l+11DD9o3fYtGEKRLgYe7qK11H94n59EHcPgF68235ZW ipfNUfza9asXB6bqGMsXBD9VpykJCUxN77gW9yCLMdAmrAGFLtlX5kd+IQ9jYzpFn49jAX dmxqu2uraoIZbKD02XE0aevBi88tBhE= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-440-vpOiIKskOfKYgd17sxPdxg-1; Tue, 31 Oct 2023 10:43:44 -0400 X-MC-Unique: vpOiIKskOfKYgd17sxPdxg-1 Received: by mail-ot1-f72.google.com with SMTP id 46e09a7af769-6d30af2399bso1077096a34.1 for ; Tue, 31 Oct 2023 07:43:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698763424; x=1699368224; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xXlUwrZ8a+TiVbwN/xlzrhXNH8IBziMOpwtSPkVcE7I=; b=Z9EkhRvFmey9aUsPm6kDeY3DhhJ+MVthX46F76rjDEEpThtcox6LpsSC0SgIt5uA1Y tTnDX98e2hpJDMX4qOC23/MS1U1dBYy9KzPckQ5Q0Inln7h93pA22GFCyLNdtA2FKM42 QBHxcVilD14kWOlESM9tIApwGTLhPcJmeLstEpWwtigeBbaUJRoTlvj4ijdCusRATGM/ cfcn6gfgsJBf5odRzMpvYSSBFNOlvqE18Yd8O1hV+uLWyq25kP2w829tnPdhRRd8Gj16 VvD0Bbk9rkrgb4aO5whXwiemGc9Iwl+YA0YUkRFwWcbg4ZitX5AJOpCKZLR3iKdHH9A0 NN/w== X-Gm-Message-State: AOJu0Yy5ZvVzoeNWjiz9zrHxqXNAKa76x/XJ3y9TLuBDyCdt3rPxzN/t EQQbds10QhrYjByHVxavv0uQem+Z2zTmv+dxNUz4LG4cERxua5JXeIXMkK+cf0mzsvt+8bMBdoC mi+QROou/7c5zrES7gSLUlvXH X-Received: by 2002:a05:6830:1e35:b0:6d3:a14:f3f1 with SMTP id t21-20020a0568301e3500b006d30a14f3f1mr2374206otr.7.1698763424288; Tue, 31 Oct 2023 07:43:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFBHVEKDScky83TG83898xQYY2ysehM/b/1rfoz+oNpMActtM8216vJOH2Z5EptpCShbw5hQ== X-Received: by 2002:a05:6830:1e35:b0:6d3:a14:f3f1 with SMTP id t21-20020a0568301e3500b006d30a14f3f1mr2374193otr.7.1698763424028; Tue, 31 Oct 2023 07:43:44 -0700 (PDT) Received: from step1.redhat.com ([5.179.178.82]) by smtp.gmail.com with ESMTPSA id j7-20020ac84c87000000b004181e5a724csm544231qtv.88.2023.10.31.07.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 07:43:43 -0700 (PDT) From: Stefano Garzarella To: virtualization@lists.linux-foundation.org Cc: Stefano Garzarella , Jason Wang , Xuan Zhuo , "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, Qing Wang Subject: [PATCH] vdpa_sim_blk: allocate the buffer zeroed Date: Tue, 31 Oct 2023 15:43:39 +0100 Message-ID: <20231031144339.121453-1-sgarzare@redhat.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Deleting and recreating a device can lead to having the same content as the old device, so let's always allocate buffers completely zeroed out. Fixes: abebb16254b3 ("vdpa_sim_blk: support shared backend") Suggested-by: Qing Wang Signed-off-by: Stefano Garzarella Acked-by: Eugenio P=C3=A9rez Acked-by: Jason Wang --- drivers/vdpa/vdpa_sim/vdpa_sim_blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c b/drivers/vdpa/vdpa_sim/v= dpa_sim_blk.c index b3a3cb165795..b137f3679343 100644 --- a/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c +++ b/drivers/vdpa/vdpa_sim/vdpa_sim_blk.c @@ -437,7 +437,7 @@ static int vdpasim_blk_dev_add(struct vdpa_mgmt_dev *md= ev, const char *name, if (blk->shared_backend) { blk->buffer =3D shared_buffer; } else { - blk->buffer =3D kvmalloc(VDPASIM_BLK_CAPACITY << SECTOR_SHIFT, + blk->buffer =3D kvzalloc(VDPASIM_BLK_CAPACITY << SECTOR_SHIFT, GFP_KERNEL); if (!blk->buffer) { ret =3D -ENOMEM; @@ -495,7 +495,7 @@ static int __init vdpasim_blk_init(void) goto parent_err; =20 if (shared_backend) { - shared_buffer =3D kvmalloc(VDPASIM_BLK_CAPACITY << SECTOR_SHIFT, + shared_buffer =3D kvzalloc(VDPASIM_BLK_CAPACITY << SECTOR_SHIFT, GFP_KERNEL); if (!shared_buffer) { ret =3D -ENOMEM; --=20 2.41.0