From nobody Wed Dec 31 17:58:59 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3538C4167D for ; Mon, 30 Oct 2023 23:03:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229905AbjJ3XCr (ORCPT ); Mon, 30 Oct 2023 19:02:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbjJ3XCp (ORCPT ); Mon, 30 Oct 2023 19:02:45 -0400 X-Greylist: delayed 324 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 30 Oct 2023 16:02:39 PDT Received: from mail-1.server.selfnet.de (mail-1.server.selfnet.de [141.70.126.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 994C4E1; Mon, 30 Oct 2023 16:02:39 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 57C33409E5; Mon, 30 Oct 2023 23:57:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfnet.de; s=selfnet; t=1698706627; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=PCsZTHDftr8v1kPvgW50F/V5olhAwY15OTuwMPbeyYg=; b=Qq/N8Vfi3ilbXcQ0xQ061biLwDUoayRiTxIIKKhFDlbJNE1ggo/Bj8/tTmcYqxuNsIZ1l0 Ryuyet8AFFPCL589Ssga3y8y47IIC6jk7MQWbi8oAgoqEvQlpkitNhxAJQW2c1kSQvWAFi pLN2tkFnyjwdvXswIDqcdh2kgLTOP3Ga/trEFSWZ8cz3FBTthlN2SuZFGB/UAzXnlGC6Xz WnCredEuDVtZyx8b8DTIVCymPrRzq5MFZjKj4fl+KuCT9Ih9wENe6h76jA+wkcUzBwCGnU J+qN3B1iNRIXg1tfkBj/R0O8J/snchKtklHx6cYxTkTlrbWTdP1NKf08BWtkjQ== From: Marco von Rosenberg To: Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Marco von Rosenberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: phy: broadcom: Wire suspend/resume for BCM54612E Date: Mon, 30 Oct 2023 23:54:45 +0100 Message-ID: <20231030225446.17422-1-marcovr@selfnet.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" On some devices, the bootloader suspends the PHY before booting the OS. Not having a resume callback wired up is a problem in such situations since it is then never resumed. This behavior was observed with a Huawei enterprise WLAN access point. The BCM54612E ethernet PHY supports IDDQ-SR. Therefore wire-up the suspend and resume callbacks to point to bcm54xx_suspend() and bcm54xx_resume(). The same wire-up has been done in commit 38b6a9073007 ("net: phy: broadcom: Wire suspend/resume for BCM50610 and BCM50610M") for two PHYs also supporting IDDQ-SR. Signed-off-by: Marco von Rosenberg --- drivers/net/phy/broadcom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 04b2e6eeb195..ac14f223649b 100644 --- a/drivers/net/phy/broadcom.c +++ b/drivers/net/phy/broadcom.c @@ -1060,6 +1060,8 @@ static struct phy_driver broadcom_drivers[] =3D { .handle_interrupt =3D bcm_phy_handle_interrupt, .link_change_notify =3D bcm54xx_link_change_notify, .led_brightness_set =3D bcm_phy_led_brightness_set, + .suspend =3D bcm54xx_suspend, + .resume =3D bcm54xx_resume, }, { .phy_id =3D PHY_ID_BCM54616S, .phy_id_mask =3D 0xfffffff0, --=20 2.42.0