From nobody Tue Dec 16 20:03:36 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8F62C25B47 for ; Fri, 27 Oct 2023 03:10:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345183AbjJ0DKZ (ORCPT ); Thu, 26 Oct 2023 23:10:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjJ0DKU (ORCPT ); Thu, 26 Oct 2023 23:10:20 -0400 Received: from outboundhk.mxmail.xiaomi.com (outboundhk.mxmail.xiaomi.com [207.226.244.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6C366129 for ; Thu, 26 Oct 2023 20:10:17 -0700 (PDT) X-IronPort-AV: E=Sophos;i="6.03,255,1694707200"; d="scan'208";a="94522298" From: Fang Xiang To: , , , CC: Subject: [PATCH v2] irqchip/gic-v3-its: Flush ITS tables before writing GITS_BASER registers in non-coherent GIC designs. Date: Fri, 27 Oct 2023 11:10:07 +0800 Message-ID: <20231027031007.2088-1-fangxiang3@xiaomi.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.237.8.22] X-ClientProxiedBy: BJ-MBX02.mioffice.cn (10.237.8.122) To BJ-MBX15.mioffice.cn (10.237.8.135) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In non-coherent GIC design, ITS tables should be clean and flushed to the PoV of the ITS before writing GITS_BASER registers. And hoist the quirked non-shareable attributes earlier to save effort in tables setup. Signed-off-by: Fang Xiang Link to v1: https://lore.kernel.org/all/20231026020116.4238-1-fangxiang3@xiaomi.com/ v1 -> v2: - Flush ITS tables before writing GITS_BASER registers - Hoist the quirked non-shareable attributes earlier --- drivers/irqchip/irq-gic-v3-its.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-= its.c index 75a2dd550625..d76d44ea2de1 100644 --- a/drivers/irqchip/irq-gic-v3-its.c +++ b/drivers/irqchip/irq-gic-v3-its.c @@ -2379,12 +2379,12 @@ static int its_setup_baser(struct its_node *its, st= ruct its_baser *baser, break; } =20 + if (!shr) + gic_flush_dcache_to_poc(base, PAGE_ORDER_TO_SIZE(order)); + its_write_baser(its, baser, val); tmp =3D baser->val; =20 - if (its->flags & ITS_FLAGS_FORCE_NON_SHAREABLE) - tmp &=3D ~GITS_BASER_SHAREABILITY_MASK; - if ((val ^ tmp) & GITS_BASER_SHAREABILITY_MASK) { /* * Shareability didn't stick. Just use @@ -2394,10 +2394,9 @@ static int its_setup_baser(struct its_node *its, str= uct its_baser *baser, * non-cacheable as well. */ shr =3D tmp & GITS_BASER_SHAREABILITY_MASK; - if (!shr) { + if (!shr) cache =3D GITS_BASER_nC; - gic_flush_dcache_to_poc(base, PAGE_ORDER_TO_SIZE(order)); - } + goto retry_baser; } =20 @@ -2609,6 +2608,11 @@ static int its_alloc_tables(struct its_node *its) /* erratum 24313: ignore memory access type */ cache =3D GITS_BASER_nCnB; =20 + if (its->flags & ITS_FLAGS_FORCE_NON_SHAREABLE) { + cache =3D GITS_BASER_nC; + shr =3D 0; + } + for (i =3D 0; i < GITS_BASER_NR_REGS; i++) { struct its_baser *baser =3D its->tables + i; u64 val =3D its_read_baser(its, baser); --=20 2.34.1