From nobody Tue Dec 16 19:55:00 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8CE4C25B6B for ; Fri, 27 Oct 2023 00:21:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231604AbjJ0AVj (ORCPT ); Thu, 26 Oct 2023 20:21:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjJ0AVg (ORCPT ); Thu, 26 Oct 2023 20:21:36 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 437D410E for ; Thu, 26 Oct 2023 17:21:34 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6b44befac59so1989186b3a.0 for ; Thu, 26 Oct 2023 17:21:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698366093; x=1698970893; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=i0gYOpz/XgQiw5wtt3cYyUWDo3FK+dwt3ja69KJWCyg=; b=dlk1/e7ph/puxm9VXwOBaiQjPQPs15YZIRsAVn4gsdhhykb74eH52huHZXGxMyQasN sU/Za39bnFd2QnZW1IXoJgOZ5V14G++IQqzdKRa2Ypq1F8cDQz4VOie2nLBYfPGQcqTl ObC/hmvgnfxUVVUt2x5WMUN9mLC5Rn2cJ8XnxK8GBjjl8DVZVTH6tpCoISKv+onPm8Nn PVM9tE+PoEt7x2Kgqb2RFZtw7m4Aglcgt8PFTBSlAXb15s3wV9oeCk9uLTfWDCNOm+av XrSKyyWlBbQGmta+nDeprfIZ5UawwsVVJEeQt7wpXKkoah5Fq2mq6jlC4u5Q2YJP27pv tstw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698366093; x=1698970893; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=i0gYOpz/XgQiw5wtt3cYyUWDo3FK+dwt3ja69KJWCyg=; b=C31qZgxmiwnDUZKO4+V0EAj2OCFKe8R9BQ+Ef7MxdDYnttFl7VI+tKJxHCrg5JgjMj xDB9J39KAMWYinDrDY8ccT4v16Fh/sUnCr0cHGWkXiwBHImbwlNjxa12MyTcUek2J+dO Al4RCN1BsiM2PUKMvdXSALQADcHkClE+IsOf0VjQTwUwFf1dMrEuwlez4s6N+OrwNBAc SGDyBFv7WJlXUUvsb0vQmxCE6r/qOq4Kt7Fi7VycWUm/+DWYqHBaNvcmVtD5nwwcJvGd bV4Jv3osIrx2vyneOLXucekbT8+isfKGuBs87h87Xmy6Fcf+aXhTXkOn/eIiJ4w1YLv3 omUA== X-Gm-Message-State: AOJu0YzMebih+AgVC2f2LLIIa5KulnhQSeylBjTTh0rgeiL6czIF89CJ xzwVvYuGessG2UWrsvrMmf1IgIOC4ps= X-Google-Smtp-Source: AGHT+IHDVla0y5rFv28aqQSb3U2ckrbvtYt8HyCM0jwWYulDBX7L3l/TyXhWFQ8W05wLts0sYdsxaA== X-Received: by 2002:a05:6a21:999f:b0:13e:debc:3657 with SMTP id ve31-20020a056a21999f00b0013edebc3657mr1252660pzb.30.1698366092731; Thu, 26 Oct 2023 17:21:32 -0700 (PDT) Received: from daehojeong-desktop.mtv.corp.google.com ([2620:15c:211:201:85a4:5aef:279b:f31e]) by smtp.gmail.com with ESMTPSA id y3-20020aa78f23000000b00690f622d3cdsm175111pfr.126.2023.10.26.17.21.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 17:21:32 -0700 (PDT) From: Daeho Jeong To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com Cc: Daeho Jeong Subject: [PATCH v2] f2fs-tools: do not reuse corrupted quota inodes Date: Thu, 26 Oct 2023 17:21:23 -0700 Message-ID: <20231027002123.1195780-1-daeho43@gmail.com> X-Mailer: git-send-email 2.42.0.820.g83a721a137-goog MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Daeho Jeong When we detect quota inode corruption, we better deallocate the current space and allocate new ones for a clean start. Signed-off-by: Daeho Jeong --- v2: change node count check when creating a new node block --- fsck/fsck.c | 148 +++++++++++++++++++++++++++++++++++-------------- fsck/segment.c | 5 +- 2 files changed, 109 insertions(+), 44 deletions(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 99cface..dc8e282 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@ -67,6 +67,14 @@ int f2fs_set_sit_bitmap(struct f2fs_sb_info *sbi, u32 bl= k) return f2fs_set_bit(BLKOFF_FROM_MAIN(sbi, blk), fsck->sit_area_bitmap); } =20 +static inline int f2fs_clear_sit_bitmap(struct f2fs_sb_info *sbi, u32 blk) +{ + struct f2fs_fsck *fsck =3D F2FS_FSCK(sbi); + + return f2fs_clear_bit(BLKOFF_FROM_MAIN(sbi, blk), + fsck->sit_area_bitmap); +} + static int add_into_hard_link_list(struct f2fs_sb_info *sbi, u32 nid, u32 link_cnt) { @@ -2150,6 +2158,9 @@ int fsck_chk_quota_node(struct f2fs_sb_info *sbi) return ret; } =20 +static void fsck_disconnect_file(struct f2fs_sb_info *sbi, nid_t ino, + bool dealloc); + int fsck_chk_quota_files(struct f2fs_sb_info *sbi) { struct f2fs_fsck *fsck =3D F2FS_FSCK(sbi); @@ -2181,6 +2192,8 @@ int fsck_chk_quota_files(struct f2fs_sb_info *sbi) if (c.fix_on) { DBG(0, "Fixing Quota file ([%3d] ino [0x%x])\n", qtype, ino); + fsck_disconnect_file(sbi, ino, true); + f2fs_rebuild_qf_inode(sbi, qtype); f2fs_filesize_update(sbi, ino, 0); ret =3D quota_write_inode(sbi, qtype); if (!ret) { @@ -2874,10 +2887,53 @@ static int fsck_do_reconnect_file(struct f2fs_sb_in= fo *sbi, return 0; } =20 -static void fsck_failed_reconnect_file_dnode(struct f2fs_sb_info *sbi, - struct f2fs_inode *inode, nid_t nid) +static inline void release_inode_cnt(struct f2fs_sb_info *sbi, bool deallo= c) +{ + F2FS_FSCK(sbi)->chk.valid_inode_cnt--; + if (dealloc) + sbi->total_valid_inode_count--; +} + +static inline void release_node_cnt(struct f2fs_sb_info *sbi, bool dealloc) +{ + F2FS_FSCK(sbi)->chk.valid_node_cnt--; + if (dealloc) + sbi->total_valid_node_count--; +} + +static inline void release_block_cnt(struct f2fs_sb_info *sbi, bool deallo= c) +{ + F2FS_FSCK(sbi)->chk.valid_blk_cnt--; + if (dealloc) + sbi->total_valid_block_count--; +} + +static inline void release_block(struct f2fs_sb_info *sbi, u64 blkaddr, + bool dealloc) +{ + f2fs_clear_main_bitmap(sbi, blkaddr); + if (dealloc) { + struct seg_entry *se; + u64 offset; + + se =3D get_seg_entry(sbi, GET_SEGNO(sbi, blkaddr)); + offset =3D OFFSET_IN_SEG(sbi, blkaddr); + se->valid_blocks--; + f2fs_clear_bit(offset, (char *)se->cur_valid_map); + se->dirty =3D 1; + f2fs_clear_sit_bitmap(sbi, blkaddr); + } +} + +static inline void release_nat_entry(struct f2fs_sb_info *sbi, u32 nid) +{ + nullify_nat_entry(sbi, nid); + F2FS_FSCK(sbi)->chk.valid_nat_entry_cnt--; +} + +static void fsck_disconnect_file_dnode(struct f2fs_sb_info *sbi, + struct f2fs_inode *inode, nid_t nid, bool dealloc) { - struct f2fs_fsck *fsck =3D F2FS_FSCK(sbi); struct f2fs_node *node; struct node_info ni; u32 addr; @@ -2890,27 +2946,29 @@ static void fsck_failed_reconnect_file_dnode(struct= f2fs_sb_info *sbi, err =3D dev_read_block(node, ni.blk_addr); ASSERT(err >=3D 0); =20 - fsck->chk.valid_node_cnt--; - fsck->chk.valid_blk_cnt--; - f2fs_clear_main_bitmap(sbi, ni.blk_addr); + release_node_cnt(sbi, dealloc); + release_block_cnt(sbi, dealloc); + release_block(sbi, ni.blk_addr, dealloc); =20 for (i =3D 0; i < ADDRS_PER_BLOCK(inode); i++) { addr =3D le32_to_cpu(node->dn.addr[i]); if (!addr) continue; - fsck->chk.valid_blk_cnt--; + release_block_cnt(sbi, dealloc); if (addr =3D=3D NEW_ADDR || addr =3D=3D COMPRESS_ADDR) continue; - f2fs_clear_main_bitmap(sbi, addr); + release_block(sbi, addr, dealloc); } =20 + if (dealloc) + release_nat_entry(sbi, nid); + free(node); } =20 -static void fsck_failed_reconnect_file_idnode(struct f2fs_sb_info *sbi, - struct f2fs_inode *inode, nid_t nid) +static void fsck_disconnect_file_idnode(struct f2fs_sb_info *sbi, + struct f2fs_inode *inode, nid_t nid, bool dealloc) { - struct f2fs_fsck *fsck =3D F2FS_FSCK(sbi); struct f2fs_node *node; struct node_info ni; nid_t tmp; @@ -2923,24 +2981,26 @@ static void fsck_failed_reconnect_file_idnode(struc= t f2fs_sb_info *sbi, err =3D dev_read_block(node, ni.blk_addr); ASSERT(err >=3D 0); =20 - fsck->chk.valid_node_cnt--; - fsck->chk.valid_blk_cnt--; - f2fs_clear_main_bitmap(sbi, ni.blk_addr); + release_node_cnt(sbi, dealloc); + release_block_cnt(sbi, dealloc); + release_block(sbi, ni.blk_addr, dealloc); =20 for (i =3D 0; i < NIDS_PER_BLOCK; i++) { tmp =3D le32_to_cpu(node->in.nid[i]); if (!tmp) continue; - fsck_failed_reconnect_file_dnode(sbi, inode, tmp); + fsck_disconnect_file_dnode(sbi, inode, tmp, dealloc); } =20 + if (dealloc) + release_nat_entry(sbi, nid); + free(node); } =20 -static void fsck_failed_reconnect_file_didnode(struct f2fs_sb_info *sbi, - struct f2fs_inode *inode, nid_t nid) +static void fsck_disconnect_file_didnode(struct f2fs_sb_info *sbi, + struct f2fs_inode *inode, nid_t nid, bool dealloc) { - struct f2fs_fsck *fsck =3D F2FS_FSCK(sbi); struct f2fs_node *node; struct node_info ni; nid_t tmp; @@ -2953,28 +3013,26 @@ static void fsck_failed_reconnect_file_didnode(stru= ct f2fs_sb_info *sbi, err =3D dev_read_block(node, ni.blk_addr); ASSERT(err >=3D 0); =20 - fsck->chk.valid_node_cnt--; - fsck->chk.valid_blk_cnt--; - f2fs_clear_main_bitmap(sbi, ni.blk_addr); + release_node_cnt(sbi, dealloc); + release_block_cnt(sbi, dealloc); + release_block(sbi, ni.blk_addr, dealloc); =20 for (i =3D 0; i < NIDS_PER_BLOCK; i++) { tmp =3D le32_to_cpu(node->in.nid[i]); if (!tmp) continue; - fsck_failed_reconnect_file_idnode(sbi, inode, tmp); + fsck_disconnect_file_idnode(sbi, inode, tmp, dealloc); } =20 + if (dealloc) + release_nat_entry(sbi, nid); + free(node); } =20 -/* - * Counters and main_area_bitmap are already changed during checking - * inode block, so clear them. There is no need to clear new blocks - * allocted to lost+found. - */ -static void fsck_failed_reconnect_file(struct f2fs_sb_info *sbi, nid_t ino) +static void fsck_disconnect_file(struct f2fs_sb_info *sbi, nid_t ino, + bool dealloc) { - struct f2fs_fsck *fsck =3D F2FS_FSCK(sbi); struct f2fs_node *node; struct node_info ni; nid_t nid; @@ -2988,18 +3046,18 @@ static void fsck_failed_reconnect_file(struct f2fs_= sb_info *sbi, nid_t ino) ASSERT(err >=3D 0); =20 /* clear inode counters */ - fsck->chk.valid_inode_cnt--; - fsck->chk.valid_node_cnt--; - fsck->chk.valid_blk_cnt--; - f2fs_clear_main_bitmap(sbi, ni.blk_addr); + release_inode_cnt(sbi, dealloc); + release_node_cnt(sbi, dealloc); + release_block_cnt(sbi, dealloc); + release_block(sbi, ni.blk_addr, dealloc); =20 /* clear xnid counters */ if (node->i.i_xattr_nid) { nid =3D le32_to_cpu(node->i.i_xattr_nid); - fsck->chk.valid_node_cnt--; - fsck->chk.valid_blk_cnt--; + release_node_cnt(sbi, dealloc); + release_block_cnt(sbi, dealloc); get_node_info(sbi, nid, &ni); - f2fs_clear_main_bitmap(sbi, ni.blk_addr); + release_block(sbi, ni.blk_addr, dealloc); } =20 /* clear data counters */ @@ -3009,10 +3067,10 @@ static void fsck_failed_reconnect_file(struct f2fs_= sb_info *sbi, nid_t ino) block_t addr =3D le32_to_cpu(node->i.i_addr[ofs + i]); if (!addr) continue; - fsck->chk.valid_blk_cnt--; + release_block_cnt(sbi, dealloc); if (addr =3D=3D NEW_ADDR || addr =3D=3D COMPRESS_ADDR) continue; - f2fs_clear_main_bitmap(sbi, addr); + release_block(sbi, addr, dealloc); } } =20 @@ -3024,18 +3082,24 @@ static void fsck_failed_reconnect_file(struct f2fs_= sb_info *sbi, nid_t ino) switch (i) { case 0: /* direct node */ case 1: - fsck_failed_reconnect_file_dnode(sbi, &node->i, nid); + fsck_disconnect_file_dnode(sbi, &node->i, nid, + dealloc); break; case 2: /* indirect node */ case 3: - fsck_failed_reconnect_file_idnode(sbi, &node->i, nid); + fsck_disconnect_file_idnode(sbi, &node->i, nid, + dealloc); break; case 4: /* double indirect node */ - fsck_failed_reconnect_file_didnode(sbi, &node->i, nid); + fsck_disconnect_file_didnode(sbi, &node->i, nid, + dealloc); break; } } =20 + if (dealloc) + release_nat_entry(sbi, ino); + free(node); } =20 @@ -3121,7 +3185,7 @@ static int fsck_reconnect_file(struct f2fs_sb_info *s= bi) if (fsck_do_reconnect_file(sbi, lpf_node, node)) { DBG(1, "Failed to reconnect inode [0x%x]\n", nid); - fsck_failed_reconnect_file(sbi, nid); + fsck_disconnect_file(sbi, nid, false); continue; } =20 diff --git a/fsck/segment.c b/fsck/segment.c index 3a9500f..4e326c4 100644 --- a/fsck/segment.c +++ b/fsck/segment.c @@ -37,7 +37,7 @@ int reserve_new_block(struct f2fs_sb_info *sbi, block_t *= to, return -ENOSPC; } if (is_node && fsck->chk.valid_node_cnt >=3D - sbi->total_valid_node_count) { + sbi->total_node_count) { ERR_MSG("Not enough space for node block\n"); return -ENOSPC; } @@ -76,7 +76,7 @@ int reserve_new_block(struct f2fs_sb_info *sbi, block_t *= to, =20 se =3D get_seg_entry(sbi, GET_SEGNO(sbi, blkaddr)); offset =3D OFFSET_IN_SEG(sbi, blkaddr); - se->type =3D type; + se->type =3D se->orig_type =3D type; if (se->valid_blocks =3D=3D 0) SM_I(sbi)->free_segments--; se->valid_blocks++; @@ -101,6 +101,7 @@ int reserve_new_block(struct f2fs_sb_info *sbi, block_t= *to, if (c.func =3D=3D FSCK) { fsck->chk.valid_blk_cnt++; if (is_node) { + fsck->chk.valid_nat_entry_cnt++; fsck->chk.valid_node_cnt++; if (is_inode) fsck->chk.valid_inode_cnt++; --=20 2.42.0.820.g83a721a137-goog