From nobody Wed Dec 17 09:42:49 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D60C25B48 for ; Thu, 26 Oct 2023 22:33:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344970AbjJZWdx (ORCPT ); Thu, 26 Oct 2023 18:33:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbjJZWdv (ORCPT ); Thu, 26 Oct 2023 18:33:51 -0400 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [IPv6:2001:41d0:203:375::b7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1BC591 for ; Thu, 26 Oct 2023 15:33:48 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698359625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7wiIXHVKZViLnzrPPkXa8K3V9xAsF9dc3+hDNlwl8Us=; b=DockHeTSLWJS3ERDQQ+vQdQYjzFI2cE8pqfjeWbPs+7eooLKzDkjxQGpB3HmA5VqHJGkSp W6Ygtk0ICvM35OJJe8Yeyf4vzFXFxOh1hmy3yWs8cwlUkj25F2MZo/ficlYUspPUSNbCTG ypIvUVDuxmxvQYyAUsT6qT6DD9WW/sc= From: andrey.konovalov@linux.dev To: Andrew Morton Cc: Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: [PATCH] fix for "lib/stackdepot: allow users to evict stack traces" Date: Fri, 27 Oct 2023 00:33:40 +0200 Message-Id: <20231026223340.333159-1-andrey.konovalov@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" From: Andrey Konovalov Commit "lib/stackdepot: allow users to evict stack traces" adds another user for depot_fetch_stack, which holds a write lock. Thus, we need to update the lockdep annotation. Signed-off-by: Andrey Konovalov --- lib/stackdepot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 3a8f045696fd..cf707ff32d7d 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -388,7 +388,7 @@ static struct stack_record *depot_fetch_stack(depot_sta= ck_handle_t handle) size_t offset =3D parts.offset << DEPOT_STACK_ALIGN; struct stack_record *stack; =20 - lockdep_assert_held_read(&pool_rwlock); + lockdep_assert_held(&pool_rwlock); =20 if (parts.pool_index > pools_num) { WARN(1, "pool index %d out of bounds (%d) for stack id %08x\n", --=20 2.25.1