From nobody Wed Dec 17 09:45:03 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7084C25B48 for ; Thu, 26 Oct 2023 18:18:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230340AbjJZSS3 (ORCPT ); Thu, 26 Oct 2023 14:18:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231701AbjJZSS0 (ORCPT ); Thu, 26 Oct 2023 14:18:26 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6F7E1BD for ; Thu, 26 Oct 2023 11:18:24 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9cc6c92d1e9so36040366b.1 for ; Thu, 26 Oct 2023 11:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698344303; x=1698949103; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=vTA02l0ubFVwBtbEfhw+KExb6bkxv2C0e8twmLrMufI=; b=J0NwBsvC9wBnqtFFoewVnsHvlxPqQTjLUnS6at9Dm+82kS3TWTMaeRLkBbEOzjIJUx uRTWkFJWImp/8B5khUz+eP0cdU2kUqaNBQujCgU6VVKzKrjlgDe5xvCGqkPpnZRMPfAE 7eO5qLHR3wHF2KvkpvPnxP8sqWlX3Ap7g5vcENXnrev9FL4TDP8b24pOgONDJ1rLsj81 JAbS+kggMFHHCBCG0zke+vPToWOsvRsj4RIVX6it44/g3OaWHOU+7b8KWHX5HAC7O3yP oHgPxgTRSmDVTm6BdNyna/erkm2nd4cYHvM132vpU9GmtCQpmK2EVCz2WZs7yKqfyubO kqGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698344303; x=1698949103; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vTA02l0ubFVwBtbEfhw+KExb6bkxv2C0e8twmLrMufI=; b=cpW/uIIoA0cWPsSfEgOatRNXceb72QyKChMZxREj46OtGgh70ryGaQ7ZYwglI9UprT ySaU/p7CXBDKtejBJV7aFwU9txD4gZppEEv9na6M7WgLGAx5y6KQxM8YeHhPKb1rBbec HFDYwp3ZQDt8a0xe/PYIXvDtWn069KzJ7SxutulgphInbTMfRtuM5npFQVwktL/xl6BP vP4J8MOUsa6LV+7Xb3E0F2rD1P80Eh1lAtElN5N/lHqm/pGM/TmAA66EuR/HGmXRmPFB 1EKDNPfkkERsk09SURbffp9vWe5Bqdzfeha7kWgOc/kjqguih9C85dRiNH/QnLZeDMp5 Zr0A== X-Gm-Message-State: AOJu0YxC/LbEX+o77DMYADcjbSSBY0S2f7ZYycHCucUsFQca3G7KgKs+ +KsvvBbEXF0jkpj3V4xNPvw= X-Google-Smtp-Source: AGHT+IGb0c8y+EU7pwRJSbuKmhoEYLvnT63W8kJwHC0nVjFBNZz0yidGLURr40R2g12EmezF/bBVmw== X-Received: by 2002:a17:907:2d27:b0:9c7:5db4:8080 with SMTP id gs39-20020a1709072d2700b009c75db48080mr348999ejc.7.1698344302945; Thu, 26 Oct 2023 11:18:22 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id p6-20020a1709060e8600b0098e78ff1a87sm11985037ejf.120.2023.10.26.11.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 11:18:22 -0700 (PDT) Date: Thu, 26 Oct 2023 20:18:21 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Dan Carpenter Subject: [PATCH] staging: rtl8192e: Fix line break issue at priv->rx_buf[priv->rx_idx] Message-ID: <20231026181821.GA21819@matrix-ESPRIMO-P710> MIME-Version: 1.0 Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Fix line break at priv->rx_buf[priv->rx_idx] to increase readability. Suggested-by: Dan Carpenter Signed-off-by: Philipp Hortmann --- Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s) Transferred this patch over wlan connection of rtl8192e. --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index d2a8a9543579..995daab906c9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1610,8 +1610,7 @@ static void _rtl92e_rx_normal(struct net_device *dev) skb =3D new_skb; skb->dev =3D dev; =20 - priv->rx_buf[priv->rx_idx] =3D - skb; + priv->rx_buf[priv->rx_idx] =3D skb; *((dma_addr_t *)skb->cb) =3D dma_map_single(&priv->pdev->dev, skb_tail_pointer(skb), priv->rxbuffersize, DMA_FROM_DEVICE); --=20 2.42.0