From nobody Wed Dec 17 14:39:11 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C677C0032E for ; Wed, 25 Oct 2023 08:42:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234218AbjJYImS (ORCPT ); Wed, 25 Oct 2023 04:42:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233934AbjJYImL (ORCPT ); Wed, 25 Oct 2023 04:42:11 -0400 Received: from proxmox1.postmarketos.org (proxmox1.postmarketos.org [IPv6:2a01:4f8:a0:821d::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AB68A12A; Wed, 25 Oct 2023 01:42:07 -0700 (PDT) From: Stefan Hansson DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=postmarketos.org; s=donut; t=1698223326; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/HoYYApUTlWYJVt7ca7iblZiwUCik47KjINRgjcfULs=; b=rifGlJP0E7sLBIGODTaemHjHfkAP4BRuaYylZ7vNLdIGl5oPhBgC07MF3+JwUWyLwtBmvb 2MmjWpHnFzk2jaqxcCuaZ4bcx2iW7FIRD1inq4Y3/YJxMXH5VHmjOJ3yTrkW94cZuili1f Ut+61IWihy7pdpzfJz4mvMW14jHxBvk= To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, Stefan Hansson Subject: [PATCH v3 1/4] ARM: dts: qcom: samsung-matisse-common: Add initial common device tree Date: Wed, 25 Oct 2023 10:37:49 +0200 Message-ID: <20231025083952.12367-2-newbyte@postmarketos.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231025083952.12367-1-newbyte@postmarketos.org> References: <20231025083952.12367-1-newbyte@postmarketos.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org According to the dts from the kernel source code released by Samsung, matissewifi and matisselte only have minor differences in hardware, so use a shared dtsi to reduce duplicated code. Additionally, this should make adding support for matisse3g easier should someone want to do that at a later point. As such, add a common device tree for all matisse devices by Samsung based on the matissewifi dts. Support for matisselte will be introduced in a later patch in this series and will use the common dtsi as well. Signed-off-by: Stefan Hansson --- .../qcom-apq8026-samsung-matisse-wifi.dts | 589 +++--------------- ... qcom-msm8226-samsung-matisse-common.dtsi} | 59 +- 2 files changed, 77 insertions(+), 571 deletions(-) rewrite arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts (89%) copy arch/arm/boot/dts/qcom/{qcom-apq8026-samsung-matisse-wifi.dts =3D> qc= om-msm8226-samsung-matisse-common.dtsi} (90%) diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts b= /arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts dissimilarity index 89% index f516e0426bb9..98d4bb797617 100644 --- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts +++ b/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts @@ -1,519 +1,70 @@ -// SPDX-License-Identifier: BSD-3-Clause -/* - * Copyright (c) 2022, Matti Lehtim=C3=A4ki - */ - -/dts-v1/; - -#include -#include "qcom-msm8226.dtsi" -#include "qcom-pm8226.dtsi" - -/delete-node/ &adsp_region; -/delete-node/ &smem_region; - -/ { - model =3D "Samsung Galaxy Tab 4 10.1"; - compatible =3D "samsung,matisse-wifi", "qcom,apq8026"; - chassis-type =3D "tablet"; - - aliases { - mmc0 =3D &sdhc_1; /* SDC1 eMMC slot */ - mmc1 =3D &sdhc_2; /* SDC2 SD card slot */ - display0 =3D &framebuffer0; - }; - - chosen { - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; - - stdout-path =3D "display0"; - - framebuffer0: framebuffer@3200000 { - compatible =3D "simple-framebuffer"; - reg =3D <0x03200000 0x800000>; - width =3D <1280>; - height =3D <800>; - stride =3D <(1280 * 3)>; - format =3D "r8g8b8"; - }; - }; - - gpio-hall-sensor { - compatible =3D "gpio-keys"; - - event-hall-sensor { - label =3D "Hall Effect Sensor"; - gpios =3D <&tlmm 110 GPIO_ACTIVE_LOW>; - linux,input-type =3D ; - linux,code =3D ; - debounce-interval =3D <15>; - linux,can-disable; - wakeup-source; - }; - }; - - gpio-keys { - compatible =3D "gpio-keys"; - autorepeat; - - key-home { - label =3D "Home"; - gpios =3D <&tlmm 108 GPIO_ACTIVE_LOW>; - linux,code =3D ; - debounce-interval =3D <15>; - }; - - key-volume-down { - label =3D "Volume Down"; - gpios =3D <&tlmm 107 GPIO_ACTIVE_LOW>; - linux,code =3D ; - debounce-interval =3D <15>; - }; - - key-volume-up { - label =3D "Volume Up"; - gpios =3D <&tlmm 106 GPIO_ACTIVE_LOW>; - linux,code =3D ; - debounce-interval =3D <15>; - }; - }; - - i2c-backlight { - compatible =3D "i2c-gpio"; - sda-gpios =3D <&tlmm 20 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; - scl-gpios =3D <&tlmm 21 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>; - - pinctrl-0 =3D <&backlight_i2c_default_state>; - pinctrl-names =3D "default"; - - i2c-gpio,delay-us =3D <4>; - - #address-cells =3D <1>; - #size-cells =3D <0>; - - backlight@2c { - compatible =3D "ti,lp8556"; - reg =3D <0x2c>; - - dev-ctrl =3D /bits/ 8 <0x80>; - init-brt =3D /bits/ 8 <0x3f>; - - pwms =3D <&backlight_pwm 0 100000>; - pwm-names =3D "lp8556"; - - rom-a0h { - rom-addr =3D /bits/ 8 <0xa0>; - rom-val =3D /bits/ 8 <0x44>; - }; - - rom-a1h { - rom-addr =3D /bits/ 8 <0xa1>; - rom-val =3D /bits/ 8 <0x6c>; - }; - - rom-a5h { - rom-addr =3D /bits/ 8 <0xa5>; - rom-val =3D /bits/ 8 <0x24>; - }; - }; - }; - - backlight_pwm: pwm { - compatible =3D "clk-pwm"; - #pwm-cells =3D <2>; - clocks =3D <&mmcc CAMSS_GP0_CLK>; - pinctrl-0 =3D <&backlight_pwm_default_state>; - pinctrl-names =3D "default"; - }; - - reg_tsp_1p8v: regulator-tsp-1p8v { - compatible =3D "regulator-fixed"; - regulator-name =3D "tsp_1p8v"; - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <1800000>; - - gpio =3D <&tlmm 31 GPIO_ACTIVE_HIGH>; - enable-active-high; - - pinctrl-names =3D "default"; - pinctrl-0 =3D <&tsp_en_default_state>; - }; - - reg_tsp_3p3v: regulator-tsp-3p3v { - compatible =3D "regulator-fixed"; - regulator-name =3D "tsp_3p3v"; - regulator-min-microvolt =3D <3300000>; - regulator-max-microvolt =3D <3300000>; - - gpio =3D <&tlmm 73 GPIO_ACTIVE_HIGH>; - enable-active-high; - - pinctrl-names =3D "default"; - pinctrl-0 =3D <&tsp_en1_default_state>; - }; - - reserved-memory { - #address-cells =3D <1>; - #size-cells =3D <1>; - ranges; - - framebuffer@3200000 { - reg =3D <0x03200000 0x800000>; - no-map; - }; - - mpss@8400000 { - reg =3D <0x08400000 0x1f00000>; - no-map; - }; - - mba@a300000 { - reg =3D <0x0a300000 0x100000>; - no-map; - }; - - reserved@cb00000 { - reg =3D <0x0cb00000 0x700000>; - no-map; - }; - - wcnss@d200000 { - reg =3D <0x0d200000 0x700000>; - no-map; - }; - - adsp_region: adsp@d900000 { - reg =3D <0x0d900000 0x1800000>; - no-map; - }; - - venus@f100000 { - reg =3D <0x0f100000 0x500000>; - no-map; - }; - - smem_region: smem@fa00000 { - reg =3D <0x0fa00000 0x100000>; - no-map; - }; - - reserved@fb00000 { - reg =3D <0x0fb00000 0x260000>; - no-map; - }; - - rfsa@fd60000 { - reg =3D <0x0fd60000 0x20000>; - no-map; - }; - - rmtfs@fd80000 { - compatible =3D "qcom,rmtfs-mem"; - reg =3D <0x0fd80000 0x180000>; - no-map; - - qcom,client-id =3D <1>; - }; - }; -}; - -&adsp { - status =3D "okay"; -}; - -&blsp1_i2c2 { - status =3D "okay"; - - accelerometer@1d { - compatible =3D "st,lis2hh12"; - reg =3D <0x1d>; - - interrupt-parent =3D <&tlmm>; - interrupts =3D <54 IRQ_TYPE_LEVEL_HIGH>; - - pinctrl-names =3D "default"; - pinctrl-0 =3D <&accel_int_default_state>; - - st,drdy-int-pin =3D <1>; - - vdd-supply =3D <&pm8226_l19>; - vddio-supply =3D <&pm8226_lvs1>; - }; -}; - -&blsp1_i2c4 { - status =3D "okay"; - - muic: usb-switch@25 { - compatible =3D "siliconmitus,sm5502-muic"; - reg =3D <0x25>; - - interrupt-parent =3D <&tlmm>; - interrupts =3D <67 IRQ_TYPE_EDGE_FALLING>; - - pinctrl-names =3D "default"; - pinctrl-0 =3D <&muic_int_default_state>; - }; -}; - -&blsp1_i2c5 { - status =3D "okay"; - - touchscreen@4a { - compatible =3D "atmel,maxtouch"; - reg =3D <0x4a>; - - interrupt-parent =3D <&tlmm>; - interrupts =3D <17 IRQ_TYPE_LEVEL_LOW>; - - pinctrl-names =3D "default"; - pinctrl-0 =3D <&tsp_int_rst_default_state>; - - reset-gpios =3D <&pm8226_gpios 6 GPIO_ACTIVE_LOW>; - - vdd-supply =3D <®_tsp_1p8v>; - vdda-supply =3D <®_tsp_3p3v>; - }; -}; - -&rpm_requests { - regulators { - compatible =3D "qcom,rpm-pm8226-regulators"; - - pm8226_s3: s3 { - regulator-min-microvolt =3D <1200000>; - regulator-max-microvolt =3D <1300000>; - }; - - pm8226_s4: s4 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <1800000>; - }; - - pm8226_s5: s5 { - regulator-min-microvolt =3D <1150000>; - regulator-max-microvolt =3D <1150000>; - }; - - pm8226_l1: l1 { - regulator-min-microvolt =3D <1225000>; - regulator-max-microvolt =3D <1225000>; - }; - - pm8226_l2: l2 { - regulator-min-microvolt =3D <1200000>; - regulator-max-microvolt =3D <1200000>; - }; - - pm8226_l3: l3 { - regulator-min-microvolt =3D <750000>; - regulator-max-microvolt =3D <1337500>; - regulator-always-on; - }; - - pm8226_l4: l4 { - regulator-min-microvolt =3D <1200000>; - regulator-max-microvolt =3D <1200000>; - }; - - pm8226_l5: l5 { - regulator-min-microvolt =3D <1200000>; - regulator-max-microvolt =3D <1200000>; - }; - - pm8226_l6: l6 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <1800000>; - regulator-always-on; - }; - - pm8226_l7: l7 { - regulator-min-microvolt =3D <1850000>; - regulator-max-microvolt =3D <1850000>; - }; - - pm8226_l8: l8 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <1800000>; - regulator-always-on; - }; - - pm8226_l9: l9 { - regulator-min-microvolt =3D <2050000>; - regulator-max-microvolt =3D <2050000>; - }; - - pm8226_l10: l10 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <1800000>; - }; - - pm8226_l12: l12 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <1800000>; - }; - - pm8226_l14: l14 { - regulator-min-microvolt =3D <2750000>; - regulator-max-microvolt =3D <2750000>; - }; - - pm8226_l15: l15 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <3300000>; - }; - - pm8226_l16: l16 { - regulator-min-microvolt =3D <3000000>; - regulator-max-microvolt =3D <3350000>; - }; - - pm8226_l17: l17 { - regulator-min-microvolt =3D <2950000>; - regulator-max-microvolt =3D <2950000>; - - regulator-system-load =3D <200000>; - regulator-allow-set-load; - regulator-always-on; - }; - - pm8226_l18: l18 { - regulator-min-microvolt =3D <2950000>; - regulator-max-microvolt =3D <2950000>; - }; - - pm8226_l19: l19 { - regulator-min-microvolt =3D <2850000>; - regulator-max-microvolt =3D <3000000>; - }; - - pm8226_l20: l20 { - regulator-min-microvolt =3D <3075000>; - regulator-max-microvolt =3D <3075000>; - }; - - pm8226_l21: l21 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <2950000>; - }; - - pm8226_l22: l22 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <3000000>; - }; - - pm8226_l23: l23 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <3300000>; - }; - - pm8226_l24: l24 { - regulator-min-microvolt =3D <1300000>; - regulator-max-microvolt =3D <1350000>; - }; - - pm8226_l25: l25 { - regulator-min-microvolt =3D <1775000>; - regulator-max-microvolt =3D <2125000>; - }; - - pm8226_l26: l26 { - regulator-min-microvolt =3D <1225000>; - regulator-max-microvolt =3D <1300000>; - }; - - pm8226_l27: l27 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <1800000>; - }; - - pm8226_l28: l28 { - regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <2950000>; - }; - - pm8226_lvs1: lvs1 {}; - }; -}; - -&sdhc_1 { - vmmc-supply =3D <&pm8226_l17>; - vqmmc-supply =3D <&pm8226_l6>; - - bus-width =3D <8>; - non-removable; - - status =3D "okay"; -}; - -&sdhc_2 { - vmmc-supply =3D <&pm8226_l18>; - vqmmc-supply =3D <&pm8226_l21>; - - bus-width =3D <4>; - cd-gpios =3D <&tlmm 38 GPIO_ACTIVE_LOW>; - - status =3D "okay"; -}; - -&tlmm { - accel_int_default_state: accel-int-default-state { - pins =3D "gpio54"; - function =3D "gpio"; - drive-strength =3D <2>; - bias-disable; - }; - - backlight_i2c_default_state: backlight-i2c-default-state { - pins =3D "gpio20", "gpio21"; - function =3D "gpio"; - drive-strength =3D <2>; - bias-disable; - }; - - backlight_pwm_default_state: backlight-pwm-default-state { - pins =3D "gpio33"; - function =3D "gp0_clk"; - }; - - muic_int_default_state: muic-int-default-state { - pins =3D "gpio67"; - function =3D "gpio"; - drive-strength =3D <2>; - bias-disable; - }; - - tsp_en_default_state: tsp-en-default-state { - pins =3D "gpio31"; - function =3D "gpio"; - drive-strength =3D <2>; - bias-disable; - }; - - tsp_en1_default_state: tsp-en1-default-state { - pins =3D "gpio73"; - function =3D "gpio"; - drive-strength =3D <2>; - bias-disable; - }; - - tsp_int_rst_default_state: tsp-int-rst-default-state { - pins =3D "gpio17"; - function =3D "gpio"; - drive-strength =3D <10>; - bias-pull-up; - }; -}; - -&usb { - extcon =3D <&muic>, <&muic>; - status =3D "okay"; -}; - -&usb_hs_phy { - extcon =3D <&muic>; - v1p8-supply =3D <&pm8226_l10>; - v3p3-supply =3D <&pm8226_l20>; -}; +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) 2022, Matti Lehtim=C3=A4ki + */ + +/dts-v1/; + +#include "qcom-msm8226-samsung-matisse-common.dtsi" + +/ { + model =3D "Samsung Galaxy Tab 4 10.1"; + compatible =3D "samsung,matisse-wifi", "qcom,apq8026"; + chassis-type =3D "tablet"; +}; + +&blsp1_i2c2 { + status =3D "okay"; + + accelerometer@1d { + compatible =3D "st,lis2hh12"; + reg =3D <0x1d>; + + interrupt-parent =3D <&tlmm>; + interrupts =3D <54 IRQ_TYPE_LEVEL_HIGH>; + + pinctrl-names =3D "default"; + pinctrl-0 =3D <&accel_int_default_state>; + + st,drdy-int-pin =3D <1>; + + vdd-supply =3D <&pm8226_l19>; + vddio-supply =3D <&pm8226_lvs1>; + }; +}; + +&blsp1_i2c5 { + status =3D "okay"; + + touchscreen@4a { + compatible =3D "atmel,maxtouch"; + reg =3D <0x4a>; + + interrupt-parent =3D <&tlmm>; + interrupts =3D <17 IRQ_TYPE_LEVEL_LOW>; + + pinctrl-names =3D "default"; + pinctrl-0 =3D <&tsp_int_rst_default_state>; + + reset-gpios =3D <&pm8226_gpios 6 GPIO_ACTIVE_LOW>; + + vdd-supply =3D <®_tsp_1p8v>; + vdda-supply =3D <®_tsp_3p3v>; + }; +}; + +&pm8226_l3 { + regulator-max-microvolt =3D <1337500>; +}; + +&pm8226_s4 { + regulator-max-microvolt =3D <1800000>; +}; + +®_tsp_3p3v { + gpio =3D <&tlmm 73 GPIO_ACTIVE_HIGH>; +}; + +&tsp_en1_default_state { + pins =3D "gpio73"; +}; diff --git a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts b= /arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi similarity index 90% copy from arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts copy to arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi index f516e0426bb9..11fec4e963b7 100644 --- a/arch/arm/boot/dts/qcom/qcom-apq8026-samsung-matisse-wifi.dts +++ b/arch/arm/boot/dts/qcom/qcom-msm8226-samsung-matisse-common.dtsi @@ -1,10 +1,9 @@ // SPDX-License-Identifier: BSD-3-Clause /* * Copyright (c) 2022, Matti Lehtim=C3=A4ki + * Copyright (c) 2023, Stefan Hansson */ =20 -/dts-v1/; - #include #include "qcom-msm8226.dtsi" #include "qcom-pm8226.dtsi" @@ -13,10 +12,6 @@ /delete-node/ &smem_region; =20 / { - model =3D "Samsung Galaxy Tab 4 10.1"; - compatible =3D "samsung,matisse-wifi", "qcom,apq8026"; - chassis-type =3D "tablet"; - aliases { mmc0 =3D &sdhc_1; /* SDC1 eMMC slot */ mmc1 =3D &sdhc_2; /* SDC2 SD card slot */ @@ -137,8 +132,8 @@ reg_tsp_1p8v: regulator-tsp-1p8v { gpio =3D <&tlmm 31 GPIO_ACTIVE_HIGH>; enable-active-high; =20 - pinctrl-names =3D "default"; pinctrl-0 =3D <&tsp_en_default_state>; + pinctrl-names =3D "default"; }; =20 reg_tsp_3p3v: regulator-tsp-3p3v { @@ -147,11 +142,11 @@ reg_tsp_3p3v: regulator-tsp-3p3v { regulator-min-microvolt =3D <3300000>; regulator-max-microvolt =3D <3300000>; =20 - gpio =3D <&tlmm 73 GPIO_ACTIVE_HIGH>; + /* GPIO is board-specific */ enable-active-high; =20 - pinctrl-names =3D "default"; pinctrl-0 =3D <&tsp_en1_default_state>; + pinctrl-names =3D "default"; }; =20 reserved-memory { @@ -223,26 +218,6 @@ &adsp { status =3D "okay"; }; =20 -&blsp1_i2c2 { - status =3D "okay"; - - accelerometer@1d { - compatible =3D "st,lis2hh12"; - reg =3D <0x1d>; - - interrupt-parent =3D <&tlmm>; - interrupts =3D <54 IRQ_TYPE_LEVEL_HIGH>; - - pinctrl-names =3D "default"; - pinctrl-0 =3D <&accel_int_default_state>; - - st,drdy-int-pin =3D <1>; - - vdd-supply =3D <&pm8226_l19>; - vddio-supply =3D <&pm8226_lvs1>; - }; -}; - &blsp1_i2c4 { status =3D "okay"; =20 @@ -253,28 +228,8 @@ muic: usb-switch@25 { interrupt-parent =3D <&tlmm>; interrupts =3D <67 IRQ_TYPE_EDGE_FALLING>; =20 - pinctrl-names =3D "default"; pinctrl-0 =3D <&muic_int_default_state>; - }; -}; - -&blsp1_i2c5 { - status =3D "okay"; - - touchscreen@4a { - compatible =3D "atmel,maxtouch"; - reg =3D <0x4a>; - - interrupt-parent =3D <&tlmm>; - interrupts =3D <17 IRQ_TYPE_LEVEL_LOW>; - pinctrl-names =3D "default"; - pinctrl-0 =3D <&tsp_int_rst_default_state>; - - reset-gpios =3D <&pm8226_gpios 6 GPIO_ACTIVE_LOW>; - - vdd-supply =3D <®_tsp_1p8v>; - vdda-supply =3D <®_tsp_3p3v>; }; }; =20 @@ -287,9 +242,9 @@ pm8226_s3: s3 { regulator-max-microvolt =3D <1300000>; }; =20 + /* Upper voltage constraint is board-specific */ pm8226_s4: s4 { regulator-min-microvolt =3D <1800000>; - regulator-max-microvolt =3D <1800000>; }; =20 pm8226_s5: s5 { @@ -307,9 +262,9 @@ pm8226_l2: l2 { regulator-max-microvolt =3D <1200000>; }; =20 + /* Upper voltage constraint is board-specific */ pm8226_l3: l3 { regulator-min-microvolt =3D <750000>; - regulator-max-microvolt =3D <1337500>; regulator-always-on; }; =20 @@ -493,7 +448,7 @@ tsp_en_default_state: tsp-en-default-state { }; =20 tsp_en1_default_state: tsp-en1-default-state { - pins =3D "gpio73"; + /* pins is board-specific */ function =3D "gpio"; drive-strength =3D <2>; bias-disable; --=20 2.41.0