From nobody Thu Jan 1 07:18:43 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 878E2C07545 for ; Tue, 24 Oct 2023 18:21:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343969AbjJXSVF (ORCPT ); Tue, 24 Oct 2023 14:21:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343663AbjJXSVD (ORCPT ); Tue, 24 Oct 2023 14:21:03 -0400 Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91B0210A; Tue, 24 Oct 2023 11:21:01 -0700 (PDT) Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-577fff1cae6so36653a12.1; Tue, 24 Oct 2023 11:21:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698171661; x=1698776461; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dRlXCpMCmorDXOQl5AgNkn9c/v2fok4N7mYXHXKr4U4=; b=b9DO/aCYjUCg6N/1ZzVx+QXyGGHy7YK5i5x1HX+1RFfzXuei1THCtRaIIh+uZ3eGAY x/A2VXlliQ/7l32IfqhPe9+tvAeNp+itSdVxrBgvUP4kEBAqCcT1+qbXmwXP4utlQ6MN wyiBhSSLya2opWHfk58mKMbDThcsNnIxZxp6PR83/31QT34DYnC04ufnwu5RMeWDSixT kIDBXITs0OZfnVR4eyrht2Nww3ratpLICTkIMQfpsB+XzQbeBW8bkCqfr0rtLfqOk4gj sZzIRqz1v8/9IhNHukJP4zZuz6SzTSCXDRWHQv0j1G+wrsor+0cpaXzx8O+eNqC39+Ol u7/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698171661; x=1698776461; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dRlXCpMCmorDXOQl5AgNkn9c/v2fok4N7mYXHXKr4U4=; b=BsG8QYjHKgwiXlocyQcNdXxGBi8LlmUtvaWuXUMQ/S89kquHR3q61u7pslkEGsnVSm PZqCgs0nxCb2TIojalpQxgdvCgahgbYF52S+dM6QYgnfu7Msk4tyinOvwnq7I1haGF2z 56RXniQeC4PxAUESyFb3DK0w0QW4OPlIyjCoJ44CkOTOGMPm6XFZ6ZjiZVxTLxSzUs/d TYMmkBIq6BjwpVDeDGBjmgVuggthSa1xcbMKu1s4gk5lha1uEzpf5OadRu3RK1qCjzKx Dxd0QMVNa73Ml2l370dLo4SQKbMoE+X6Zu6tFzVXnY6Zu7v8uAe6ludaWzY6RE20kTTL Ob8g== X-Gm-Message-State: AOJu0YykZz7bLS9SUurUuZVf4xK3s8QVw5/oGWWz3lUkzGXzAF6+fT7i lzLxMtV/h38lAzvmwTXV8HI= X-Google-Smtp-Source: AGHT+IF9Oz5kRrdI+pmGEoGEJWNvqhDPhWIslaqJL9uAJb2+QwlbXjHaS7rUXRsLBBI3Ot5sGIFOLg== X-Received: by 2002:a05:6a20:9187:b0:17a:eff5:fbbe with SMTP id v7-20020a056a20918700b0017aeff5fbbemr4716343pzd.8.1698171660904; Tue, 24 Oct 2023 11:21:00 -0700 (PDT) Received: from brag-vm.. ([117.243.121.127]) by smtp.gmail.com with ESMTPSA id b28-20020aa78edc000000b006be0c9155aasm8105219pfr.91.2023.10.24.11.20.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 11:21:00 -0700 (PDT) From: Bragatheswaran Manickavel To: shannon.nelson@amd.com, brett.creeley@amd.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: Bragatheswaran Manickavel , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] amd/pds_core: core: No need for Null pointer check before kfree Date: Tue, 24 Oct 2023 23:50:51 +0530 Message-Id: <20231024182051.48513-1-bragathemanick0908@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" kfree()/vfree() internally perform NULL check on the pointer handed to it and take no action if it indeed is NULL. Hence there is no need for a pre-check of the memory pointer before handing it to kfree()/vfree(). Issue reported by ifnullfree.cocci Coccinelle semantic patch script. Signed-off-by: Bragatheswaran Manickavel Reviewed-by: Shannon Nelson Reviewed-by: Wojciech Drewek --- drivers/net/ethernet/amd/pds_core/core.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/amd/pds_core/core.c b/drivers/net/etherne= t/amd/pds_core/core.c index 2a8643e167e1..0d2091e9eb28 100644 --- a/drivers/net/ethernet/amd/pds_core/core.c +++ b/drivers/net/ethernet/amd/pds_core/core.c @@ -152,11 +152,8 @@ void pdsc_qcq_free(struct pdsc *pdsc, struct pdsc_qcq = *qcq) dma_free_coherent(dev, qcq->cq_size, qcq->cq_base, qcq->cq_base_pa); =20 - if (qcq->cq.info) - vfree(qcq->cq.info); - - if (qcq->q.info) - vfree(qcq->q.info); + vfree(qcq->cq.info); + vfree(qcq->q.info); =20 memset(qcq, 0, sizeof(*qcq)); } --=20 2.34.1