From nobody Thu Jan 1 08:59:20 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E8EC00A8F for ; Tue, 24 Oct 2023 13:17:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234245AbjJXNRA (ORCPT ); Tue, 24 Oct 2023 09:17:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232084AbjJXNQ6 (ORCPT ); Tue, 24 Oct 2023 09:16:58 -0400 X-Greylist: delayed 452 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Tue, 24 Oct 2023 06:16:53 PDT Received: from mx.swemel.ru (mx.swemel.ru [95.143.211.150]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80E8CC2; Tue, 24 Oct 2023 06:16:53 -0700 (PDT) From: Denis Arefev DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=swemel.ru; s=mail; t=1698152956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=hXmr2tFx6UpqbD02yGf2BN9YhkOrEZYGzBXYckcZFSs=; b=L8xQxTygCr/5WGn6hUiQF+9uJAo1fbJO4Qqu9OIoSozVN/Fiuoaw3vA+mrkeUXSuKChb4p IUNB0Z8sVPN1vvf9RrosmqdifQ44gJinOEoArbp0P9wan8uRVgtgpJJq/TUULhbJCwHnpL yMLFN5NE+d1hIANTIfl2BQ4pPVjxy4Q= To: Mauro Carvalho Chehab Cc: Sakari Ailus , Laurent Pinchart , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] media: marvell: Added function return value check clk_prepare Date: Tue, 24 Oct 2023 16:09:16 +0300 Message-Id: <20231024130916.19419-1-arefev@swemel.ru> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Return value of function 'clk_prepare', called at mcam-core.c:905, is not checked, but it is usually checked for this function. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Denis Arefev --- drivers/media/platform/marvell/mcam-core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/marvell/mcam-core.c b/drivers/media/pla= tform/marvell/mcam-core.c index 66688b4aece5..afb7f4009d96 100644 --- a/drivers/media/platform/marvell/mcam-core.c +++ b/drivers/media/platform/marvell/mcam-core.c @@ -901,9 +901,10 @@ static void mcam_ctlr_power_down(struct mcam_camera *c= am) static int mclk_prepare(struct clk_hw *hw) { struct mcam_camera *cam =3D container_of(hw, struct mcam_camera, mclk_hw); - - clk_prepare(cam->clk[0]); - return 0; + int ret; + + ret =3D clk_prepare(cam->clk[0]); + return ret; } =20 static void mclk_unprepare(struct clk_hw *hw) --=20 2.25.1