From nobody Thu Jan 1 08:57:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47184C00A8F for ; Tue, 24 Oct 2023 12:50:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234342AbjJXMue (ORCPT ); Tue, 24 Oct 2023 08:50:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234405AbjJXMuV (ORCPT ); Tue, 24 Oct 2023 08:50:21 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72870D79; Tue, 24 Oct 2023 05:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698151819; x=1729687819; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=knR7ls1kB5KT3RFeC+htrjrkzsMRNbLQDuFhEdcYC3I=; b=fKKAwqvxkCUp65mrkvSjley4uzLtMycVd9EwR53AZT3JP8yhSPGRGbY1 x8ZMnebWVwgWRDjnZiZC5Os6ZQrwj0HdfRMlTKfdeuWbZAqoVt5k0XwLW MEDWU3ocqCZ8EjSC03EPfrj8Stst4pyLZ7Kg7uV0vBV+G58r7Uqpo3eUf XJwCvC9cpM+On5+JBrXk2VLCsLIs3XYPzI6cQJACkmeGffc+aagnp2rzs 8lqZb+vSnc4JTTfDeUCo8jTOeb+6fKfQNMwERPelkqZ16qgfoPgEx9fxz oiikxgPhhnjGf3CugPyNxNjySFIJfqhB+0RzU+PiXfa8et29Z/RizNC90 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="418172703" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="418172703" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 05:50:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="875061014" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="875061014" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 24 Oct 2023 05:50:13 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 5AD9681C; Tue, 24 Oct 2023 15:41:17 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Greg Kroah-Hartman , Jiri Slaby , Tony Lindgren Subject: [PATCH v1 1/3] serdev: Make use of device_set_node() Date: Tue, 24 Oct 2023 15:41:13 +0300 Message-Id: <20231024124115.3598090-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231024124115.3598090-1-andriy.shevchenko@linux.intel.com> References: <20231024124115.3598090-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use device_set_node() instead of assigning ctrl->dev.of_node directly because it also sets the firmware node. Signed-off-by: Andy Shevchenko --- drivers/tty/serdev/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index e7d663901c07..e46448efc48d 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -15,9 +15,11 @@ #include #include #include +#include #include #include #include + #include =20 static bool is_registered; @@ -510,7 +512,7 @@ struct serdev_controller *serdev_controller_alloc(struc= t device *parent, ctrl->dev.type =3D &serdev_ctrl_type; ctrl->dev.bus =3D &serdev_bus_type; ctrl->dev.parent =3D parent; - ctrl->dev.of_node =3D parent->of_node; + device_set_node(&ctrl->dev, dev_fwnode(parent)); serdev_controller_set_drvdata(ctrl, &ctrl[1]); =20 dev_set_name(&ctrl->dev, "serial%d", id); --=20 2.40.0.1.gaa8946217a0b From nobody Thu Jan 1 08:57:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE03FC25B48 for ; Tue, 24 Oct 2023 12:41:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234292AbjJXMlY (ORCPT ); Tue, 24 Oct 2023 08:41:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231815AbjJXMlX (ORCPT ); Tue, 24 Oct 2023 08:41:23 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2BA890; Tue, 24 Oct 2023 05:41:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698151281; x=1729687281; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Nem6qrCq+0poVCw5HdXcByXmMdoy6+KHsYkGPkm5hkI=; b=bJGqpbEQpmuDdyhrIVKqlLxF1+bG1Gb+EJfJbv0TVvmYR5TQO2aaluHV +tzrS3jDiJCRnnMecvwXxgjVIcwQ1Mwgf9WNPAWzUydn+bKCY3PR5tBs1 m5cFR7Qdsm6xJOzru4KbezSa3srLDJ5Op+7p25E17vyn62bBeoJBPe/Uu uqT7ZvlCbZacx3PFC9juQQ27UQly6YCYiNPFZ+ZcN0jawT6GwSIZGkleJ kk095WOnRlMv2JwSs1dYhoebLsIExgPXJkULrpTxAOq7KKr/Oy1MHUNzy MFEfHj35jzwxkpWuCbSIv+B2VEM6mdhAQP6uIixmKzXcJQ/WZcz4TKB8q Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="389894161" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="389894161" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 05:41:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="1089822129" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="1089822129" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 24 Oct 2023 05:41:18 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 5DF5E9CE; Tue, 24 Oct 2023 15:41:17 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Greg Kroah-Hartman , Jiri Slaby , Tony Lindgren Subject: [PATCH v1 2/3] serdev: Simplify devm_serdev_device_open() function Date: Tue, 24 Oct 2023 15:41:14 +0300 Message-Id: <20231024124115.3598090-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231024124115.3598090-1-andriy.shevchenko@linux.intel.com> References: <20231024124115.3598090-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Use devm_add_action_or_reset() instead of devres_alloc() and devres_add(), which works the same. This will simplify the code. There is no functional changes. Signed-off-by: Andy Shevchenko --- drivers/tty/serdev/core.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index e46448efc48d..6a1e75f98f16 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -187,30 +187,20 @@ void serdev_device_close(struct serdev_device *serdev) } EXPORT_SYMBOL_GPL(serdev_device_close); =20 -static void devm_serdev_device_release(struct device *dev, void *dr) +static void devm_serdev_device_close(void *serdev) { - serdev_device_close(*(struct serdev_device **)dr); + serdev_device_close(serdev); } =20 int devm_serdev_device_open(struct device *dev, struct serdev_device *serd= ev) { - struct serdev_device **dr; int ret; =20 - dr =3D devres_alloc(devm_serdev_device_release, sizeof(*dr), GFP_KERNEL); - if (!dr) - return -ENOMEM; - ret =3D serdev_device_open(serdev); - if (ret) { - devres_free(dr); + if (ret) return ret; - } =20 - *dr =3D serdev; - devres_add(dev, dr); - - return 0; + return devm_add_action_or_reset(dev, devm_serdev_device_close, serdev); } EXPORT_SYMBOL_GPL(devm_serdev_device_open); =20 --=20 2.40.0.1.gaa8946217a0b From nobody Thu Jan 1 08:57:39 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D54D3C07545 for ; Tue, 24 Oct 2023 12:50:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234430AbjJXMuZ (ORCPT ); Tue, 24 Oct 2023 08:50:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234396AbjJXMuU (ORCPT ); Tue, 24 Oct 2023 08:50:20 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 404E410D5; Tue, 24 Oct 2023 05:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698151817; x=1729687817; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=KaitaaTgM9cu8b9iRzHkj5trQ0LrGSk+xNOF3Ya/2bQ=; b=HhVzcX/jwDB6uNwqWJX/qTrVtYxgVVUaFSL9U0bCPaVoii8CL/y4rhun UEp5U3l7XpWxxigmvhvTItCAcff+wQmc70Ldk/e/YLSt3/Xi9GtvpfwWt ZFMQIqmsRWaDs6NjTymt96yioZFv2wx3IBXJD+0XS52D6mVBKR/DniU1Y PMiOFR4yEGBpHRP+B2DEpq+oKQwHEDZ6FVAiU12S17f7azmgTeNpAnPeT 5iGkQsr4DRzf9jzFFL+ZcJwWxeuPfhsJLYJG5JznYMlyWs3UssNEsaMRq vZdcI8DWtIh1h15goqQfBf2neZ0oB4nf+gzNa01jkmAG7EveGSaOKISft A==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="418172698" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="418172698" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 05:50:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="875061013" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="875061013" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 24 Oct 2023 05:50:13 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 725ADBD4; Tue, 24 Oct 2023 15:41:17 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Rob Herring , Greg Kroah-Hartman , Jiri Slaby , Tony Lindgren Subject: [PATCH v1 3/3] serdev: Replace custom code with device_match_acpi_handle() Date: Tue, 24 Oct 2023 15:41:15 +0300 Message-Id: <20231024124115.3598090-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231024124115.3598090-1-andriy.shevchenko@linux.intel.com> References: <20231024124115.3598090-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Since driver core provides a generic device_match_acpi_handle() we may replace the custom code with it. Signed-off-by: Andy Shevchenko --- drivers/tty/serdev/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c index 6a1e75f98f16..a5fdaf5e148e 100644 --- a/drivers/tty/serdev/core.c +++ b/drivers/tty/serdev/core.c @@ -665,7 +665,7 @@ static int acpi_serdev_check_resources(struct serdev_co= ntroller *ctrl, acpi_get_parent(adev->handle, &lookup.controller_handle); =20 /* Make sure controller and ResourceSource handle match */ - if (ACPI_HANDLE(ctrl->dev.parent) !=3D lookup.controller_handle) + if (!device_match_acpi_handle(ctrl->dev.parent, lookup.controller_handle)) return -ENODEV; =20 return 0; --=20 2.40.0.1.gaa8946217a0b