From nobody Thu Jan 1 11:02:24 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8DBAC25B45 for ; Mon, 23 Oct 2023 19:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231958AbjJWTPs (ORCPT ); Mon, 23 Oct 2023 15:15:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229537AbjJWTPl (ORCPT ); Mon, 23 Oct 2023 15:15:41 -0400 Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 01C8694 for ; Mon, 23 Oct 2023 12:15:39 -0700 (PDT) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-5a8ee6a1801so49026597b3.3 for ; Mon, 23 Oct 2023 12:15:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698088539; x=1698693339; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:from:to:cc:subject:date:message-id:reply-to; bh=Fgbudwquptx3kxGF2Rx/jDbv8sQ1FkhX6MwfxQpq3LQ=; b=Jyt0/uLO9cpaOM5TuA8al91OF2xAYoGUDUZDSSBAyxeu7pjDhEfZnxhMpOE9L6GRHH CT0V4Ikd/IkpVXszW5k0EzyNFWcerRFEoYsPISXXs3YqSExFIpI7P9PvEZSl8tPc9DS6 hafeTTJncrdo8HYY3zmxQh4FRJnmEmD4GPgb40Yaib4dTp92X3T8swvhQt3HAUCP+X+J iqM0zRn+oTmkG/U1yYtpGL/TJ9aLZGKlPFjRw+fPBU6JzImK/F3UpfBws7UAAuqzBSwq 5I4rb5UGOGIuUiATt8fkyZNtQsi223GV9uXhZiV28dlMEY2P3oHklcRoyrDGWbec3rw0 WfHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698088539; x=1698693339; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:reply-to:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Fgbudwquptx3kxGF2Rx/jDbv8sQ1FkhX6MwfxQpq3LQ=; b=U7hR1A0LIPFpxl7cFWPdgjB/JodBy/TUEnYuwzNqfbSuH2SsXIa80z4xSq0jF2mb45 LiNi1Lnpyt0Ct8uBpaY5Fw9qN+bmyceQ0udXnDbm8qD2OfSHd5tKoJQLNqlRWlSxHkrP tJTF/akNv5jjWDOTLBDv0HXJ1qZYczOm2ckT+TAoQKrzxjPBFkTpX8HZoqZ3Kbz/2Tgg /UGfWvQ+imbGmK8b+fI4XsapLhJCN6GBmMWrSOfpWAdHurdAfYBydgdkEqMPZmgLhvZh NzS+VZFBkTfdzA9OBz4lxNInTNRvT1Lr6FgkoJ2t6vtzazNSRAMPWsGv7LJB9nKDwBXf p6Ew== X-Gm-Message-State: AOJu0YxV4UzgvlmuZZWZJAr2tfb5JkQOpnkbXLCkdSUXCs/o49abHr1M kHlUVgpCM53eyZs7QbrdSt3uUzqxqY4= X-Google-Smtp-Source: AGHT+IEudh7lv+vB3jmTBdAfnrXmjFNTxJ/CNAhB5midYZMIoFDKf8WDrbcSjw2PyODeBffCvgZo3fQJbXA= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a0d:db43:0:b0:5a7:ccf3:3f28 with SMTP id d64-20020a0ddb43000000b005a7ccf33f28mr200781ywe.0.1698088539262; Mon, 23 Oct 2023 12:15:39 -0700 (PDT) Reply-To: Sean Christopherson Date: Mon, 23 Oct 2023 12:15:29 -0700 In-Reply-To: <20231023191532.2405326-1-seanjc@google.com> Mime-Version: 1.0 References: <20231023191532.2405326-1-seanjc@google.com> X-Mailer: git-send-email 2.42.0.758.gaed0368e0e-goog Message-ID: <20231023191532.2405326-3-seanjc@google.com> Subject: [PATCH gmem 2/5] KVM: selftests: Handle memslot splits in private mem conversions test From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Roth Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rework the SYNC_{SHARED,PRIVATE} handling in the private memory conversion test to play nice with ranges that are covered by multiple memslots. This will allow letting the user specify the number of memslots, and more importantly allow testing KVM_SET_MEMORY_ATTRIBUTES calls that also split across memslots. Opportunistically update the error messages to clarify whether the assert fired in the guest vs. host. Signed-off-by: Sean Christopherson --- .../kvm/x86_64/private_mem_conversions_test.c | 44 +++++++++++-------- 1 file changed, 25 insertions(+), 19 deletions(-) diff --git a/tools/testing/selftests/kvm/x86_64/private_mem_conversions_tes= t.c b/tools/testing/selftests/kvm/x86_64/private_mem_conversions_test.c index c04e7d61a585..c3992a295b5a 100644 --- a/tools/testing/selftests/kvm/x86_64/private_mem_conversions_test.c +++ b/tools/testing/selftests/kvm/x86_64/private_mem_conversions_test.c @@ -28,25 +28,25 @@ #define PER_CPU_DATA_SIZE ((uint64_t)(SZ_2M + PAGE_SIZE)) =20 /* Horrific macro so that the line info is captured accurately :-( */ -#define memcmp_g(gpa, pattern, size) \ -do { \ - uint8_t *mem =3D (uint8_t *)gpa; \ - size_t i; \ - \ - for (i =3D 0; i < size; i++) \ - __GUEST_ASSERT(mem[i] =3D=3D pattern, \ - "Expected 0x%x at offset %lu (gpa 0x%llx), got 0x%x", \ - pattern, i, gpa + i, mem[i]); \ +#define memcmp_g(gpa, pattern, size) \ +do { \ + uint8_t *mem =3D (uint8_t *)gpa; \ + size_t i; \ + \ + for (i =3D 0; i < size; i++) \ + __GUEST_ASSERT(mem[i] =3D=3D pattern, \ + "Guest expected 0x%x at offset %lu (gpa 0x%llx), got 0x%x", \ + pattern, i, gpa + i, mem[i]); \ } while (0) =20 -static void memcmp_h(uint8_t *mem, uint8_t pattern, size_t size) +static void memcmp_h(uint8_t *mem, uint64_t gpa, uint8_t pattern, size_t s= ize) { size_t i; =20 for (i =3D 0; i < size; i++) TEST_ASSERT(mem[i] =3D=3D pattern, - "Expected 0x%x at offset %lu, got 0x%x", - pattern, i, mem[i]); + "Host expected 0x%x at gpa 0x%lx, got 0x%x", + pattern, gpa + i, mem[i]); } =20 /* @@ -335,19 +335,25 @@ static void *__test_mem_conversions(void *__vcpu) case UCALL_ABORT: REPORT_GUEST_ASSERT(uc); case UCALL_SYNC: { - uint8_t *hva =3D addr_gpa2hva(vm, uc.args[1]); - uint64_t size =3D uc.args[2]; + uint64_t gpa =3D uc.args[1]; + size_t size =3D uc.args[2]; + size_t i; =20 TEST_ASSERT(uc.args[0] =3D=3D SYNC_SHARED || uc.args[0] =3D=3D SYNC_PRIVATE, "Unknown sync command '%ld'", uc.args[0]); =20 - /* In all cases, the host should observe the shared data. */ - memcmp_h(hva, uc.args[3], size); + for (i =3D 0; i < size; i +=3D vm->page_size) { + size_t nr_bytes =3D min_t(size_t, vm->page_size, size - i); + uint8_t *hva =3D addr_gpa2hva(vm, gpa + i); =20 - /* For shared, write the new pattern to guest memory. */ - if (uc.args[0] =3D=3D SYNC_SHARED) - memset(hva, uc.args[4], size); + /* In all cases, the host should observe the shared data. */ + memcmp_h(hva, gpa + i, uc.args[3], nr_bytes); + + /* For shared, write the new pattern to guest memory. */ + if (uc.args[0] =3D=3D SYNC_SHARED) + memset(hva, uc.args[4], nr_bytes); + } break; } case UCALL_DONE: --=20 2.42.0.758.gaed0368e0e-goog