From nobody Thu Dec 18 15:31:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0DDCC004C0 for ; Mon, 23 Oct 2023 16:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233654AbjJWQRY (ORCPT ); Mon, 23 Oct 2023 12:17:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjJWQRS (ORCPT ); Mon, 23 Oct 2023 12:17:18 -0400 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2050.outbound.protection.outlook.com [40.107.249.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35765103 for ; Mon, 23 Oct 2023 09:17:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VEPtuHNCJ4L+r/69sIF8dnzICbsFzEGkVE5YCcw2y8IvtbQpywxabDSWjw/pH2txUuUgdPTz8SZHT7DAp3YrELHL4BLrG4k1+UESB7jprizJ5uXEOHDG9G84JU0v0ExTR2cTTXMO8+SqWwhXAXhVdjCZD21GUeFEeQ0EutNv+ndd3a7p81fD3VzeNhjLJAiocJgk/5GPY0M8Fi+U5dPPbl8WwBe8s5U5WSQ0E+kSt3NkWRBziHUls7tKPFJ4+FOrc1DM81Y9B2+13oaSMU1sZURsmieU9a82tAH0copaMy28JfQkAzkVRbvdYGszMZEli7DZyxZT/fprf1LKJC1GWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D6/0l63ENa1rCG9AOCfTVMMHkxQaSAkgSO/Y9e4768s=; b=mpnidE2G8Dj4rEXd63pZV1b3apmJvh9ZnNO+ZVQE98yEwP/Bu79ncIUOAyTbyy8pjLD/XhvwwC6LuoU841m/zRrarJtcRNu4BPj05akJSj4qw/fHanvxWT2TEjcmBaQc3O91ms+1htKWx2e/HGLi5o/3AH7aAjBgmoy1MWZc31SgwSaB/tos5RCoFDCcRLwoFi/mQJmliOuDRx8ZANiuFV88S5L3M7Hv/g2LhH/97S9GRwqCe3QYRw6jhv6Pv4gRbTDD4rZg+Oh5z00OUmFmYWCUsDIbh7fFGjGvUVnxgQiQdEVvRkiM9Wkz4NFItH/ACUJEN/5UHpPBf1aEXkRV9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6/0l63ENa1rCG9AOCfTVMMHkxQaSAkgSO/Y9e4768s=; b=eqkEEWN6Y6cZG4cfFM/fPzfThbRIIdKKPaHd3k9sGLUFNbdsEJUSKkIYKDQ26wFGNKl2aSIstmeADe5jtoNCCIa33aYqk7nvX0j4RXxtbvOTvSMob1r9HqVD7lxSuXty2LPU/1fV5Sx3guV4hzCAs5g66DL7rMqjDdsXec1hmWA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by PAXPR04MB8655.eurprd04.prod.outlook.com (2603:10a6:102:21e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.16; Mon, 23 Oct 2023 16:17:14 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098%6]) with mapi id 15.20.6933.011; Mon, 23 Oct 2023 16:17:14 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 1/6] i3c: master: svc: fix race condition in ibi work thread Date: Mon, 23 Oct 2023 12:16:53 -0400 Message-Id: <20231023161658.3890811-2-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231023161658.3890811-1-Frank.Li@nxp.com> References: <20231023161658.3890811-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY5PR20CA0002.namprd20.prod.outlook.com (2603:10b6:a03:1f4::15) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|PAXPR04MB8655:EE_ X-MS-Office365-Filtering-Correlation-Id: 8489aece-a84a-42fc-3c3d-08dbd3e384bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QGIVRFM0DhgJsZ7DOn0j/KOO4HpplLY5uZvEb8EXTbTOILKtN69HmexNHN+hxUygVPi42yUsGjTwiTsqw04XkW+h5lFqCDMt1wqn/dCCNAcRoeog4/MStnhUW7KAWfrMAShP+Lqb66IttY6Q9H0UH82/YZuRGOx19pItwM9NaEWBLRLeQJesL7q7LMC4pUPbDMWMZNTza1qIvEzQ/WncxZIpgWcPXqDfzThDHfY4qmufWbCyyf2E2KBbA4S334KbKjdsqOJDIdAbwPUV/yNIt1IjuDT4BLIwKBPvuQOqHey4Ihf5vcUzVu9FHsq3jB1qBkZb91inewNC2PLV+HC5rf3EzM+0h3LKczzRsxOyTtpDCaDb3vlOT78zfASGcmwslAyvG5BHHpSbsbqsInKFnKdDVLwoyLaWvVeyBNYw80qTjxbI+uKxOTrnkIX2Pl6N48782zxdLXlcctXEg6loYUmomdPV3c8EwcPGMsZYhj+yqax7Jl4y/l+By3wYeOuY1FkGfZLj9iuc/UW+5rYsDkdYiQuE8UEYQAwfA76B3B8JszBMmT8jR3T0XXh3l0/2O0pTugpDwdYMC3O9BLc3b9pmtCwt2sA9YTPs+AglFgOqsl//h1xxVJIxJ3+yyA3n X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(39860400002)(366004)(396003)(376002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(478600001)(6506007)(6512007)(6666004)(86362001)(316002)(41300700001)(6916009)(2906002)(6486002)(5660300002)(52116002)(36756003)(8676002)(2616005)(1076003)(26005)(38100700002)(8936002)(4326008)(66946007)(38350700005)(83380400001)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9xG898d1HPqildgpO2+8kvlb7/VOhVc51pME8yo8eVViiBsYLWg2KIvpmF6u?= =?us-ascii?Q?qE9xhocyi7LTVhNC7N1VTkkxpIY6qawS2iVORG4RzRpZ+amHrCbPt7/97pWq?= =?us-ascii?Q?W89CefpGJs3/nv3NMim0k6er91thvKDNY2byDkUPPG/zk/oCA2dq5Aj4bP/V?= =?us-ascii?Q?AjL21wvR8kkbf0cHrW9+YiEaa9Zx5fvSQpqNl7W5hNxrf6Aqi/ZHvlWm2hDQ?= =?us-ascii?Q?OuzUD0Af4X11PXfpmVtJ4vTW4wSZgXBA/jVLWqwTP9FaCiIZl3H7aLrpAaOe?= =?us-ascii?Q?Cem6cxdfw4K/OYwgTmljvZ6uRn11ipiIImp1my+XXBihiWXxDY+sQv8wxT+e?= =?us-ascii?Q?YqnW65NCGLRqkLdf2C0Nx1b3rm4GDyaWkUtBaJOIfL+Vu6rzPnU/rYlOyNGC?= =?us-ascii?Q?VefijjiWHbBxOAz59dTGFnzadGdcQa7Q2RmWO6C1hDridN/h3mZphZCyTeCE?= =?us-ascii?Q?YlL4/FYwmS1uRiggAZbZ8GwqX6iC0Cvoi7s3mTqQEtXr+m+edRlCFmVvyZpF?= =?us-ascii?Q?M6ZHVtiaMH6a2rgOlTmPplpSapUwlmK+avboal5yar86mEYWCWkICU9TlYGb?= =?us-ascii?Q?uttcy2uh7z53L2UmnY3M3xBMgTGCGefENMnU9xL+oGSp16sXp5TY1hlDvLwg?= =?us-ascii?Q?lWwJtVTFPN8bmbt21Gjj6q5iglaupYH/qrQs7aG0cOfmQvqJ5dB5H/bUZNxs?= =?us-ascii?Q?I2o96dCb//lyX+CLEGqjZiPK93khekQ/nX9GF6Jcu9Xfe/g52yEDpipu11Fm?= =?us-ascii?Q?BxJVbkXNGP+/W9W/LTH11TDwvO/1pEUCT4XOMlj3obfTs3+Ic6yksptqdMRD?= =?us-ascii?Q?GQ2OaLMLzqU6N+vqaeM4sAblWcTtFaTKPL381viGk00JP0QB0cmLO9iGlnZT?= =?us-ascii?Q?acRtQ+u37b2cTd74IhvGgtcHLDq2y1VrHwUvEkUn9oBNtlJX7p5RxqqMn+Wb?= =?us-ascii?Q?y4YmO71k95dBBUMogw5KbMXEt/v2JV5luiV4I1y9QPayfZWVtKZro3al8Nxh?= =?us-ascii?Q?Go6J4e6pdRL+w/9jCK8IjiJ74l7HQyvTHdQ9/7hyznkfsDw4nyoD34ZnUc7i?= =?us-ascii?Q?D6X7ZA20beFB51UttTpmpofkafS4JbiYeaV9j1bTqEfyo1Qc8GedmEbQBrby?= =?us-ascii?Q?zSF4LVb6JJOyC6VzQpPwnkawVRGOn4dTdU1VW1wWP9I1i2oEqL8EDMyNXVPn?= =?us-ascii?Q?E48oYVJ4GBkMXYNlscaUTVQRvVhzdWFTdqDLlLWabiYjvcfgOJSCT3HLureb?= =?us-ascii?Q?KrtVIywCAWySv9G2X6fnitG9dyvwQDi1jS2kncOmIZzxLCD5qpXyxY/jy/F8?= =?us-ascii?Q?BLkS7tkUupQ0gyyMEk7C9nZPImj4z+Xg422qY2Y0Xd+vPKcUQE6TYtTQN5Az?= =?us-ascii?Q?wHGBulUTKLmsRkSzpKbkLc+CV9cD5+xyh938cHKwTzWBHqKYS30cuRUgLztJ?= =?us-ascii?Q?FzjFYHNvwG43CVaL7JvtvaSdsiRa9iUfNekrwMTqo6mD873ithCdrGYUoMkq?= =?us-ascii?Q?tZL+6jLsznVTACeJEPcfPIpX0rIFKUKqF60L6ka9Ethh+02z0Le34WlYU9+N?= =?us-ascii?Q?ekr6YC/s25Mxkh8Ce6nVKIOJJ8e5XQOmZC6t0bdZ?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8489aece-a84a-42fc-3c3d-08dbd3e384bc X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:17:14.3524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9uflEK7zPHL/LXkr8Lfd/TBXARYo03GlXp4fmMfSYmqzDHcJqyyjNBM8uuBctIlw7bUzjNsglpJNEmZiEVuWTg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8655 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The ibi work thread operates asynchronously with other transfers, such as svc_i3c_master_priv_xfers(). Introduce mutex protection to ensure the completion of the entire i3c/i2c transaction. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Notes: Change from v1 to v2 - update commit message - Add Reviewed-by: Miquel Raynal drivers/i3c/master/svc-i3c-master.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index d29de5fe533e6..8cd708c965085 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -174,6 +174,7 @@ struct svc_i3c_regs_save { * @ibi.slots: Available IBI slots * @ibi.tbq_slot: To be queued IBI slot * @ibi.lock: IBI lock + * @lock: Transfer lock, protect between IBI work thread and callbacks fro= m master */ struct svc_i3c_master { struct i3c_master_controller base; @@ -202,6 +203,7 @@ struct svc_i3c_master { /* Prevent races within IBI handlers */ spinlock_t lock; } ibi; + struct mutex lock; }; =20 /** @@ -383,6 +385,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) u32 status, val; int ret; =20 + mutex_lock(&master->lock); /* Acknowledge the incoming interrupt with the AUTOIBI mechanism */ writel(SVC_I3C_MCTRL_REQUEST_AUTO_IBI | SVC_I3C_MCTRL_IBIRESP_AUTO, @@ -459,6 +462,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) =20 reenable_ibis: svc_i3c_master_enable_interrupts(master, SVC_I3C_MINT_SLVSTART); + mutex_unlock(&master->lock); } =20 static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id) @@ -1203,9 +1207,11 @@ static int svc_i3c_master_send_bdcast_ccc_cmd(struct= svc_i3c_master *master, cmd->read_len =3D 0; cmd->continued =3D false; =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 ret =3D xfer->ret; kfree(buf); @@ -1249,9 +1255,11 @@ static int svc_i3c_master_send_direct_ccc_cmd(struct= svc_i3c_master *master, cmd->read_len =3D read_len; cmd->continued =3D false; =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 if (cmd->read_len !=3D xfer_len) ccc->dests[0].payload.len =3D cmd->read_len; @@ -1308,9 +1316,11 @@ static int svc_i3c_master_priv_xfers(struct i3c_dev_= desc *dev, cmd->continued =3D (i + 1) < nxfers; } =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 ret =3D xfer->ret; svc_i3c_master_free_xfer(xfer); @@ -1346,9 +1356,11 @@ static int svc_i3c_master_i2c_xfers(struct i2c_dev_d= esc *dev, cmd->continued =3D (i + 1 < nxfers); } =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 ret =3D xfer->ret; svc_i3c_master_free_xfer(xfer); @@ -1539,6 +1551,8 @@ static int svc_i3c_master_probe(struct platform_devic= e *pdev) =20 INIT_WORK(&master->hj_work, svc_i3c_master_hj_work); INIT_WORK(&master->ibi_work, svc_i3c_master_ibi_work); + mutex_init(&master->lock); + ret =3D devm_request_irq(dev, master->irq, svc_i3c_master_irq_handler, IRQF_NO_SUSPEND, "svc-i3c-irq", master); if (ret) --=20 2.34.1 From nobody Thu Dec 18 15:31:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41B2EC004C0 for ; Mon, 23 Oct 2023 16:17:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233580AbjJWQRc (ORCPT ); Mon, 23 Oct 2023 12:17:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49094 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232058AbjJWQRW (ORCPT ); Mon, 23 Oct 2023 12:17:22 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2056.outbound.protection.outlook.com [40.107.6.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F28110C1 for ; Mon, 23 Oct 2023 09:17:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y3t/wGFSe5J7o3cvXafWvvWkh7d6iBVwWFgggd8nFWq1PPU6ixv7hNV/AQXLDncgjGWy/usd33LUd6xtyBW3bzkgL9vmPkdCNj6+bBGBFI8hmp8XTYXDIZDeH1BVPUenCFozKzrAd7RSkj+fHTvdZmpFNDpDDXvYLJqqjpiNKs+AozzIc0vXORSvl4j2Ka4L2J7gN4m1b7wQ1gdUwDEskU0NVEneeTfQ16ydgajBccB5hbEjbuHfQr8JmcoWJ0bCTplUpEpaLra1e3yZA7oJVivoVhJUrAV024zLcL+dpq9M0jr14dHK8kXLZpb8MlJrkUoBFxOGJYla/X7HDJuYpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uJcAQxBYawmHt4F5h8Rz2JZ46sg6P7hOUVI6G6WO4qs=; b=CMHkEw+IiBtGz2jc3iBm2G6/UmHF/0YSoY6KizC6+1iZLG9LgT7ga/cBYqPiGl8QB+h/Ak62h/E2HiyIv2AicM2xcwOscNXzxVtcAuWhF/Co4zWoK2ovn8UZo+VCyGGbQwfwEsm6BwZ9iMF485Ot+jKO45roGZOvlo23oOBgSvKwxAOgBpyEdNnPJgEjcg/DW6XYXGcAvRFV/XQq/feCQ6hE3Rxjv6c2TYSzyg4csE18RdnnkoJ+CdMXNL4sbonumAkQoSvI/ZuhKVSE/SpXKIpkyvuPGW82hn/IqpU1dUZYdm5p25cvfP5HNfPtye6fqFJwx4zGjUFRLDSVHVBcKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uJcAQxBYawmHt4F5h8Rz2JZ46sg6P7hOUVI6G6WO4qs=; b=YfrBIctZZvCqD5SStvTd/2NQf7LjhG9osMMGjVSGMEGVVlr23Acc93JDvsl4IByr33q9hwBP+OjUsGY+rm5NfWpwaPkCuGMWqH1FJ2n+oQ9AstciU74gkND43AqSFyiAXQyR+yCfUNozw2lxCjs9NpuBATta2m61pXo9TL3r+CE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by PAXPR04MB8655.eurprd04.prod.outlook.com (2603:10a6:102:21e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.16; Mon, 23 Oct 2023 16:17:16 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098%6]) with mapi id 15.20.6933.011; Mon, 23 Oct 2023 16:17:16 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 2/6] i3c: master: svc: fix wrong data return when IBI happen during start frame Date: Mon, 23 Oct 2023 12:16:54 -0400 Message-Id: <20231023161658.3890811-3-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231023161658.3890811-1-Frank.Li@nxp.com> References: <20231023161658.3890811-1-Frank.Li@nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY5PR20CA0002.namprd20.prod.outlook.com (2603:10b6:a03:1f4::15) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|PAXPR04MB8655:EE_ X-MS-Office365-Filtering-Correlation-Id: d48a6b18-aad1-4ba2-8d2c-08dbd3e38632 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DGJt/1i3AbMH/FS7ITSmYt0LuXfN1kl5jLs0pyRLtgbm4I9f3KHNfBEjCmN1amFEVdMQ8NM06UH/ZNflZ/8FW8K/ClowR64lYlfo7TzCVt5c7Cz6WJ5Zr+FopNkV27S1YiXjaWTME0RnhkZTbqT9jr1SHrSLAww5kNE0wY9YJsFZSu5ZIW9PfhpYL+OiPzCidxWH/VXI57fGAqwtAx5oL0yMsj+qlbzCld8mTmsowUK4ywtlMG14iZZhefG90BJIchEWzYPQKttkirDmviKW+WGr6dTs/q1uG1eTMPAF3wKA+OhlKzHq0A+44RLfzQWFy9jMEVl6KftVD6WLsu+BNs6rNAoBWXMw9VRreaml2i38BWITJE5c7LnKaRH4frHVahXbDa/L64MtLUbhTzrimutLggPDYYP/zXqDEltQuzvXotHluTmPzvAMC3j3WfwYhbDG506dWYYrSra4fbkqlyQp88IdG2ESMf4QEjWNr8PDlKvf2JLwcEZFusIZ8BSSFYU2PdjCRmJ+qF8n0U6BKPX/5vZm7IwB7/wIjSDzhpWvIDQXyblIY+AH/Vm6NtegahEkEdu0a7WuhM0AvKRhFsRgVecR8OqwtD/gwiqfwopTvAHL1Iod0KBb52AmUlio X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(39860400002)(366004)(396003)(376002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(478600001)(6506007)(6512007)(6666004)(86362001)(316002)(41300700001)(6916009)(2906002)(6486002)(5660300002)(52116002)(36756003)(8676002)(2616005)(1076003)(26005)(38100700002)(8936002)(4326008)(66946007)(38350700005)(83380400001)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WGJJSGZjQUVLUGdLWHlhcU9Zakp4TXRhSlNlbTk3NlRGNk1jNXRSVjN4Vjhj?= =?utf-8?B?eDgvS29rNmRzUXYya09Rak54ZXROeGxxb2prMExLbUNHMEFyVnJXWFRucFdk?= =?utf-8?B?RktpZUtaQ0dJYnFOT1AxdUlWNGVPTUh1UlhUZGk3aVd3WjZnWkd6Z3JXaDBX?= =?utf-8?B?SlVDQVZPR3lLTUphWUowdVY4bXRkZXVkTkNidEVYOXlCczdWRkxycUNQVU90?= =?utf-8?B?bGxEdHdjbFZYeHBHYmt3WEQrWXJaeE1BRmROMWE1bjZzRkF0RkJVUXpWUVZD?= =?utf-8?B?V2JEKzY1Z0trY0ZkYTAyZkNGRGRpVkVvbWlDd0didC9TWUlSVDJCMHoxUzVE?= =?utf-8?B?YzJqV3FYZVVoL1J2R0ZZcGxJaUNrbTBqVDhhYU1oQXRJcDZvdWVQTytRcEt0?= =?utf-8?B?ZkQxV25KTk9aVmlqVTNwTFlvUEpXUEw3eDhIL3djaXhoZVloOG5VWVBFZlJU?= =?utf-8?B?WUsyem1GWFFBblhYWXNPdXBzY245SlFZeEpGSFN0aUJ4RERYZ3h2VlJtZ2FO?= =?utf-8?B?aGJzL0xPeDlnODRDMEcvSkZiUDRSb0JBZFFQSEZRRW1WelUxTmRvdFRvcTJW?= =?utf-8?B?cjNhaExtOGdWUjFzUW1JNFk3M0hZdnU4UlN3dUhQRXBJVmpuTi9EcEJKZHpl?= =?utf-8?B?Y2lWRkhCeS90YVdDL1NXbloyaXQyZWRWamFqVlprbzVvcEE2c203SFpobXJB?= =?utf-8?B?WUsrVFFwTU1KVzlsODN1VysrNmlvWG43dW4zMHZWT3h3RG1aRFBpamFYeEVI?= =?utf-8?B?aWZHOHVITThoanJOVHhLditnTS95UTllMTZvOWNBTFhEU3pyMXE4QmJBUmxK?= =?utf-8?B?ZUFrZFdGMnltWFM0d25zdkVMakZRaHpDcVBwYThMUlBpVXp3cldsZGg5UDJY?= =?utf-8?B?eGVFZmdkU2gyZWE2cGhYdUxmU2I5dElWVGJkb1JaZHgrbVJTdFVRNEdod1lt?= =?utf-8?B?SzcybUZkY052K0VITFYzUk5uMy9wRk9BVUdWZkhWejFhVTBRQU5tU0NGQUc0?= =?utf-8?B?YnNvK256NTFrSGI2ckNha1B3U2lrM2lvRWJYNFFDV1VvM0FqbWFrNStobTZV?= =?utf-8?B?ZzZLVU1EQ3YyUmFSUWdjTWRhd2FnVmxmL3VMYkx3NUJRTS9jUnFSdjY0ZlRM?= =?utf-8?B?UDVhUE5KYzNpUXkyN1h6d0dLbTQrRlQweENXTStqU082SkdXM0Nqa2NNK08r?= =?utf-8?B?T2hadXJ1dmszZDVSc2VDY3AvMlBGRHE5RmN4V2ZCQjJObVMrakdLb1VpWmg4?= =?utf-8?B?T1FyQ3poRXo3TDRoWGhiYTdCakQ3Qytpc0dwL3NXMnI2OS90eUk0THc5R1Nu?= =?utf-8?B?emJoK2ZkZERzNlh0Z0E3V2VBakt3UCtWREdYRGlMd1ZucTk4aytKcDN2VkRu?= =?utf-8?B?ZERadlEwL1dvemtrRVIrUzJFUElQbkxlMUVlem83SXVXVkdKZ0lOdS9raTNW?= =?utf-8?B?a2Rmakd0S2FXMjdnYnpVZ0dVamJBa1VPZndSUEZaUU9DOWFRTENqTnZ1QjJX?= =?utf-8?B?NUU3SUVqS0NIWDlReWw3aFJoYk05aGkrdlBsOCtaSDViS21JME9TQXJPVWxK?= =?utf-8?B?WHE3RDFISkU3ay9KMTZnYXVHYlg5Tms4U2dVZXpLYTdmaEppN2tNS2ZOODAr?= =?utf-8?B?ek5Fa3BmUTJHUXlKR051MldiRmpGdy9QQjdtNVFOZVhxS3RTZXRKL0tBRDRS?= =?utf-8?B?WDg5K21Cb3hSbjZackJYcndMY0pqZUJwUStTeWVrYUJ1OGxzQmRmdmY1bEhS?= =?utf-8?B?RFozZGNCck1QMFl2SU5ZeFVaSUxlaC9MSC80eW1lendEcnJoZ2M0SXpMMHFR?= =?utf-8?B?YzEvcjl6VHZTT05NN3hPSmR3NEdLOE10VVVpWko4UWxkeVprRFBJYWRRSC83?= =?utf-8?B?T0ZVTldhcER4RTJVcTJrUHV5TjhZZUdnS3RtMjlncXluYktjalFIdEJ2a2NW?= =?utf-8?B?b2RVK1pZS0llQ1RNd3UxZnZQeTVvUVltV1FPZi83OWdzcUE3aWEvZEltOCty?= =?utf-8?B?RFZWYUZvMFVBS2xJV0JHK2ovSHNuNFVLdzROSXFyclBlNlJzQXowaEtvRFBu?= =?utf-8?B?RG9SaU9Jb01UVmVHSm11aHJFdWFWY2FvWmYrUkRCTUJrK01Mc1VpYXpkOHYr?= =?utf-8?Q?+YCdSaeRYv7SLHB7psO9R7Z5P?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: d48a6b18-aad1-4ba2-8d2c-08dbd3e38632 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:17:16.7065 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uM+OSme/CEM72+aqI7lUpTxo+9mEMSHpDKBsP/oAyHAuVF41ruJPbMCMYdWcQHyW2wgs/tLljFntP38UvOHlaA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8655 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 = =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 = =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2=94=90= =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2=94= =90 =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2= =94=90 =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80 SCL: =E2=94=98 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94=80=E2=94= =80=E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94=80=E2= =94=80=E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94=80= =E2=94=80=E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94= =80=E2=94=80=E2=94=98 =E2=94=80=E2=94=80=E2=94=80=E2=94=90 =E2=94=8C= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 =E2=94=8C=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 =E2=94=8C=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=90 SDA: =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=98 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =98 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=98 = =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80 xxx=E2=95=B1 =E2=95=B2=E2=95=B1 = =E2=95=B2=E2=95=B1 =E2=95=B2=E2=95=B1 =E2=95=B2=E2=95=B1 =E2= =95=B2 : xxx=E2=95=B2IBI =E2=95=B1=E2=95=B2 Addr(0x0a) = =E2=95=B1=E2=95=B2 RW =E2=95=B1=E2=95=B2NACK=E2=95=B1=E2=95=B2 S =E2= =95=B1 If an In-Band Interrupt (IBI) occurs and IBI work thread is not immediately scheduled, when svc_i3c_master_priv_xfers() initiates the I3C transfer and attempts to send address 0x7e, the target interprets it as an IBI handler and returns the target address 0x0a. However, svc_i3c_master_priv_xfers() does not handle this case and proceeds with other transfers, resulting in incorrect data being returned. Add IBIWON check in svc_i3c_master_xfer(). In case this situation occurs, return a failure to the driver. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Notes: Change from v3 to v4 - When -> when =20 Change from v1 to v2 - update commit message - fix typo yeild and falure =20 Change from v1 to v2 - update commit message - fix typo yeild and falure drivers/i3c/master/svc-i3c-master.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 8cd708c965085..abebef666b2bb 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1010,6 +1010,9 @@ static int svc_i3c_master_xfer(struct svc_i3c_master = *master, u32 reg; int ret; =20 + /* clean SVC_I3C_MINT_IBIWON w1c bits */ + writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS); + writel(SVC_I3C_MCTRL_REQUEST_START_ADDR | xfer_type | SVC_I3C_MCTRL_IBIRESP_NACK | @@ -1028,6 +1031,23 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, goto emit_stop; } =20 + /* + * According to I3C spec ver 1.1.1, 5.1.2.2.3 Consequence of Controller S= tarting a Frame + * with I3C Target Address. + * + * The I3C Controller normally should start a Frame, the Address may be a= rbitrated, and so + * the Controller shall monitor to see whether an In-Band Interrupt reque= st, a Controller + * Role Request (i.e., Secondary Controller requests to become the Active= Controller), or + * a Hot-Join Request has been made. + * + * If missed IBIWON check, the wrong data will be return. When IBIWON hap= pen, return failure + * and yield the above events handler. + */ + if (SVC_I3C_MSTATUS_IBIWON(reg)) { + ret =3D -ENXIO; + goto emit_stop; + } + if (rnw) ret =3D svc_i3c_master_read(master, in, xfer_len); else --=20 2.34.1 From nobody Thu Dec 18 15:31:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F7B3C004C0 for ; Mon, 23 Oct 2023 16:17:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233681AbjJWQRg (ORCPT ); Mon, 23 Oct 2023 12:17:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233659AbjJWQRZ (ORCPT ); Mon, 23 Oct 2023 12:17:25 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2056.outbound.protection.outlook.com [40.107.6.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FA1A10CF for ; Mon, 23 Oct 2023 09:17:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kEnTgr4uz2GhbpBNOlcEoKnkMloS2sDKKkKLTLltEf65KrsPVigmVbFYTlnbEMLv1c8X3QQFxzT3VNssbmNWHpaabWe1cPlLJOs5Z72nwBmDlxFHRaq4XyVFNZpyfVZuLdOhW0bXvY36bfaRqbmrWCoUtAdlVr6ZLtP9r2kCQhw5IH/YXxR0/rHCFFnydPJM0Vy06Hu6FytXa3odODox0Fm4S6qH317mqfYmDBX9iDKx9cMxRHvpF/5XDITmVYZPD1OwDT6+UNFYP+E6Gjail/tq1ht4SU2sSNpIXzU7/zUXyvReeDkgBOt4jBO+ZSfWRsO5KzvsDdN1aJ8aRfm64A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q1Eg5x0kveUbh+2VLsIws1d1wUUv0QNkE46sI/KeRdQ=; b=eRsX5YV8+u4UqoH611YbcOc6K/dLREz8097MsRG65zNVXCI63tTrU15zxsTh80UqEwwzutq+lxdiBbxxl0lwJL1pVtzI5GI262sf9ywavGD21kVXYp/hQSqL1NzsF2JeBVEA5JeFK5Tv+B5ZkQ4cJHuYFNJKBHW8XT5lfAxwwjeeadVf1Lch/Mze02e2CQEcqNmnXfo5wbhi5OIaiwbpYEOKKT4XifiO5ofm5ZpydqPsLh4/gcAjaAKXCDEcF6qaSvrI7ybt14zkciDa9SD5o8yAgDxatgoin7TSs2E/dVkJ3WYR0Ix2AR+e0l26gbbZvdeuSBKUgp1igrfKqbvFuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q1Eg5x0kveUbh+2VLsIws1d1wUUv0QNkE46sI/KeRdQ=; b=M4IVsNvYUbSIaNCQkpM55WwkhvzRFYSjYcn7DVy+SbFHJaP6gANqENhO8mNMBxrq0KUVEEmHn9jwe5UwrI4BqZBO/CgAqHwDARvXXajaEjF8sPuWSOlk/HpkG1LuMjvWCOTIhVMfMihXlrlH4VI2B80Lkn4PiemltwtLSm+IAxw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by PAXPR04MB8655.eurprd04.prod.outlook.com (2603:10a6:102:21e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.16; Mon, 23 Oct 2023 16:17:19 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098%6]) with mapi id 15.20.6933.011; Mon, 23 Oct 2023 16:17:19 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 3/6] i3c: master: svc: fix ibi may not return mandatory data byte Date: Mon, 23 Oct 2023 12:16:55 -0400 Message-Id: <20231023161658.3890811-4-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231023161658.3890811-1-Frank.Li@nxp.com> References: <20231023161658.3890811-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY5PR20CA0002.namprd20.prod.outlook.com (2603:10b6:a03:1f4::15) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|PAXPR04MB8655:EE_ X-MS-Office365-Filtering-Correlation-Id: 1090b22c-74d4-4639-68b4-08dbd3e38793 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EOayPqRAm1d9ObrnFbDFrySO+h1SeZuHIyndiZlVwXqzWp6Nemzxk11touoRt4k9yUnyYdIBNiL0iA0QU4qu4wlPYM4bm6pnITBH1/yU7IVRvaXA6RgqiCv2xiBV2zsuyq0X37riL7KzCYcrsOdQN8CDUu2n8jL+3TjNypGoR2JoDjSDSbmXfG0DrmAlW62JbYb40OzyVx2GBIwkLp/PJz4Gzi7L4HsXfNBgkyfOHVGbYIPtsjbgTpImpxw10lBiZplx4/zknzbvAYcp1JgEDTtnVBx4Xl2eINk8sjRQTHLuEhaffM0Hh/R4QhZeQbuQ6atbTkQ7a2LWTdWiaO2mys18159RLHJIPf2jDrkcKPa00Otgp+8NLbeyH4L3QjuQ6sIHZ9UyRaM+wXhPd5QlC9hgfkH6xQ0B8JROlh9mI5WThsK4q0/67tMD/gsUc19VNbuHsP9IrGPCKEIdlQ/8PaadK0XBf1mXEMZJeTm8WeRikmMyhUV/r56EyoTvgiBtsYpcdUABw8lc2CK/UogKk/zbrxWM7fNHz7iyNfAuXcI6Q/v4msEuWEROdD0nxDwCBtDQSOIDDEmImYwESZ6JD+NZ7NJjjyseFPa3JJzd7jsIjD8VweiPKNeWUEY3dkCd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(39860400002)(366004)(396003)(376002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(478600001)(6506007)(6512007)(6666004)(86362001)(316002)(41300700001)(6916009)(2906002)(6486002)(5660300002)(52116002)(36756003)(8676002)(2616005)(1076003)(26005)(38100700002)(8936002)(4326008)(66946007)(38350700005)(83380400001)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/0axMwlIomY2+G1KJdkFqix9Mo4htMPR0YywEiu0RJCLrzMF9VLRYPKZFF+b?= =?us-ascii?Q?gtZRtqtKmt4q66NeaCd4/shde5MAoosJL3alQsh9PtATadobez5Vei8ACij4?= =?us-ascii?Q?pjf0s8QlUs7jfw7P7Av0AUMqMEFLEPmxIzZuhrQP6tI0/gPgDdVa+rNslDSd?= =?us-ascii?Q?XYn0iZoPDoOXEHioHC7DBzEH9WB30TdmHTHt6oO2zYYqqKmpJ5P3BVdNOQ4Y?= =?us-ascii?Q?URLwFYGtrOwNYkNZbZ2cYbms881ozHw8iFXCbbHLT8Q3ujTkxjSGxdw5zhvc?= =?us-ascii?Q?kttD9ul/Ag+CBzvppy7SntXX2xhVMFEtfFft7+lNfh0q1cFReggpA2z52UJw?= =?us-ascii?Q?jHBVXH2f9gtGx7JfIz9UZw0YLAn49yek1Dx8YSwzHqHExLLvlADoy2dL5eWj?= =?us-ascii?Q?2Q53bkldqcGchvmBkS5N6u6dz4QvQobdQaj0zKu64YZSCYIsj92CvdALuV+M?= =?us-ascii?Q?pHFuHMxoAtsyUuNkWNh2GpSlT8Bb6gXHFIRm02MQBuceuQeYVTrWVwjUW9sm?= =?us-ascii?Q?dU+ng9qqSyIOdnJkO4KQZ/zwLoPEbNuVypi98EGSX3z+Pwp+01aka1JreUxn?= =?us-ascii?Q?wX4aS369y9ixVcnpK5vTDf4BQlkIDKNelgOjkIWt0nIQtFraCxDqdORpWBIX?= =?us-ascii?Q?BQP7bdIuhv5Cu8ZWUBGnVjrVwkXdxSlmPDvGIA7D5TlpwnikShA0VcSVyTZM?= =?us-ascii?Q?R1/JD+q0GRsfZDUHijMy7OddhqOdWS0D/Z2ovosivGDI7PSssseSQ3rW5s5z?= =?us-ascii?Q?LKVzGNRcWuJlPu5+kPPUaQrxG554+sgP9Q/3irzAp4+OIbmQz36Q4VUlFXvh?= =?us-ascii?Q?X6rM1rnf8dEXduNqmExn0nzJSKSL2/TEmsOGRUvkDqh59zfvLbVVLkfqNfNC?= =?us-ascii?Q?37D7QjNQKzIMPwlm1WNTBddI4FfYKstlT0ujuM5DyekhRFu8pZO8aYzRo/uR?= =?us-ascii?Q?FWuuSm6SbmXWVevRo1lNwPB9TZC1xtjqRGzvwugdYLJB8qpU0fqceypW8jd1?= =?us-ascii?Q?1pYqTX976gyY4GaEfhXioTqbOknbyKx5CWdb/H75vp5eEzRHD/pt2pJF9s/J?= =?us-ascii?Q?nuWWS05kjt9ixzeBTuDY9rH1pD4wjJymnh3RuHvcUzR39buxLW+dKi9oOagA?= =?us-ascii?Q?QpKjc8JQwXww+TIe6jAQV7c4ZubXgDTcxDcqDbidSSDv9HCUb0QZPoepXqRW?= =?us-ascii?Q?SIekJRMaAYY8OBInYLwuLV5azlcnMxCTgnNOvZFK90Hgvn0muWmpyXuu6Dcw?= =?us-ascii?Q?xZXCOItnFx0ntilVL4LY0pn1XV0/W5H4V4Yu15zB1Omhqo9H2M/LYyOgKucH?= =?us-ascii?Q?cjMAAcaOEDstNhEoXxsGy8AGjSesZmjwe1PQMhkz+FAkDgAqlpCgSlUQdL7Z?= =?us-ascii?Q?7bqgUviDdbadNnIJzXCnPpuWCv3OxfEqBuul6EqrAYcoFBJJF05vkqPCo8iV?= =?us-ascii?Q?nKxDrbfG4Y+INNf4wFLFThmUSGMxaRR3Oir5uTlUMgWy7e81nUu4ecYBdi9N?= =?us-ascii?Q?jwA4Xm7yGLByegqU7jpcafl5U8VpoqQ5Dx2KqnbK9hyH+A9ldlY9UMkH9tB3?= =?us-ascii?Q?Y28UwFHmuV9nQpnmDrhSXhH3vEUh2sdU+o0qlsiR?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1090b22c-74d4-4639-68b4-08dbd3e38793 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:17:19.0411 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Z1Heo6JT1FJKSp5sPlkvWlKQNiOIn6xOHdZiLUs+DaLbYp+vVXd74xOEU1UWGCeSHiikmVH49LbfR7YkpbucgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8655 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" MSTATUS[RXPEND] is only updated after the data transfer cycle started. This creates an issue when the I3C clock is slow, and the CPU is running fast enough that MSTATUS[RXPEND] may not be updated when the code reaches checking point. As a result, mandatory data can be missed. Add a wait for MSTATUS[COMPLETE] to ensure that all mandatory data is already in FIFO. It also works without mandatory data. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Notes: Change from v3 to v4 - add review tag Miquel =20 Change from v2 to v3 - update commit message and add no mandatory data in commits message =20 Change from v1 to v2 - update commit message it also works without mandatory bytes =20 Change from v1 to v2 - update commit message it also works without mandatory bytes =20 Change from v2 to v3 - update commit message and add no mandatory data in commits message =20 Change from v1 to v2 - update commit message it also works without mandatory bytes =20 Change from v1 to v2 - update commit message it also works without mandatory bytes drivers/i3c/master/svc-i3c-master.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index abebef666b2bb..dd06b7c9333f1 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -332,6 +332,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_mas= ter *master, struct i3c_ibi_slot *slot; unsigned int count; u32 mdatactrl; + int ret, val; u8 *buf; =20 slot =3D i3c_generic_ibi_get_free_slot(data->ibi_pool); @@ -341,6 +342,13 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_ma= ster *master, slot->len =3D 0; buf =3D slot->data; =20 + ret =3D readl_relaxed_poll_timeout(master->regs + SVC_I3C_MSTATUS, val, + SVC_I3C_MSTATUS_COMPLETE(val), 0, 1000); + if (ret) { + dev_err(master->dev, "Timeout when polling for COMPLETE\n"); + return ret; + } + while (SVC_I3C_MSTATUS_RXPEND(readl(master->regs + SVC_I3C_MSTATUS)) && slot->len < SVC_I3C_FIFO_SIZE) { mdatactrl =3D readl(master->regs + SVC_I3C_MDATACTRL); --=20 2.34.1 From nobody Thu Dec 18 15:31:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 235F7C25B41 for ; Mon, 23 Oct 2023 16:17:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233738AbjJWQRu (ORCPT ); Mon, 23 Oct 2023 12:17:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233572AbjJWQR0 (ORCPT ); Mon, 23 Oct 2023 12:17:26 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2056.outbound.protection.outlook.com [40.107.6.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE25DD7E for ; Mon, 23 Oct 2023 09:17:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SXYzDykA5PSoEeT+D9nhOJQvrUKnf0bjtw8qG6QPff+eWNIC9iil5TJe7BSTMjD9A14U7mwJmWUNpPrQoT2QInzXhGJJ1hLKTUc1MGxfyaceWSCU0t/n0Jhb4fLrXVXU+YYGReJbbHyO/I9BoPMEaPTEXGaa/q/xoS2KlXZ6gkcyKEw1FCymyvANr617e6m4jxOZsqUcrnrSrutkCrqaFWwLquhoh8pIK34FKm7Q1NdbJ1WNJp8xp8EoPgCR52EcuSw/w9G3E1ANLuw3AQ6oXQjta9KJm5lykcYw3FeBu2RfziQTadwGlWWt3Ula3xv8E9a7iLxAOKiqR5bi1JS0lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h4mJGV9acOW2cLGFSJ8HHBb/l6kCukylYAa2hfxh9Kk=; b=H0TjZ2P9mzuAk4q5PULUniR0oTPNu9kchTy4b8YimwxjGVn1PZwNxYRErufOHR1ENG6QMR3rHMSOEvuKue+CtJeoWdHMtfBd8KF71e8oOH62V8U6/HyGMmxGBVh2Ppsy9gqyEMTIbjKIcInllw5A0j+XKEhIvfXwvZBnrSnk9nAjuPYQ+JjCin0r6O8KLC+AcAxlhNTjSaRUAOo+43yuwbd4i3T3xq+ifq2JlvCEeMegYhsdqT9hZhzpTUBysFl+4hwiGyzaCVrnaZpIO6u0lgcHAF3d3mhSTO4JKMm/qnh3KxMKdy3C5uBzHDK7NnQs9pY05VLfo3e1S74StwDyRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h4mJGV9acOW2cLGFSJ8HHBb/l6kCukylYAa2hfxh9Kk=; b=H41A+DHUyVgZfpeNUxBLi9emY5G9wj4xSdcoeA//jxIuKIBXmpEijzxTzl+9S4DKR7ulJ/N6DfUZ5nhs4AhI6dx2D+ulC9iz5NV/yQWI4s1+gIlhEkIKlRMcmOg9KZR7rkUA/197kepu+PYYQoqAUSo4s48OlfnAcqO52VJU5+I= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by PAXPR04MB8655.eurprd04.prod.outlook.com (2603:10a6:102:21e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.16; Mon, 23 Oct 2023 16:17:21 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098%6]) with mapi id 15.20.6933.011; Mon, 23 Oct 2023 16:17:21 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 4/6] i3c: master: svc: fix check wrong status register in irq handler Date: Mon, 23 Oct 2023 12:16:56 -0400 Message-Id: <20231023161658.3890811-5-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231023161658.3890811-1-Frank.Li@nxp.com> References: <20231023161658.3890811-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY5PR20CA0002.namprd20.prod.outlook.com (2603:10b6:a03:1f4::15) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|PAXPR04MB8655:EE_ X-MS-Office365-Filtering-Correlation-Id: 3069292a-2621-486f-446b-08dbd3e388f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lR4XnIQi1rymZuHkpoaYphbgxmNRz1SPJUV85YsB9cowoObQLDUoZ0PJiRvVNWg5ThCMsD4PJVSsy82i0RHOroO/5txBJs76e30SzdH5dUnkvwo6ZGur70jIIzRG3VXHcH6HyzwPJjmSzwWM6Z5LOS8KMF2/r1CSXa7kWbJ+IfdZhyu5kZT+lvTmyUaUbm67EEPRBJnXBZcHlBKEsQxbLID837FkGDvlD0RwyKbKnuhgFLMor3cv9ja36jtAJPUHVbsfhGSRgjxjmFWI2N8ggmJ/rZAlEI0icItbqqY7OB6nydYpZZH4Rnh2zbvWpM0sXq6O9m78Y1FrfBOJtRQygAV00RdzgSxH0036NZHvl4N5vw7cYfHrNnLXHzVlcY0CZRy4xnoci/ZaXTJzCNfa2hY77aKTTMCZZ/9D9J3SjodBhW/hdDFrF8TBUqPMV4TCNI2U/15TT0M7nCMrl13IsOWmwnhHynz1wUkNILN6abLp8ER0OBj8hgNGbB/yRIc0DWh11y30pU5MWuQwmnEWJwzTbps1HaqW+JDw8akn3KmgaosUdugD4V8K59UFrElhQxRVODlgIa/SO+axS91j06qzRtSws7LO6c9yberZSgGduHFNsRNQTktK9L5MSbKu X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(39860400002)(366004)(396003)(376002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(478600001)(6506007)(6512007)(6666004)(86362001)(316002)(41300700001)(6916009)(2906002)(6486002)(5660300002)(52116002)(36756003)(8676002)(2616005)(1076003)(26005)(38100700002)(8936002)(4326008)(66946007)(38350700005)(83380400001)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EpREH2ApipoCFTjNKq78RmnjXZbB0XRrG4CC+afhXCiIpKgh2cKFCI4Rb0bV?= =?us-ascii?Q?FhFLENsAlBd9DsG3oVZbT6zWkFtv5XrcJX9ryFTG9b8bnE8Sapl+U0+Pilwh?= =?us-ascii?Q?Grhm99mEjnr6tD9KNAers6S0xGonuKnwhABr2GP0JXGtfFXz3mCLE+pI3+gI?= =?us-ascii?Q?S+EUqBRg6/pZhwuqGvfsWQ0WFkqyqXGlOT9DTmxv/JuCtJkIvnIKS8vT6+hd?= =?us-ascii?Q?oftLUWb9dw7WyjfO4xNVfeWzBMlM/p8K3a67WDlHa+s7Tyv+KepMe/J3JcO9?= =?us-ascii?Q?4c5VIKcLcOTkFYKSlFoB74U35yotDSWyVpU1L+9GWklXpfPWYWQccpoiDylg?= =?us-ascii?Q?ev2DktSPP9nx2v3ft49AmusCC5/k9u2jOnyRewm6ZrBIuJlkGJz2yq/BnMDr?= =?us-ascii?Q?3Qyv6em5Fj60Uwe4Q9ZmbEDFfasfzPBCz6mqrSzeX862rgG7DyUqtSvajI9R?= =?us-ascii?Q?PESdsNza1OXcvQRYnjkOGzKDX/Py8d7kAWKixc4tL9HgxL7Rpr/bXGMGrvH5?= =?us-ascii?Q?CFxvkRJ5TPHQhqH9FE5ZohyqDRlMY58rzPAnNwJet2Zy0dPVSBpOukscEuBv?= =?us-ascii?Q?gM43OtPTHz4G1Ms2AuR5P9MC2IdbkNPyelGZs9WuNtPtEqDigHgDkjuF/0Yz?= =?us-ascii?Q?IPb5Ndf3NImfkto2pKk1r7AVNE3NNKdk0Do2uDK7ovzx8AyRAqAzeJR0FOig?= =?us-ascii?Q?9AXLHTRWL+prQRaFCbp5GcYp6M1yMJe+X7DjkATyUDAhq8Unk5nP/tNRtukB?= =?us-ascii?Q?ZlXW0q0Jr8m+OV71Wt/QoQR7NguP6GCOtOTk68zO2kMy/olRSaxso1cXAqj+?= =?us-ascii?Q?juYyhFNr+nkUb8oOfb7pNuxJLFob4INP7PT7Hd7StAVrEsWUDIxl7267NYgD?= =?us-ascii?Q?uJPA54Dfgc3wJHcccrPg0VoLjy9xcz/8SPlIj+8FGUVHf8eeLXXsmtVL6CZn?= =?us-ascii?Q?Qj+i1VPESyz1q0dnj0986ZIFO0/sw50PsCs4c9JDbFsnxZ4jXRHll5dY+YCA?= =?us-ascii?Q?EsTa8/7uCMFgfT9HA3kCQZYVnJroDEB78CwTZfoGjZTmDHBOlPiXHL0yatVq?= =?us-ascii?Q?MxrHi/MrNfqXWin+Ej4kWGiJ7s0aZ1hl7ir+LR+fjWSC/FHy1OV97aPH3YBw?= =?us-ascii?Q?Sz8eUXORz61jBVbyUPiNRW7dg+XGA/OeogvT1JCdeByLguT0+MjJvBFJFYLm?= =?us-ascii?Q?vysnD4ezIdNbeAbkFd9thQOCltUmAuLCtVH4kQT/vR+2Jx5MmdNKLW4Y/7ji?= =?us-ascii?Q?dUxuxutHzZq8fG2X0cJtkb8mMNXpL3ZQn9H2r6RrnnN2rGjUHaWYnxC+W7NR?= =?us-ascii?Q?V+uoK79GXqqoPd6G0Wmy52QvHDB/2CxR1CBJ3j8/5WCd4mWEkyTdCqutmJGg?= =?us-ascii?Q?qYuTYX4F6Vavkw0BUcnBQvSZyZ643SsbPuruuMoZR1A2UTa8OeKUFlPS4zEV?= =?us-ascii?Q?kfS9UaxQab7aLclN9e3l3eSAoA6ev/tAe89SaZ3XIus4c90noYldHnq+R+nr?= =?us-ascii?Q?UXnM2IZ5e8VTqCkgojrEVt9XN0htcgmfaNF4eE6BLDrRILXPLBnjXqJgs7gU?= =?us-ascii?Q?LhbRQRr5gmMItIK9yOCyWLewUmS0c+o44CSK8vqW?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3069292a-2621-486f-446b-08dbd3e388f4 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:17:21.4682 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6waxxU/5KgXtirH/MXaK4sRjHcHfjEpQVpfP3ntSLWlh4Wc9+ib2dIK38AdsV2/1pnjnCiv7n8d7hy9bnTcMfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8655 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" svc_i3c_master_irq_handler() wrongly checks register SVC_I3C_MINTMASKED. It should be SVC_I3C_MSTATUS. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Notes: Change from v2 to v3 - 'wrong check' -> 'wrongly checks' =20 Change from v1 to v2 - Add Reviewed-by: Miquel Raynal =20 Change from v1 to v2 - Add Reviewed-by: Miquel Raynal drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index dd06b7c9333f1..b113460f059c3 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -476,7 +476,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id) { struct svc_i3c_master *master =3D (struct svc_i3c_master *)dev_id; - u32 active =3D readl(master->regs + SVC_I3C_MINTMASKED); + u32 active =3D readl(master->regs + SVC_I3C_MSTATUS); =20 if (!SVC_I3C_MSTATUS_SLVSTART(active)) return IRQ_NONE; --=20 2.34.1 From nobody Thu Dec 18 15:31:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03E6AC004C0 for ; Mon, 23 Oct 2023 16:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233745AbjJWQRw (ORCPT ); Mon, 23 Oct 2023 12:17:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233629AbjJWQRa (ORCPT ); Mon, 23 Oct 2023 12:17:30 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2056.outbound.protection.outlook.com [40.107.6.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4E6010DB for ; Mon, 23 Oct 2023 09:17:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=A1kEb/HtXe8z82lgXkqqIdG8l5+6CupeCbPBbz2vifYsXd5MAQ5s2SG0w7G4j411cs8gNmvCmHn5mVN1P5zIFr66S9j1+nCwoH17CA+g+htTSRz4ECrEFYtJMWdSvOk5VvfHG44zeRZLEkaAoWYeib9WBTHVeRO0f07lkaPiD4/FEehEty7quIVxThmmHkCNE3NbTt2WpEtoQm+9oIbU1fxFdXa/xzcxyE+HVjGnoABWWUd0ptv7CPBx4uTWPyjgDgl8XJjStv9qN0+7Sy4IpBOvcUNO8c0C5+4XlwvxkZEreShxG96ViKBQkxxZ+2VbFSoZ+E8hsNG2acU4smDwVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cU4Cbhls3SW1lImnaGTFfi2FqvW7XvhiDiskv1v3GyE=; b=Runx58+tzrbXHdf9ap+UXV6saHtPvsLXh+ROLB+nrIRuzKt5bxmTSvDP/C9YdlZRyUl9wXhg/Bhp150e57uuKWDxxfocVyJkEAiWRGTmkA4h6MhrF9T5jdeUFFoM3c3DrwhctI9Gybu1mlnkTY1g0EhgKniis8DRdWZGkDe2n+JcfJSSocSplKSK58/mlI0ZVRUZz4sUP9GqUTZ2W5NR90JpxYZ1+g0rzJrfonMjAz325DupeZB98GwxewpTi0wkc8uBF0hap59pnrD89hiZZejbwXS4pX1gxp1mZA6sNmlDXiKuV0qMhJJUlkBPqqk5nrO3VCw/C6ayR/deepq8RA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cU4Cbhls3SW1lImnaGTFfi2FqvW7XvhiDiskv1v3GyE=; b=nMydSNsQkxIYKcHXm0iV4jNqxqCJG16D+H0ldoClMPcJR124kadj9snCHDMWjiUrcwx15xqDTg3nEJPJoYz/aZ2gVleOJLvAk16Z3tIlpYZIMb8nE834D9/1EJ1LUZv0pidwlzdR+hzTPqi1g6y+rjP0RLJ7ucA2At0t9g7U+Zw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by PAXPR04MB8655.eurprd04.prod.outlook.com (2603:10a6:102:21e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.16; Mon, 23 Oct 2023 16:17:23 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098%6]) with mapi id 15.20.6933.011; Mon, 23 Oct 2023 16:17:23 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen Date: Mon, 23 Oct 2023 12:16:57 -0400 Message-Id: <20231023161658.3890811-6-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231023161658.3890811-1-Frank.Li@nxp.com> References: <20231023161658.3890811-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY5PR20CA0002.namprd20.prod.outlook.com (2603:10b6:a03:1f4::15) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|PAXPR04MB8655:EE_ X-MS-Office365-Filtering-Correlation-Id: b1a567a4-ee41-4744-32c6-08dbd3e38a68 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: J2o60YH4aEIGMS0wnhTWPT8LWlysfWkLHbhfGfnHjDd0twDX0W8LtpdCVfGrxKezf15mXeVNaiDPl9GJcj+PTNGZp9IvMaIhP5Ah+MBsuCvmdCuJFz4lDjw9e+jRLuZo13IOwRFx0svTQEItgNxuPTByOqFGAOieqKsO1f/iFP2o188gOsPMlWngyRswrR+v5f3cgMVWfKCNJnux4UinTA4YNX7Flji0HILGWkZnq23x2jwELyJwQq656wiXDAkNZKsnpmiLNWqAUIjbFTs0OAYzFlv4J2viwbLSI7Vjbh9w3mNAIoV+KvbpjbnxUuWv8H5ugg6K25NHC5iy8CZVa0AVHk9ek6fE6FD9Ce9D3xFZB1yjyfjcIBPhQ2KCyjP1jcByS5mtiI8qzvVIH6oJntKTQlCtoGQ90JvUg/gYxnYqn3Fn/o0lcwlppKetePSabv15etZtbcQ7MoRTIYLLTI5y2Xw0/pFM6rNcrnWJnzS8e4rBSoVUO21ysTyUI0uTBlchI1KmxzbJ3QjRmVrxaJPWAtLpw2l6k1WGuFkqRpwgGq8slrz7lPFdSlqbGPqhnQFY2l6M07LbCmIrDDFixGIdsMb9IEIxitsGRFKpDpwSDKSS6z9OPdyRdnYMfS0k X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(39860400002)(366004)(396003)(376002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(478600001)(6506007)(6512007)(6666004)(86362001)(316002)(41300700001)(6916009)(2906002)(6486002)(5660300002)(52116002)(36756003)(8676002)(2616005)(1076003)(26005)(38100700002)(8936002)(4326008)(66946007)(38350700005)(83380400001)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CcmzQ/Bic81S3jCB9xE9Yhc+KTggFhQp4cN+3Er43R2qojbpCYsXLP37PcMZ?= =?us-ascii?Q?DufKDE7pDQJ55Je0i73cnPepL3yHg+HQfDv4Op8qkNw5amd8jFrXObN2Y79J?= =?us-ascii?Q?yjfq1pk4yi8a+VYVOCBMSSI1kqJjSvhCI7944i6C7lKugkW2M2UnfygUvwm8?= =?us-ascii?Q?7S5vsZIwH8TbcPn1HlBG2zmgasHr77I6L56LYl2zkR/K7W/VqAJcAhPMG2nR?= =?us-ascii?Q?gVDmUBfN0UwTwtwENr6X9TNk6kGiH0S+rs6jJtNEi45BvKus1XUsjcFTknzz?= =?us-ascii?Q?pjDDBv7X9Ljp9gSPXmytWEZJTLZLQqvEspdtdh4++zM0RuvlO63B6Wfm5X4x?= =?us-ascii?Q?F1EXM3HUKxUzFink8XNPpsZLsbsPWyMLHU4Vwgk9dHr0L2tvsKxvVP9nNG5r?= =?us-ascii?Q?HDeGL0YTOm5qwoU2610MCRvDwdty2vExuPIoxwLGc5afrdJ+jIafKTEYlAlK?= =?us-ascii?Q?GB/pN4MMeXr1shcmgCeYL2tYD6ZoOrUsC8o25iwA6JnXsp4O8FM1eiStBjeN?= =?us-ascii?Q?jJ5R0cDj93JUdb8Sc+m2HXwYysr8SHZH3nPiZ5a5Q+ZURdgFCSTAb96lffhq?= =?us-ascii?Q?sqAghgi0DhhPchDoTbxCX6aUoU96ZUzpIvn6EZShaWnFYWpfrYF6dLuIGJxz?= =?us-ascii?Q?uMLfUaNEiA+PLcXCtUpGNbvj2JeWpH3vZNGmOwKzAImOgbciG54S7AMHakOl?= =?us-ascii?Q?DT6gpegKuza9Iyt0atfrNWTmPIMJNOSffDaUz/DXtxmdefdfwB/bzCfgp7hn?= =?us-ascii?Q?wyo6pHx0i+uL6VflzykvMjnXCm74elcCzKbsdR9IKRHj3DI5F4xZLObd0gsZ?= =?us-ascii?Q?5RhhQDKQz3Qz1lqq0z6fCv46JD3FEB52ayTtoP9Jd2gUIvLzodXI1ILv/Irm?= =?us-ascii?Q?l3Au2TiCRj4vCjMqjeFfOkutoovFasFi1g2I5aBzIDELfI29B/BBfZQUskYz?= =?us-ascii?Q?p7pZurHItBXUEv6/c2qZC18+wvLd3VqMfcB7cK0Qi3lP/OdT4Fd9RiiK+NT/?= =?us-ascii?Q?rf6XQe9T5kL36Byg6pTPyyPWOZPHzqwiwIBOTJVOpTSlgfvYfnjh9molLQU/?= =?us-ascii?Q?MkNZc+rfHJVgHwAq5HPVjYx481FqNBfdJUSkTzIqSJcCBy4zVVCJmhu4XL6T?= =?us-ascii?Q?kF4LzCg6gwg75wtHHvxKOGdGI/7eKAaz1biFfrckghEDYesaZf9/QTqpyrLJ?= =?us-ascii?Q?LEwn2hxp7Iw9OXRQfSBJFADpHOS9gnHQcjieniJ3WmmMnQZUO4hvT3pu8dHk?= =?us-ascii?Q?i6DlDmBnIdMRV+p7t+i8+cprzn/Irh3HoiajEkbAQLyY0smKKKk24G5fjz7M?= =?us-ascii?Q?BrCjAw35kioeio6P3v3BvAoFEhcgcaq+I4kkPpoqCuZmnkmRwRTSLYMIJl3z?= =?us-ascii?Q?Kzz9Rk/SrUMEPg2E3NTwuKwgnqJNQwtuW9krnoNdv7OLM1u346w9dYR2dIUw?= =?us-ascii?Q?PGFg202eIqe9hskiRXD0BXLI8ihqKmB2s3VOZD0doGL02JTTAtigXho4pPpJ?= =?us-ascii?Q?ziOatDAPDMvr1O4wIcSyxfPToVCC4+8G4u2O4lENJmoWixkayKVyveODa2gw?= =?us-ascii?Q?h0wzFvaoXAOtwshcwfhMStkGt5Yd4nRusT/xoohu?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b1a567a4-ee41-4744-32c6-08dbd3e38a68 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:17:23.7770 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: giuBRlfaHk3hLM4JmCSETV7BP56CetrOvBakPF6dBSzikbmyUh5HSdPMlysFO5LVA7P7/ex/JZwooFCU96yPfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8655 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Upon IBIWON timeout, the SDA line will always be kept low if we don't emit a stop. Calling svc_i3c_master_emit_stop() there will let the bus return to idle state. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Notes: Change from v3 to v4 - remove duplidate in commit message Call svc_i3c_master_emit_stop() to let i3c bus come back to idle statue when IBIWON timeout happen. =20 Change from v2 to v3 - Update commit message and add review tag =20 Change from v1 to v2 - Update commite message =20 Change from v1 to v2 - Update commite message =20 Change from v2 to v3 - Update commit message and add review tag =20 Change from v1 to v2 - Update commite message =20 Change from v1 to v2 - Update commite message drivers/i3c/master/svc-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index b113460f059c3..1a57fdebaa26d 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -404,6 +404,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) SVC_I3C_MSTATUS_IBIWON(val), 0, 1000); if (ret) { dev_err(master->dev, "Timeout when polling for IBIWON\n"); + svc_i3c_master_emit_stop(master); goto reenable_ibis; } =20 --=20 2.34.1 From nobody Thu Dec 18 15:31:48 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF963C001E0 for ; Mon, 23 Oct 2023 16:17:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233763AbjJWQRz (ORCPT ); Mon, 23 Oct 2023 12:17:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233641AbjJWQRb (ORCPT ); Mon, 23 Oct 2023 12:17:31 -0400 Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2056.outbound.protection.outlook.com [40.107.6.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B77610EA for ; Mon, 23 Oct 2023 09:17:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BRLI6FkfM/TdaI18u///YcnF0M0g1tIz0GvzM0xejITvTwaYIhkh/+mwTEOBeU0gvTiWJQSTt0jnelZEaLCcaZ9Q2VPV4oGKoyhvE4KqVyuh498Jl19lut+7cQyRawOyUR8Wx9Iu+DT50gXy2eIPKOM9kZQfAKWVH0JgrS1hwkBIzNAxQGDY37y/Omc7DnqDf46DyUgEpWXJTKC5dEmjduMBvtc4LaUTk4ILjtJfSge7u/bmUwYN10pb/9dK5/f+mGs/xap3KyIbwitgojhygMpVG+NOOBf+uJZfuAm5E9B5WMKA+aJdchc9L5IHzCC7TaChicD0G2twYbOVEVo3ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nxBwTfviefvCF4FZJghiatpkh63SM3ZApfysbHSxGKY=; b=SNnX29DqPMWWJ9x1Ds5XY/6Y5ps95vOjaahe6vSPe0wGM7Zlmbcql3s5IW8TEgkXJu42Ry+7iAl2uZtUbuVbxF6RAuuYVmmHr6AHZsDEwrPgKsAxQ4rBff0z6i59qZQf0TfhlE8t53ua+RiWURRKEPNY259vuGItGsJrW4/SwfYNX8CwbI3F33hkZfkyXbDTG9IRG5aCXGFK3FY6saxSCkeIecVyrFZHSSk/0JqP2a2meOrANJ2z4anAe2h3Xsnc7OdiEPhLv4B642QxppnLnjT4xOYjbo3v+2XUZ5yjyQojNA6DcyDyJbS2JWmzAGYcc9zhvENs7omtW5s5ZfV7oQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nxBwTfviefvCF4FZJghiatpkh63SM3ZApfysbHSxGKY=; b=pbOcV8Av0KqKjZ5l+K+zgQjOsDMsYc4Vq1aB2o3MjVX2avT3yaZCu/SBJiXZIGGWNl/zF8JDHQFr8wHpctq69Yaz7vPQ5ww9INCPjHnMMv/spEugLKLdDpcOLw32T2Rw5VfnFTVCE1ogd2buW5liSZTdMYJ1GucalyYlSvl0w4s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by PAXPR04MB8655.eurprd04.prod.outlook.com (2603:10a6:102:21e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.16; Mon, 23 Oct 2023 16:17:26 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::97ca:a905:8e64:c098%6]) with mapi id 15.20.6933.011; Mon, 23 Oct 2023 16:17:26 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v4 6/6] i3c: master: svc: fix random hot join failure since timeout error Date: Mon, 23 Oct 2023 12:16:58 -0400 Message-Id: <20231023161658.3890811-7-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231023161658.3890811-1-Frank.Li@nxp.com> References: <20231023161658.3890811-1-Frank.Li@nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: BY5PR20CA0002.namprd20.prod.outlook.com (2603:10b6:a03:1f4::15) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|PAXPR04MB8655:EE_ X-MS-Office365-Filtering-Correlation-Id: b6aa3968-6fb1-4441-0e8e-08dbd3e38bc9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8zCVGeih/1XImRLE1hl3BcOTxLhQr7KRepfcuRX6ha/BJfmXPe6bw94yaVdNh/u58eVxmV4gO2G7rKDVqAMvxFpUKBj3eSgcoLeiEfUb9PHpDPX/IRpktinvigrtFPYRTtV2pNLnJ4DpIJm8jT/75kSVYyNg+G0uBU8SDYSx9pjaufZB3NDDimrQl0UE4sz5bahXtmzhUssUsK2KUuNqV+lgP4qb4EQJikJYuOqWf09CMo4tyEv9/eEZXX9KAlGi9faKO6je22yyUbMUCfQF9huuuliR/C+bvuUqc1xTgJa6t5nr1pGEyn0Qh1/uuNHFl5TnaXVjM5OGgadqH46Z5pxDHB6py35jhv+4QfTiowwJOGp9NCNhZXHWOKlnJO6Vsoyc0mXOH31DtIZeTH+IigJB0UlYdirJuPu+wXcMP6axN5DzHA8CvWfOfqo2X1cCGhCro5XfuQbbckm61zZf/WecHG8cGPPyZAP4CGhnxTOBZYQ5Yhh8xPCGKd7AWBg0ohTxfYUCOS7rD54Rm5yyAwOcxJMu0v0JRjWX5mDNBdRPVj56v1zy2dQWHQFJ6C68dRHx5jQ9tnDAy84qlCJgseWS1pP3jm6bz9/+16q6BoED0Y2vxAD3uBd6YyyuEMJW X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(39860400002)(366004)(396003)(376002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(478600001)(6506007)(6512007)(6666004)(86362001)(316002)(41300700001)(6916009)(2906002)(6486002)(5660300002)(52116002)(36756003)(8676002)(2616005)(1076003)(26005)(38100700002)(8936002)(4326008)(66946007)(38350700005)(83380400001)(66476007)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UFQxYnJHS1Y0T0c4Z3FyNklJeVptTUkrdU5QVVZIdmh5MEowbE4xdG9ZZGlR?= =?utf-8?B?Q2JOYmxLRkdIckZBbC9IWlJMQzVVaXFacUdsSjU0dTZzaHVzdGhmTlZoRFZ6?= =?utf-8?B?RkkwOS90Y01MRVk5ZjRHUHJyVUxyMnUwaEJ0NXhIRUlrUUNmR1IwQjBJdjZG?= =?utf-8?B?eC91M2xHd2JNT203eCtDUlFHQTgyUEFLM3ArcnhYd0JGWlY1Wk03Y3lpZnVB?= =?utf-8?B?a2VtWk5MdVkybVBsakJyN0E2Ykg1c25TWTFZeUwxRUJGa2ZOSTJZUExzWGw1?= =?utf-8?B?UTB1S2lGVkhGR0ZjNTZpR0creEpXTGFXbThubWVZZmRHb2Z4WFlXY3RobUhY?= =?utf-8?B?bEVKV09pSXpxbWNXQXVCWStldmFPZmVYSUNOQjRWY2F4TXFRNzMvSDVDbEdI?= =?utf-8?B?WWVTZGQzc3ViM0hiaDRCV25Ra25kSXFKc0hndGFTUHErRy93ZGNxa2ZYY3oz?= =?utf-8?B?VmM2ZDVsMWJCU0VLOEFMTWhnekh6UEVlTzBQVVl2MU5HNy9xWHVWYkxod3ND?= =?utf-8?B?dEpvQVhmSThsd0N6T0tPbXNWRGhUK21lZEVjOUlEQUErc3ZreU5ZWU1SZllX?= =?utf-8?B?STV4SXg0MGJiTE8rb01QYmM4Q1c1aTNMMlNZdzBRbFo4dDFHWUVSMDdab1ZC?= =?utf-8?B?bkRZYWUxMkkrbjlGSXBMN2lTMTZZdzY3dTJQTzlHYTk0eWQ3b0ZiVTVNd2ha?= =?utf-8?B?R0t1b1UwTHovWlVnSjlMQVdVVmJzOHlaVElyMHNLWEozQzlqSHdsREJnOGty?= =?utf-8?B?TmJCQkNKRGgvcTBkTVJ2SG85L3Q5bHRkaVF2emZvMmpLQjZVQnlxdnlmVFNN?= =?utf-8?B?QWZ1Z05TZTVmcHE2d3FvejIzSHpBQ0VKbjROT01rNmtSbzNOSSt1dmpDMUZX?= =?utf-8?B?SkZMUndaWksrTnFVbFUvUjBBQkpvendUV2RxbTRVMGVvNlVmQWtOa3E2T1l3?= =?utf-8?B?MDZxZncwQXk3dHNsOFJCUzBab1ZmRG9Od3M1NjdEVCtZQlJBODlhbGNFaHdG?= =?utf-8?B?ZC9adWJ2ZXFKYjhCZWl5TlFiUC9rQVJGQnJkM2tzZ1BwOXdhdmluUEwvTDZw?= =?utf-8?B?cWhpb2pOcUNwZGdGWkpOVEMwbmJiMmJTUmFFUllOQ0JmSTdKeGRmMHY5SG83?= =?utf-8?B?MC84eThLSERBeE03OGM3OUd4V1ovRzJUMDIvMTladExsVm1QTkRPZU8zY2ta?= =?utf-8?B?L1hpcmUxa3N0bTBKU1lDTjlvVE5KN0kxWEJBVjVlOW9JRHBadGNBQ2NRL1hk?= =?utf-8?B?MENaTzk2WHBzanU1VUFQQlZYeHRmUzFqVzIzM3d5TXpOY2hCZlVuRk84bWdp?= =?utf-8?B?VWxMRXlCZVk0YlhnZ1FVbjRhczNmZFpiNDNzMWFTR1Qrc1c3T2ltM0JlZ0JD?= =?utf-8?B?MFQ4aER3YVBUZlFFejlaZFdrOTlSaGE5cHM5STh0K2NnRGtxR3MyM0FCZGl1?= =?utf-8?B?VUlKbXhRczFzTnU0K01mOTNhN205QnRSV0VhZjE3WVZNU2tFSU96TWh4NGpm?= =?utf-8?B?elFGOWlFRUJCaDZ2Rjk4cWlKU1Y5WUFFd3FiRCtpaEF0QlZybm94OTRzaGdN?= =?utf-8?B?R3JYTkorRExRWnhmTUFsenNKTnBXK2xtVjRweDhPeGVyNGgvaXlSS1BXN1Fo?= =?utf-8?B?NDN0VkdIbG5MTlZQK0ZHOEhkWnVQL2l1d3graU1DR3Y0dlpwMDkxcHdobVNR?= =?utf-8?B?TSs3eXFkZ3NYN0Z3aG5CN281ME1GWjBJVXVxanRRRTY4elZwU3o2dHgwMXBV?= =?utf-8?B?QnF5WE1HU3JINkhwUXFsc3ByT2ZLQ3VhV0t5MnJpeVZIQmVMbTNIazYyWW02?= =?utf-8?B?RFNrOTFKWE0yNVVWcmhLZnp6dW1HWllFaVZHTGU3SUwyNndnWnBiYXpERjVt?= =?utf-8?B?K0UzMHVrVGV1bFdrTnVTejRwVXR4MTNOOHB2YnFHVjcwOG5yY0QrZ0NSV29O?= =?utf-8?B?M1g3eWtsUkJyYTl0bFZJMTNtcHhDNmZsYy9GUUw1Z3VuTzBIL1pMS2hyNy9L?= =?utf-8?B?Z3F4WVVaVVc5WUs1NTliK091NDBNZG1FUndOMllibGllcW1kOEY0dHlHbTZH?= =?utf-8?B?eHhObGtvV2graW1xcGxGM1BqMTh4N1ZRZitiUkNyMmFjNTAwdzJualdhTExh?= =?utf-8?Q?q5F6x5hc2oylmxOXC/lq8NzQ7?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6aa3968-6fb1-4441-0e8e-08dbd3e38bc9 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 16:17:26.0587 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Fv2aAifx1F2hnB4a9mY7Ky225TgNnfdoQNvWE8DzyfWWSXdNQy2obMMT08ujlHnYmFcBAsyMQlKzPObKwtOM2A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8655 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org master side report: silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090= c7, MERRWARN 0x00100000 BIT 20: TIMEOUT error The module has stalled too long in a frame. This happens when: - The TX FIFO or RX FIFO is not handled and the bus is stuck in the middle of a message, - No STOP was issued and between messages, - IBI manual is used and no decision was made. The maximum stall period is 100 =CE=BCs. This can be considered as being just a warning as the system IRQ latency can easily be greater than 100us. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li Reviewed-by: Miquel Raynal --- Notes: Change from v3 to v4 - fixed missed update commit message Add dev_dbg for TIMEOUT case This can be considered as being just a warning as the system IRQ laten= cy can easily be greater than 100us. =20 Change from v2 to v3 - remove 10k at commit message =20 Change from v1 to v2 -none =20 Change from v1 to v2 -none =20 Change from v2 to v3 - remove 10k at commit message =20 Change from v1 to v2 -none =20 Change from v1 to v2 -none drivers/i3c/master/svc-i3c-master.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 1a57fdebaa26d..6b6bdd163af4f 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -93,6 +93,7 @@ #define SVC_I3C_MINTMASKED 0x098 #define SVC_I3C_MERRWARN 0x09C #define SVC_I3C_MERRWARN_NACK BIT(2) +#define SVC_I3C_MERRWARN_TIMEOUT BIT(20) #define SVC_I3C_MDMACTRL 0x0A0 #define SVC_I3C_MDATACTRL 0x0AC #define SVC_I3C_MDATACTRL_FLUSHTB BIT(0) @@ -226,6 +227,14 @@ static bool svc_i3c_master_error(struct svc_i3c_master= *master) if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) { merrwarn =3D readl(master->regs + SVC_I3C_MERRWARN); writel(merrwarn, master->regs + SVC_I3C_MERRWARN); + + /* Ignore timeout error */ + if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) { + dev_dbg(master->dev, "Warning condition: MSTATUS 0x%08x, MERRWARN 0x%08= x\n", + mstatus, merrwarn); + return false; + } + dev_err(master->dev, "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", mstatus, merrwarn); --=20 2.34.1