From nobody Mon Feb 9 15:25:53 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FD0B3B1A4 for ; Fri, 10 Jan 2025 13:31:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736515887; cv=none; b=FxwHw01t3xmtACJwXXKikHQMoVAcWItROQN3DFoNukjbbWnUYNimK6y8mKmvDFqYHxaOS149aNYzkRO2kigYLV0cijwg0fhKicgnFZeeIuF5uJqbqJR2+TCX6gNwfMjBkUs0LbB5UFh6/Kvd77YDDJsNOJUHKfm6xTI0ia1+Zmo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736515887; c=relaxed/simple; bh=Yn0yDiaGCUYQbX+kBDNWi7Wqy2+4x3TU5RubErw6Doo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=mGnaDlAWxn7osYpEI4IDF9I8pAj7vCIIj9o7y0NFC3G4sGCnG0Jqt4yOwRYnAi8+7GQrpmZS6ORMyc7cFUohbQ4HzxCa3FZMaoqbo+jljLO5aNX+yjw9bOTIWDpHTxGZpoPpf7CX2Ly4xATPTrjwPHtc6T8N4ps1QAE9L1RxaXk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=woF3JD9B; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="woF3JD9B" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-43622267b2eso22529595e9.0 for ; Fri, 10 Jan 2025 05:31:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736515884; x=1737120684; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fy/DbTIkkOlFt9RUb5dJSds3N2C+4xTIp3gr3Wl8Gls=; b=woF3JD9BL0ijLFM9malxzPbZGAeVnMbe0y1xJWLBk2iNfGOFgw5pzkHz8X5wvh71j8 alHrzg0SiPZCEqifteOaIxZrfM+k9Fjeo9c7RDmg7qm74Jz94tYFwX3Mnw1igY+oEivV 7uBA3LULyXhYJNrW5SkPSyaoL4hAKTwsJTjIbVr3nfpA14ZTwSwKn1COuuGx/g7mOW12 YOj+EwfsL4MsPuYdARtohFTzzRHltLvjO7UZJYF2EIZp8z/axwmXBxSU/aOU94LO6FxC d6P7v1L1xMP6wCQ2BdKQV3ci7dppDS9wQIHfekM0v8yG92h0Ykr1hG8Qt4rX1+CL8pVS WZWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736515884; x=1737120684; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fy/DbTIkkOlFt9RUb5dJSds3N2C+4xTIp3gr3Wl8Gls=; b=dqVTKGQL8mNoZfjod3CQ8zmpvmNzPGxLjuNgP8D+Oq8vtkmktKMETYoYYn2V3u7mPH xRpzTLSs4GlV85hiA5cJpGikw+Ec8P+3q3eAC8FWFtjK+EymEuiREZ8P0FRTVsonUd68 U8VvGpL3E+vpiwtqP7rZFjlPt/VsQ4XhuO5DTK9EWIwWu+dY03l9hApzG2cbzUCTWWgg 5OqO9ZODhnmF2oZTybpzXN4xcYEItOpdVtFf1SrldIICjFKOvoC2RVHjuya2gvc+uxon S72QedGK4erVrwfi4JGZDm0V1f200a5OMzrdJV/oUW3twKNnYC/+4qd0IWaU+oiNIMXX LgXA== X-Forwarded-Encrypted: i=1; AJvYcCU93T4Bu2Vqx4XAb4a6791/Y7CeqGlvnGFxo96KgOZOynwMjuuhz3swCHbglfpVx7fuVVSYii1cMdVFVr0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy92ewp9Z1rFfQ66Bcn+GMZuTng/8xzoL3UHyL3Hv6C5QMO1xBv LXX+hAiBEHifH/pQsJSHRCsd5dkPzx1GqN7dQUHsTdJfGyUzd4tHajLtRhYZcpc= X-Gm-Gg: ASbGncuXDxualQ8hY/xpl86cPbemJt1u9I8NexmoGL2Kw9Mr1s21PEJ5FL2TNivF3tI BqmyU51dMGgcC/4vuod1/Pg5yJ8Y0APpwrmd7OadjaXV8IQ68kNg6/ZcKBhM5m+2/HgGO+Mx8JW YdFc08Ohh4yNXpEw/4IdA/C+URnJFhyktYpGLu1JTlYRDNogRWHEdev8Vl5W9s+9rtgbIz/kDcp gzagCD29ljYwrBztJc4qDbHBfOVpcQKsCEXqITCQt4k1CIkifzqLz4f4N9i X-Google-Smtp-Source: AGHT+IHKxpgNUmOUdkrc6PQxJw1G0Fu/KYCSSNNFr/GjW9WVuFsnr7/fR3quCBLX5bmiMLZjyBIZ4Q== X-Received: by 2002:a5d:6c6e:0:b0:388:c61d:43e0 with SMTP id ffacd0b85a97d-38a8733b9e8mr10763857f8f.48.1736515883672; Fri, 10 Jan 2025 05:31:23 -0800 (PST) Received: from [127.0.1.1] ([2a01:e0a:5ee:79d0:2555:edac:4d05:947d]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-38a8e38c990sm4598193f8f.56.2025.01.10.05.31.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jan 2025 05:31:23 -0800 (PST) From: Alexandre Mergnat Date: Fri, 10 Jan 2025 14:31:12 +0100 Subject: [PATCH v7 2/6] drm/mediatek: dsi: Improves the DSI lane setup robustness Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20231023-display-support-v7-2-6703f3e26831@baylibre.com> References: <20231023-display-support-v7-0-6703f3e26831@baylibre.com> In-Reply-To: <20231023-display-support-v7-0-6703f3e26831@baylibre.com> To: Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Jitao Shi , CK Hu , Catalin Marinas , Will Deacon , Simona Vetter , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexandre Mergnat X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1234; i=amergnat@baylibre.com; h=from:subject:message-id; bh=Yn0yDiaGCUYQbX+kBDNWi7Wqy2+4x3TU5RubErw6Doo=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBngSEn2Qf8+H9Mmsv7OXpjVxiPUD7Yjb1fkvT0Ur9q aV5CbwSJAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCZ4EhJwAKCRArRkmdfjHURTGKD/ 9Ty+ydloEEvoD/Kmij1B/CcQVBe6jSd5+V7KY6pP8cX3F8EGZ5DuX1JRDTw7n6qr0v8t5hMj3vnD4y 3kcOdro29k0f3zDbIKnPaldi4Xooy7mth7N+AIF1rG5vrhs5ZwSXy274aJnNwjbi7F79VQtY/ED8BK JMCyF9De60OQ05V2aA48pVLy+YKkoTMB1fGsR6iAmSINWJN1X92qBuivVZpp0sWhjFdllJnA8EGdOB zeRPjNyx0Jn5zrNjYnHseUpuZ8JbV9nWc1zccvD4gVGxDasxqANpeJ6v7srfMCEwDX2lMGQNFqD+V0 ZVV5PnpcIMWPEmo8Fck7WktUnlvHLppVhOl9ZRJ7J5kRzjvt2n/EvBzUojg2t79aKfTJYm5GDHc9lY dWUW6TSq8QSfjkim0hcDojluxIR6FFUsBBYOzXqvptNZr4r6+P2ebaPBNEZBW3T59Z7+AezTXsmLl2 e3HorWswN5WkZpMRCxFb9n2o9eYtwQs5vTRsS/8hVwnwSpM6d19kGVflYfRjoD9dsS3mhncHZzuDXm aSQEe+FxnEU0BZDAdK9ISk1MmLJHWsiJt6V9Ugiv0vEh54yST3DsiO+1pgpS4KQ+yI92tRmf929/4y 8Ylibc+sqUSryOVik5cnV84QM5Y3QZ9+THVZUDG1vFs6e5bdZDV80jGHCO8Q== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 Currently, mtk_dsi_lane_ready (which setup the DSI lane) is triggered before mtk_dsi_poweron. lanes_ready flag toggle to true during mtk_dsi_lane_ready function, and the DSI module is set up during mtk_dsi_poweron. Later, during panel driver init, mtk_dsi_lane_ready is triggered but does nothing because lanes are considered ready. Unfortunately, when the panel driver try to communicate, the DSI returns a timeout. The solution found here is to put lanes_ready flag to false after the DSI module setup into mtk_dsi_poweron to init the DSI lanes after the power / setup of the DSI module. Signed-off-by: Alexandre Mergnat --- drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/= mtk_dsi.c index e61b9bc68e9a..dcf0d93881b5 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -724,6 +724,8 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi) mtk_dsi_config_vdo_timing(dsi); mtk_dsi_set_interrupt_enable(dsi); =20 + dsi->lanes_ready =3D false; + return 0; err_disable_engine_clk: clk_disable_unprepare(dsi->engine_clk); --=20 2.25.1