From nobody Mon Feb 9 01:21:19 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE157204C0D for ; Thu, 9 Jan 2025 10:38:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736419083; cv=none; b=ulEHjy/KOiCyoshkUHVmnOxJrzEMv3o0veZsyOBGuQnzCoWVl7iZGEdK73adGRps2uU9dRR1zsfxncDpKYFCy8euR4z3I2IT49FLEAEZbmpl0YElnrcHnsUQtlokb2IAVyQRDuBm/2STtbpgBjRirLeIqvTmfFw4hdxbR3NNnr8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736419083; c=relaxed/simple; bh=Yn0yDiaGCUYQbX+kBDNWi7Wqy2+4x3TU5RubErw6Doo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uvEQGRUdBZeMgtMRWN1URkSSp8Xj4nDbVPo65eY7sDQxoazx8Cg2KrIBLuI48AlkMaR/z9zn8BzHepZR+uMZQmA4+xlOzhgWEMdFRkYwditilz6W+uL4StrA36GUuAAtNBQAR4E4Sj3mSV5fzypAALLCrDkJQk4Dx54oo+0eXTA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=FZns/Rt8; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="FZns/Rt8" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-43690d4605dso5820905e9.0 for ; Thu, 09 Jan 2025 02:38:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736419080; x=1737023880; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fy/DbTIkkOlFt9RUb5dJSds3N2C+4xTIp3gr3Wl8Gls=; b=FZns/Rt8mUrJXwVUzbyciWpaS6Bydj6mK7kSVU2LO/76PdYc+cBW9rsUqX88QoJAMZ LWJzIYTeM4Qn6AVEBt6gxhU+4Q+TDN4k0qFplSXqurbz0YuN+ec/YCB/JVeZdQkjvadX ksk78mT/1SVcjMw147tDp8fOowC0T6JBT/3nwmeypyUDX9omOS2k4WPabC2CE/Kp8eRT P9zWhOKYCJnaUKMTfXI0d4qgVE/tKrvloJZT0nPOe33udAs4sPR+Lk5pcSFBug8w8JZt hquITNbltFBB0uA7A3DeTj4B9vr2aw6TmJpsmk1GaEHMJnV7JOq5v/1U7NrjvxKV6HJz VZhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736419080; x=1737023880; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fy/DbTIkkOlFt9RUb5dJSds3N2C+4xTIp3gr3Wl8Gls=; b=TKxwiFevCVwJ+7LgFzwV0jiPQtR6nPfDFeaJ833h+rL+v3UUgAUX4P1XlryDvaCdeg 08X4VPMuom53+PgsMPDac8kS7I+PYiZ/wRsWqXaxAOePaQnhnw8JNB07Px2A81ugipca /SdFbVOrA1lI3lJTHmMWuRz2qBC5UzyboXXrR4mAAj2CC03Lr5xQmpGidf+TOMc6/cZm m5/izsA9twxt29F5YRi42+3pINuJJ3/y7PCI/g71H4MA123BWlIfETcjGhTJwwjUNwfu h9qIaQ1GkoQSOeIu9hFSFbOzKQSMaz6GNdwA2YEuCRt4YrgHLsnhpx9EDB3dyqz/DEsw Ez4Q== X-Forwarded-Encrypted: i=1; AJvYcCWGIfnLMekyROYDL8JTL4rmRMeY8tSbAq0sAJ6TCx55AzT3s+yb53OQd5P5qcMzboz4EiY5bFP0Sc8gboM=@vger.kernel.org X-Gm-Message-State: AOJu0YwsIVvSd8ihMdzqURU0fA8QC8nbUCN/s4ldi1gxIyE+QDuOEFSR mEhY30g0EIwnaYxH3z4GteOVyaWBnJ2w3LHu8r+40rmRpv+VKspGTSoq0xxcyh0= X-Gm-Gg: ASbGnct6USuaxF/+Tk5fwf1zPEGM7WwmQAPxanCHfyIy6YDhqzbOaOi0PjKNxkmQDmW 9kA6UMpuzXSSDmx+g9fuoTRMBqx8pBDOwsskfoyl5M6QhIsXTOkSYE5K5t3b6QMMiUmAFsGj/6C EeOvMTA0kSSor+PfEgGi70dQqGI+bQ+mIDdtK6y2F4MG1FswM0Y1gusrQTeqdo7YGLd+sFsYqZw 7p4IpU342P4UOOym5jTcQI6GAyZcl9epNnRn+WGn5RLIcEUuNnr+HWszXE= X-Google-Smtp-Source: AGHT+IFqrF9VBaIGIQv342u8nnxcL3grxMu66H5YdF4aKnHXSKZ8sqOEG/h96wNqmjPS/6bRF8WYeA== X-Received: by 2002:a05:600c:a44:b0:434:a852:ba6d with SMTP id 5b1f17b1804b1-436e2692d98mr53720915e9.9.1736419080138; Thu, 09 Jan 2025 02:38:00 -0800 (PST) Received: from [127.0.1.1] ([2a01:e0a:5ee:79d0:125:358f:ea05:210e]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-436e9dc8826sm16428195e9.11.2025.01.09.02.37.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2025 02:37:59 -0800 (PST) From: Alexandre Mergnat Date: Thu, 09 Jan 2025 11:37:55 +0100 Subject: [PATCH v6 2/6] drm/mediatek: dsi: Improves the DSI lane setup robustness Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20231023-display-support-v6-2-c6af4f34f4d8@baylibre.com> References: <20231023-display-support-v6-0-c6af4f34f4d8@baylibre.com> In-Reply-To: <20231023-display-support-v6-0-c6af4f34f4d8@baylibre.com> To: Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Jitao Shi , CK Hu , Catalin Marinas , Will Deacon , Simona Vetter , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexandre Mergnat X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1234; i=amergnat@baylibre.com; h=from:subject:message-id; bh=Yn0yDiaGCUYQbX+kBDNWi7Wqy2+4x3TU5RubErw6Doo=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBnf6cDwdONFcg4NoVECip2enCTYPobmCH1FlW7pj0f vkaE7iSJAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCZ3+nAwAKCRArRkmdfjHURSPtD/ 4w4jm96OBg+7I4Hu11Al/9Y0xh9+Oh3kbilSLdnrom4hY3QZ4s7zBD3cCsVUNkid0FLAfkhsMpd4eD phj+a50KyeJxdLZ2W9mahlJrExdjQhYo1QuiMNzOwvUhb0setLby8V6aFbs6qcjiHddZZh19gF2OL5 IJwG0L1WBP48ANNIByya4m067yxpJr+JmuDQbkRVFtWB9oXwzfAkL62i2nYaiyA6tWQNL/q12MGydn cNcFzOWckYcGQWzG6MAM1XFekhLlrawheg/eYFMYrHD+gFX9cCU35y0+Go2MnFzYW4y7llOcVjwBOP vlLLQFuys/YltGsZ+2K/Mw2hrUO9PFHdQWGvnRfIslGH6jIFVcH1nJ+/FhHrpC6mAc9b/VlTjxjMTF 5zx0MZ8x4SKVvYp5YpnmmAaryXjax2HWnGX355TxNOb8JQLf0Su+Cb0ZbckN3+9FpOqwmTg2Ga0PbU k6uL0C7UZCbj9okzz1bFSMvAlWXvoQn0EicsTdbmucSljHbw4R7nCGRr+h4d/fYL1dkMpVvR5+3F7T GaTnq5/w5LziPJ+FE1wRHcGfYi9iTS/vNVfuFKgGNRpBKJBJFnsyNSU1bGpzHXmktkJbLimW1NpxEY pxQvTazZz+jDn8BL55TiOGLwoUJr8eBRA2Ioyd7Z2ctupdak/5s9qnWE66lg== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 Currently, mtk_dsi_lane_ready (which setup the DSI lane) is triggered before mtk_dsi_poweron. lanes_ready flag toggle to true during mtk_dsi_lane_ready function, and the DSI module is set up during mtk_dsi_poweron. Later, during panel driver init, mtk_dsi_lane_ready is triggered but does nothing because lanes are considered ready. Unfortunately, when the panel driver try to communicate, the DSI returns a timeout. The solution found here is to put lanes_ready flag to false after the DSI module setup into mtk_dsi_poweron to init the DSI lanes after the power / setup of the DSI module. Signed-off-by: Alexandre Mergnat --- drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/= mtk_dsi.c index e61b9bc68e9a..dcf0d93881b5 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -724,6 +724,8 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi) mtk_dsi_config_vdo_timing(dsi); mtk_dsi_set_interrupt_enable(dsi); =20 + dsi->lanes_ready =3D false; + return 0; err_disable_engine_clk: clk_disable_unprepare(dsi->engine_clk); --=20 2.25.1