From nobody Fri Dec 19 20:33:48 2025 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 634231FF7B4 for ; Wed, 8 Jan 2025 16:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736352953; cv=none; b=jGnQZy4q9HleoDpOADMgVRJmpsQTx2p01mttveuq50rKdGYs6lfMQOdnuqaBgTZGIE9jXtf9FC3L8eTnIk1IvSWvJQQeu0l76NNRTDudfXiBjyma+kP18fLgLqaGXKr6nvLe2PuhE3i3NGe/VBUjFkYrPtBGxMT7qbWE4jrdcwU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736352953; c=relaxed/simple; bh=Yn0yDiaGCUYQbX+kBDNWi7Wqy2+4x3TU5RubErw6Doo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=OZ+MyxldNgFYhRUDpd3g/mb/7uv8Q9oq9B4U5LAqYNRXfWF01J7KVKTPStdq926c2oFzuN2kfRY6+NuGJIeEGKn1zFgoA/0H0Uh2r4xTX+AukwVApYM6JMxmBUw45/brLMvHIOKr1UFWUAL4SZ8FZqkQyk2ecGWdl3ubNwlb60Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ioTuLL2R; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ioTuLL2R" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4361815b96cso6345e9.1 for ; Wed, 08 Jan 2025 08:15:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1736352950; x=1736957750; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=fy/DbTIkkOlFt9RUb5dJSds3N2C+4xTIp3gr3Wl8Gls=; b=ioTuLL2Rm9LHL7wQG9zYXlJWIL8v3r6WBZ8jF8IU2FOFKfVnX0SG9eyG4wxeo6oDKP QpcQg8AMtejGdLk1FBDS2h6vbsC8uacK8uQWI7OPICWJLbIHX9Fw0Iae6rKFeFQa7Ikr +rqSOa5ykuCaYVpyS/hu0UiOr/0z3t+V1FN3t4KSeiYilml+FhHZdDyYQm7yu91O59DO aryBp+o3onAnDXJbSTVg4Qjf3rQBGYWsN4+mcYKPt6582V5bz5nLlcg3jUqIuNp3McOb zuAFTcf8762zyotr7UGnL3YI0b3uwCJhrfAi1SxU1WQqNIxBUPJv2aziU22QJDaFUK9G +2LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736352950; x=1736957750; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fy/DbTIkkOlFt9RUb5dJSds3N2C+4xTIp3gr3Wl8Gls=; b=M4REJfQmtdT4NIqikA9XVIbNXMjvJYq2e/6hxiLGoDEGfdv+R5XP36qw8HvtwmVa6U 9ccI1qmeRWZU3WzHw4HieRhW5oqzh4jiV8B+aITKEpjr2ff68ZwMm2AGeFKHvq/bf3O5 9XzadkZMXaSAloJVGoAnLfaFMnT83ocloYw2nYs4TBIGbU8ftwN2ZnwHlK/MRHLMv/89 8IBUlpxk0Vo4UPnDrtCwSEnEXvZNxmdk8nXYT+x9rS+k0qIXu2GrKOJtEGwq6SKQRCcW jH7PGTi/fE7/P2Buq/eM9HVKJdb2aL/pga+BxnIa4xbN+gn+cChBu1r2pDiWYyrKLf/n 09Qw== X-Forwarded-Encrypted: i=1; AJvYcCUUVdXwsjOoMcI1Jc9EPl3u7hSgl9V4OzOMFVQbHVW0Z8+R7wkjfNh/me5lDx7BJ13k4DM6hbVsnNly27g=@vger.kernel.org X-Gm-Message-State: AOJu0YzG5rwcjtnluKijaC+5bW29pc4jIA1iJaIE5vvcS0RBzEq9H8z7 MYU22IRyQN3+yokc8LHMmYfwCGzfcjbKxDKrGyQdyIYKWcDR5mWUIsL6qGcFRG0= X-Gm-Gg: ASbGnctrHOrE/tWDJivFUfjcwHjaEuMF9KdJcA3ZdRHYh5OM4WU6TreBxCuc2w/yhAo aOxpd/sr6HIqnlDa+hgmUbSHMowzAT6qBaiKmpBC2uOJw9qRL5apY+9IJxGl2PoE3KISJtP/yKS NmM/L6fBnx35NYKjq4gY49gL85rKSr+LO1Dy6fphDfDNQfIKxsdDXYwC5CYL3Cp+App/LaD4YAm AerZNC/80HVecAp3g3uDV21OkoyWdw4nQKbG2hH+/Ie71sjpbGeJhV8NsHz X-Google-Smtp-Source: AGHT+IErwM3j92JVYdrvJX3rbay8OfkvXx94igFMozvvvB4mQLpq0RzpMVuPEGWSZVlYGy9bvneCfQ== X-Received: by 2002:a05:600c:1d9c:b0:436:1af4:5e07 with SMTP id 5b1f17b1804b1-436e2696d35mr27681225e9.1.1736352949654; Wed, 08 Jan 2025 08:15:49 -0800 (PST) Received: from [127.0.1.1] ([2a01:e0a:5ee:79d0:a6ac:e6d2:88e3:8ea1]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-436dd14dfcasm44378105e9.1.2025.01.08.08.15.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jan 2025 08:15:49 -0800 (PST) From: Alexandre Mergnat Date: Wed, 08 Jan 2025 17:15:44 +0100 Subject: [PATCH v5 2/7] drm/mediatek: dsi: Improves the DSI lane setup robustness Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20231023-display-support-v5-2-3905f1e4b835@baylibre.com> References: <20231023-display-support-v5-0-3905f1e4b835@baylibre.com> In-Reply-To: <20231023-display-support-v5-0-3905f1e4b835@baylibre.com> To: Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Jitao Shi , CK Hu , Catalin Marinas , Will Deacon , Simona Vetter , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexandre Mergnat X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1234; i=amergnat@baylibre.com; h=from:subject:message-id; bh=Yn0yDiaGCUYQbX+kBDNWi7Wqy2+4x3TU5RubErw6Doo=; b=owEBbQKS/ZANAwAKAStGSZ1+MdRFAcsmYgBnfqSx5htXrZ1ekJrvaqOwSRFlMwld/dEfa0QLcinc YbzjdD6JAjMEAAEKAB0WIQQjG17X8+qqcA5g/osrRkmdfjHURQUCZ36ksQAKCRArRkmdfjHURXnkD/ 4+h/AOARecYGq4oShtmb2NW0jX93mfDG2xklUJT2F6zBdbeNzF6+Hf9vpfH4IpJ8qCOhzaDAiccTsL n/F91FRgA3NhV9vLIweMBfpouNgCAJqDxu2pVQ8JyFArTbNkI6MaA6tXhjHbSFdkiZkH8YSC72VtwM bodY/gV06hSkUUimxNUXCx4v1YuSI8QENLLVyMHqubbw2PAm0ROJpZKngxxzQF9Rq9bqENCWWiJNRY Ytvo7Bx4FGwzHo57pskqyQ1mAmfje/TeJfv7GuFhUpZ61PaoWaCK0/2ewIrMg9c62/X2ZOR3VY1ci/ /+m09ncl6oqERlR2m9zs7k7q9b9jHAEVeeKaCcHuSjYP9kRyfI9jygs7XOJCnpMlcLDLNDRra8gR5X FvhyaNTLwPHtRkcueY6llSeCx569I6CL3vY6Kctoc76+wJN/ZYGXnIRbu977CDV4r/PvTP9njiTJ84 ADMCGK3XcaIRppY8TNSWvsCyP0JBEQSt8lWNXtGem2TkJJePfcXNdp8Dca76q9L7/t6XheWKjOl/CT eO3iTUH5b0ZhjfF7Vbbq8kHA7F82w79IHNou2cAvQaKO3Yx6ExoIWkcvl76WWSaY+eikcL3TgEVN2J keKvH3T/7q8YjxVodQBfIsjyfX9ikYrJJ/UquoQr3Hl0ZXEosxA3at8BhiRA== X-Developer-Key: i=amergnat@baylibre.com; a=openpgp; fpr=231B5ED7F3EAAA700E60FE8B2B46499D7E31D445 Currently, mtk_dsi_lane_ready (which setup the DSI lane) is triggered before mtk_dsi_poweron. lanes_ready flag toggle to true during mtk_dsi_lane_ready function, and the DSI module is set up during mtk_dsi_poweron. Later, during panel driver init, mtk_dsi_lane_ready is triggered but does nothing because lanes are considered ready. Unfortunately, when the panel driver try to communicate, the DSI returns a timeout. The solution found here is to put lanes_ready flag to false after the DSI module setup into mtk_dsi_poweron to init the DSI lanes after the power / setup of the DSI module. Signed-off-by: Alexandre Mergnat --- drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/= mtk_dsi.c index e61b9bc68e9a..dcf0d93881b5 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -724,6 +724,8 @@ static int mtk_dsi_poweron(struct mtk_dsi *dsi) mtk_dsi_config_vdo_timing(dsi); mtk_dsi_set_interrupt_enable(dsi); =20 + dsi->lanes_ready =3D false; + return 0; err_disable_engine_clk: clk_disable_unprepare(dsi->engine_clk); --=20 2.25.1