From nobody Wed Dec 17 09:50:17 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED59CDB47E for ; Fri, 20 Oct 2023 10:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377214AbjJTKpv (ORCPT ); Fri, 20 Oct 2023 06:45:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38594 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377184AbjJTKpb (ORCPT ); Fri, 20 Oct 2023 06:45:31 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 610921BF9 for ; Fri, 20 Oct 2023 03:44:35 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A8D792F4; Fri, 20 Oct 2023 03:45:15 -0700 (PDT) Received: from e122027.cambridge.arm.com (e122027.cambridge.arm.com [10.1.34.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 390923F5A1; Fri, 20 Oct 2023 03:44:33 -0700 (PDT) From: Steven Price To: Boris Brezillon , Rob Herring Cc: Steven Price , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Dan Carpenter Subject: [PATCH] drm/panfrost: Remove incorrect IS_ERR() check Date: Fri, 20 Oct 2023 11:44:05 +0100 Message-Id: <20231020104405.53992-1-steven.price@arm.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org sg_page_iter_page() doesn't return an error code, so the IS_ERR() check is wrong and the error path will never be executed. This also allows simplifying the code to remove the local variable 'page'. CC: Adri=C3=A1n Larumbe Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/376713ff-9a4f-4ea3-b097-fb5efb685d95@moro= to.mountain Signed-off-by: Steven Price Reviewed-by: Adri=C3=A1n Larumbe Tested-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panfrost/panfrost_dump.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_dump.c b/drivers/gpu/drm/pan= frost/panfrost_dump.c index e7942ac449c6..47751302f1bc 100644 --- a/drivers/gpu/drm/panfrost/panfrost_dump.c +++ b/drivers/gpu/drm/panfrost/panfrost_dump.c @@ -220,16 +220,8 @@ void panfrost_core_dump(struct panfrost_job *job) =20 iter.hdr->bomap.data[0] =3D bomap - bomap_start; =20 - for_each_sgtable_page(bo->base.sgt, &page_iter, 0) { - struct page *page =3D sg_page_iter_page(&page_iter); - - if (!IS_ERR(page)) { - *bomap++ =3D page_to_phys(page); - } else { - dev_err(pfdev->dev, "Panfrost Dump: wrong page\n"); - *bomap++ =3D 0; - } - } + for_each_sgtable_page(bo->base.sgt, &page_iter, 0) + *bomap++ =3D page_to_phys(sg_page_iter_page(&page_iter)); =20 iter.hdr->bomap.iova =3D mapping->mmnode.start << PAGE_SHIFT; =20 --=20 2.34.1