From nobody Thu Dec 18 15:31:47 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1A7DCDB47E for ; Wed, 18 Oct 2023 15:59:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232179AbjJRP7y (ORCPT ); Wed, 18 Oct 2023 11:59:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50988 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232506AbjJRP7u (ORCPT ); Wed, 18 Oct 2023 11:59:50 -0400 Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2049.outbound.protection.outlook.com [40.107.8.49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BD0511B for ; Wed, 18 Oct 2023 08:59:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ejz+2WQVDrE3Av4MsHY1HCoNN10iReF/YAhDtdn93cTnUvFy+Ne8hDGr7Zj498CxYN49FhslrKzn+6/SB4Wk6XWeI7Dpk0MxoQuUUzNaTAQwfB8M6SogQNa6xAm31kwPpNEcGhtJ6jVdlS7CKrj4SH4O8drcJY/kV1SH2hk2stmtoux5w7QqskVXaC4sGXlb7ecEE5WSbUb6vbXhG2Su9o7Uhh4QbuqWtkUy4NVUKXUFCBfjIL41TtmD1j6o4SElp4dBFGpEQ6SfigdXU6qDuaZ15nAnyEN01aPyTuPQua2LMYzX46PjJplY7/n3KDAUERxGNUaGiZLIzN6WR2+1iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=D6/0l63ENa1rCG9AOCfTVMMHkxQaSAkgSO/Y9e4768s=; b=Ah+ARwdmGqBMcPEzKZIKXM1gIi9lo26Ni7qzjdwR8BKmSqXm1yVUg4fbvG3HesoIrbE53ivTEtGL9NKlINI5cUBDhlDptbGe27DVnfxCcCsaGcyPPJkBpBjMHbS/77FelfMENGlvscCGjwhiwNSu1rWVxDT6G29Pw5xsCziItWrf38OVAFH0zbXnOXb6u6RZ4Ca36/oM5PC449uTkK6IDS5oXsHQ9tC6wOJ3yunyciVMULEg7P6FHKJqFCeqVgDiYtCgPnreG16K+8oDDnfq6gJp1nuNaGE+niJPTfK19W0VU2IfuCvKkrb63sSePCqe7WhxlBgske9580gqlDmuPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=D6/0l63ENa1rCG9AOCfTVMMHkxQaSAkgSO/Y9e4768s=; b=Q5NYwqvQ7p8iWUSztW7xtRxFsw6uN+1HhjOCFGmrDn/OfwQ54JKs0e4iWvc3fwyG6yBOE+A7fJLDzF3DrCHKpjHd+iTdbsqAv+IsG6Pu3X28F1dGYor1j/XYG1H7hOrKenm9S3hJR3Qc2C09nzLnGj4aabj0SX46oViKLtkc3lI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by PA4PR04MB7694.eurprd04.prod.outlook.com (2603:10a6:102:e7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Wed, 18 Oct 2023 15:59:46 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 15:59:45 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.Li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 Resent 1/6] i3c: master: svc: fix race condition in ibi work thread Date: Wed, 18 Oct 2023 11:59:21 -0400 Message-Id: <20231018155926.3305476-2-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231018155926.3305476-1-Frank.Li@nxp.com> References: <20231018155926.3305476-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0210.namprd05.prod.outlook.com (2603:10b6:a03:330::35) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|PA4PR04MB7694:EE_ X-MS-Office365-Filtering-Correlation-Id: 8422bf32-b37a-469f-a9c8-08dbcff33f0e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4C4+msirxM8mh5btHeCFDfWuzAmQWS1If09OhsBbkJ4J3NyDmWnJwnBIKUie5BR89x2QuyQ3tusLBxMTCSGwp7vJZ2fqDGkWSi3YDljpaIWrnwZYZjdX2HTAoY53noBOW/PpPE2kSjhqZuGRpAYCiasGMBR3C7y/MQUHRvv/vESrE92MFyPQvRkulaX6amtI4V0Iy9DTr2tqKdCnUVGm+zxom0WBCqTDQmwGEkPXJDnrUeeKIp66jrlC5oS8mhjmhYXtpT6I9/kKUcSpdhVB5OGzaAckzN0nWxBwP7yAIIejY+zLX/mu9Iy5I+gHnOWmc5kXYvx+fzDtPWRAMrXovcFOPskbfMDmAFl+XqOuetkY3MmCGiTRGlRfXDxT24viW/kuMG/fwNHtZFjJqRhhsoxzZyCwp4NIOGDBufHhDdyUPgIRz5OIR41sYi90Pb6GvLsFE9D3YBf6rxly4maNcZIOr9eIm4hUO90/zdBvgWMPonEYQKwQ8GdpHir5Hmkz28aJtFYPj6EQnvyZjzN0vL9bV6zwJw+ZLmel8fTNhXhlPUSgE4IiPulgczolmlIcrq5utN7E9U2ImKPVlKCxtCu1yTgjQiJqwFtP7D38gaE31Q344yccd+RFHfVq9Ca3 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(366004)(346002)(396003)(39860400002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(66556008)(66476007)(66946007)(6916009)(316002)(6486002)(478600001)(6666004)(2906002)(38350700005)(36756003)(86362001)(5660300002)(8676002)(8936002)(4326008)(41300700001)(26005)(1076003)(2616005)(83380400001)(38100700002)(6512007)(52116002)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RdDsDBLkX1y1e/C9zijEOwLjnOlwWObwlyZLzAv1OI0cDKpq0cmFsskZkNuk?= =?us-ascii?Q?EY28KdBPw1mc7y2XYw0Rvrjhl/cbZahd/NCnFYDZt6s/dmbaqyda1/HCRqFb?= =?us-ascii?Q?h5Xoub4NU+/0ez88kTQFEu2s3UoKxJztFfs7yYRHP745d5Q8r7Cs0he7mAgV?= =?us-ascii?Q?98RURsR55XGVuL7Q6lU+1V68X6CBeDuyo89/lVxQg9n3Lj4tqiWHM1NZxlqe?= =?us-ascii?Q?ty+nPa2SMmwlMngikZk/Uswr//uFFCWUpvfruABsFUSynKuDstqoe6NBjjzA?= =?us-ascii?Q?1v0ycp70SI/nqlM6JuKkleGIeP0JXsRJDLbsuh4JHByRoRMlHdhER7nlxalT?= =?us-ascii?Q?BqjMiJ85sXdU66IG+gqLMPwwrZ5g38ZUvm2L8QqR/5iR3tkKIPvv8hQlKbIs?= =?us-ascii?Q?3ne2feP8DGm7CCgR5PlWpjZhFWdZs7i30pMgxQZeVyMidcnCYoRIZimC+zln?= =?us-ascii?Q?+qClGHSTC6QTC3tsj+OlMoq3ezLMdtZ1ZIJ33/BtUa6mkevaEbqhCqg/7nk6?= =?us-ascii?Q?cUoJDhWVfVNPtj7Xmj82Nk63wrVXZzmph/2Sy0Orv1z5tk6UE2c/1Rgue1fO?= =?us-ascii?Q?BP+CT6p8588QyCb60IHZyiHFrrz/BoLtFjycPGV7zHWwxZx0VNo6KVLZv+Rv?= =?us-ascii?Q?A6XJymEcUd1pNH+LAQvuUdTVd/gPTMxlLZASXyaq0rozAGGQiz7r/hrZJkZX?= =?us-ascii?Q?uVj3z3dNx4t6+XWJBAb9nto/LR2eb1K+0mLQ0XJMLKMF8E+s76seovt2wavw?= =?us-ascii?Q?6ix+WhZEHKN3Mnh/qBNtWjElb5+XNpQcHV98XYEgbIXj/i1tLVtdIjHEImkb?= =?us-ascii?Q?Zat4VWI7BDHnWkcT6/vciMoNd8Vl+srQQyyZMfSFIeIEJEgi1Gq4c4jYqBYB?= =?us-ascii?Q?tqlZ8H55bll7a/ASPvSf1BIaiH1GvMaX5y0JNq7kPcMzrPaYwV5pUE9br+K6?= =?us-ascii?Q?kTBQBSaoHOfWfw2WRCIFOCGkiim1X334pjHyRLo18SAsowDZ8IOKgapaSYdk?= =?us-ascii?Q?ZybGXmNKmpH0Vzr7aqDONYWT9vxzuWQE9Qy2Sjh4GG9+ACTS3Wb3+GjmHhT5?= =?us-ascii?Q?CggrXiZE1HaZTlze0/Kp8oSRXHbY9yS5VkFp/xHVWWjYkNtmGV34hvPwfheC?= =?us-ascii?Q?WL17YSkdhr0rf64kpmJuHycgYSFkK9S/ojltYczQltPZDhFnCw47c1N/3F40?= =?us-ascii?Q?szrjT6wUCYbtqMBxcW9JzcePBnd/lcfHPURVg8iaBYB/Juun8kN5JxbBtgWB?= =?us-ascii?Q?hiNDn3khlJ70SjREUhsbd6/bNQ6ovq4g2IG0306GL5H7NsvTmnUGCjvUBAtf?= =?us-ascii?Q?rEFElfBuCJlTKwxQiBi1Kisz4AWNR0EX5G2ZuGsECOZtNjTIMx63OCvliY+Y?= =?us-ascii?Q?rNQSDZAv14IHyBYzt9CJjBcwDmXpqABbVIBAmPkaFunfNzEHnb6bLoYOB5gU?= =?us-ascii?Q?X4gn7uPaLdA6lqifi3C8qCgf55WbTcsBqCVFVyhk3pHSdjiSA88Ip6yVL91h?= =?us-ascii?Q?xRZAuSLJOXV+AJXep0KGo+gpZ/bwX+y5vJBASVXud1pTq0sfkduW6An6lbvb?= =?us-ascii?Q?unQwuxKfYJlVYe8dCrT/GsJ6qCqVl8O3jD0VeN10?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8422bf32-b37a-469f-a9c8-08dbcff33f0e X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:59:45.7748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kWzls0pEUG79HlpujAQZOcIngpvLo87aUC/rGV6GBkaE0M3rw7AayWruHUax48t8QbUXZlW7yIsPnprbuLCINw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7694 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The ibi work thread operates asynchronously with other transfers, such as svc_i3c_master_priv_xfers(). Introduce mutex protection to ensure the completion of the entire i3c/i2c transaction. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Notes: Change from v1 to v2 - update commit message - Add Reviewed-by: Miquel Raynal drivers/i3c/master/svc-i3c-master.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index d29de5fe533e6..8cd708c965085 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -174,6 +174,7 @@ struct svc_i3c_regs_save { * @ibi.slots: Available IBI slots * @ibi.tbq_slot: To be queued IBI slot * @ibi.lock: IBI lock + * @lock: Transfer lock, protect between IBI work thread and callbacks fro= m master */ struct svc_i3c_master { struct i3c_master_controller base; @@ -202,6 +203,7 @@ struct svc_i3c_master { /* Prevent races within IBI handlers */ spinlock_t lock; } ibi; + struct mutex lock; }; =20 /** @@ -383,6 +385,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) u32 status, val; int ret; =20 + mutex_lock(&master->lock); /* Acknowledge the incoming interrupt with the AUTOIBI mechanism */ writel(SVC_I3C_MCTRL_REQUEST_AUTO_IBI | SVC_I3C_MCTRL_IBIRESP_AUTO, @@ -459,6 +462,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) =20 reenable_ibis: svc_i3c_master_enable_interrupts(master, SVC_I3C_MINT_SLVSTART); + mutex_unlock(&master->lock); } =20 static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id) @@ -1203,9 +1207,11 @@ static int svc_i3c_master_send_bdcast_ccc_cmd(struct= svc_i3c_master *master, cmd->read_len =3D 0; cmd->continued =3D false; =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 ret =3D xfer->ret; kfree(buf); @@ -1249,9 +1255,11 @@ static int svc_i3c_master_send_direct_ccc_cmd(struct= svc_i3c_master *master, cmd->read_len =3D read_len; cmd->continued =3D false; =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 if (cmd->read_len !=3D xfer_len) ccc->dests[0].payload.len =3D cmd->read_len; @@ -1308,9 +1316,11 @@ static int svc_i3c_master_priv_xfers(struct i3c_dev_= desc *dev, cmd->continued =3D (i + 1) < nxfers; } =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 ret =3D xfer->ret; svc_i3c_master_free_xfer(xfer); @@ -1346,9 +1356,11 @@ static int svc_i3c_master_i2c_xfers(struct i2c_dev_d= esc *dev, cmd->continued =3D (i + 1 < nxfers); } =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 ret =3D xfer->ret; svc_i3c_master_free_xfer(xfer); @@ -1539,6 +1551,8 @@ static int svc_i3c_master_probe(struct platform_devic= e *pdev) =20 INIT_WORK(&master->hj_work, svc_i3c_master_hj_work); INIT_WORK(&master->ibi_work, svc_i3c_master_ibi_work); + mutex_init(&master->lock); + ret =3D devm_request_irq(dev, master->irq, svc_i3c_master_irq_handler, IRQF_NO_SUSPEND, "svc-i3c-irq", master); if (ret) --=20 2.34.1 From nobody Thu Dec 18 15:31:47 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60AA8CDB483 for ; Wed, 18 Oct 2023 16:00:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232220AbjJRQAC (ORCPT ); Wed, 18 Oct 2023 12:00:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232187AbjJRP76 (ORCPT ); Wed, 18 Oct 2023 11:59:58 -0400 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2075.outbound.protection.outlook.com [40.107.13.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D827A11C for ; Wed, 18 Oct 2023 08:59:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jfaWnrYpE1jAknfEuW+BVJomXqFkgPRpuH3J2xbdsIHFxoGE/rzSLPrXy8LmE1WF/Nkp0NhjX+iFgsSiqgxSwEl4zkXPU4QYlGJTLJxFk+VOrQ8lQd2Tmqef5sU1sBqhq7Ya5QtUeorgr/Gl9SwQZ56SAPiWLqVVVkS4EDSX4B3pestrYx0eYGOvvnFJUSSwGrGupapT3UDtPml3Lqb7k+oArsS21V7VlKehxW/4fUzb3h6Dr3VnqTfsLkZGTVBnfdVBpqOTv4Z5m9rbiKwp6oEZNjUQpcUzStogIwXAgmjsShUZsuG17K7iKOwM2BkfhB2ZQRhJ8XK41WqAvvk1fA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nayoLnZA6AxlXnKCCet/C/KGKXlH5vBlf4Xff954ehM=; b=Cs6A+f+UA2MHIjh7xAS+eKueKVu4GRgxDqtIwRuftQ3y1KkWx0e75QSdSrNqOPYLevH/9w3UGr67zj6EyEjmg3o3cVCma+M9dvtetbQPpjmsBnZCHoqg3nMJXVr54o3oksLi9a0OV6wlGxjfy2PQ3cWg4jnYYsaUnE2C2r/ox/NQUDztLO5ME6/ztL0tJDzFmbZTdqzQJvPQOFVEm9kGGzpKSb4hxfLUVYGdk7jCOxH5zmOncvYg4hTdrtuizB/OmOGga7Qz0jCIfpett0PK09CdcJr0TZdmNBKXDp+vlT+43Z1wjjDfPnIVW9Ir8ULvcXpv2Pk+U4M/jaUjsHx8qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nayoLnZA6AxlXnKCCet/C/KGKXlH5vBlf4Xff954ehM=; b=fGsyOL39waLA/RWuJbGv8x+k6tiNcRqmdvI9gY3nxfUtRD9D4HcuT4XSWqyEvqatBdMsfryPMAzk1MuIhVU1g3PkJeRFZ0JyiGJR60pk/ht+qo6A5tM5y7JC/LdqRf6NylCrBvvO0goO0DnrqR7507nOa0lY8ayi/rdVx1HSk+E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by PA4PR04MB7694.eurprd04.prod.outlook.com (2603:10a6:102:e7::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Wed, 18 Oct 2023 15:59:48 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 15:59:48 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.Li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 Resent 2/6] i3c: master: svc: fix wrong data return when IBI happen during start frame Date: Wed, 18 Oct 2023 11:59:22 -0400 Message-Id: <20231018155926.3305476-3-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231018155926.3305476-1-Frank.Li@nxp.com> References: <20231018155926.3305476-1-Frank.Li@nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0210.namprd05.prod.outlook.com (2603:10b6:a03:330::35) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|PA4PR04MB7694:EE_ X-MS-Office365-Filtering-Correlation-Id: b3668cf9-f417-4413-0618-08dbcff34133 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zU8c6VPiSrcWJUHv36UOlWkRAmNu97Wq+uEKfWVjc7WOjokflQ5N6N8479ayadzuPw7/Az5xmWR4jd6LoYNGEQM8yEnoP7ZomDxKpCn3d/zxyx0CEpetz6+INS1pr8ykGDwhxIJ0GBJ7zMUdH+agXXoH2aQVMRumvWOlRZHPk/8dgnKkAcqXhsdqqg0w7SDJ680PHv4ZbiNIerxjKY14K95EWJzRTeQJK7FqY1B6wowv18PiKgSMvq/nGnKz6f7IwsL9wP0uMRvONYR80MBXYGVgO17MRDtFGiqZVj/R7zsWNJsBtqU2OoNbNwdrUGecBtyZwNtRCUcN1dQW2K4gHgl25+NwKwPiK36RWUyU8A+PhHT+hqjKWF39yhDN26xBBl3V2uxHqIyA2lmQBRV06Vawg6qXhBJdNsBnQvKoFA46Wlax2MwXV8M2OwJvr9WFyLEIu+NBpzv6UA9G19MrS0xyd1rXGvzEMrRf6tGaAHCOd1VECPULzWFC3nNicc3Guwjb++2dP8FgekNz/qhuzZE6lOtY4Aoxoh1BRDCQX18OqS4/Ka+lE1Wil3SRfdyAIEc3yiC215XFIWJJe+KJb0N+mTQ18zPTbss6T6s4mZNJZk5CPVXoCXKbNkYkz+/H X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(136003)(366004)(346002)(396003)(39860400002)(230922051799003)(1800799009)(64100799003)(451199024)(186009)(66556008)(66476007)(66946007)(6916009)(316002)(6486002)(478600001)(6666004)(2906002)(38350700005)(36756003)(86362001)(5660300002)(8676002)(8936002)(4326008)(41300700001)(26005)(1076003)(2616005)(83380400001)(38100700002)(6512007)(52116002)(6506007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VDdYUDFlMmwxb21DK25wU3RQMklDMTl6S0tib29la1BmYVRkL25lK09TWjh3?= =?utf-8?B?cWxvaU1WZ2M4NUZKUVp4THJHdlZHQVBwR3RIWHNJQXBjU2xIdUdXL2xMWjdt?= =?utf-8?B?L1hLMDI1c1NuTVRzU2NTSkllbEdzb2ZyMzRRSnp4UjM0bnVtbTBDUUhkVlNG?= =?utf-8?B?VDQvQnFZaGVMQllTTERZcmxVNmY3UTJtYWV2VmdqTnlsdUNPS3VjRTA5cGo4?= =?utf-8?B?VXVLT29aMk9zbHFvVEMrcEhKN0NVUHFlSG9aRlhoYlY3WXFST3JvSlYyYS91?= =?utf-8?B?ZlVYcXQrQWt0eEkyRjg4Q1FFUkZkUElKaVVSV1dhcjlHT1E2YkFIeEI5dUlE?= =?utf-8?B?U0ttdktyWWwyWFJGQzRVY1NCS2ppMVZNZUkzSzhkU3RKKzJTUnp2UmxvSkVS?= =?utf-8?B?NGVtZ2YrcU95VkVDRUNKYm83c1F4c21uY0loK2hHTlcxYVBvTDh5NjNRSGZL?= =?utf-8?B?MzZ4UWZ3RUkwN1FzVlMyTnBianEyVFJUWFJEc2lSaENZdUFiYlpEdnZ4bGNp?= =?utf-8?B?VG85bEVsa04rTHFueExsNnhHV2dSYThCMzNKS3BBZ25PNGdEOXdqVUtNVktp?= =?utf-8?B?dFVCTnBTVlRpUlIxWEpVZk4vUTZCNHUyUjN3ZGNVZk9HSnAreGxWMm14VGgv?= =?utf-8?B?MS8wajV1Z2R1V3hKN0JzRDJORXptSkk3ZjYzN2ZRSC9jVG9lRXlqdWFnNDBD?= =?utf-8?B?anBDRkE3RWRTUUxKN3k2MDI1Z1JEZnlPN3IvUE9wbFZNbkE0N016dGFXN2pu?= =?utf-8?B?VHBLajdSVkJEcDNOa0IwNTNJdmlMWTVjWUFZcmsyUFBJVnRodlArWkxLSERj?= =?utf-8?B?cnpkTWR5MkZ3UW9WMlZpanBqQnFMamY4Qys0dkhaU01Bb1hKOHdUUGtLYTBK?= =?utf-8?B?TGhmT1Z6R1pYc3kzWllpQzhCSXRrdUI0NUpVVHNUNGdvYUJpZzM5eU9QY3o5?= =?utf-8?B?dFRIN0xMU1E5cUE3QjY0elVZbGVaYTE2bGt3aFozZUk4aDY0Nm15TXVvU0h4?= =?utf-8?B?Z212TFF6bUxYMW1JZGdWN1dwVWdpcDd5NXJob2lxWGlZZVZSWEpwTGxoeTI5?= =?utf-8?B?TEx4N1IvT2V0RHpVc0ViMXJCd1hXWjdMQWRwbTJpOGdHcy9tcndST3g4Z3hp?= =?utf-8?B?NHFJOVpTV2Y4ZTZDQWN6UlZmb2twSnFFS05KMVJyWVgya0ZxcDRDRXp1UlR2?= =?utf-8?B?S3Q1Z3NvdHFvUjdrWEM4d2NXUXJqRC9QRUNGaXFKeHUyYkRBQnVIMjU1WGpR?= =?utf-8?B?ckpMeWdkNXJkMmh4amdDb3Q3b0lpV2sxRHdGaE1zMlRNdEpwUHYvQlI3TDZi?= =?utf-8?B?QWljQkpxSGxQMGdjY0I2cUtrTEtXeUZQUmE1bStnRzJTZzdsNFJzTWlmamt5?= =?utf-8?B?VitZNGJlR3MyL3JLckgycmdKMmxHODdXb2JtNXRXb0pVOUFtdk5BYWZLMFNH?= =?utf-8?B?cEU1bVBPRCsyQnJKYmxmWUQ5bjg1dUhDT0NsM0RmeTJHMXV6U3QxejB5cWhv?= =?utf-8?B?ZTd2WE5lOG90R3hrZ2c1K3FXUzY5V3FwQ3ROVmtGZFhTbGNjakNtU0duWWpQ?= =?utf-8?B?bFZhOGcrcFdnZ0RXbExVdlpRbFZUL3ZwQm5Hd1l6UWtGRFV3QnhvZUpMUHJj?= =?utf-8?B?UE40bDViNHFYM3VCOFVBdGZZVXRrOCt4K2tncFNFM0RFRU94a25GVXVENnJh?= =?utf-8?B?NkFaZFFsWFJveGIzenNJcjRqeVNFbHJCMmM0WkhPSUtOb2tFOGxOR1JTUTNh?= =?utf-8?B?ZlZzd0ZkTVJIWlU3dzcrd2xLSEF0emZqK0FlNlg0bG9NVHVTRHRndGRMOXJk?= =?utf-8?B?aUlnSGFtRW9iOU5QN09GcE1pVmdpZlJNVkNLWERVUWswRWIvemxGK2ZwNDg5?= =?utf-8?B?ZTFVRFV6VHJuZi92czFLZTQxNEMyTEFRTFo3dTVEVFdBTHM2cWV2S1VSM0hp?= =?utf-8?B?U2ZLV1VPRWplVVVKM0VzUFpQRlZYTXA3M0NkSjJFcllBRFZNTDdUaDRoRjlE?= =?utf-8?B?QzJ3aWJpWDBTR08vQkUxc0IrOGVTZGFodWljQzZZOTdSN0RNaWNDSGdGd2Ja?= =?utf-8?B?aW9MeGF6azlUS1lyd3dTWkhKMTdISGZKTEtRLzRHODhXNGJ5YjFwaUdWbUtP?= =?utf-8?Q?QgzfW1/VOEPaNgb8FzLp548+1?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3668cf9-f417-4413-0618-08dbcff34133 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:59:48.2273 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QRsBa7JWfzK+YweX5EuEKX7chQbGcC9JZ5hku/S09EdEHmxrHjmRdQRqP6HzUZzLUXaUrmhI+Hx+VEVuYgCBjQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7694 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 = =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 = =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2=94=90= =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2=94= =90 =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2= =94=90 =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80 SCL: =E2=94=98 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94=80=E2=94= =80=E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94=80=E2= =94=80=E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94=80= =E2=94=80=E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94= =80=E2=94=80=E2=94=98 =E2=94=80=E2=94=80=E2=94=80=E2=94=90 =E2=94=8C= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 =E2=94=8C=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 =E2=94=8C=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=90 SDA: =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=98 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =98 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=98 = =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80 xxx=E2=95=B1 =E2=95=B2=E2=95=B1 = =E2=95=B2=E2=95=B1 =E2=95=B2=E2=95=B1 =E2=95=B2=E2=95=B1 =E2= =95=B2 : xxx=E2=95=B2IBI =E2=95=B1=E2=95=B2 Addr(0x0a) = =E2=95=B1=E2=95=B2 RW =E2=95=B1=E2=95=B2NACK=E2=95=B1=E2=95=B2 S =E2= =95=B1 If an In-Band Interrupt (IBI) occurs and IBI work thread is not immediately scheduled, When svc_i3c_master_priv_xfers() initiates the I3C transfer and attempts to send address 0x7e, the target interprets it as an IBI handler and returns the target address 0x0a. However, svc_i3c_master_priv_xfers() does not handle this case and proceeds with other transfers, resulting in incorrect data being returned. Add IBIWON check in svc_i3c_master_xfer(). In case this situation occurs, return a failure to the driver. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Notes: Change from v1 to v2 - update commit message - fix typo yeild and falure drivers/i3c/master/svc-i3c-master.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 8cd708c965085..abebef666b2bb 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1010,6 +1010,9 @@ static int svc_i3c_master_xfer(struct svc_i3c_master = *master, u32 reg; int ret; =20 + /* clean SVC_I3C_MINT_IBIWON w1c bits */ + writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS); + writel(SVC_I3C_MCTRL_REQUEST_START_ADDR | xfer_type | SVC_I3C_MCTRL_IBIRESP_NACK | @@ -1028,6 +1031,23 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, goto emit_stop; } =20 + /* + * According to I3C spec ver 1.1.1, 5.1.2.2.3 Consequence of Controller S= tarting a Frame + * with I3C Target Address. + * + * The I3C Controller normally should start a Frame, the Address may be a= rbitrated, and so + * the Controller shall monitor to see whether an In-Band Interrupt reque= st, a Controller + * Role Request (i.e., Secondary Controller requests to become the Active= Controller), or + * a Hot-Join Request has been made. + * + * If missed IBIWON check, the wrong data will be return. When IBIWON hap= pen, return failure + * and yield the above events handler. + */ + if (SVC_I3C_MSTATUS_IBIWON(reg)) { + ret =3D -ENXIO; + goto emit_stop; + } + if (rnw) ret =3D svc_i3c_master_read(master, in, xfer_len); else --=20 2.34.1 From nobody Thu Dec 18 15:31:47 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC71ACDB47E for ; Wed, 18 Oct 2023 16:00:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344783AbjJRQAJ (ORCPT ); Wed, 18 Oct 2023 12:00:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232262AbjJRP76 (ORCPT ); Wed, 18 Oct 2023 11:59:58 -0400 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2047.outbound.protection.outlook.com [40.107.13.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E8D4118 for ; Wed, 18 Oct 2023 08:59:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=elL22lKNDIcIEXF6ZPCFLsjYDCLaxpQNppVx2N6a3RBIVF4UeZvhD3ItFYJCvbRw3vgTMhqP0Q6/802otNoYL4ADaAm4ByYxBuihc3HtGvDmqZ/5DILLeYItNsQKcquGMgKV2QTVg5WoNVxGzpXYcdhhNNyvGrM9r9kt1NaEp3tKihmINBlg9qTStR9QeWFBrQwSp5+rZvry467k5WJdjBKm+xpsbUthXZcu5xVuDmGeqDM7ZlW4mQBmZz+YG9of1VAvx+mEqVcPRgtrhEOzBCvdThrE2Pie/B2VJ8wLoQorRY6PkQzO3ZZOaLZB0caSpPRvTVrxKRno+HqrVqs2WQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rmA0TmfYW8MJ+DqQikfItM+khhjIvm5K1uwmiII6AZE=; b=cz4PARiIIuRDwocngOey09ITBe8xNFBjCZjJBFJ6RDFSGo7D1/kas/gXvZLqceIfmqxJ2dZOPikStNIGKEgkNJcDCsIFoKmJKOJZ61xJJzhEqQ61mD8AeTA6qdt495Yk8JokayY+kQImhyyxTR5/wJy5ty88yBdjeYFW9CaPFLN4a/GLpsez/vIj6oaT4tmVpVbc4fSmeGFuCLQ6IciqoOunfH0bD56gUZiIWVXKYleyZSJxyXllLYB2sgBGc0lWsAo150NID/oY2ZPPzpZm96h344mI7WjMyyroOsOvDlZGXRPHl6edr1gbSBoSHX8flUtvGq+euUWvzCIZxDlqYg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rmA0TmfYW8MJ+DqQikfItM+khhjIvm5K1uwmiII6AZE=; b=bvxSrmUR7J5kYXMhtxyUEPTrZATUG92yijCVso3eeqlY30MErIQHwIzI3/3q2BK58d5A/oUpVCOBcu9qi+VWivL1AyeALYVYgVlwP60MUNeFYgFwSY0yj04GiE1mp2azEYCTkcWkh8RXAfk/di3hcX0aO660khydfgLgLOn7aaA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AM7PR04MB6966.eurprd04.prod.outlook.com (2603:10a6:20b:109::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Wed, 18 Oct 2023 15:59:51 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 15:59:50 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.Li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 Resent 3/6] i3c: master: svc: fix ibi may not return mandatory data byte Date: Wed, 18 Oct 2023 11:59:23 -0400 Message-Id: <20231018155926.3305476-4-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231018155926.3305476-1-Frank.Li@nxp.com> References: <20231018155926.3305476-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0210.namprd05.prod.outlook.com (2603:10b6:a03:330::35) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AM7PR04MB6966:EE_ X-MS-Office365-Filtering-Correlation-Id: eb1691c1-0dc5-4a3e-90dd-08dbcff342c3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Om+SKY4e6UluvIO+BjGqxmdqbMDjCT7jVI4jE/w8d2/MmG8xQkZdlqNoap34MJ+8Fwaa9WEISjOGJPkrodzeU6ahV7oQXCYS3bN14f4E5Wa61t44b2/ll4VwNs7ZxwXmRDihQVoTlzuobdAXicxSteJDnuD5C2GItFkDq8eEEHnbhA89Sfr5GhnQYnsz05+eJoDrGyjhZHDN8Mf1bv42ea31T82RB8jcqx3E23Rnssc50rMpzlkuaKvvsAPDVUpAdGDKjFy55f19WDJuLlRzfJteygZHDLRgKKfey08owIgg3T+Pf4u6GUkQjGHsyk0TqyEVLUXn30narP9HMwkK4lKGOP8yIRyCarEuuah7b10ftrBCj0cRo7czA7fzjTVAfWlRT0o7PVuMsx5scVeCY9ibQ+Sg8in/+uBG1isD3bZggYBDCQwotaSyg/h+gaPJ/lHrmwclTGgPJtON5MRilSjRcqaqmk+et28ETzl1KEpGkBoyid0SVbpq+ddbxG0kOkDmmWzZyWFqczogrEgvE2GTnMkgHXYg9G0TItXLC0AecVjzdC9+UN4tiW78C3bRWc+8zHIUHxg5iwvcgp95mCARSqWsKPZaqzu1b8aLruo505mnU/7xtYIUK651/hic X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(39860400002)(346002)(376002)(396003)(136003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(2906002)(478600001)(6486002)(6666004)(38100700002)(8936002)(5660300002)(8676002)(66556008)(4326008)(66946007)(316002)(36756003)(66476007)(6916009)(86362001)(41300700001)(6512007)(52116002)(1076003)(6506007)(2616005)(26005)(38350700005)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?z7xoQ2JldThzWaJKO6+pf7KdqgVsTvKDkjbj+pQjNDgxKvFtbpxHOnoVF0Kc?= =?us-ascii?Q?sgzlIix/hEW7ScyUtdpd2nArTDTU+tMT6NcYXdYSj4DCer1igSwt/ZXpcEl8?= =?us-ascii?Q?vq/SQYC56fXQJM5VhxQvf1WU2sNa6fzmYJZ/hHjgsK684KSl0b8gMwCYmdLM?= =?us-ascii?Q?2JMmMgxLbRD+dmW7zadu77toFC9IzxyYmOBrOYBrEjKxS6viSmvXLpzHE+4a?= =?us-ascii?Q?Zjdhpii6wi+Ttq1vk0SJu/NxmRnRc0836wH1gklr1hPTffuneaUy4x9Hrgbq?= =?us-ascii?Q?WJ3KRqIQKJ/ufXLeP1erd4gM1ICseduc/IEd0LwnTaZFtJYB8SJhLinbXxv7?= =?us-ascii?Q?i9WjEXaQWvdpAjlJ5yiwEyE0D6sSEdezqReVM7XCKznMU9QrUHG1lGkhG8ed?= =?us-ascii?Q?fpLFKq5eeoEj+Q0I48IAi6ZAQ+9Fi2aegZrjcuDN4onA5P6HZbL5yhHAyaSy?= =?us-ascii?Q?5tx/yUr/VaJdB4DB3AjAetFE9n9huFm03TtGbA8QEMnTKezbmVR28ulIhtIB?= =?us-ascii?Q?f+RlQZqCxvP0QwylV/GrsEAWeg36WmdP4BcpfamnwdKmG5ywxqCkbWQRSEjS?= =?us-ascii?Q?tDEO2C7A+L90o8mIIdHTg1Aiw1AdLEAi+aLEAGxmrmaTbDpjclEyfOjK/S+t?= =?us-ascii?Q?9HKGoiafJkovHRrNjpql0CpgekNs6kM8kvdfUyvDEZCbrBiqhXZkeL3EWXgp?= =?us-ascii?Q?5TzTaUfJhNLUQJEVflHr6QuYjmfNeBL5A5zgD6a5qPYoJCgSYjx8QyooIoIC?= =?us-ascii?Q?XjqNmw1nIAlO51dm8bC+S7Xj9yQNTjKOvqf+2hsnlCcLkvAeOrPBqc+yJoOf?= =?us-ascii?Q?kVezOrD2RDLcIQMLtVQQevp0MiEsPK2W09hrhzmu7Xux/H7nOoCLv8U3DdYh?= =?us-ascii?Q?inDQyxVu84AppI2u7lEA/LlF/P/2+9BOV6HwHT0h+eVBZbJVUro0k7LCekTn?= =?us-ascii?Q?1x5FflI/TLQMw73mevXeXkZ9RnfXGt0tcViD189GdfI70j7SNZ26I3Ynx+79?= =?us-ascii?Q?m/k2EYVqwGXPSOSjKY5dXQ3wispxb1DuzcMUHfct7CZdSJ4vBDFvogs0Aee4?= =?us-ascii?Q?Ku1qKNO3igZBmS/XeYxrwmGSS0IL4Jl98AsXjJRch5SZ3MBkgFQowvMkxqkK?= =?us-ascii?Q?CsDOoakPtIw7KQ0MH2BT5hpldUn3/GBZXM84RAKEgsz709iHRzXI5FFecYiY?= =?us-ascii?Q?PCX479xMwiBGL8N7sOYp3Z90aWgWE3O8I3WUnEKS5nriaLIdrf6gKCyYzCNP?= =?us-ascii?Q?BtFRlZI5cxcEucS8DrDOTv575Hw3VqAsuPfIXfXOheX2RUznX1DNg9WfBsDG?= =?us-ascii?Q?fID1YECPuNfTpslju91sx7vNARMeGBlMAzjk611n1QpjrgUqHZBNidPPAvEv?= =?us-ascii?Q?m9L4SGueBK1iyrurEtdqYMl28IJZGkW9ijG3kggGZYpu0yGxhIaM30ESpk81?= =?us-ascii?Q?0325UVhrCgVio08o1FgecZNGoskMgQ56KpKabADV4MbjuULLjGZyQkLOFJC6?= =?us-ascii?Q?hPhCffXIPBCGZ9gbrL3ZRCoyd01Kx9DIySPWXV5zk7OCZtbWmeIINKxSqbMU?= =?us-ascii?Q?JiRBFGQypgeqGkYFekPMvfHWqGA2wm1LUmbbz87E?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: eb1691c1-0dc5-4a3e-90dd-08dbcff342c3 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:59:50.8903 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3W1EFH5QHzMVrocEcrtO3pulaVILJ0eWgdP/2M8bMLUw6gl+DbyKW+1fUHKcx/K4/6rD9BhjYHCrRT1UpMwj1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6966 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" MSTATUS[RXPEND] is only updated after the data transfer cycle started. This creates an issue when the I3C clock is slow, and the CPU is running fast enough that MSTATUS[RXPEND] may not be updated when the code reach checking point. As a result, mandatory data are being missed. Add a wait for MSTATUS[COMPLETE] to ensure that all mandatory data is already in FIFO. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li --- Notes: Change from v1 to v2 - update commit message it also works without mandatory bytes drivers/i3c/master/svc-i3c-master.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index abebef666b2bb..dd06b7c9333f1 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -332,6 +332,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_mas= ter *master, struct i3c_ibi_slot *slot; unsigned int count; u32 mdatactrl; + int ret, val; u8 *buf; =20 slot =3D i3c_generic_ibi_get_free_slot(data->ibi_pool); @@ -341,6 +342,13 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_ma= ster *master, slot->len =3D 0; buf =3D slot->data; =20 + ret =3D readl_relaxed_poll_timeout(master->regs + SVC_I3C_MSTATUS, val, + SVC_I3C_MSTATUS_COMPLETE(val), 0, 1000); + if (ret) { + dev_err(master->dev, "Timeout when polling for COMPLETE\n"); + return ret; + } + while (SVC_I3C_MSTATUS_RXPEND(readl(master->regs + SVC_I3C_MSTATUS)) && slot->len < SVC_I3C_FIFO_SIZE) { mdatactrl =3D readl(master->regs + SVC_I3C_MDATACTRL); --=20 2.34.1 From nobody Thu Dec 18 15:31:47 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 107DDCDB482 for ; Wed, 18 Oct 2023 16:00:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344794AbjJRQAF (ORCPT ); Wed, 18 Oct 2023 12:00:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232335AbjJRQAA (ORCPT ); Wed, 18 Oct 2023 12:00:00 -0400 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2047.outbound.protection.outlook.com [40.107.13.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2427511F for ; Wed, 18 Oct 2023 08:59:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MduOfhjH/LdwUtG06Ew2098PgJ41MQQqrwjzuPOmaMZ+kdfrCdAo5mkdBECZ7KY7cyTnL8sussEv294xYC35MXlJoQlmof8tnn0N7a2FbhdzVVbKnfA/Z2YG5SYMkl74zAxlG4GdqQoyiVRpJx3zJHDHODWAPn7f7n0+5Zs+laiflvXFmesFp/kgGa9YW3SCez6ro1U/CqBo4M87ELzR4If62Ig7Vyx7NJ+e+gxjMw945t6VaFUkkAiwpJrMuoz9UcqIpDT2p7YEo8uxx00+amz7uIuYhLAIR9sUmfHWAna2cfmN+OM2gUMJQO3+5sleqa0/YaKeKsIPXPyiARmS+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ghMi/AjqmeuflsZPjowu1AoqUyQlM4/JO+IAd05K8m8=; b=IqOEH9CJS+j9dxZgR2yEbWh+JmUh/sLcmKqYDT1JcInjEj1q1OpVah+1MS5UlNqst2JKpLe+NaAJSGEGY4YxkjEBEsjhlP6QYLMvLmmJTmn66WBKKrSH/65++LyaFneKf36pBNftWNLolvw0UKmclVJENRLruGPU18sJN/yDNlI5NRXSPx0w7c4Lb/SuLqTX0gQ7Iz4gJFRGv0EVxKDR5VmVQ+Ja5fkz/68AJi6H3nAbhneS3uOA5oNpspcBNo3T+IVuACxGXis6xHp9HoIg9JiudVmsyYI/aHWHzDtaIdC4g9GQqJqCINTFl03FhtQ2Yf06tGuGmin00kBSvSy68A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ghMi/AjqmeuflsZPjowu1AoqUyQlM4/JO+IAd05K8m8=; b=lGEcrEycImBcT70mVsCuAnZY21OYSVIRJDOB7ZuJ0h3aiJ7OhrKCnbpR3uK8N8/IE/IrAC5nhfzjtUvCGegecrC/uaZi2t8mXE4rbYwT6Bz+QyhfDGYHquIcicAB8lYZ1nv+8oM5pEZGXLrmUAOEB01edQxL7bJOV8fnlTQf1DY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AM7PR04MB6966.eurprd04.prod.outlook.com (2603:10a6:20b:109::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Wed, 18 Oct 2023 15:59:54 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 15:59:54 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.Li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 Resent 4/6] i3c: master: svc: fix check wrong status register in irq handler Date: Wed, 18 Oct 2023 11:59:24 -0400 Message-Id: <20231018155926.3305476-5-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231018155926.3305476-1-Frank.Li@nxp.com> References: <20231018155926.3305476-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0210.namprd05.prod.outlook.com (2603:10b6:a03:330::35) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AM7PR04MB6966:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e072b63-f091-45d3-ba7f-08dbcff34432 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o4fWw9ZM8N/m5xDM33uJ4HdiK1ld3pQPedGUKi85zJ7BYmqeKNBHHm3k3uncepvDYDO1wxa+PDeIvF9WgX/GG9grnqHKs7d5lgUeSwFXaVKI+o+epSOt+8MtfzQw2za0T/6WyO9dYtxIe7D+zCEGdCcUa9lMEwSYowBoM9Ciz4EiGDFIMYo8XETPKBkr+DvX0cvmriEDGtwIXBo94yPEdhauW3RKMeFd6yoBY/ZieUYvOR+qg9JebAVKQ0k0phl3LDlbqp+VG6ZiGur0MgUWze6c37H5iCpb2+rl5dgX40HUe/Vh3/Kp2lHf0n7iZP4XlVnOtTxk4CVkKWxFP/n8xcDMlK+X8DrQnPwqAjOtJJLlrs+gacZOytas2CB4im5CoR1V6+IQHdj1Lm2ZhDRs5iHlpe/LUTcEpQMJWeL2/TGKE4Q3qXeSPudiA5wiXFF81XOpw5gwQ3/aAK9Xsnl7b+brW1Jw5EdIN1cNoNMbbruwrinynuWX3q55flh7p8/UfXKSz2q+FyrXf+6PMOjEntJ8nLg4jXrfa0Eh6xXygVRbdCO0qbBal7zguc6xNFxeaTIN7FFNgTP1MLcwBKTjuHL+w1RNVcUOBy4NQavVp2DFrgZhkJ7N7WU6KakYi1E7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(39860400002)(346002)(376002)(396003)(136003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(2906002)(478600001)(6486002)(6666004)(38100700002)(8936002)(5660300002)(8676002)(66556008)(4326008)(66946007)(316002)(36756003)(66476007)(6916009)(86362001)(41300700001)(6512007)(52116002)(1076003)(6506007)(2616005)(26005)(38350700005)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?h90RWPYZsEHs1ff8kqjfxPnbhINnOxCeSY332nStR/VX5ag39/snqoQidqGQ?= =?us-ascii?Q?fFQIoJu66AxPZnlc7kTOL4jNfcd9iWiWUe9vVQusFbKJBCBmvc7r5f6Y3cVF?= =?us-ascii?Q?PXO/R86DAQVpsxnNS+Ti+c1g1hCyBFmWYZN9LLzXUd+hVDMTpb4wg0y9D6c7?= =?us-ascii?Q?0EJRvx/4B7QEg0IbOcRlk11lmJTsAfZp1K9dgaNMGmgBOWEnpa/fi3O3Xm/7?= =?us-ascii?Q?BExA+wPTq0XQdalEi+bM7ysipCgvUkgWulMzxr9Ll1U7vlPi0/sEtRfdzD8p?= =?us-ascii?Q?wrnEDP8htgArNkTYOmZ4tbFhrcw0AOHsdeqxEtnUQ3QbCiaKQETj/iAJZ1Yi?= =?us-ascii?Q?rBhU6b/ZWzHicsUEEzEDFKOEmagUWI9RBySckoOO2hcp3XVpXHhSVqi3Mn2F?= =?us-ascii?Q?O/evGqHe/uZR93VcBwr2YSqyoNTiNnxJdZGRT80hjPzBPlI7h/0meuu6W4rz?= =?us-ascii?Q?V1s3jJTCXElchxIf9/Tr66sgT8SGLRb9rGlAHsWnEX9MpJhkEgU/gGtHWG5O?= =?us-ascii?Q?4afXS5hs1TeDZtetaeA567np2rJlY7QPy81BRJoaM1/WYvh9HA/Pka7TAg3+?= =?us-ascii?Q?UuxTDg1zB2vptUpDRxH4ekITX9GljvylEwL+N369NH+PcvRjgZ4Mn3seSuCW?= =?us-ascii?Q?fzrUjmJlmHsT0KgX/D4Hk7stkgB3r6gMZhfO49vY35dM0kw1naIYex5COj4M?= =?us-ascii?Q?VO25zG0kBvq5gBmoD4v8iqd0DXyNcDSbUmXfaVv1HVzh26OvOpUdBcGVeZcS?= =?us-ascii?Q?xAbC4gpYBd9O61YMk8P0RC9kI4+QylTPFDJ9KOKr5BjIRwc5xZS5R3Irhew6?= =?us-ascii?Q?ExIlfzbcGH5XuYj8VCAr7kjvhxunNkCCVLwVq7ipO+DqirkUYgkmY/MGTtPE?= =?us-ascii?Q?9ghsHNQS60htu7dj04nATx60QKff7MO4pYtp08NBRNYO1gc9Jh/RFZeleB4S?= =?us-ascii?Q?jaH885NgX5/Lf9xURk1PcZJJS7FWCYsSAGyjVJpQ5C/n6CcXjYYVgc5JCJzd?= =?us-ascii?Q?JAHgh8CiCzRgvI/6knK7VshuFSYivJv3kmzMQbcTDfq9frkCRw2Io3SNffbL?= =?us-ascii?Q?eAsHIbOn/fVmpHgTs/DkH3QhmR5mHaSc9bbATvzadIAVl+fo8cctUGD93ERC?= =?us-ascii?Q?Kg+CK2N0F30Irgrj3L6JqfWnH4zPW8MwsZLtzPYAn4URhJOT+cLDBhycaJGi?= =?us-ascii?Q?uL8mliC63o5es/MD4V7y5YvH4X3vt935nDoRz5HNDJr0kcKJjkfeD//bo0V+?= =?us-ascii?Q?77KIyggQ7uzseEEvVGsC9wiqoHfRZH1NjC6mRkoZqX3SqU77iM9/SxMus0zv?= =?us-ascii?Q?i3B2+dbYMGBga+1PQuDU5R7gHaGqLRD10N5ixb71+vUhvA1SqGmUqokCOhlB?= =?us-ascii?Q?8LZwQLpAeVOaTS5nT9wtD6NSnNTtdsDCLJ9Hes/ck2z3Kge3GtPY4M7RjFuc?= =?us-ascii?Q?ZVQEBTVIXDFynsqv8HO5VviDzgx0gHEVQeGtOPuDEJ4LphG3PtISW43/7Nxe?= =?us-ascii?Q?0qgItvDh27N786+2F7LXUdTnAq3E2wAOxP7Y0lRq5AAG4IMPnxsLJjQTYvzt?= =?us-ascii?Q?6W00SFhUlRFw8O5xC34HpCGQ8degTr4nKXLGPbbm?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3e072b63-f091-45d3-ba7f-08dbcff34432 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:59:53.4539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: duZdMaKarVguVUIRRqL/0gLXw2QgJ+bKMv4PdDEGBcDAaZZbZctCzUTZ9QG7jSWK/DUfqaV3aileL7rRYj++VA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6966 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" svc_i3c_master_irq_handler() wrong check register SVC_I3C_MINTMASKED. It should be SVC_I3C_MSTATUS. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Notes: Change from v1 to v2 - Add Reviewed-by: Miquel Raynal drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index dd06b7c9333f1..b113460f059c3 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -476,7 +476,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id) { struct svc_i3c_master *master =3D (struct svc_i3c_master *)dev_id; - u32 active =3D readl(master->regs + SVC_I3C_MINTMASKED); + u32 active =3D readl(master->regs + SVC_I3C_MSTATUS); =20 if (!SVC_I3C_MSTATUS_SLVSTART(active)) return IRQ_NONE; --=20 2.34.1 From nobody Thu Dec 18 15:31:47 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7BAFCDB47E for ; Wed, 18 Oct 2023 16:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344825AbjJRQAO (ORCPT ); Wed, 18 Oct 2023 12:00:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232413AbjJRQAC (ORCPT ); Wed, 18 Oct 2023 12:00:02 -0400 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2047.outbound.protection.outlook.com [40.107.13.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DF6B7124 for ; Wed, 18 Oct 2023 08:59:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kDV0hPtOlQJ+7rTJ0Gpm6ns48CC2s4UrF6W+7RRs98UWmqNWRVBCPN5M5zROTMIpB+P8Jej9F9scHoZiJuWCmB6dEUc5xsEyWZ3NsS8cCQ9ImIw2A9Ar2zQ+8b9WvhBalNtbecQSOUZt8SVVa89cjnVZd2wt6Pq9VMpdaRLHQbVz1eZabFC77MVcvum0WviwBcudD4jh6EIY9250tXZQ4rVJmaN2oKi93pVEXKrNnCVlnQeJWWsM1TAm3Kea4uIs87RxRwT7ASxB1h7APa5pGFi87qU5MzTPsW1xlRutMoDn4u2ys/jWZnljVjlfBuyAoHQ1bWWP/vQwqXVQi/kiEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HRiKdLELnJRJ0nyk972LH2tykiePszc/EPeBiGyUew8=; b=CiUgteJwKCd3F4RhILwFl1gDX93Q3mr6BOnCg0Yh0O8SdxNvYc3BtB/uk12CYxpI+n8eRFvEl3Got8mdenYhAvMXL8cIG9lW9ZbqZq4Ti+8nZ97NjMPOKoxNDkQnk09YCG9dlLllczvkmg/2x8KqXD+rfZ+ThbJwfMR/ekgdidqVqSp9fxPs+5sPfS60sZK0oDPnU7Fz/FggvZSLtPB+afjtw/L6usdZtAQU83zcNxLKmF8ZSnI/Xupae06ViPPzhR+m5+i0gED3eM7LlmZ4O9PYNt2Ff4fesx5xXyHZky8WLkGT8c5LqhwW9H+Z7Z0d7d8niiPFEhY9TWY8GkVp+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HRiKdLELnJRJ0nyk972LH2tykiePszc/EPeBiGyUew8=; b=eFQdEt20fjK6bS9B1YSbLwYZz9NOGOSEkaaaJJnYLLKbIi7Zt7HGN8pmlO85KAi3KjES/QkmKStkRyLdTDCOjwVprLIL/wEBoUsbDNP4GX63MbWt0iMDKDlrlxWBdMaHvwtxJNm2f8pmer9gDYEsQm4jL8skXfE+kZVpCw5uk2o= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AM7PR04MB6966.eurprd04.prod.outlook.com (2603:10a6:20b:109::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Wed, 18 Oct 2023 15:59:56 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 15:59:56 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.Li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 Resent 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen Date: Wed, 18 Oct 2023 11:59:25 -0400 Message-Id: <20231018155926.3305476-6-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231018155926.3305476-1-Frank.Li@nxp.com> References: <20231018155926.3305476-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0210.namprd05.prod.outlook.com (2603:10b6:a03:330::35) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AM7PR04MB6966:EE_ X-MS-Office365-Filtering-Correlation-Id: be53f2c2-92ae-46d9-09d0-08dbcff345c8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EXo3zhscrBsauzK+Q6NamX0iK2PYI6J9S34Qe/JVPL9UuBPA/dCQ+DClA3fy8oUu6Q5ZpH8TAm5qkgFBI/MjThtsFGT9NgQJ4HaiqOukAkpi89myIRxlOVaMwR4OGV/9Cd9vMuIzmwFLxTsOrxN4iKrU+bLD5pCWmaMC9bgOGq7PE7InIJyhYaCrqDBBLU/LidnzlnJL5W40iJH/G08gl0/xxtEvtyh4J3ZN9b/ZdZp/sSdeMa0DeeOf5vUAf1ztUf7MLJ42Z/rZjJAIF4fHg4HmgVq74+setNO4qVwxFWHKn8DXOchRh8L4toAD3pSOgSfj9C/5+q85oxqEmta408hpuqpd1o22FFGr8xxf09trXiE4ySxZAXOiIlAgYfDbr0q1wyoyDGEWL9hehjdyf40XyNz5Ger8A0f8W/vsZE+x7XX0m5B0ad0ejALxwORQskYgInmZXgNHfM92c+e3sCZujYLkUERcKS/49QPmtZJ+oorE2BChRriZbRAJGAwxXvA91159rkZjMmgnq5F8W0LPiHoeXnyuT5lNfq80WOA3zfcatlXGjndci6hIBe5qyJLS6ma2UY+/vKwjJ4AH+07i84oyAItvCaSV38REvNF8E2IiUkQd0aRNEQGYSQvH X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(39860400002)(346002)(376002)(396003)(136003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(2906002)(4744005)(478600001)(6486002)(6666004)(38100700002)(8936002)(5660300002)(8676002)(66556008)(4326008)(66946007)(316002)(36756003)(66476007)(6916009)(86362001)(41300700001)(6512007)(52116002)(1076003)(6506007)(2616005)(26005)(38350700005)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ydFHcasc5LkaRtZsorlH9V8tXLhyh5C0pkl3Ea4K1d52XeEi40BCZrzkMg3t?= =?us-ascii?Q?F0h50ulivUlvvHtm0A/qa4Zi/g43iwMBtSicz8nSpwO7jpTUGo9/jngU8PbB?= =?us-ascii?Q?mRZRl6N+cMMBTyLQCNN4ss7sF25vH/BtTYVd82oHGXwN5MKPc+jCwhjvmarQ?= =?us-ascii?Q?Rw9wAtl+KsASbQNJJvukOhdcnfXOSQKVtf7o/epo42MTaM3MdDsQRISnG3bj?= =?us-ascii?Q?zprMw7++irxeLUkBCvfXh87m/4NObN6tao3exOc0WirsyrDdIKKqdh12mWic?= =?us-ascii?Q?b9iNxkOYlBn4D6LH9WERyruXzw/7NHaul9PKRfVp4S9t+SizNsgPKHKlqMxD?= =?us-ascii?Q?fGhPKT5UWQwD7E6aV7MDbWxfmMPuYo9trHAJYVTpogsuIEk9USOn+zIsSx4G?= =?us-ascii?Q?6wy0nf08opPyIXXtzBmFvp42TX7BZttlAnqURE5g+OQwiUtFfIoAVeVwgvud?= =?us-ascii?Q?11+kbMqbvl1pZ2hUjRsoGSJSst5KWHn4Qutw1dOQuI93Nt6k/sPENU2QxTvP?= =?us-ascii?Q?mCq9vEdSTqXkprsuucRKb/WGe7QShL6A8EkpFIRYEq+18TpVECLCk9Obon3z?= =?us-ascii?Q?gBF8Yu41i7KjtMn+ygEt+siMoUSl8LHhol/21hbdB7G0RJvuP9jJ7HK4kfxo?= =?us-ascii?Q?QNVUIihcOnz+63KfLYqbhfC/n8/JsotLoDgslPKhCdHUQf0a0Vt7oFPf4TqL?= =?us-ascii?Q?gf7kUTJMnyoCpv7ABAa19F7OwVgO2WUP3XSDS9kCKhRHkzNuFrW+z553nNZV?= =?us-ascii?Q?Ud7HIkg8gtUUZ1onVwlH1EkbY7Ce8TZNHbf2CYe3Cfso1cfeOuXBQsM1A7VK?= =?us-ascii?Q?4DzoML10tHsWGlIWWHDoblPcEeZWrJYIXYNrgrMojCwbYOuhr6tYGT2h0GNE?= =?us-ascii?Q?pRxAWp2hqj0ojpQv6xJdMRc9p+qXGITY8Fh7qYm10ZuuXpyWQOe01D/a0YuP?= =?us-ascii?Q?QkGUkwtldRe2GNOe4T3V4zMW0fsrXmrgamMpzWCBjSNF0qlNmTbhKsDQ23ZA?= =?us-ascii?Q?nq2kqwOCWExwktoSYVvWAAS7Q6rKDoiS5YHGHGoHoc2XCuhCOojHnvUwRctF?= =?us-ascii?Q?Lerts9j/QZKSHt+28h9zsDKMq2f5XrB/GIup282wcAD2tg5IcdKr69D8Sxgf?= =?us-ascii?Q?YjmVdrs6mZBHfmIN4y+4xjtb2OWTsY991nbhLWv1r6IBlCOktFkPOkr7oIt4?= =?us-ascii?Q?ghi43gLgpGElQPZ3YY0dN22l+Wc0fM73rwVlTw5DcLGA1cp5XEGzwjB0S7D3?= =?us-ascii?Q?LbHBh+cpTGTUoHcjHN2yMnnBwl7Zr3CqXfN8x1lGAnKZunWeIDSEXCke1zRh?= =?us-ascii?Q?t0fr/RNvyJXapmYYHRjhraRdW73bawQlsQEfWe3tvCN5ReVNfCi+nOm4UNJd?= =?us-ascii?Q?AXyq75mqxWjKlnFdsKQ03DIs2spWSuTRgTTZxJEnQpJB3ausTYOO6SVdMCrx?= =?us-ascii?Q?8LQH4xMM7C/fZbScEAjd6010/BmWvQLa9eAteGO0jE8o9KXHuHINuLnh2MbQ?= =?us-ascii?Q?Q6IXPXh24/kOHUOeCA9DhQmkYb913lxSto5fcawqEGlICobyQMUMMcna9FTn?= =?us-ascii?Q?R5ZSZdFOU2pvYDMNGhjEU0LJCdYloAs8MFquLCli?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: be53f2c2-92ae-46d9-09d0-08dbcff345c8 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:59:56.1138 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zDJOlxiKPeawwY6QwaXrSwjINlntWoxxPVSVO7Nyz5rz3QjUEdkFE+4P+ujUoyJIJXj/2Vro+TmN4LRVJ7TANw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6966 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" If IBIWON timeout happen, SDA line will always keep low because miss emit stop. Call svc_i3c_master_emit_stop() to let i3c bus come back to idle statue when IBIWON timeout happen. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li Reviewed-by: Miquel Raynal --- Notes: Change from v1 to v2 - Update commite message drivers/i3c/master/svc-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index b113460f059c3..1a57fdebaa26d 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -404,6 +404,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) SVC_I3C_MSTATUS_IBIWON(val), 0, 1000); if (ret) { dev_err(master->dev, "Timeout when polling for IBIWON\n"); + svc_i3c_master_emit_stop(master); goto reenable_ibis; } =20 --=20 2.34.1 From nobody Thu Dec 18 15:31:47 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D9ACDB482 for ; Wed, 18 Oct 2023 16:00:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232400AbjJRQA0 (ORCPT ); Wed, 18 Oct 2023 12:00:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344704AbjJRQAG (ORCPT ); Wed, 18 Oct 2023 12:00:06 -0400 Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on2047.outbound.protection.outlook.com [40.107.13.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A07B2116 for ; Wed, 18 Oct 2023 09:00:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PXIvC6ZLfNB+KGG0DzU8M85j5GIWB56VpQh6c4GPAf3BCF7gjkq4sS/OovCn4OPZvnhwmpxfju1qwYnXfsMj++JqXfeytijqP1tyqfMbYTQJSdc81uHDNlBTNJCXzH0KTnpIFcOkE8sVccj6Lbc/3hTewP8n+sKSNg6ZkrqonZFiBY4dnNlNO9P/s73BAGwOzZeJXOxvnOvGUx9fRNCIbP0QPX+200aSZgFZobtC64FhZQdB+/HOqnj2UX+c0CCUGZWjpgcVw1sTkjj/beoTlquNg5Ywu+sEppUFUfmN4vyYgyot0sv4jiRMY0aXZ5Hp6wzoCUskUckBAW/kC728xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=478803QczRFFXBUKZoVGKqPgxQF91oUCRqBqSsaRd+c=; b=QWeViCOLj9+yWPPu9X2ZaQjBd/Jj427tpv8uOkPEIyJjkQqpTile/Ogeh9282QquzXgDgdmCRhxQJSVmw+7afrBZikW2ovXedm4vXR5j5UVa0IKemmdegdYg//gMHkop68TFjJrewccgz3qFCZg7wLrxZ+zPW3c5Sk8CbiP5zss95ZCNuDRh/A9bv4uR9xHZPLvUdmtOlOTIEtbwpXlZUkwnwOtEI3LffRbjpxIGDz3ywwnNoJDyw1+0mzh+EWoFhCi014fuW3mp74WVgTCAl9pouv0+vgc+UwUqpfTjj2u6HnhR2WMZ9by6WrbehYjpJM5VvsePro1xBmP2Oomj2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=478803QczRFFXBUKZoVGKqPgxQF91oUCRqBqSsaRd+c=; b=I7lSfk6mpf4kco4xiOh1PzN5kobl9au2hHtcGe69DWXLY2mE3VQOrIitd5qc6peg73MI3eN+VrWVMuC5f8leVdxiwtQyC6aN3wyd0qSV6owNX3zRcs3e8D1qYIbA4HQSvCh1hIsdB807ZDfnwlBgdYnTGCBMAilUdYalThj3OZ4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AM7PR04MB6966.eurprd04.prod.outlook.com (2603:10a6:20b:109::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Wed, 18 Oct 2023 15:59:58 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6907.022; Wed, 18 Oct 2023 15:59:58 +0000 From: Frank Li To: miquel.raynal@bootlin.com Cc: Frank.Li@nxp.com, alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 Resent 6/6] i3c: master: svc: fix random hot join failure since timeout error Date: Wed, 18 Oct 2023 11:59:26 -0400 Message-Id: <20231018155926.3305476-7-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231018155926.3305476-1-Frank.Li@nxp.com> References: <20231018155926.3305476-1-Frank.Li@nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0PR05CA0210.namprd05.prod.outlook.com (2603:10b6:a03:330::35) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AM7PR04MB6966:EE_ X-MS-Office365-Filtering-Correlation-Id: c2be9190-f7fc-45cd-6d61-08dbcff34751 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Smkj3gwC3HUe66vGSDimpNAsvQlq7DV5p1MyVAdR7X+KEKe4PZSZZEj5/VnNVMKgxkC1ozjDt4VaK3YQjPcn37OMmUfFlkzj41AU5k5An8cGQOE5V/Jl4vS89JULr/fdYuXA7NOF5ct6H0nSyPm5wxSWfthKLaPdT5bKPQuFP/SGuhVJtfK1HuLwgIgVCjRXw4t/1sQnWuZogYXKKij9rQ6Q7BnX+VB0pLZwJEiOFEcmxwhN1Y9eh4wHTqj8hgaJWcl4Ob1WUkD5vtGaSG5rccTBGyr1RE30VZQSnSaN8elm2w2Y6fDMPW+0SvmTz4XiK5tSXfz2gIKw9YrWsXDNw6opudtkzNmXxTT5mOl/hc88IEdhqRr1NPzuZo6DcxJz+E2ZNNNp/bUmNAzl9qv1/Gh/I58Kyyp4hsWmM6R6pNbICtflNmFHSfmy/JHws+m2WuCs3Ohv8KsFPUy7hoaAPfFRd2gNrqsObFP1LaqFFn2pDaItddkDveYuJcH6GfWbnlzHO048918hk3yO7A4/8i/OLY0yRDJ8/E5/TL0tnCYdcAo40WlkCHxSYGmJ/pIL2GpUul+kuNf2m0VtW1BEcXiXvfyueL2dE83ZagKmuOiK1rpfJoJb8Z3HWOpwdoO6 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(39860400002)(346002)(376002)(396003)(136003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(2906002)(478600001)(6486002)(6666004)(38100700002)(8936002)(5660300002)(8676002)(66556008)(4326008)(66946007)(316002)(36756003)(66476007)(6916009)(86362001)(41300700001)(6512007)(52116002)(1076003)(6506007)(2616005)(26005)(38350700005)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RGYzVUdwSlJJUDFkVWw5VjB1a3RONUF2UCtYREFtdnpGS2RjS0tPK01jaEpI?= =?utf-8?B?c1djekpaWnBQZnZqNWlyY2NOdXJSL252WWxKaksyU1dReWxqaUxWY1E2dlVB?= =?utf-8?B?djJSMGlnM0ZCS2tSUHRsMWNyMHMraXA0anA4QWRXQ2RoaThVVlhKNTFMUUFX?= =?utf-8?B?REY4QXN3dVMvY1lHL2ZWUVp0N1RaUEt5YTU2NDgwcVN4SFNCcWFmY3U3REY3?= =?utf-8?B?MFR4OC9VVUY0TFJTSHJJNWFROG1VaC9OUmVaeFlVaWQ5Y3QrU21nUURrRVpy?= =?utf-8?B?Q3huQjR5TmdWSzRLTmFHQmt4NkZmZlVwRUZaUFZyL0xyZUg1WENTN2kwQndy?= =?utf-8?B?NUpoWHJmOEJDZVFJL3pKbTBpRk5yc0k2QnF5UHBjT3NHcGNSRGd4cUR0bHIx?= =?utf-8?B?a1MxMWNqT0NldTFxSG9pZXZvcFpuSFNLUzB6VkdCUU95SVFYTGM4Nms4TnJS?= =?utf-8?B?eEJydis1NzdXeVdnR0psN0dGQStkSlFQQUpHaHJUU0I4aVhDU3BtbmJCUEw5?= =?utf-8?B?am05WFNLbkJYU2ZwTWhZTUJMNzdDUnpZajBmbVVHRkpIY1gxR1hYT0xweWgr?= =?utf-8?B?ekpSdHVrZ2ZvdDhSMU1hMjhqT2cwNSs5bitqSEduMUtGNnBjdGZGdG1pRmFP?= =?utf-8?B?QnJBazZaYWoxem84UEREU1FIT1c1Q3YxdTZKbjlIL3l3bGV3N0g0L3ZRT0pV?= =?utf-8?B?dVRIdFNGZEZwLzZKNW12NU12dFZTRnozNHkzSEVXbk55amxESElmcy8ybytK?= =?utf-8?B?WnVoNzhQSnZsMTdtdVQxbUNDMXZMalduM0RRMlhsYVRmSXNLK09ERGN1UzA4?= =?utf-8?B?YUhiMHhySGdtUk56S0hSeEVoMUtKNURlcGQ2cml6NHc2VlJlNXFFTmM0aWRu?= =?utf-8?B?aDdQSU1ILzlBTDdrTUFlMFZkVlhtU2FqeEJBUmNabVR6d29FMUJUSHBSUzRo?= =?utf-8?B?Q3FkeGdQditKQUtUcXVOQXZvSUhuSS82SG1pL2piZmhuTmU5NnFTSDk0MXFh?= =?utf-8?B?TjBMYUtDTDVtOTNqTkp3NGpBWGJvNEtUV3E3ZlExdWFKcTc5SHlpNU1QWm4r?= =?utf-8?B?cnlsWEUxZ2d1eTlObXpLZVIycDBWTi8xOGRWaGdIT0ZHSWl6ZHhWUEJZZ3lJ?= =?utf-8?B?VTN3TGZZK2RHcGlZZEZNbE5NelhLbG8wM2ZxcTNESU9rcThtL25JWmZqSGRv?= =?utf-8?B?NEgxOEcrSGVKL2k0MmY2YVZlaG9HMXBVRGJUcjhBZlZJTFFHQldGOUVJSXA5?= =?utf-8?B?SnFUZnY5VEtNdUZCR2xQbXhzTmU0U1VJQzVaTDUxOE5pZ2tXYU9Qd0FuS3pp?= =?utf-8?B?YTl0RFViMmVuVE96VXYxS2hDTHViTlVMT3k4ZjdMQWRoQ3VvVUFESGY4TlJ4?= =?utf-8?B?U1JrRDBtdHlqNjV2bWE1UVVpRDF3SU85bjRoYzl3V3pudVpiWmFqdUFwcnV1?= =?utf-8?B?eFc4SysyWFBsNHd4OGxTQkdRbUZnKy9CSGs3a2RhZzFtQjZwcmd3b3pVb0Jv?= =?utf-8?B?UUJqcWhSY3BWTytoV1FsZVkyYTk1Y3JrRklhSTJtN3NrWHR5TldNZEh0cWtp?= =?utf-8?B?MXc2dVRDQUZLR0lwU0Juc2VCZGtkS0FNZ01WdTBRc2ZIbEZqN2tBQ0VDY2xC?= =?utf-8?B?Rkd6ZWFyRU9aRHRTMFRJY3pVekd1dXpOVGtscG9kRkIwZjBpMktidk5WemVZ?= =?utf-8?B?TnpSdWxKMW5KYmozdEtCaWQwcmFpcE9naXRlUnU1L0lKUkQxNVdZblVUNm04?= =?utf-8?B?RkRZa2s4RUtpUWtHUUIvQ3o3eURHd1FKcXZ0ZUlWelNmRFVJMXhEN09KWWpl?= =?utf-8?B?SlluMXlSNWFrdjZvd2pqd3FYTXU5OVpFQTdTclQxeHpPenJwQnVGVW9ENVBk?= =?utf-8?B?amFoZXI1MzNHZW10UUJxZXFNOVVsRmlzQjlKQ0VYY0JxV3k5VGFsc08zWnh1?= =?utf-8?B?OGxtR2NHbnFJc2ZoVWNYcm02Wlp6VVcyME80b2pMRGkvVGFvVllCMTdNcE5L?= =?utf-8?B?TVF6SExiaHdOdUtkc05FWTlGRXZXWkZvbmtmK3NZdW5iMVg4ZE9xeDdIVUcx?= =?utf-8?B?MFVJY3hDeExlM1JoR1BMTlBiazFGSG5LaUcyaFd6SU5SMGZpWDBQMyt4MThj?= =?utf-8?Q?GKqPKpgYhS11pSc+BGHyCDWml?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: c2be9190-f7fc-45cd-6d61-08dbcff34751 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:59:58.5131 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4I63UuGnjXmXnwy8MxQis7lE52/x2VZWoraOOvtBb+ac2OVVWOFq1FgDitYaoM1rPLMYGh/QX9lhRt+GEq1sPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB6966 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org master side report: silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090= c7, MERRWARN 0x00100000 BIT 20: TIMEOUT error The module has stalled too long in a frame. This happens when: - The TX FIFO or RX FIFO is not handled and the bus is stuck in the middle of a message, - No STOP was issued and between messages, - IBI manual is used and no decision was made. The maximum stall period is 10 KHz or 100 =CE=BCs. This is a just warning. System irq thread schedule latency is possible bigger than 100us. Just omit this waring. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li --- Notes: Change from v1 to v2 -none drivers/i3c/master/svc-i3c-master.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 1a57fdebaa26d..fedb31e0076c4 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -93,6 +93,7 @@ #define SVC_I3C_MINTMASKED 0x098 #define SVC_I3C_MERRWARN 0x09C #define SVC_I3C_MERRWARN_NACK BIT(2) +#define SVC_I3C_MERRWARN_TIMEOUT BIT(20) #define SVC_I3C_MDMACTRL 0x0A0 #define SVC_I3C_MDATACTRL 0x0AC #define SVC_I3C_MDATACTRL_FLUSHTB BIT(0) @@ -226,6 +227,11 @@ static bool svc_i3c_master_error(struct svc_i3c_master= *master) if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) { merrwarn =3D readl(master->regs + SVC_I3C_MERRWARN); writel(merrwarn, master->regs + SVC_I3C_MERRWARN); + + /* ignore timeout error */ + if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) + return false; + dev_err(master->dev, "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", mstatus, merrwarn); --=20 2.34.1