From nobody Thu Dec 18 15:31:41 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98912CDB47E for ; Wed, 18 Oct 2023 09:05:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229619AbjJRJFx (ORCPT ); Wed, 18 Oct 2023 05:05:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229570AbjJRJFu (ORCPT ); Wed, 18 Oct 2023 05:05:50 -0400 Received: from m12.mail.163.com (m12.mail.163.com [220.181.12.199]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A2798EA; Wed, 18 Oct 2023 02:05:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=uPGzn fD2Jxiu6/QXi1pCYsVwDO+lI2Iyml9ofCWoSGI=; b=W7mtxSM0iWu4WL+1nYy6o Vmswr9/QP44ONQkPyzXjYZrLNEoq4ja5DIBJBh6AEfx18+qG0/i9s3PygcwvjYln WoIO1nB6MgFkqd9Kh/ir00u1qgp5xW3r719xt/Bffe1pOMoNLSKnGSwHWpjoeuNt Yy8NE4gpUJhzv/urRNapMs= Received: from ubuntu.. (unknown [171.83.47.247]) by zwqz-smtp-mta-g3-3 (Coremail) with SMTP id _____wCXOGzgny9lgxGFAw--.2672S2; Wed, 18 Oct 2023 17:05:36 +0800 (CST) From: Charles Yi To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Charles Yi Subject: [PATCH V2] usb: gadget: f_uac1: add adaptive sync support for capture Date: Wed, 18 Oct 2023 17:05:09 +0800 Message-Id: <20231018090509.1244839-1-be286@163.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wCXOGzgny9lgxGFAw--.2672S2 X-Coremail-Antispam: 1Uf129KBjvJXoWxAr15JF45Xr17KrWDWry7Awb_yoWrCFykpw 4UC3y0yr45ArZIqr48AF4rAF43Aa1xG345GrW7Ww4Yganxt3sava42yryFkF47AFWrCw40 qF4Fgw1a9w4kCw7anT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0pRwL08UUUUU= X-Originating-IP: [171.83.47.247] X-CM-SenderInfo: dehsmli6rwjhhfrp/1tbiWwYN0mI0cVp-TAABsN Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" UAC1 has it's own freerunning clock and can update Host about real clock frequency through feedback endpoint so Host can align number of samples sent to the UAC1 to prevent overruns/underruns. Change UAC1 driver to make it configurable through additional 'c_sync' configfs file. Default remains 'asynchronous' with possibility to switch it to 'adaptive'. Signed-off-by: Charles Yi --------- Changes in V2: - Updated the indentation of commit message. --- drivers/usb/gadget/function/f_uac1.c | 30 ++++++++++++++++++++++++++++ drivers/usb/gadget/function/u_uac1.h | 2 ++ 2 files changed, 32 insertions(+) diff --git a/drivers/usb/gadget/function/f_uac1.c b/drivers/usb/gadget/func= tion/f_uac1.c index 6f0e1d803dc2..7a6fcb40bb46 100644 --- a/drivers/usb/gadget/function/f_uac1.c +++ b/drivers/usb/gadget/function/f_uac1.c @@ -33,6 +33,8 @@ #define FUOUT_EN(_opts) ((_opts)->c_mute_present \ || (_opts)->c_volume_present) =20 +#define EPOUT_FBACK_IN_EN(_opts) ((_opts)->c_sync =3D=3D USB_ENDPOINT_SYNC= _ASYNC) + struct f_uac1 { struct g_audio g_audio; u8 ac_intf, as_in_intf, as_out_intf; @@ -227,6 +229,16 @@ static struct uac_iso_endpoint_descriptor as_iso_out_d= esc =3D { .wLockDelay =3D cpu_to_le16(1), }; =20 +static struct usb_endpoint_descriptor as_fback_ep_desc =3D { + .bLength =3D USB_DT_ENDPOINT_SIZE, + .bDescriptorType =3D USB_DT_ENDPOINT, + + .bEndpointAddress =3D USB_DIR_IN, + .bmAttributes =3D USB_ENDPOINT_XFER_ISOC | USB_ENDPOINT_USAGE_FEEDBACK, + .wMaxPacketSize =3D cpu_to_le16(3), + .bInterval =3D 1, +}; + static struct uac_format_type_i_discrete_descriptor as_in_type_i_desc =3D { .bLength =3D 0, /* filled on rate setup */ .bDescriptorType =3D USB_DT_CS_INTERFACE, @@ -280,6 +292,7 @@ static struct usb_descriptor_header *f_audio_desc[] =3D= { =20 (struct usb_descriptor_header *)&as_out_ep_desc, (struct usb_descriptor_header *)&as_iso_out_desc, + (struct usb_descriptor_header *)&as_fback_ep_desc, =20 (struct usb_descriptor_header *)&as_in_interface_alt_0_desc, (struct usb_descriptor_header *)&as_in_interface_alt_1_desc, @@ -1107,6 +1120,9 @@ static void setup_descriptor(struct f_uac1_opts *opts) f_audio_desc[i++] =3D USBDHDR(&as_out_type_i_desc); f_audio_desc[i++] =3D USBDHDR(&as_out_ep_desc); f_audio_desc[i++] =3D USBDHDR(&as_iso_out_desc); + if (EPOUT_FBACK_IN_EN(opts)) { + f_audio_desc[i++] =3D USBDHDR(&as_fback_ep_desc); + } } if (EPIN_EN(opts)) { f_audio_desc[i++] =3D USBDHDR(&as_in_interface_alt_0_desc); @@ -1317,6 +1333,12 @@ static int f_audio_bind(struct usb_configuration *c,= struct usb_function *f) ac_header_desc->baInterfaceNr[ba_iface_id++] =3D status; uac1->as_out_intf =3D status; uac1->as_out_alt =3D 0; + + if (EPOUT_FBACK_IN_EN(audio_opts)) { + as_out_ep_desc.bmAttributes =3D + USB_ENDPOINT_XFER_ISOC | USB_ENDPOINT_SYNC_ASYNC; + as_out_interface_alt_1_desc.bNumEndpoints++; + } } =20 if (EPIN_EN(audio_opts)) { @@ -1354,6 +1376,12 @@ static int f_audio_bind(struct usb_configuration *c,= struct usb_function *f) goto err_free_fu; audio->out_ep =3D ep; audio->out_ep->desc =3D &as_out_ep_desc; + if (EPOUT_FBACK_IN_EN(audio_opts)) { + audio->in_ep_fback =3D usb_ep_autoconfig(gadget, &as_fback_ep_desc); + if (!audio->in_ep_fback) { + goto err_free_fu; + } + } } =20 if (EPIN_EN(audio_opts)) { @@ -1685,6 +1713,8 @@ static struct usb_function_instance *f_audio_alloc_in= st(void) =20 opts->req_number =3D UAC1_DEF_REQ_NUM; =20 + opts->c_sync =3D UAC1_DEF_CSYNC; + snprintf(opts->function_name, sizeof(opts->function_name), "AC Interface"= ); =20 return &opts->func_inst; diff --git a/drivers/usb/gadget/function/u_uac1.h b/drivers/usb/gadget/func= tion/u_uac1.h index f7a616760e31..c6e2271e8cdd 100644 --- a/drivers/usb/gadget/function/u_uac1.h +++ b/drivers/usb/gadget/function/u_uac1.h @@ -27,6 +27,7 @@ #define UAC1_DEF_MAX_DB 0 /* 0 dB */ #define UAC1_DEF_RES_DB (1*256) /* 1 dB */ =20 +#define UAC1_DEF_CSYNC USB_ENDPOINT_SYNC_ASYNC =20 struct f_uac1_opts { struct usb_function_instance func_inst; @@ -56,6 +57,7 @@ struct f_uac1_opts { =20 struct mutex lock; int refcnt; + int c_sync; }; =20 #endif /* __U_UAC1_H */ --=20 2.34.1