From nobody Fri Jan 2 02:28:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA14CDB465 for ; Mon, 16 Oct 2023 15:32:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233628AbjJPPcz (ORCPT ); Mon, 16 Oct 2023 11:32:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233425AbjJPPcv (ORCPT ); Mon, 16 Oct 2023 11:32:51 -0400 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2073.outbound.protection.outlook.com [40.107.104.73]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4941ED9 for ; Mon, 16 Oct 2023 08:32:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mN4dSZsYVnxL3yEn+1Kji+In1KAgNTJsvRx+MMC5xBxx+wn4esucUjpSmlRqd72uDWtf2JsuWZESxFVYqnbdifKjIL0Ov77sM7zC1SqeruP/814FbwE+x3t2YhEfccTy1u99gJZJqjXwt3R3lWMR2ArJVWjWlWM2R3pmWn799B/F5xxDSZlAmrmsuG2KHcXa2iUSBlXqq3xdPgnZ/Ag9eY5EvGsAEQepYrWFGsl1NX/wYSSNewpDfZPvk6Y+49aBGpWHgm9CZCleFTJeIwY7bLHBlTGezDVXXsFYac4ydV1/xCriFSqUpsjMUewhlYTX8moONXST5sXNRFrdA5BZ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xn4mPAvhPGdHiiCr3YwVziVD/SfIEV3x+7h8xcqcUzA=; b=QOyDe1gCVqTaCwcsFgHJNVKH1/gNWX3SdhWoOzzJg24DodPKd1EcPSKn1eXqw1TqkZAa/D1oChXav7RyXSu0Cq0P28KkkRDoOmGiAWa4oFBjPjf3neEEiVeHsdEmw2JIR3voBNZCdAk3tBxEboDcUclxiJEF7MLpfeNuV4LP03rQwM/UPsYR/EVhhe83UE5L5pzbFQ0GmicwcHMJBGrxgYZDY75PCPO9IvTF7cV/9Frjlay6RHE1W31Vjho8VlLZfJS3GjuT/x9RYj0ntdI0THBaneC11n5nUVWxDfJB/n3gPbFZd4Tvo0GC2ormHANTK13h2e3GUaBQT5B67H+/cQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xn4mPAvhPGdHiiCr3YwVziVD/SfIEV3x+7h8xcqcUzA=; b=p1NSuLfZ6oQTyKP3Z5Fm/Hv+mRMq1tb4vLUeksDExBeNen66yxM/v7Qx+dz7YiBMUb93WeNiVGuk+ZABBpe8Yw/LCF0DDzkOPVqE0m5kBomFdePjIvMEM3bStJcs9pcxJ/EpIi/ozRQptEGT/nwx+/hWy+QpF5bJ0ubQ4ZuWiyo= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AS8PR04MB7592.eurprd04.prod.outlook.com (2603:10a6:20b:23f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 16 Oct 2023 15:32:48 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6886.034; Mon, 16 Oct 2023 15:32:48 +0000 From: Frank Li To: miquel.raynal@bootlin.com, conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH 1/6] i3c: master: svc: fix race condition in ibi work thread Date: Mon, 16 Oct 2023 11:32:27 -0400 Message-Id: <20231016153232.2851095-2-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231016153232.2851095-1-Frank.Li@nxp.com> References: <20231016153232.2851095-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0P220CA0029.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::13) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AS8PR04MB7592:EE_ X-MS-Office365-Filtering-Correlation-Id: 26d73f0e-e4e4-4fa2-cd0e-08dbce5d26b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AABSY/doIXSuIx+laH/eQ1V61vf/gnpQIoxEa/IbMyvRDq+iu/X9s+BwH1Un+PGxXii0CYzdZRSAq62jIjfWGvSbupgD1gx+SKmeC4tZTWaGS/wkSZlcR/Rcpqpl9Kd+25J+Vq48dnupXMV4UB1PqjBzoI7nb8tbbSPK7wRCIW2GVvW9imBGMgt6dBwTEQGZ6ZMVcADTqSz2bBPBbZpD38tsF4X2HBTrT5T1RMbrTFX6MBWxXNlwgnKKYhWHiCCIqgHvPcxHhTYBSWEac4aMipcVwavtYQ4pT1B5CqN4oZwSYVQvABKpz33cRXGRA3vvpgqPsOsRc4DMtT79td0t5l5UExLhC4tkFOeRCvgP4Rkc12Kjq6Io5U0ZwH4bs9hUhwq3bUwFOxsc94tWPiM/GxFNxMU2b6zvEwLE+jiW5xf3SSn6Y1ssgoH7TnVsbUyCtlxDBsaYC/+1rjmUP52qJqKWJxgKoCQHjdFkOODmPqBb5ObDVdsimjbGRiYRkpfQEWWN59vY6vWVhFUtWDs4Sfl5acmb0CrLjFZ7QzY6n/rvuYvp9rAcb0MLZxmRZJ155qu0QY3hrbnGszfQnLoWQjQoUpRVsvcpQq8MM45ULb8tZIhw+GNqNDakLOjz4jQd X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(376002)(366004)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(6486002)(38350700005)(36756003)(38100700002)(83380400001)(6666004)(6512007)(26005)(6506007)(316002)(66946007)(66556008)(66476007)(478600001)(1076003)(2616005)(52116002)(2906002)(41300700001)(86362001)(5660300002)(8936002)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?6Hb7fQ/bCrQpNyRFy3eS7Ipvehe6iM90xZtvB2BiY6/nnLDfLd4E245GcMLA?= =?us-ascii?Q?0qxmkuPZHSQ66klwvF6IWLUOfvpzLz1wXLD6zla5mrK+kCpYi1VglYK7ZHbR?= =?us-ascii?Q?N8i1kCVS+mxk/dOdKb3Su1sKr9EZWzkEYaDl4SlyBIKjn86fYj7kjMzJvxdv?= =?us-ascii?Q?hzc0xHqrB1+8jhFl3s47ObAGHvu5gscfiisTmzNix6q96OmfvmvPlCGKMWK8?= =?us-ascii?Q?Xa1J9qqTU3nPrvw4vkvV2LfZKY6px14U6LI7Zf+M/u9vlhp+0RaRFn9P2KIo?= =?us-ascii?Q?+BrnBKVdkSObqLkqIQaa5miJLLTkuJdDHTvzngdwnePlS789AM776lYRR5r9?= =?us-ascii?Q?/zZ3RwUtiwJlHyA0QicHKj2H0891uM96lC6IFT3lUy4rafCJ4+a0MR+qSF8O?= =?us-ascii?Q?IiNcgEnIwNysdRjYXs7Z9+jbpc4RABo2AqJSmpD/Qa+9mJZ143nijTkKugIj?= =?us-ascii?Q?2QidszjHeAhmgJn3OkAyyKFxHhFxN30N/nhA7eC/YCXRXOuy9cc1HzcmD8dz?= =?us-ascii?Q?PcjAHRDuCIxmvJV+qjAgP9WLDxu8yIrTdv807Au49xYMPd24HJWwnd9PbUHM?= =?us-ascii?Q?JUYmZxV1nbDaxPVy1gKwLBmTCDwCuYmpH5aosIC2lQtg4uwLwggTYR134cIZ?= =?us-ascii?Q?uvTiS0xWT0yfC7H97fd3h5xFIZzUn08VHhBlPXYvudIHmlWae4ffZGWRFfIn?= =?us-ascii?Q?UHSjDy6Hmjgc1FvI14x+jEwGjtyx6rv79X21u3BK7mS66BgD1hzvdKwf5dN7?= =?us-ascii?Q?3txuJtaLjyjtyQazWGgZ+XDyUsHzJ0b3B5EvvF66YqRdAh+5dQ35iDrk/Ozz?= =?us-ascii?Q?d8rPUxhy6U8ghHFO94atS5EPIbZ8KKqZOaUMAngBObrpZFrlPhLsxOap9qqT?= =?us-ascii?Q?Kdyc52o+vbE+LEBNdqsR7xs3+YHEbxji0WIMUjF4MOe2tknZ3DXzW77G7g9N?= =?us-ascii?Q?oIF1EMQrOj6Wp89OUCDgiWPN0aiPa1hxcPi1JG1RiYi0jNWYFs8byfsWhhS4?= =?us-ascii?Q?5O6UH4D0ICyhuCDBPwwMgqqP3O0o3l76oZUkv7U3m4boJnPb2Jka6n+PMKcL?= =?us-ascii?Q?W+8H9mPFkLGbr54NTvASElJb4aSCaguKbJZNmcBuLVPZuDj2Xy9+niXGHNRC?= =?us-ascii?Q?HB90Wj3TzlLjhNF6RVeU/q9sM4Q5jdd3CpRfOhbwL5mBxEBOi3I5xmx8H9eN?= =?us-ascii?Q?S/uAMLlxYNDxqAxYtko668ET2KzOUwgJdFotByGmzEK8PErABN3K5vyOhoQh?= =?us-ascii?Q?YbPMhTd63wSesnW7SVvg+onGzAdhQRnbJUbhPFoNiLWWuOWMaK4e1491HQHD?= =?us-ascii?Q?Vc90JskRm3iKLNpTBnIjAUSUaFyuUqgpEK5LBCKIzuCrxieHLqxmzUNWix6u?= =?us-ascii?Q?BW/cspn+C0sh0NEljmh5UOcm7afY/hwv05NJmYbg2TeSOVb6rLkKYOZYYnWN?= =?us-ascii?Q?QYXPy0OVXqpmhJuwJ0SMqMCisWfXhCwYBbXPlEAWZRDe/t/8ElftDQoeKrW2?= =?us-ascii?Q?tjf/TPMCeqqIfQifbRPCL7FHYe1rKSpaE9vIFfB0wBUoTdARF1SeMK9B1rAP?= =?us-ascii?Q?90h2EY+uHb3g18IQ9BI=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26d73f0e-e4e4-4fa2-cd0e-08dbce5d26b8 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:32:48.1604 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: q3XSOQmhczwsxHwqXMiJuWtIEs8HCTFdcCACjloCZHpkxHGjXMzkX/x9Ltzt2bUySyIzJPRJe/hun17mjCEgEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7592 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" The ibi work thread operates asynchronously with other transfers, such as svc_i3c_master_priv_xfers(). Introduces mutex protection to ensure the completion of the entire i3c/i2c transaction. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li Reviewed-by: Miquel Raynal --- drivers/i3c/master/svc-i3c-master.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index c308e22f0ac5..ebdb3ea1af9d 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -202,6 +202,7 @@ struct svc_i3c_master { /* Prevent races within IBI handlers */ spinlock_t lock; } ibi; + struct mutex lock; }; =20 /** @@ -383,6 +384,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) u32 status, val; int ret; =20 + mutex_lock(&master->lock); /* Acknowledge the incoming interrupt with the AUTOIBI mechanism */ writel(SVC_I3C_MCTRL_REQUEST_AUTO_IBI | SVC_I3C_MCTRL_IBIRESP_AUTO, @@ -459,6 +461,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) =20 reenable_ibis: svc_i3c_master_enable_interrupts(master, SVC_I3C_MINT_SLVSTART); + mutex_unlock(&master->lock); } =20 static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id) @@ -1203,9 +1206,11 @@ static int svc_i3c_master_send_bdcast_ccc_cmd(struct= svc_i3c_master *master, cmd->read_len =3D 0; cmd->continued =3D false; =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 ret =3D xfer->ret; kfree(buf); @@ -1249,9 +1254,11 @@ static int svc_i3c_master_send_direct_ccc_cmd(struct= svc_i3c_master *master, cmd->read_len =3D read_len; cmd->continued =3D false; =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 if (cmd->read_len !=3D xfer_len) ccc->dests[0].payload.len =3D cmd->read_len; @@ -1308,9 +1315,11 @@ static int svc_i3c_master_priv_xfers(struct i3c_dev_= desc *dev, cmd->continued =3D (i + 1) < nxfers; } =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 ret =3D xfer->ret; svc_i3c_master_free_xfer(xfer); @@ -1346,9 +1355,11 @@ static int svc_i3c_master_i2c_xfers(struct i2c_dev_d= esc *dev, cmd->continued =3D (i + 1 < nxfers); } =20 + mutex_lock(&master->lock); svc_i3c_master_enqueue_xfer(master, xfer); if (!wait_for_completion_timeout(&xfer->comp, msecs_to_jiffies(1000))) svc_i3c_master_dequeue_xfer(master, xfer); + mutex_unlock(&master->lock); =20 ret =3D xfer->ret; svc_i3c_master_free_xfer(xfer); @@ -1539,6 +1550,8 @@ static int svc_i3c_master_probe(struct platform_devic= e *pdev) =20 INIT_WORK(&master->hj_work, svc_i3c_master_hj_work); INIT_WORK(&master->ibi_work, svc_i3c_master_ibi_work); + mutex_init(&master->lock); + ret =3D devm_request_irq(dev, master->irq, svc_i3c_master_irq_handler, IRQF_NO_SUSPEND, "svc-i3c-irq", master); if (ret) --=20 2.34.1 From nobody Fri Jan 2 02:28:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 072DFCDB482 for ; Mon, 16 Oct 2023 15:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233674AbjJPPdB (ORCPT ); Mon, 16 Oct 2023 11:33:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233616AbjJPPcz (ORCPT ); Mon, 16 Oct 2023 11:32:55 -0400 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2078.outbound.protection.outlook.com [40.107.104.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5CBFB4 for ; Mon, 16 Oct 2023 08:32:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eVkXKgA1+LpgBKJxpjyFd/bVugKjzVctsj3qK7B2kqE4GbY3rHdSw36nQYzu2+0wwbW6pMcnpcQF/Hgwc8Un++7SDSlUeak2hy7jcFmbZi3GofDeWdiebOWXkUJT2/UqFIG4Np+YIURQB3qjwvimmEG8G/Ny2BeFndW3/rVc4Dxt4iq9jh/vQycd2GLuv0nJ0z1hmKECymLEahE8Pw96R7Sc5MkVfjCaFjn9tp2tpvn+qYmGwh8GZNiq8aIvWt6tCa1GdeDEumS0O6PE13hAqEPP9//4E5tPf/+3eoCmoTmSqi07h9DggO9e/37epF30/n8Y9+vQhGcZDXnkk+uiNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PvIe54O5QCnNX7y3AwVwXO/OJ5Uma3/csUrgUguDejw=; b=IUS65wvn5eLDwJZ3br1/UW3zgvgVXBI39tw9TNPtFs8K4adLicWHfC6JKVWaL05opnW3DzbduKiAvq8Mobh62uuAH7Lw4fvmj5M8svEtz9gEVZAFmoSImClng2ePpe7rnhwe2awpGR3QY5pTdMgVYrJRTZf6EIUuYGIQQ2AkPvxZCINlgpAu5lers+jNSH4xFCTJou820pa4Q5lxvI9kmlu5up4uMgoJU4e6YIWlU3pMcqUjQEGHO4LmmiM/EhuDZd7KPkclZn/SgBTPx9SRz/8AAqUf55zswI3hEEy1OPwXqYUuZxMBYAvcwPLJfZNZi7K4roHXIO4nzpL0Ykv3Iw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PvIe54O5QCnNX7y3AwVwXO/OJ5Uma3/csUrgUguDejw=; b=AKApbANDLCdTH72KxQAaf5/ykh5DjBg8ZE7TyhA0Bc3H/h4ey0T9ytt0F6XAgs3S0MxxNU4MMzcrSymTtYWwyHOavV5AdWU5kjwz6okdB6XaytQCKUf1QNlFyhDC5NYTU70FPEcXkdWNtgBsdlM/cY8A4vTB9Fk6zNgUyCjymV4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AS8PR04MB7592.eurprd04.prod.outlook.com (2603:10a6:20b:23f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 16 Oct 2023 15:32:50 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6886.034; Mon, 16 Oct 2023 15:32:50 +0000 From: Frank Li To: miquel.raynal@bootlin.com, conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH 2/6] i3c: master: svc: fix wrong data return when IBI happen during start frame Date: Mon, 16 Oct 2023 11:32:28 -0400 Message-Id: <20231016153232.2851095-3-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231016153232.2851095-1-Frank.Li@nxp.com> References: <20231016153232.2851095-1-Frank.Li@nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0P220CA0029.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::13) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AS8PR04MB7592:EE_ X-MS-Office365-Filtering-Correlation-Id: 2bba315f-0fe9-4cbd-5aa3-08dbce5d280b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TfD4F+UQUfCfQWT1KV3mgpduE+31+aM+gYyYgpwFlKHkL8HVnQM5XSoQuFmO8grJdRmXUFsagROQrIFyxuM5axm0Q4wDWSavbp9T47D+kNR37FzpLk15zcNt/119gM3qeCYExJb0K+GF/K5tdFp29J5FiXWjzUNuVM/UD5pEJXsVdZLW+iyL5RZeStx4uffpcjPljohq8tp1pg6xLWM3ytd0jNuxpWpSmkHf6rjU9T/3ri2Yyx658YCZL+MIbuHPB0CWIwO8zihdnDzugE8JgZ7ZJctZPCdrKI4Au3UcYa2gXPXjqB870l91KQkhE8HIN3cWZN3Uy/c4wZK+yQHnXoTGeEHIp8Pu1xuWojyE1y/MdtSKEffn8KGpYB+LuRmEmLVisWMDY4MDsWR1EsnuzZERCPsO7CiXsEXXxQdOWRVa/MNrhkLlsuGtLjnaDNIY0/qJxVAxoRffRw34l7Uhnx4f3HwNUvkLS/JH9c0A9kfpjsBATy1/rRJebp2IoU5zadqn51WuTXCdQg/NVPUopnipD475qbbrig8XsB1sJ19RFVEin9HVPCRa3QFxCKYlbZ4DWOEi+RD5GF1ksE73DeDtm0CEQ+TYobSQGxAKy39iww53Lg3qFKF/dKeSt8+r X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(376002)(366004)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(6486002)(38350700005)(36756003)(38100700002)(83380400001)(6666004)(6512007)(26005)(6506007)(316002)(66946007)(66556008)(66476007)(478600001)(1076003)(2616005)(52116002)(2906002)(41300700001)(86362001)(5660300002)(8936002)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VWlrK1lobmJScVpmSE9UR3Nuajl3VlM5NGVac3haYUQzbVBLV2dxNlhjTlFJ?= =?utf-8?B?Tm92U2dIV2JrUkNEdmVaUEJQS1YxeVhLTXVRTkQ0UnpXeXM1KzNsSGFzL212?= =?utf-8?B?cXRUQkpyMnEwcGlIaGNlYVNJa2YrYlNTTjQ1eHhzVWFxc0JDdVdYUjQ4eFZw?= =?utf-8?B?TjlFQzVBOSt1OW9Nc2cvbUVnWlB4aER0enhRQ1o0T09jV2ljZTJkUm80eWlP?= =?utf-8?B?TnpCQlVPRUxPdEsvQjl0ZWFsTmI0bGpqNDVHcVRzTThYWW9QZkF6LzVPTmpj?= =?utf-8?B?dWRCdkpPMzNhSkhGVld5VmRTM056N0tscWUzSHBJVnFMZFdRWlhUWXRQc1dl?= =?utf-8?B?SFhzcG5rTmM5K0JSWWU1VTZDYmx5M1Nac0I5bVQwT0Q4RGRkTUZFQWxPQVZu?= =?utf-8?B?L3d3Z1RXeUJFWXArZ1FxWFJiMWhVQTZYdG1ndzZYeUtwelJldVRrV1Q0bTlR?= =?utf-8?B?cktlSlVyVVN0QVZSV1QxazRINUwramhLWUgwRk9va1dSb0J4Zm9HQVdLRjZL?= =?utf-8?B?dVNiR1l6WDhHcEpXSjNQRnRiZ0FSZGk5SHFIckN2ZzV0TENvWWd3d0ZyZGRm?= =?utf-8?B?Tlg0TWFuSjFkMG9ISEtUSDBDRlcyb0FJYUE5a01nUkJJcDV1amwzV1JsdXlD?= =?utf-8?B?aUJvbFhIQnJNaDlDSXpJTE5RL3Z3ZXhRK3pQdDd0ZXFwZnEwcElDS3NFOUlt?= =?utf-8?B?czBtQXl1SDI1MnNlUFJTSXRoOENSbEliYnNSaldWQ1JHOTJHaG1yT0diUTV1?= =?utf-8?B?cFdmckVBU1VFTU1RYU9pUVVqZEd2cWI0a1JRYzliK21xQ1pSZk0yVDlNTkhX?= =?utf-8?B?REQvSnlqMUx4eWdsZnJ3U0J2Yi9CR3VRbmdBbUVoOEZ3RDFtcTRYSlZOOEVY?= =?utf-8?B?VEdDMld3bmpvRmttZjVqYk1MN0FYOGtnc3ZvbU5iMTN0NURqUUh0TGt6OG1j?= =?utf-8?B?clJocnFIQzVQbHNsMzRhUVVwZ1JLemdEbkJ4Sm51VlZ4cVFJRWd2VDE1MjZn?= =?utf-8?B?a1c3dzlEMm96M0tLNlhQVTBwa0RSZFBlMCtEM3h4UDhxYmNtamN1b2xaUVZS?= =?utf-8?B?WlV2eDMwWU9GL0JkWTJWSGd2b1ZLUWJhUUU5Z2QvNXRWUHVIVWJ1SFB6R0Z0?= =?utf-8?B?NTJ4b0Y5d2c2SlVWWG52UHFYdWxDYU1DQjU4UnZudGdLWkdyR1B3ekZaVXE0?= =?utf-8?B?UmhJamlBMTNUMzRGY1NvdWxjTUhiM3M5QVB2SWN0d0ZtbHZoZFBVcVhJU0Np?= =?utf-8?B?SkJNTEYyVjNEOGk5Y1VMbkdpbmY2dnJ4RmU4STRCY3dNelVlWjRiYUhwOVZ0?= =?utf-8?B?VThJdmhCVlNGWGlMZllJV25DN1BRNWhMM3p1STBCNVNwSitabjR2MmRzd2JC?= =?utf-8?B?amVMTkQ0WnoxWEJRTndBRk8wRVNyNm4vOERsUHZIUC9HS0V6TTFHQUtZQ1I1?= =?utf-8?B?ZnY3dXJFNEd2ZjNtZVV2SVZRUlhMbFRqclc3UktRQ0UwSlZRMk1FZEJjditQ?= =?utf-8?B?T1h2OXBaaU96QTVKeThCSVQ3dllHa2FPRDRmRGF3ZUJuYUtoaXVoTWRIaGFL?= =?utf-8?B?UEhra05QdXgycDNkNkFGTkZRa211cWlDYXE1ZWQ4OElpZjlLTlAzbFBKUC9a?= =?utf-8?B?UlloOWZ0cElEK0RPV1haeVNlN1djT3RRU083ZEVCQ25JS3NNSEVNbUdqdXpp?= =?utf-8?B?aVpid0dRRW1JYnhqZ0NwaEhzeUZ3VmF3YjhNZG5WL2pyelZlY0x2eUk0WG9O?= =?utf-8?B?eVRIQk9pZXJvWmJ4VjQzNFA1UDFyaG1IQjJLNVd2aGI4VWVuNUVrTUZyUDBW?= =?utf-8?B?MVpWM3NOM3M1aGhxRDBFY1Exb21lcWlqMDkzc3FDYTIxbGtBb1JVRmp1Unc4?= =?utf-8?B?b3E0Y3ZmQ2ZTdSs3Zkc4bFVGZHdpY2VSWnVEL3VSZ1pJazdSeTBkSTZncHpn?= =?utf-8?B?cGMzMXpCQS9SZlREZG5tRlMzV1k0NnRqNVBEeVdOMTBqMTFnNnlpb3RLY3U1?= =?utf-8?B?VUg2bnF5TXBGMnExLzZvdXRpSHNSaXYrS3hKYzEwdzJOZWJEalNYbzNMOURs?= =?utf-8?B?SFYrY1BJSStNOTMvdjdOVTlvbzhVcVJDSXBzNHFJMmR3T3pjZDZ3THB6dXdz?= =?utf-8?Q?0oA0=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bba315f-0fe9-4cbd-5aa3-08dbce5d280b X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:32:50.3807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ULMIngN0t84bbebWLfXv0QzBaEJuC2xkOy/Txofu01yrltD6TSf0nnYFIieoQ4adtEcl4ZDDYKYqrBOTa3IrOw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7592 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 = =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 = =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2=94=90= =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2=94= =90 =E2=94=8F=E2=94=80=E2=94=80=E2=94=90 =E2=94=8F=E2=94=80=E2=94=80=E2= =94=90 =E2=94=8C=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80 SCL: =E2=94=98 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94=80=E2=94= =80=E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94=80=E2= =94=80=E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94=80= =E2=94=80=E2=94=9B =E2=94=94=E2=94=80=E2=94=80=E2=94=9B =E2=94=94=E2=94= =80=E2=94=80=E2=94=98 =E2=94=80=E2=94=80=E2=94=80=E2=94=90 =E2=94=8C= =E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 =E2=94=8C=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=90 =E2=94=8C=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=90 SDA: =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2= =94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80= =E2=94=98 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94= =98 =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=98 = =E2=94=94=E2=94=80=E2=94=80=E2=94=80=E2=94=80=E2=94=80 xxx=E2=95=B1 =E2=95=B2=E2=95=B1 = =E2=95=B2=E2=95=B1 =E2=95=B2=E2=95=B1 =E2=95=B2=E2=95=B1 =E2= =95=B2 : xxx=E2=95=B2IBI =E2=95=B1=E2=95=B2 Addr(0x0a) = =E2=95=B1=E2=95=B2 RW =E2=95=B1=E2=95=B2NACK=E2=95=B1=E2=95=B2 S =E2= =95=B1 In-Band Interrupt (IBI) occurred and IBI work thread may not to be scheduled. When svc_i3c_master_priv_xfers() initiates the I3C transfer frame and attempts to send address 0x7e, the target interprets it as an IBI handler and returns the target address 0x0a. However, svc_i3c_master_priv_xfers() does not handle this case and proceeds with other transfers, resulting in incorrect data being returned. IBIWON check has been added in svc_i3c_master_xfer(). In case this situation occurs, a failure is now returned to the driver. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li Reviewed-by: Miquel Raynal --- drivers/i3c/master/svc-i3c-master.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index ebdb3ea1af9d..0f57a5f75e39 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -1009,6 +1009,9 @@ static int svc_i3c_master_xfer(struct svc_i3c_master = *master, u32 reg; int ret; =20 + /* clean SVC_I3C_MINT_IBIWON w1c bits */ + writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS); + writel(SVC_I3C_MCTRL_REQUEST_START_ADDR | xfer_type | SVC_I3C_MCTRL_IBIRESP_NACK | @@ -1027,6 +1030,23 @@ static int svc_i3c_master_xfer(struct svc_i3c_master= *master, goto emit_stop; } =20 + /* + * According to I3C spec ver 1.1.1, 5.1.2.2.3 Consequence of Controller S= tarting a Frame + * with I3C Target Address. + * + * The I3C Controller normally should start a Frame, the Address may be a= rbitrated, and so + * the Controller shall monitor to see whether an In-Band Interrupt reque= st, a Controller + * Role Request (i.e., Secondary Controller requests to become the Active= Controller), or + * a Hot-Join Request has been made. + * + * If missed IBIWON check, the wrong data will be return. When IBIWON hap= pen, return falure + * and yeild the above events handler. + */ + if (SVC_I3C_MSTATUS_IBIWON(reg)) { + ret =3D -ENXIO; + goto emit_stop; + } + if (rnw) ret =3D svc_i3c_master_read(master, in, xfer_len); else --=20 2.34.1 From nobody Fri Jan 2 02:28:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68350CDB465 for ; Mon, 16 Oct 2023 15:33:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233755AbjJPPdE (ORCPT ); Mon, 16 Oct 2023 11:33:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56604 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233643AbjJPPc4 (ORCPT ); Mon, 16 Oct 2023 11:32:56 -0400 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2078.outbound.protection.outlook.com [40.107.104.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89997E6 for ; Mon, 16 Oct 2023 08:32:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RBBxVUMQcPDWdqR3rhatFPJo32IP2xUTo+VKeqBERk019x75VsuAMvbOxI49k2IMJXA43YLbk+tnNxCG7rbMkKteCpQs7Fd3HI05R8MtzaQ+pFiCMY7iN6Z9Ub6FTXgZbA2nt/x4DuDYLZ0lD7cbfxjgWyb2GcErRTTekWeA5ObsHYgTWV5dszwH9w/keWni7h9xRG3waQW6BVP0ODRk14XdXNPm4r8skVq9eizLkhwFqd+dao3wzTl2bgHOCU4UeIH7JLShGdMDyuOiyxudXxu/Ihc2pqEqKR9Mxh1G9rl6cNRRIDeJdMLvlXyLk9tnIQWhY5sO6L8F6Y6qmYjLfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+nlpPOSgD82lCFohI2OxZVAzkZFLmByfJ5q7/Un/BtU=; b=jYYc0yN/fggC1AM3E8EBeGYa5w0uMjMks63rvv/OOQ78ZQl2OSudoPyFr5QG+cgpCnG39ZQmPZLSnbUKUq9ZpYXFUHlwgyLph6xpCeJipYnTJkBNf9fT2dgSPDEppAbxLZmBQUgeP7zPY2xqDxTPP2pB4xlOyh/ddOXus+9IYXHs4xt8HMd49uGlus7/bE6w/7BqDSmuVbwVHtJQUKjOHT0CjrQKnd7UD2JhuFc9DF/R8AETkoy00ws+0fxG29PQ7Stpnx6Vjd11fqHrAJt6SDT8Qc+QvygHqwD1nb//tFBco7HgpachLWUvTG7o4VYJk2/pryTRXSR/0rYgwO1iJQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+nlpPOSgD82lCFohI2OxZVAzkZFLmByfJ5q7/Un/BtU=; b=QVgiMOnZ6e31r5UB8NQNNvxRd59Mw737pHPAFE3sD8ExIMJlYvrH0N0/OdbnOOixXXY/690iPSNsDBCMmGfkA5umxybyq9M5wAELCRNNof7ypLmFzHkCMUWb37StIdFWlKaYppr+z5oNPXniV6bxlspo70VGanO5m6FveNEnquI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AS8PR04MB7592.eurprd04.prod.outlook.com (2603:10a6:20b:23f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 16 Oct 2023 15:32:52 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6886.034; Mon, 16 Oct 2023 15:32:52 +0000 From: Frank Li To: miquel.raynal@bootlin.com, conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH 3/6] i3c: master: svc: fix ibi may not return mandatory data byte Date: Mon, 16 Oct 2023 11:32:29 -0400 Message-Id: <20231016153232.2851095-4-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231016153232.2851095-1-Frank.Li@nxp.com> References: <20231016153232.2851095-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0P220CA0029.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::13) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AS8PR04MB7592:EE_ X-MS-Office365-Filtering-Correlation-Id: 228fb6ec-eb36-4ae8-85e1-08dbce5d295b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: r5DQA8AAe9uCLCPw/yNtnHF/BtLLZ69MhREwJTvSOIez5aXdTkCF1A6/c8xUnWGcrxtBpzo7dhhfRinvgLyIZEcF3BlrLeg2Q2nLP7iCKrQLvsIkIO95YYU0j1zy373/aEkdGL5gafcDyu4yf+gnoh7JLPdh/0d/nOnvcUAAzGy0JSZRHUhm6iyDjitb/hWuLml8pLQmdk30f+F9Az9W2W+z0afAoCfuuO33f3AIpb2Uz8WkaDWTa7EpqvkDfVIyqRGljipGellu4mqw5wjUEmwa77qO6r3dNntVO2Z9usPT9mFkrAA8p1glwNVgCEF9NyTHfV01U3hdMCU2Y/mBOYYJjVyK7QwibjgwXYLgpqQVALrqqwKlGi6Me3JNJe1CDxIn6a1sJEY+b1e48Q43cTDYAxYaHmknn06YhiHxKXuGw+LyP9KVNC+rdixvHH6P0QoiDUZHdH0+W2V3P+6+6Hj4mv81du7s3a3vAlDs2FFdp9KkoFHfoD3TCyqcWKLV86vdoYjQkjgzapsHsgWlmAgMn7kG821cuZM5QvkNnS6aI/hCbpVStc8mSVIx8dWJHdVJg6Q9w9wE2NQ/8m10Y2KMRhRXPqOaiIvjMLxcuW4DVfyMb/cy/A7LN+x9yGaP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(376002)(366004)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(6486002)(38350700005)(36756003)(38100700002)(83380400001)(6666004)(6512007)(26005)(6506007)(316002)(66946007)(66556008)(66476007)(478600001)(1076003)(2616005)(52116002)(2906002)(41300700001)(86362001)(5660300002)(8936002)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IoBqb4FNPokrL02kKzDsKh0FN2+tQuLyUOPGzgEtYslwTLUdJ2I2mvRkzfct?= =?us-ascii?Q?UnsVX2jeEiViDKjY7ttXGPaLlr9A8LgSYIdnEJKtTgMuzXsuRr4PZX4v9Kcg?= =?us-ascii?Q?BAp/foqajeWElzOBPq34eNaRsRuUFZTYlNSR73QoRnOgkGIw0ruSZjc0uFt9?= =?us-ascii?Q?6Rc3/VztkYZdKF/7ie2ySBM7xTbOmyllIhclZF6uUkpf9zw6tNo3X2SiUsY8?= =?us-ascii?Q?TPHKpX2nAEG3wS4YeYMSj9yDsgJLMV3Xphs9Gc4Zh4B/L7Wo2ZuQ58swDCSO?= =?us-ascii?Q?w60nF1iw0I+2ycqw1d7uZW+NnLF83oUpdEEww88uh/FpWiaMiIFscjiQ5O43?= =?us-ascii?Q?x+U0mcplVplUxWW2qOgbFhvNlZKWG9T78QaGvVUkvR9tBMsq1wzIroQLVjAw?= =?us-ascii?Q?1v5rXExt5Q68gTNxekBdrYIhw/0LnEAtnthlY39JX4L0UE0ldfG8CKTLGEId?= =?us-ascii?Q?xMG6T7Fqe9s2lN7nCcbyHIgqjqmUEotv8QQZSvaroUNUKfXrEBbdQEt9DLWH?= =?us-ascii?Q?44boC3YFakrXyb+MGvohu6HBEjumpa+2VsnVPZCkzoRyiakd8Nu2TOc72/lT?= =?us-ascii?Q?pZrbIwHUli2P2DLmfKy2OOd39rqGZmTT5l7VNoLkD656wohOFmJUCU5L2Nr2?= =?us-ascii?Q?FOi42weOMyVlAGSSzbl4ok20AH5WIX6F40wNm24RaK480J0DcjPSS5oMdUDn?= =?us-ascii?Q?Wra8XhAr9XrIBj074AmqmamD1TlGVx0gHoD5iBOJl90FM03ByOFaYxGDuH1L?= =?us-ascii?Q?YXXYUsE1kyAYRBcYVDKnDwBhc6f8Lc5M5ujBqAfhfG9JixbrNuZufUtFWSTr?= =?us-ascii?Q?ix2fkJwOLQgBgMt9nzqU8nEkopjaYTrIYRqjsSWUPLNi0oaPSol/EIfNPD0m?= =?us-ascii?Q?q82+1gJFiWFJriYR2+g55fkGj6q++DTgc3X1VdqugGYXN+UDEFsWBwkMNcfP?= =?us-ascii?Q?6XckpfnGXtWnkN0faxRvDKLAFBElF3qAPXAExQgSdr2OLDCc//F1/cy8Xnfv?= =?us-ascii?Q?ulkZg3NXsu0lmtii+lUYXKeRnvPOY8ibyBGfPtK8oGBUK3/DoNQVse4VhSH1?= =?us-ascii?Q?pwLfIwaPT7g3bHJsSUaLGmH7q9E4RnI4lqkvv/Cavq9QTlPKne5Qsi+thE4E?= =?us-ascii?Q?y9UMpxXW7eD/OId+iqJ5a3CEIrvXEsOwTc2Dl5GlQdyiGYWnUaYFr9eAbDZT?= =?us-ascii?Q?pIe6nfD0ur+H+rRsQXL6fBWpOwa+v8QKMfhU31nBn8OjabMkw7bmLHlXVRcT?= =?us-ascii?Q?PkOXUbFEAhTUyeZc5jnTUZB7dnOTrs8f1CoX55P7dlX4qjp6gHOs0VQYn5J9?= =?us-ascii?Q?1nJkrUvTa/vpoPmaGM2WsYaeNMUh8Ries0lVyYiqntvyvBhg0KrE+wHQu/uX?= =?us-ascii?Q?XwMga5SSBpoxgmvIVS9oRIiD5S/CWSqoIxNeWkVABWRbLul8iPYp4vLxppnR?= =?us-ascii?Q?GXqsSRwmuTLUw6+kQpzuVUr/LhBPReSfZriA3bcce8pJS0MwuIuLpAQPTNO3?= =?us-ascii?Q?Qxp36vIuh4Zf0kyM/FsykEE1aggt1HBiQVRskrCfqHVC+3u67HsoUtIey9Wm?= =?us-ascii?Q?te5NrHaxIa6Mxd5/0y8=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 228fb6ec-eb36-4ae8-85e1-08dbce5d295b X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:32:52.5814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: s8TH6LOoBvCXB3j3NM3BetkRqfwiIOaRbtjPpHw3s4Jy+SI1PqPDcN0o33A8+Jk6JvnF9NFGvckCHXGJfkIEEg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7592 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" MSTATUS[RXPEND] is only updated after the data transfer cycle started. This creates an issue when the I3C clock is slow, and the CPU is running fast enough that MSTATUS[RXPEND] may not be updated when the code reach checking point. As a result, mandatory data are being missed. Add a wait for MSTATUS[COMPLETE] to ensure that all mandatory data already in FIFO. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 0f57a5f75e39..c252446b2bc5 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -331,6 +331,7 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_mas= ter *master, struct i3c_ibi_slot *slot; unsigned int count; u32 mdatactrl; + int ret, val; u8 *buf; =20 slot =3D i3c_generic_ibi_get_free_slot(data->ibi_pool); @@ -340,6 +341,13 @@ static int svc_i3c_master_handle_ibi(struct svc_i3c_ma= ster *master, slot->len =3D 0; buf =3D slot->data; =20 + ret =3D readl_relaxed_poll_timeout(master->regs + SVC_I3C_MSTATUS, val, + SVC_I3C_MSTATUS_COMPLETE(val), 0, 1000); + if (ret) { + dev_err(master->dev, "Timeout when polling for COMPLETE\n"); + return ret; + } + while (SVC_I3C_MSTATUS_RXPEND(readl(master->regs + SVC_I3C_MSTATUS)) && slot->len < SVC_I3C_FIFO_SIZE) { mdatactrl =3D readl(master->regs + SVC_I3C_MDATACTRL); --=20 2.34.1 From nobody Fri Jan 2 02:28:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DD32CDB465 for ; Mon, 16 Oct 2023 15:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233782AbjJPPdG (ORCPT ); Mon, 16 Oct 2023 11:33:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233725AbjJPPc7 (ORCPT ); Mon, 16 Oct 2023 11:32:59 -0400 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062.outbound.protection.outlook.com [40.107.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70CD3FF for ; Mon, 16 Oct 2023 08:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QmC7We94+7hL4bCAfvFTxmKhDQjf597L1h2l7xaIz96qN8zbSbn5DhXaovLwBgj+7BfC5bDv+Dk1BQL4iSIFqyfG3CZaeMhiI8U4TkIsdj1qI1JZge5YCr5x7+CgYuIUadW4LrGedDy5Lb66dVN/2BgRHeH00FEDQzIbNqUi9n15PX6qqfiNVjJmzPjEobl0SdzUUzGc5Mq11UFaGJCeYcCX3gtiORm8DNOjcNCNpGf/gDNN4Gj4XfHPOg5W5LiQQdd4pTQZyHv3WodhjvlxqRoQbhRjdyJfMPfKHsBntcq1ZR09JRGPjUjWA7JM6qdIYWOBwx17GZ2a8vUb+UYxTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pkwx0UMNI50CmR+xgaVcJ28Fsm+ChWROSyDoeW267Xs=; b=mWAKQJCSfP2rL0HC9WYZ0dOlhNVbG/G/G8E3fN14Rh+ZE8xTPQ4fMK6bVlvsRpCzINKmrRp/c3fZG06/BenZg85FbIjxELnD6RM6OmPVe9sLKg1yvymN6p5PRuEO1itGNCkIYZCh+O+AV85fkL5wulOKwKfaed+m9+r7H6HN/VCpkMACVwDcvekFvdLPFqlxSIT+cRaid/8m+efq1we7EaTMvu+6OsvC/7Jxc1wOZGgXhYNV/hwH5u60exKirKMMi6q9E0bxvKfKk2xJoJI+Bkmdwvp5FC0jtl/hWIO7nn6O2EnUptHuWV1KdgCN0YcMYI6qpEk+aycx9/qs5pQj3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pkwx0UMNI50CmR+xgaVcJ28Fsm+ChWROSyDoeW267Xs=; b=S19mgDaQjfosE1u4yCHEYBHim0Lk8UVm+DNfqJGKImpYY06pW24UaN5CLRVkMSe+G0sOMTkfaDbajlwUjrc4Hm4nlRo8C6q/tQKu2Iti5B07g6D7lYtkdvfHYjrBsUXbOYKveotgW4TsayYR9kEVXZMisM79fFW05ZjVm/WNvTE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AS8PR04MB7592.eurprd04.prod.outlook.com (2603:10a6:20b:23f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 16 Oct 2023 15:32:55 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6886.034; Mon, 16 Oct 2023 15:32:55 +0000 From: Frank Li To: miquel.raynal@bootlin.com, conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH 4/6] i3c: master: svc: fix check wrong status register in irq handler Date: Mon, 16 Oct 2023 11:32:30 -0400 Message-Id: <20231016153232.2851095-5-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231016153232.2851095-1-Frank.Li@nxp.com> References: <20231016153232.2851095-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0P220CA0029.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::13) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AS8PR04MB7592:EE_ X-MS-Office365-Filtering-Correlation-Id: 958d9ac9-255c-4b13-75bb-08dbce5d2ab0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: AklonxF0IOuaSK2EjHqFsyVkmMVH8hR0oPnavOguDnuEPcqXborvhO+eyJiu0p9JOxfs+0vT2wcBNSbQpo6LTkGGHPQxg58SIE7BErt4Qdy6GpJScW4bji/zJotVhQ8hsM/yhlpGClF5f8nHX3w+nFLV4P+vRupDxH2tTGZbnlfWMpq5jGGBpkDQMDcqGqwn3RdcQmoO6AJ6lVr0d1QKln5WITxNMOxHeLdCrEuvrP1xYg63r6HR+0Q4UpCVfcNIOL/Y3BklMv3CS4lAoWznlrP+l0Zz7AsKvE4DzK/JPJ56kGB6ZnnzDuRKjS+rf+m/fr3r6q9L9xdxOC+w+HsWD2zX9kCnFfhE8ENTAX26Eup67UTZo9N952Sk769fW0CBR6slQ8hfxPuXI5/39hljd4Y39FtxFGA1XeufEYpCkDgAON4NocaTZFWsYpTiedRGUroigBhtxXdiyGLigcgZ8Q/76SqbKw+dbCYvuUmnG234L28dv2ggryd5hpbb5Cf8uK+kYJeXr1yaOi+YNE2HTMD2vRbrcUBNYFfDSdKGZyn+q+Yk502ubKtgI4xPUH99BWfW7CBIuHVkeDqJJ2ajq8J/4nT+Js0Gd+lOuzaS0PM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(376002)(366004)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(6486002)(38350700005)(36756003)(38100700002)(83380400001)(6666004)(6512007)(26005)(6506007)(316002)(66946007)(66556008)(66476007)(478600001)(1076003)(2616005)(52116002)(2906002)(41300700001)(4744005)(86362001)(5660300002)(8936002)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lL9nJCaNBMiAiZmDrLSExmgDbVk5kNZIGKh+DReo98rM3GhTegQ2pxcll6Ul?= =?us-ascii?Q?wtcKVmpEr8aq2muDMSzl1uPdrYLIsKiyQ20J21gduummISRSAuW4WS0FamTs?= =?us-ascii?Q?8J+xE8s3r5q15F0WnbylMctO8CVbmY8+2o5CH0iyOD5FIgtdQg/1KlWpzuCp?= =?us-ascii?Q?GdrqgMPK5EStsu2KUOdpawwBQha5MmQ8taEdYBA0ijcAJGJQfgVnLH6zaYn3?= =?us-ascii?Q?QScVbfRSQp+IKagRidRktf9KG94crRikgqOQFe4Fh8xKUMmMERfJpG5AqhmB?= =?us-ascii?Q?0lEJfhB/vZXtxhj03jWt/y42lb3bUhB77HhWFDl1AmCF6tCvfONCahUVJE0A?= =?us-ascii?Q?L/19Sw5UYJLzO3ouMDVaVLL7SaNbm/2t4SEhA8pAsf2zp/oQFQmi9evQ5UQO?= =?us-ascii?Q?YZfKDGnVp2Wb9GRe2lamdRRJEJm2HnAsm840C9H/VYAHWo5u858TSPYcHc2G?= =?us-ascii?Q?8BZHnTEF7WADgDUmAE0RWBJF/qxUczF+/hgjyOcJ8UZYOSHtxucnBVNFiS32?= =?us-ascii?Q?trQmoQUyr4t3pKAK/Jlp/ObWGu+v0Nq5cF4MxdhpIUrFEaoLGi58rw2ifcTN?= =?us-ascii?Q?+kR1y/GXiENjFPeQk9ZlcRDa7h0gXJPOJOBE35rqYxItlqoJ6TFKdjmd3gjT?= =?us-ascii?Q?HergQmLRgmanlErxfjAqyE5b34F5fhNylVRsNIEmXKSLO6thrXaixYqqsMIA?= =?us-ascii?Q?TcDofUa4Of+6UUINxv3vDfUyu2zHt75CQm1J1tKOwwsU8I1WuWzNaOdfb7Mr?= =?us-ascii?Q?vw/7Oa8en/wMN3VYEDIfVcGP6Zj9QbxP7kgHiaRCepsiUSr6LwyFsUVHFg+R?= =?us-ascii?Q?uC570XGtxZ5u8GoFba/pOQNchLM/4FoZ70rfP11iaQSjcQ+woZDQDsDrlIqj?= =?us-ascii?Q?a3RZCs6ojSo6eBgDJ5JUqpcn3w3e2QwmEP2Abt0LbJ60mrKdx/oe4bxwER9+?= =?us-ascii?Q?OEdjX58hFgW/Lcvz4PirgTVlvsc95e08fEV8EcKDJt4C67aATV+WXNuIgPct?= =?us-ascii?Q?W5BNVNugIyZaQPktgtMSTVF8QZKCcYAL1khjDnCLVENnU/48hGPPBKY69uiF?= =?us-ascii?Q?DlahmamXM0CeyPQnAHpFYqzYRkqPAvNF1irr0j36zf63lC148wIPWoyJOB6Q?= =?us-ascii?Q?wpbuJKAkYAAIHvBRItsB9OpKIW8Tx9F6VhJLbBZ6rS8MVdVOxCnm7A+3+ReE?= =?us-ascii?Q?uEGvzUUK8PpgexMSwSiAMrrcBCZUmUyoGOmHpWjCFLQ08bxQ7KYMRN9aePG6?= =?us-ascii?Q?BWAI6+Zki7i49vkHRMLsWy5KJJu9E/fiWsQrUnA5gxb1R7aaSENSfaG0MYKb?= =?us-ascii?Q?PDnLM7UONEHh8N2LKqumndM4nEqd6P0keTIh2FybWKKks/4JKl3mEroSFYDh?= =?us-ascii?Q?xVqjB1XkEecZnWWk1SriSXresQxhVRwL9I8PoseXAJWUN8xf9RS4KRYekJFF?= =?us-ascii?Q?08ss/dJWveQJgnnuxRVxPEUjoTIUOzGJZ5fQev3/0UfD/KYQtmFShk+svPsP?= =?us-ascii?Q?fUv6IaNK9Swc7rxEhwhuELOM6etBmufCTkm+ZmGsvLvjMX3RTi9rGdmQfBjJ?= =?us-ascii?Q?6UyIxK0ieNnETYUBVS0=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 958d9ac9-255c-4b13-75bb-08dbce5d2ab0 X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:32:54.9788 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7BOtF7WycGyecc2Dfcew75vgAOWUtH/EnHsxEo0uhrCqGi4+kSv/Ye/59Sz5srvnI0PNtTVm8VMPCRmumKbPTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7592 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" svc_i3c_master_irq_handler() wrong check register SVC_I3C_MINTMASKED. It should be SVC_I3C_MSTATUS. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li Reviewed-by: Miquel Raynal --- drivers/i3c/master/svc-i3c-master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index c252446b2bc5..5ab68d6e439d 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -475,7 +475,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) static irqreturn_t svc_i3c_master_irq_handler(int irq, void *dev_id) { struct svc_i3c_master *master =3D (struct svc_i3c_master *)dev_id; - u32 active =3D readl(master->regs + SVC_I3C_MINTMASKED); + u32 active =3D readl(master->regs + SVC_I3C_MSTATUS); =20 if (!SVC_I3C_MSTATUS_SLVSTART(active)) return IRQ_NONE; --=20 2.34.1 From nobody Fri Jan 2 02:28:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 874A9CDB465 for ; Mon, 16 Oct 2023 15:33:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233821AbjJPPdJ (ORCPT ); Mon, 16 Oct 2023 11:33:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233425AbjJPPdB (ORCPT ); Mon, 16 Oct 2023 11:33:01 -0400 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2062.outbound.protection.outlook.com [40.107.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47CE9107 for ; Mon, 16 Oct 2023 08:32:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UZ2bdahQ2GbI2sH9R6/h3dYO9x5BxVgcX4uA3AIB2P5+w9iFDZolcLp7ctDbD/DWsEY44Q5o3MDEHjEYibSsyU4RUKhoqvIg64aNvHimxfRhydoM/LIZ/WEI8oyYJfiXh0L+Nb87SQpz7DSUQhvHn2w8bBI5PEAHDvLiLpZsiphR8OKf9ZO+A9hDISuW1EBKwdpo+wd6WAGGgFIWmY+9AHEZ+CUL+1bB0yQh3UDt92YsDBwXxIrJKhlYtB088umbaZiR1oE5jIH2D7hHfJurDIzHZk7YdQK+qcr9sCia6EpUJxUC+sez9AIit4m/RqJcwFrxUALVTzl1qPyBh/NoDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=svPLmeygmo1OLpXLFU3spLAsG1jWt+ncndklexvqqX0=; b=Z3F/6phuuM6k+hRgdNSiBHjnfYJ3InB3dtLk2qsoIfGDHypwjXswBmL85d4TUZ+Rk4n99ZSkTVHrPW2sQG39ONd5nVGiwqH3LyXSfWGrPq3V/HgXf77J6ikvy3ZuR0TBPqfSabmCEhTp3iABQQfxKvL6eF2mt29UKRKdngv3cCyknUlPkhdrpL4A2HbzYdQAOsTlHoxss2lKVNswp/v9LT0TEndf7/rR77Xc3IIJ8Ik6AOln38kVtm8+wMWrZBwKSriaHu0R2f4I8ThCp0Qi+mORV1XpS+Zgl9cAnMGi7OwNAG1EiuXZ9JRAdkFVHV1LdXm4NgoP7Wc2Rc5mPVMKOQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=svPLmeygmo1OLpXLFU3spLAsG1jWt+ncndklexvqqX0=; b=OUX0Kp8xqvuISFgcW1UVssKNzuf1wVVU8FvGEHsNJRTLxClkkjieM1fdOFeQLXd4ZOvL2eFv0EhzMsSXCykj/jIGDJk/FEdSA7TQFYyDxq1n7OMmH3GuDrD+iNyQaaJJ0P+OGh6ZNqU8D07v2/7U3rkmOU1/llDltD9c6ioSX3Q= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AS8PR04MB7592.eurprd04.prod.outlook.com (2603:10a6:20b:23f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 16 Oct 2023 15:32:57 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6886.034; Mon, 16 Oct 2023 15:32:57 +0000 From: Frank Li To: miquel.raynal@bootlin.com, conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen Date: Mon, 16 Oct 2023 11:32:31 -0400 Message-Id: <20231016153232.2851095-6-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231016153232.2851095-1-Frank.Li@nxp.com> References: <20231016153232.2851095-1-Frank.Li@nxp.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0P220CA0029.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::13) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AS8PR04MB7592:EE_ X-MS-Office365-Filtering-Correlation-Id: 464e0d18-8fe8-4836-fecb-08dbce5d2c5f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6QJeyyzmuZngP6gKTxj1zFp92WRrkPGCj4lpf02I7a54XfIGalYNrhwCtBe+TnOsCeKBXvJPRNz2IRCLfSLLMQmJESws8cx3haxgBfMPLLmrpk3WpDnYpGtSJWyd8p1VVzg8ys9bv8J9KW7dtJg6kpUU7UllnWwYP+UTIkCMAPAXnFVaquMlg46foCM8h0+dV4bD3MP/ARqgZLMMCc67Rnyx9JXtHVQpgx04S7I/eadkuiwvipsm2biY6xkPRH2XXzSzD0TDNJ3mCCN7RsIC45yCQTRwGu/XuDiiY/mk9gHIAGDqbdZ+ptl2vTzmaP3TUJfNfALgWFPv8BGYSMR21UpofXelwymaKaI1qzySa6/EQ3B+H/9PB3rE4+q1hKyNSlazoySBfdSOPc2AFu2LqPbkFkCiIxma7QZHUiepI66e6YdPqfWWydiHIKlUd8LAvg0geuJFo+8KVp2vHjhjRZg1jXhq0XRkB38Att+95C/0f7c8hs7i14/kcA/dejzxqjNp5iG9gdJCuF3/q5UNTScoUyFSYEUsRXnsHGt2gyTf56kSOS7ekrSBS/+dWxCkDWffcR2pZsaKl2kxVQLrDmsU2hZV0gd+qpZ2mlcPaV9F8t/ByPfreIqPYJBN9V6O X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(376002)(366004)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(6486002)(38350700005)(36756003)(38100700002)(6666004)(6512007)(26005)(6506007)(316002)(66946007)(66556008)(66476007)(478600001)(1076003)(2616005)(52116002)(2906002)(41300700001)(4744005)(86362001)(5660300002)(8936002)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?iVMOCfBqIgTPFY+kplyiKwf9lfS3BopNOSlqXaX7itXKUNLsgWHawI7LNYiI?= =?us-ascii?Q?7lYxkdd1PH+Ta0v1fpXYQVxG2HacfxQe9+/BrVDodwM5jENRogJ9/tbjUJkR?= =?us-ascii?Q?d1Qa0xnVb1MWAynjQc/Uv2njqipWad7z/CqfVraRSh/eNd73Butm6UaFQeWx?= =?us-ascii?Q?Q7KJV191D+C9I0T7ZEt8Oy9XQQhcpgV8rOZqS57JD7P3FSQ1JetbkwvfRdXK?= =?us-ascii?Q?R/6zjviG5meCVaVkGslTS/qFoeyreM1PNMVClmW/MW1sMrbGUm/E07fUTA22?= =?us-ascii?Q?VKmnZ+2Uo2BiS2XVTmYC49MCeL0T2f16iga56AkBVElratGJe2Qs5Zw/EVVj?= =?us-ascii?Q?EjFKCyiuFcQrZwoXx2ocjgP5isHEobwecX4bTdemH7gTIyk7+yglG8IpGlkZ?= =?us-ascii?Q?RnMtzY4c4z1KOe3a8G0A1+mSI1Ngh4MfOTNVvZDbGWk87ZNc9rLRB9R7B90V?= =?us-ascii?Q?lOrFYnfQTifepoDmLs/uEnNfNjwxDSEue58PBb/N49oxTqy9Tw9MiI3K3cAp?= =?us-ascii?Q?2Q0AGXEzhoepg2CRIEEOgJ0tq1hjt3chznyz5r/OSu4QfUX22vM86iJc+Taa?= =?us-ascii?Q?51UaUtDjRGL7nSxJNfqdoUTUl1puIKwnxZjXZMsaOHqnYh/SRtj9hx9i8MsW?= =?us-ascii?Q?i3wDyKmbIiNnUi5kFCUhI+E5AmAi1FgNh6kmp0HyO2Xbo4tlivDXvwOMIM+M?= =?us-ascii?Q?uDqfstnc0QPKW3ikIpWuyvaCUm/dnR30u+xFGiY2RFF6sx4bVBv3hq93rTCC?= =?us-ascii?Q?+WhgJ9I1nFxcUa1KUxKABFhhtNuD9R3tgBn8fzOOyO1E8mP00cehdyo3B410?= =?us-ascii?Q?RtDRV3oMAAexC/CEXHvY/wI6D1rYNxUNIRkM2PznCBK+3RY/UEYsQdBR2vG0?= =?us-ascii?Q?UT2TgzRikscp/HEMwiJefY+3CvbaNcLTKaEQrqd0+/4U27TjdhYxzvnmcp5w?= =?us-ascii?Q?yfnYcW5vFfzWG/2MoOuTs+sCPkfpzkU+XtOzZpCgLTDpWPUW1kvaIOaJdZv6?= =?us-ascii?Q?fSvFnVrtOW9cHsIgqkJlKdD6VzZV9meseBNxK1q/dzpFIFjNsS0p3ZknfDAI?= =?us-ascii?Q?CR3XQQsSRGGJ6NDUg+UUCa1Az+EAQDLvqD7KZLtfOmZNnxUtMa6Nnegfkt7S?= =?us-ascii?Q?7yAFx2rS7ONsQktYPGDBcG9AtaLas1orBYuOpiNlfO2Le17nSXzN2hO9XOFR?= =?us-ascii?Q?2Zq3GRxxvfuvjaZhnm5NcGt1ZZVOArQq+WaVHKViGcS9+kBIRUy4VkShiXda?= =?us-ascii?Q?a3u018GxTsA4Lx4tw/zP4THM4h92Ck7iKr9FO4kVg9xoPBzcm4xjopsxCBl/?= =?us-ascii?Q?D6qubfWNjSKyL6DiwfnBpqjBX4cG+qU7SakoeUISiiKTEZ9MYQjSH/FJA1zM?= =?us-ascii?Q?fwwwlxXPMWCuSy4g3c3hWhA7SvlcSJjD39MIpyULe6fdmC+q4LCCisviLdQH?= =?us-ascii?Q?wcGfNJUelqCjcLzKPXua4MHBFUT/4msZZudE5r2mQjL+wJ5IffjG1JQbNut8?= =?us-ascii?Q?TiovAQGGolp87bANLyCaThGVHrk6iLijv8diHYUf/XKMyusr0xc26mg5qYW5?= =?us-ascii?Q?hWKaPpzycZwmRQwiGxA=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 464e0d18-8fe8-4836-fecb-08dbce5d2c5f X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:32:57.7975 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: M21CludxDsazxwvfhFlclz32ywvU4G/QQi753Gu1SQzsXMIuNtHRbAcykadlrg2IPPIgjRoUiG0pMU/LcmUrQA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7592 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Need call svc_i3c_master_emit_stop() release bus. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 5ab68d6e439d..5bca369d6912 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -403,6 +403,7 @@ static void svc_i3c_master_ibi_work(struct work_struct = *work) SVC_I3C_MSTATUS_IBIWON(val), 0, 1000); if (ret) { dev_err(master->dev, "Timeout when polling for IBIWON\n"); + svc_i3c_master_emit_stop(master); goto reenable_ibis; } =20 --=20 2.34.1 From nobody Fri Jan 2 02:28:21 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43BCBCDB465 for ; Mon, 16 Oct 2023 15:33:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233946AbjJPPd1 (ORCPT ); Mon, 16 Oct 2023 11:33:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233759AbjJPPdF (ORCPT ); Mon, 16 Oct 2023 11:33:05 -0400 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2040.outbound.protection.outlook.com [40.107.104.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BA5DE6 for ; Mon, 16 Oct 2023 08:33:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VmAUmKqK401Br0AJYvqvy2dhoSu6Jr4/dla8smGWtMbUi6brrR/zqnDLIwave4E1bgEmTNGF7/PwkzkpzznWWiK4l7Sf8NAOgc+3NBwGbq5dbwpT8Rebji7bRFVEDG1OONMXwFkripuQy8Gbi207tLUPzdat8FjwayVr97ZTQjMc1BJPiv0g8DXe+KLASzdllnozlkex6rI/wJG8bZCKGOigVXsYhqJfAwJlqHq5seNSB+G8WCu4kUkDlvvPe1c5GVTw8wMH6m9wnADGFbELLlKuT/MwX3ZNbbQLKQRp2PQBkN4Yo/q1pQn2LteMcyw7DiGAH22RxsuXts3L2vLczA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jorvWz4GxmzMDIDvdhZin08SLMEa5RtSrhynf9Gb3b0=; b=hbBBJzrpUdsNUr3nyIYyEaS3peWMMRi8E2mi0tCB7cisHWJYO9TYeHPyxvgXzTHEAmSfDvYt+5geF4oteQcS/gtWlndfaWDAOHgmNO0bO0q2zHpUvcowHxPgstUk2tmCwtl+TxKBgaJnehyKhvP3nMW0KDYXbHHBdj5mg22E0XyNWRZMgvtYj2O4YBWeO8Wc68etqMAZgYrhvHrelVTC5rkJeDA6Z5BhGVlG6V0WvIXFpL6cqF0QJTRs190mskX4HRteCUtoscuDkqc/UqUQW83nvidP2PbQ44exixder3WwfPEhFWg7PgSOMkxi/+SPFLJnP3s0Rt7tpQGQGa4ERw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jorvWz4GxmzMDIDvdhZin08SLMEa5RtSrhynf9Gb3b0=; b=rXMw7J8YJAr9dIX79Jwi742ViKY2IebJHIkhjS46zoxHOWin6/j6/fvhLRKFt483vhvHs1FWn6KvOkKv3Mwzp8ro0f2szkUJknyuc73l0AEf325MNHLyMEJ5RTgTQcod1m3Hy9m2LJeAebTfHINZeBeCFu7Dcts2iHSTuEtvy5w= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) by AS8PR04MB7592.eurprd04.prod.outlook.com (2603:10a6:20b:23f::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.36; Mon, 16 Oct 2023 15:33:00 +0000 Received: from AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2]) by AM6PR04MB4838.eurprd04.prod.outlook.com ([fe80::1774:e25f:f99:aca2%4]) with mapi id 15.20.6886.034; Mon, 16 Oct 2023 15:33:00 +0000 From: Frank Li To: miquel.raynal@bootlin.com, conor.culhane@silvaco.com, alexandre.belloni@bootlin.com, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev Subject: [PATCH 6/6] i3c: master: svc: fix random hot join failure since timeout error Date: Mon, 16 Oct 2023 11:32:32 -0400 Message-Id: <20231016153232.2851095-7-Frank.Li@nxp.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231016153232.2851095-1-Frank.Li@nxp.com> References: <20231016153232.2851095-1-Frank.Li@nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: SJ0P220CA0029.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:41b::13) To AM6PR04MB4838.eurprd04.prod.outlook.com (2603:10a6:20b:4::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM6PR04MB4838:EE_|AS8PR04MB7592:EE_ X-MS-Office365-Filtering-Correlation-Id: 29fbe925-b5c6-4cb2-63fb-08dbce5d2dca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Omz6K+ukA2OsFCNQkf2lslJ4lb67m29Rgfg2LOyTuzX/C7R7xjDeKlpMGquTaz9qCcsqmhkTEZ0kM3oXw+QUxlJXqpD6YW/bSz+yKiJa0I7hf8GfSbQ/EAMD6OfZdSMUxtueeayvCg1FIFAcCPnThMEe8ORXTKrvwMuZXDDPNbiJkBOcFpMvHSYR2PJqMUbTJVsbcCgXFZXlAlVMrpSKBooWa7xIKog5KLsd2DH0lkYdpn87CIIy2/fi3MFNZxxFWKcBD0s41VvNYbAknJkgQwkbSbGVp6gepjiB87D3AZG6fhIPTwIf0AkVMsFp1p1lJWHk9vUC7KElqjPVkMFj1rSmiMGo8xse/OWuEEZnphQwoomvDbGNldr/VhKlzR66CLGKc8BetbzUEEa0vy7rvVlK/+0wtvxSTK4SaL2nnrYPLGd7M8/aHXEXd6oKaN8N1GmY8Pa6AKw3kGNXi48EJDMNtrD4VypogQyq1AkEgNcXaJfclbhMDPX7Y16MwJBUBl1EexWwW1AawmCFEdzzChJ8QeCk9Ra0xPGyuwCl+n1cTQlOo6eLUakzx3aENFWbSdRSWSifjqJmh4wRIQTyv8nPgW2HVY3FP03v39YUFu8Hd7Qlu0jVpxavlvJ5bF7+ X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB4838.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(346002)(136003)(376002)(366004)(39860400002)(396003)(230922051799003)(451199024)(64100799003)(1800799009)(186009)(6486002)(38350700005)(36756003)(38100700002)(83380400001)(6666004)(6512007)(26005)(6506007)(316002)(66946007)(66556008)(66476007)(478600001)(1076003)(2616005)(52116002)(2906002)(41300700001)(86362001)(5660300002)(8936002)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHpFOVBGaWZ3REJwUnpKMTVYZXprNHpBaWRkTGlySGNlWlA2QVNsTitlZ2hM?= =?utf-8?B?VlZXTzZJSWtSSTVqYUl0T1BKb1BWdnZDTnVoZ2tyaHVYcGVaMnR3MjBYdG83?= =?utf-8?B?ZkQyQWNyclZseUdaYUY4b1hnejZ6TzM4akk5M3ZJUnJ0UVF1Umc5N0phU0N5?= =?utf-8?B?Wkd1VXFZZXc4ZWdjVlRFZnVYZSt2WUhpWHhISHJtS21pYXF1cnlLb20xYkdX?= =?utf-8?B?MGhuWTFEU1VWaWkrNVI5THQ3ekNCK2ZwcGlRQ2hIVFJtWndhUU43S2xHaUx0?= =?utf-8?B?WklFZG5QK2hWb3ZQYTd4YUtFMkltTzhtc3hydHR2SWlVS01GNDh1bkNpbUNQ?= =?utf-8?B?UlhMVXpZcXMxdk1Mck9qdjJpUTlmVTB2bUJ1RE5DT3NiaVo1WVY0ZGhrU0Y2?= =?utf-8?B?YjJzYkhDTEJhYk9rN3d4TzJLcDArNnFEdklGR0drT2R5bzBsYjBaUlIzeVFn?= =?utf-8?B?UTQ3RkJROWRDV09kT0JQbXpYZlVicWlrOFlsdTNPdndGa0VBOGFYek1pTHl1?= =?utf-8?B?VGFCWUtqNHFkekRTSXZIYnlzK0F5OGhEdk5JSEhBVTRSMitabXFXWEFyb0tT?= =?utf-8?B?b3JUNGNaanVhSjhxSkoxelpLeUtsVHFmWmoydEE2dHFua0JKZ0NJeWR1RmZv?= =?utf-8?B?aEVraWNIMS8zMTRhZ0o0QTFGRHduSEpINDdnM1VzTzh6SUgxa3pkWWd5NVJT?= =?utf-8?B?NmsrdkZGZ2dnb2IzeXh5dmwrckx6ekc1YWdwVmYvNytxR29ldVM1VW55Y3pQ?= =?utf-8?B?TzdUdkJ4a202RXpROHZvYWpSVHFGZjhRbWJVR1h2YkJDMEcvNGVVbnJZSE5K?= =?utf-8?B?S3ltQ3BvRWRSZzcwYmZPb0VBWXZUK0h4VzFoU1pQd2s2MU81L0d2OTQ3cFlE?= =?utf-8?B?OHZ6NmVheFRYdVRDWGZXZHU2Ri9Wa1ZEd2Z5bnpRRGJzZmRZN3JPaUpPRmI0?= =?utf-8?B?WnkyTURMREhCK3dZam9jWnJCajJSWVpadjEyVlU4d1JZUHUxR2E1UGQ2WlZ4?= =?utf-8?B?YmVjZzFpY2RDcWxVVFEzcXJKbUNpaUh4Zms0TndIcThCMlNEQ3lZVzEvSUdi?= =?utf-8?B?Rkh2TFRwaExQU1ZVdmoyM0NFVXVGR1lMalF2VjBaVjZmWEpIOFVLY3dRTW5j?= =?utf-8?B?SzU4RVlGajdWbXZkRzFsblg2WHhaY1VmNmRrRGowMlZXMFRsd3RwcGJyanZK?= =?utf-8?B?SmtVVmdDNnVwQW9yaGlzQ1REVmF5QmNFa0orWk56a0FhVlZjNFZ0U05vWGpE?= =?utf-8?B?N2UvbStzRjQ0RThld0lNcFYvenBoSmpQaFByYW9jVHNnZUpoejhuSVNFaFhY?= =?utf-8?B?VDVUMTV1ditvN0E1TE5LVDFpTXZ6K1UvNWRtc2hoODhldXI4UlA5UHdoSVRZ?= =?utf-8?B?MWpKMTU0bDcrSG1qQmloOTJoTnJyL2NVTjEzZG5YOXJqZ04yVHdINFluajlp?= =?utf-8?B?b1V5WXJWa2lPTldZRnZSM3FUeFZvQk9Tc3VLRVY2THVFcjdhWHNyY3d6V1do?= =?utf-8?B?SzFUdGpEdWd2eGlxRStiT3lESXVISWQrZW1Na1FDV0Q3QTgyZW9NWlkyekhG?= =?utf-8?B?VDlOeVRVcXdYeGJaRUFZUXVRcStvK05EcjlSUGNNdmxRdDNRZkFFSzVEcXg2?= =?utf-8?B?eG1rSjgvcHB0Z3lmcXBFUlY5M3RlR1loVmUzandVeEN2SG56cEVMbmpnNENi?= =?utf-8?B?dzgrK1lWWjkzQmxUZ2UxVFJ1RVFHZFhMR1F2eU1UWXlYZXhEMEtBbUVpZ1NJ?= =?utf-8?B?VWcvV2dzaFk3SVZSSWNGWU95bFp3djRYbU1PUnBCMlZMOHFOWkxNMzZPWjBs?= =?utf-8?B?Q3BOb0o0NTRmei9xVU5jbXhQZFB1SWdyLzN4YnFoMlFpL01RZ0Z5MUxzOVl1?= =?utf-8?B?YmJFT2h2UjZrMVZmQ0NuNDNuRFkwZCtlVEJNNjVrWGhEWldQajlJQ0doLzZV?= =?utf-8?B?TE1zZkRNTWpBRytoTXlVaWFzUTRscURRbEczdlUxT25BcFZyUDExVnpDMlBJ?= =?utf-8?B?V1lIU0JRZEQ3aFZVbUtUTnlMK0M5RWR6ZnRXczRyQXBmVlNxekloN3NHdk1n?= =?utf-8?B?VGdJMnFHMnlPQUwwMVNZREFRRnNCbnJPTmNNaThUazVTaWZHaXUwOENVSzB0?= =?utf-8?Q?Hh7E=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 29fbe925-b5c6-4cb2-63fb-08dbce5d2dca X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB4838.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2023 15:33:00.0238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fqbvfMzSso1nkE2LhfC/pJvaW4YIKna9QxITqKKFJWBikliTVEChVSNdZ1P9bHbeCTwLzvsTfflphDNHgJHNcA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7592 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org master side report: silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090= c7, MERRWARN 0x00100000 BIT 20: TIMEOUT error The module has stalled too long in a frame. This happens when: - The TX FIFO or RX FIFO is not handled and the bus is stuck in the middle of a message, - No STOP was issued and between messages, - IBI manual is used and no decision was made. The maximum stall period is 10 KHz or 100 =CE=BCs. This is a just warning. System irq thread schedule latency is possible bigger than 100us. Just omit this waring. Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") Cc: stable@vger.kernel.org Signed-off-by: Frank Li --- drivers/i3c/master/svc-i3c-master.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i= 3c-master.c index 5bca369d6912..18bc277edc8a 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -93,6 +93,7 @@ #define SVC_I3C_MINTMASKED 0x098 #define SVC_I3C_MERRWARN 0x09C #define SVC_I3C_MERRWARN_NACK BIT(2) +#define SVC_I3C_MERRWARN_TIMEOUT BIT(20) #define SVC_I3C_MDMACTRL 0x0A0 #define SVC_I3C_MDATACTRL 0x0AC #define SVC_I3C_MDATACTRL_FLUSHTB BIT(0) @@ -225,6 +226,11 @@ static bool svc_i3c_master_error(struct svc_i3c_master= *master) if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) { merrwarn =3D readl(master->regs + SVC_I3C_MERRWARN); writel(merrwarn, master->regs + SVC_I3C_MERRWARN); + + /* ignore timeout error */ + if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) + return false; + dev_err(master->dev, "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", mstatus, merrwarn); --=20 2.34.1