From nobody Fri Dec 19 04:01:21 2025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCBB5CDB474 for ; Fri, 13 Oct 2023 02:04:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229496AbjJMCEl (ORCPT ); Thu, 12 Oct 2023 22:04:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjJMCEj (ORCPT ); Thu, 12 Oct 2023 22:04:39 -0400 Received: from m15.mail.163.com (m15.mail.163.com [45.254.50.219]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A980EC0 for ; Thu, 12 Oct 2023 19:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=9r32H Jr+aZCW8hq5PA5ylkFRQQicXVfPBRAd4cEZX70=; b=OOdAW49H3evvBjINGia5r GEGSXFjjNA//Gb8AlS1uaq85j2IUVn9DoWGOcCqND6S9Bdu6akoOyYqw+e+GqxCm pKucz41MI9rGpPJqewSw5nsLP5S5/BCSs2wnMw8BXqidefqNUCof9IxguuEcvQ4C QNgAbm/xF1j770l2oE0QtU= Received: from icess-ProLiant-DL380-Gen10.. (unknown [183.174.60.14]) by zwqz-smtp-mta-g1-4 (Coremail) with SMTP id _____wDn74yHpShl9zKfAQ--.16988S4; Fri, 13 Oct 2023 10:04:00 +0800 (CST) From: Ma Ke To: airlied@redhat.com, kraxel@redhat.com, airlied@gmail.com, daniel@ffwll.ch Cc: virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Ma Ke Subject: [PATCH] drm/qxl: fix a possible null pointer dereference Date: Fri, 13 Oct 2023 10:03:50 +0800 Message-Id: <20231013020350.344576-1-make_ruc2021@163.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-CM-TRANSID: _____wDn74yHpShl9zKfAQ--.16988S4 X-Coremail-Antispam: 1Uf129KBjvdXoWruF13Kr4Uur47Xw43AFW8JFb_yoW3KFg_WF y8ZwsrXryDu3Wvkr47Z34fZr1SvF1kZFWxZr1xt34Sqr48W3Z8Xry7Zwn5Z3y7Z340yFyD Aw4UGFnxAFs7GjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7xRKfOzJUUUUU== X-Originating-IP: [183.174.60.14] X-CM-SenderInfo: 5pdnvshuxfjiisr6il2tof0z/1tbivg4IC1ZcjGVeaQABsm Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" In qxl_add_mode(), the return value of drm_cvt_mode() is assigned to mode, which will lead to a NULL pointer dereference on failure of drm_cvt_mode(). Add a check to avoid null pointer dereference. Signed-off-by: Ma Ke --- drivers/gpu/drm/qxl/qxl_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_di= splay.c index 6492a70e3c39..8a14edaa4aa3 100644 --- a/drivers/gpu/drm/qxl/qxl_display.c +++ b/drivers/gpu/drm/qxl/qxl_display.c @@ -236,6 +236,8 @@ static int qxl_add_mode(struct drm_connector *connector, return 0; =20 mode =3D drm_cvt_mode(dev, width, height, 60, false, false, false); + if (!mode) + return 0; if (preferred) mode->type |=3D DRM_MODE_TYPE_PREFERRED; mode->hdisplay =3D width; --=20 2.37.2