From nobody Fri Jan 2 13:45:48 2026 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A403ACDB470 for ; Wed, 11 Oct 2023 17:39:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232457AbjJKRjR (ORCPT ); Wed, 11 Oct 2023 13:39:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230234AbjJKRjM (ORCPT ); Wed, 11 Oct 2023 13:39:12 -0400 Received: from EUR02-DB5-obe.outbound.protection.outlook.com (mail-db5eur02on2088.outbound.protection.outlook.com [40.107.249.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DE0EF8F; Wed, 11 Oct 2023 10:39:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=klwwR+6mfGr75TVyoV7h8z9micylMuyiaZQZ8n1PCXEoOacW5oYAIDf6juYJz7wyiSze955lSyCBSyj2bLksypvZF2ZV5EpOM4JGayxLCK1y/gy8elOjOrKOoMWoRCsWG7aqKkMfHryJXGdpDiJK1uJ9BVBWu0dT3wWeVf5hgmD9V0bF2cI8MPoDgBR9q5mOxLqKk77p6OwKcPkQx9HVPLRriePHXNsAxfh8mjdGX59iFxdsJrEBW+2sNcEi2awoNMBSnkjH0oKmU3HZCZSVWFyZDgRY0jcYG/70AKZxBWTI+pKKAgfglPRmbCZQQqwQwTU6puK8Xd3P4n3E40VTjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6KQh/iKhf9LXRW6pVMZ1tYdiYaWX6FeHAsXrrGRngEU=; b=AUz3U2fU/BT4VNr5sXIo3f5tdyEclvTEcCcz4TpXXqbslp9rvbZHZVXGQhq7/eBzlrPQY9E4nd66K7jsCNDz03gsJ6sZLJCdDVjg6vt03g1ZmLM/2vI9M7tF/BzQ52vi9ETUMjgB53XKGbciiusNmi3sTumGcBgLG8dF6dMLBAopnJ8I9QfI+RCtxwPx8ttZZ0BaAxrDSt2Ix7Q/PeoC0HhFkYpX0UzNSMymfJUcb8sfr/thjQIbxa0cNXhTFeOrI0zzFwG3y1rvJ3OzyGh3BhchQeMkyb5J9lLTG4/wZo2Y/V4s3Nq1bMSGsI5flO514iqIN7QeG28qNj0y/zCFfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=kunbus.com; dmarc=pass action=none header.from=kunbus.com; dkim=pass header.d=kunbus.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kunbus.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6KQh/iKhf9LXRW6pVMZ1tYdiYaWX6FeHAsXrrGRngEU=; b=na+PDpR1mbteH6+kkcXBGL+92Wdded29TmdqZ0oqp8SO4L1B+VLuAeZRdNcAldvlalZkct87JkPWNcjjSEHIaWVuBEhHwSuaA5c89+WdygkvRmKvOEKUMwz8jLU0+iomderGUygye+XYLOVZhi5N/g9nDFui9DISmY9Yp9l3bTY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=kunbus.com; Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) by AM8P193MB1187.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:362::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.41; Wed, 11 Oct 2023 17:39:05 +0000 Received: from VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::550d:2425:c0ed:3e59]) by VI1P193MB0413.EURP193.PROD.OUTLOOK.COM ([fe80::550d:2425:c0ed:3e59%3]) with mapi id 15.20.6863.032; Wed, 11 Oct 2023 17:39:05 +0000 From: Lino Sanfilippo To: gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, cniedermaier@dh-electronics.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de, lukas@wunner.de, p.rosenberger@kunbus.com, Lino Sanfilippo , stable@vger.kernel.org Subject: [PATCH v2 1/7] serial: Do not hold the port lock when setting rx-during-tx GPIO Date: Wed, 11 Oct 2023 19:38:23 +0200 Message-Id: <20231011173829.10508-2-l.sanfilippo@kunbus.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231011173829.10508-1-l.sanfilippo@kunbus.com> References: <20231011173829.10508-1-l.sanfilippo@kunbus.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR2P281CA0093.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9b::18) To VI1P193MB0413.EURP193.PROD.OUTLOOK.COM (2603:10a6:803:4e::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VI1P193MB0413:EE_|AM8P193MB1187:EE_ X-MS-Office365-Filtering-Correlation-Id: 783012d7-e28b-400d-331c-08dbca80f6d4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tGRCJjbeSdmcDRTtJiWANZpXMn+re3GcZBJHlcf/hsmZ7D+RudCRbEOpBcZouBoAjPDaWTTnUdgLKJGL3yIQvCV3Zf3GokTLAJR6d+uLyIGAcN3/M/ESQHazdtzrHsrwTV3PejFAYUcIch6q5pO9UR9gRs45ckY1CksWarlvJ19L5o+MRxoBcXUuitR02eMc9J0CPIqZ9FznT5vgpUTTrBNOdTvYNdznISQ1TunYs8VLL3qWNySJflFxrV7VjiDu74isH63E5zZNPusY6iN/gQsNMUw2mqFsU5YhQwSyDQuZWmBbau6sqw+USLJ/wE1XBgb+cDUfSlydjlviV+edAqK751uOlQnDY343uUPs6LdELXdIL31ldfofVMMcY3z6HEMUT55j1yyA3NXhNsoOG7A5l6TSfuacvCb3q71WY1JdmToVs8Mty3/qAze9oGdqDndPIg4UCd0mzQyG5T6I/dzj5vMWmpTGdWQG4b54T/GvuWQYUiQfxLP0IPtTmbYzFYZjcwxUBqfnau6dv9huMhlCveWj4VaVyKZAWnLMve5qpKtBhcLjbxiuiWDsFzjb X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1P193MB0413.EURP193.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230031)(136003)(39840400004)(376002)(366004)(346002)(396003)(230922051799003)(186009)(64100799003)(451199024)(1800799009)(6666004)(2616005)(83380400001)(6486002)(478600001)(1076003)(52116002)(38100700002)(6506007)(6512007)(66476007)(66946007)(66556008)(4326008)(8676002)(8936002)(41300700001)(316002)(86362001)(7416002)(2906002)(36756003)(5660300002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?hrjWRu5dgBrm2wayejrE3KsI4QEYzrpebvOGLMFrW1Sge+v9auE70OjU/At6?= =?us-ascii?Q?xY+8GFBTDZn71GiQnBT7XlMk6ZU+r5qIpJXbCz4WTfTbvDkvEg/nNL24Naak?= =?us-ascii?Q?1hW1BSijtPHAVgaza4awWXVkJixOIW+qeLrBOFE+pSxKsHCg/8EXsZ5W5lZt?= =?us-ascii?Q?zheKgYjAFOX6iuHKD/t5HK+NvMBLZqRgzi6EURCE71xEbTblkdfO9yiDANeb?= =?us-ascii?Q?hSZLEmtYaqEP+83EREGnJ4i14APGGR1n1nBE082+EklQS3pFYgWsPBVg95Tk?= =?us-ascii?Q?t4nIyixy9By01d3gJwsyRYvJApC1rKcPiuanFCnhSZtN71ce3xR9b5aPvK6P?= =?us-ascii?Q?GUdzK0Q1Cs9i5nn94Vc4Ymkh6XC7RwSTBOP/YIQtNyCjKpkY+X68AewfTbGd?= =?us-ascii?Q?pLfVEj5f+hEKXegCCKh9klh/27TDLsIRFRLfF/C4KfsVQjtrjns0rgDKHLSm?= =?us-ascii?Q?sbgFqdPlBhAsb3pOjUyERQ0sjlwXvM6F1apzW4tEanVoq6/YUMmr1eyRa0bN?= =?us-ascii?Q?WCJY6e3O0gOlQshnSRQbkPJdJ5IjuHMDC1eFVsropiNv5w0uG2cYl3xO6XUL?= =?us-ascii?Q?vzY7W1MqG3gmr6Kf1Yc32D2zH02HF378rGAIoCcZ1/LjAqPvbHgP6068j+8h?= =?us-ascii?Q?yssDUqOqhe6ECtqtpDttsfv5rX481wWGTFWbjkYH8PHW6CsksVkWn1OwDqR9?= =?us-ascii?Q?eEhf2K8/6/QUgrVkrWweKPDAptRdKQpqhE5JTQWvePl9+El1B9IivRy6ZyBZ?= =?us-ascii?Q?cWt1F6wpyO2Efa5/Tjno9cNnYY8EhBPpvZNgNeRhxG2zMEs9uDYbrUcY7tkf?= =?us-ascii?Q?N0SEEzc0QPwQjwFRnCO4y8mBvOzS1+SPWiliaWk4W35QvQdsOGD8TEMqYHTF?= =?us-ascii?Q?NHVVRwpYX6tc5jFvg1LPwEMXz0VB5F+ACe5jw7iW8KX4YUfBEnD4dT2dsjfA?= =?us-ascii?Q?eg7JfXc9bwgVFAH1Bg1FYA/XmTdrN+1Mc6g3Xp/Hgfe9pYwOJcdKCptgBvMa?= =?us-ascii?Q?V25Cbf2VL5uUjXqnJFPwN1XaKyiNRYsd36mNSjYf8JFJNm+5ik3WNjk7E75a?= =?us-ascii?Q?loIOpk6YO/DGjqVsHLhjOyUQfeucdsG5cDGSyHT1jGpoGWRCjo2yYHR9ld4z?= =?us-ascii?Q?F0Dyftv9CB+j+aui2/MkXe9Qldqk3aoivhLBETCiLMwg/84JayeOP9Jl6un4?= =?us-ascii?Q?TLKdRhuCdpdRU0zfHugJk5RbnuiNeZ5PFGK5H53DsnKA8lreHIJiZlAOHmch?= =?us-ascii?Q?qR6zewD2cr/cWqOdoqREmtV2/1tWvWtAjgkRZZ4yOH3znHYxS9hkXj7f99Ef?= =?us-ascii?Q?ib3uVijoiFbu90mcausMZdtQWjI8xpvweos41GcPpkLbt7WRL5k+xFSJ3y4l?= =?us-ascii?Q?mscG9Fa2yhCPjRsxKslgaOwabT+ioLkgxjV4SW6E+m70PMNpNWOEW4r2lSeF?= =?us-ascii?Q?3VfSog8cqoHIbf8DiK4tIqnRpsyhe3fTWNYxm1JW/1YerCCGEHqrm5o2nQjy?= =?us-ascii?Q?EZry1SMqpiIkiKm07QQhk9V3B9M2blmZibSdI9mAigIjK+/rVTxzf/kx2y53?= =?us-ascii?Q?Q66zazXGgBvTncqx0JU83Dek+Gvf+XZcq6D0RMVJsmLN9l37NFAcKukEEwKF?= =?us-ascii?Q?zxgkcaeFhWXv5WlklTWT/eiyNexmNZ3GZhUBjl+Xu0LU?= X-OriginatorOrg: kunbus.com X-MS-Exchange-CrossTenant-Network-Message-Id: 783012d7-e28b-400d-331c-08dbca80f6d4 X-MS-Exchange-CrossTenant-AuthSource: VI1P193MB0413.EURP193.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Oct 2023 17:39:05.0610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: aaa4d814-e659-4b0a-9698-1c671f11520b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Snc63m0C3MogJcDZ/TOJFOnkcz7rUAIvNmIXBirTZkHZ8ZX9NGgdCcFJF2ogsv2Q8u/kV9TbUD2Euo8ykP63tA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P193MB1187 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Both the imx and stm32 driver set the rx-during-tx GPIO in the rs485_config() function by means of gpiod_set_value(). Since rs485_config() is called with the port lock held, this can be an problem in case that setting the GPIO line can sleep (e.g. if a GPIO expander is used which is connected via SPI or I2C). Avoid this issue by setting the GPIO outside of the port lock in the serial core and by using gpiod_set_value_cansleep() instead of gpiod_set_value(). Since now both the term and the rx-during-tx GPIO are set within the serial core use a common function uart_set_rs485_gpios() to set both. With moving it into the serial core setting the rx-during-tx GPIO is now automatically done for all drivers that support such a GPIO. Fixes: c54d48543689 ("serial: stm32: Add support for rs485 RX_DURING_TX out= put GPIO") Fixes: ca530cfa968c ("serial: imx: Add support for RS485 RX_DURING_TX outpu= t GPIO") Cc: stable@vger.kernel.org Signed-off-by: Lino Sanfilippo --- drivers/tty/serial/imx.c | 4 ---- drivers/tty/serial/serial_core.c | 10 ++++++---- drivers/tty/serial/stm32-usart.c | 5 +---- 3 files changed, 7 insertions(+), 12 deletions(-) diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index 13cb78340709..edb2ec6a5567 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -1947,10 +1947,6 @@ static int imx_uart_rs485_config(struct uart_port *p= ort, struct ktermios *termio rs485conf->flags & SER_RS485_RX_DURING_TX) imx_uart_start_rx(port); =20 - if (port->rs485_rx_during_tx_gpio) - gpiod_set_value_cansleep(port->rs485_rx_during_tx_gpio, - !!(rs485conf->flags & SER_RS485_RX_DURING_TX)); - return 0; } =20 diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_c= ore.c index 7bdc21d5e13b..ef0500be3553 100644 --- a/drivers/tty/serial/serial_core.c +++ b/drivers/tty/serial/serial_core.c @@ -1391,14 +1391,16 @@ static void uart_sanitize_serial_rs485(struct uart_= port *port, struct serial_rs4 memset(rs485->padding1, 0, sizeof(rs485->padding1)); } =20 -static void uart_set_rs485_termination(struct uart_port *port, - const struct serial_rs485 *rs485) +static void uart_set_rs485_gpios(struct uart_port *port, + const struct serial_rs485 *rs485) { if (!(rs485->flags & SER_RS485_ENABLED)) return; =20 gpiod_set_value_cansleep(port->rs485_term_gpio, !!(rs485->flags & SER_RS485_TERMINATE_BUS)); + gpiod_set_value_cansleep(port->rs485_rx_during_tx_gpio, + !!(rs485->flags & SER_RS485_RX_DURING_TX)); } =20 static int uart_rs485_config(struct uart_port *port) @@ -1407,7 +1409,7 @@ static int uart_rs485_config(struct uart_port *port) int ret; =20 uart_sanitize_serial_rs485(port, rs485); - uart_set_rs485_termination(port, rs485); + uart_set_rs485_gpios(port, rs485); =20 ret =3D port->rs485_config(port, NULL, rs485); if (ret) @@ -1449,7 +1451,7 @@ static int uart_set_rs485_config(struct tty_struct *t= ty, struct uart_port *port, if (ret) return ret; uart_sanitize_serial_rs485(port, &rs485); - uart_set_rs485_termination(port, &rs485); + uart_set_rs485_gpios(port, &rs485); =20 spin_lock_irqsave(&port->lock, flags); ret =3D port->rs485_config(port, &tty->termios, &rs485); diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/stm32-us= art.c index 5e9cf0c48813..8eb13bf055f2 100644 --- a/drivers/tty/serial/stm32-usart.c +++ b/drivers/tty/serial/stm32-usart.c @@ -226,10 +226,7 @@ static int stm32_usart_config_rs485(struct uart_port *= port, struct ktermios *ter =20 stm32_usart_clr_bits(port, ofs->cr1, BIT(cfg->uart_enable_bit)); =20 - if (port->rs485_rx_during_tx_gpio) - gpiod_set_value_cansleep(port->rs485_rx_during_tx_gpio, - !!(rs485conf->flags & SER_RS485_RX_DURING_TX)); - else + if (!port->rs485_rx_during_tx_gpio) rs485conf->flags |=3D SER_RS485_RX_DURING_TX; =20 if (rs485conf->flags & SER_RS485_ENABLED) { --=20 2.40.1